After upgrade of linux-libre, linux-libre-documentation fails to build

Done

Details

3 participants

Leo Famulari
Rostislav Svoboda
Tomas Volf

Owner: unassigned

Submitted by: Tomas Volf

Severity: normal

Tomas Volf wrote on 10 Apr 17:05 +0200

Recipients:(address . bug-guix@gnu.org)

Message-ID:Zhaqq9s3JSDl7mqx@ws

Attachment: file

Rostislav Svoboda wrote on 11 Apr 01:44 +0200

Recipients:(address . 70324@debbugs.gnu.org)

Message-ID:CAEtmmezz5Ome_mxMo3e6XuviYuTvbWoY4QUeEiAfOHuWr74NCA@mail.gmail.com

Toggle quote (2 lines)

> linux-libre-documentation is broken again:

Try to repeat ./bootstrap and configure

See also https://issues.guix.gnu.org/issue/70140and the commit

74517806f80dab17474a3c5f0b91d437e4d4e052

Cheers, Bost

Leo Famulari wrote on 11 Apr 05:12 +0200

Re: bug#70324: After upgrade of linux-libre, linux-libre-documentation fails to build

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 70324@debbugs.gnu.org)

Message-ID:ZhdVK4WDqH42Ph2l@jasmine.lan

On Wed, Apr 10, 2024 at 05:05:15PM +0200, Tomas Volf wrote:

Toggle quote (8 lines)

> linux-libre-documentation is broken again:

> starting phase `build'

> Traceback (most recent call last):

> File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>

> import yaml

> ModuleNotFoundError: No module named 'yaml'

It looks like the package depends on pyyaml now. I wonder if that's

intentional. Did you search the upstream bug tracker to look for more

info?

Toggle quote (2 lines)

> How are these not caught in the CI?

What do you mean? The CI server did register the build failure:

https://ci.guix.gnu.org/build/3863875/details

As well as many other build failures in the kernel packages:

https://ci.guix.gnu.org/eval/1228559

Tomas Volf wrote on 11 Apr 16:42 +0200

Recipients:(name . Leo Famulari)(address . leo@famulari.name)(address . 70324@debbugs.gnu.org)

Message-ID:Zhf201svFeMkRenZ@ws

On 2024-04-10 23:12:43 -0400, Leo Famulari wrote:

Toggle quote (13 lines)> On Wed, Apr 10, 2024 at 05:05:15PM +0200, Tomas Volf wrote:
> > linux-libre-documentation is broken again:
> >
> >     starting phase `build'
> >     Traceback (most recent call last):
> >       File "/tmp/guix-build-linux-libre-documentation-6.8.4.drv-0/linux-6.8.4/./tools/net/ynl/ynl-gen-rst.py", line 26, in <module>
> >         import yaml
> >     ModuleNotFoundError: No module named 'yaml'
>
> It looks like the package depends on pyyaml now. I wonder if that's
> intentional. Did you search the upstream bug tracker to look for more
> info?

I did (now) and the search gives nothing. However I suspect the commit in

question would be a304fa1d10fcb974c117d391e5b4d34c2baa9a62:

docs: Makefile: Add dependency to $(YNL_INDEX) for targets other than htmldocs

Based on the diff:

+htmldocs texinfodocs latexdocs epubdocs xmldocs: $(YNL_INDEX)

+htmldocs:

I would assume it is the texinfodocs triggering the YNL_INDEX for us. This

snippet from the commit message:

If one of other targets such as latexdocs or epubdocs is built

without building htmldocs, missing .rst files can cause additional

WARNINGs from sphinx-build as follow:

Seems to indicate it is intentional.

Toggle quote (11 lines)>
> > How are these not caught in the CI?
>
> What do you mean? The CI server did register the build failure:
>
> https://ci.guix.gnu.org/build/3863875/details
>
> As well as many other build failures in the kernel packages:
>
> https://ci.guix.gnu.org/eval/1228559

Right, I should have written the question differently. I am curious how this

got onto the master. Given the point 9. in (guix)Submitting Patches, and the

fact the QA should run on every patch before it is accepted, I was surprised

that the broken build of dependent package was committed.

Since this was second time in past ~two months the linux-libre-documentation

package on master was broken, I was curious if it is special in some way.

Have a nice day,

Tomas Volf

There are only two hard things in Computer Science:

cache invalidation, naming things and off-by-one errors.

Leo Famulari wrote on 11 Apr 16:55 +0200

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 70324@debbugs.gnu.org)

Message-ID:Zhf561zU6NRKor9H@jasmine.lan

On Thu, Apr 11, 2024 at 04:42:27PM +0200, Tomas Volf wrote:

Toggle quote (9 lines)

> I would assume it is the texinfodocs triggering the YNL_INDEX for us. This

> snippet from the commit message:

> If one of other targets such as latexdocs or epubdocs is built

> without building htmldocs, missing .rst files can cause additional

> WARNINGs from sphinx-build as follow:

> Seems to indicate it is intentional.

Okay, thanks for looking. We can add a dependency on python-pyyaml and

it should work.

Toggle quote (8 lines)

> Right, I should have written the question differently. I am curious how this

> got onto the master. Given the point 9. in (guix)Submitting Patches, and the

> fact the QA should run on every patch before it is accepted, I was surprised

> that the broken build of dependent package was committed.

> Since this was second time in past ~two months the linux-libre-documentation

> package on master was broken, I was curious if it is special in some way.

Oh, I see. As shown on the 'kernel-updates' Cuirass jobset page, our

infrastructure at ci.guix.gnu.org can build less than of the kernel

packages successfully. So, the documentation failures are "lost in the

noise".

https://ci.guix.gnu.org/jobset/kernel-updates

I'm looking for more people to help with the kernel packages, and one

person has joined the effort and that is great!

But if we want to hold the kernel packages to the normal Guix standard,

we need more help:

https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00079.html

Based on lack of complaints, it seems that people are only using Guix's

linux-libre kernels on x86_64. Either nobody is using the other

architectures, or they are using different kernels. So bugs are seldom

reported or fixed.

Example of CI failure bugs that don't seem to affect anyone:

https://issues.guix.gnu.org/67535

And qa.quix.gnu.org is too slow for kernel updates, which occur roughly

once a week. If QA takes more than one week to process the proposed

updates, then we would never catch up. The QA workflow is very good and

we should be using it, but it needs to be more powerful.

Leo Famulari wrote on 11 Apr 21:18 +0200

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 70324@debbugs.gnu.org)

Message-ID:Zhg3mY6G7U-eJh0K@jasmine.lan

On Thu, Apr 11, 2024 at 10:55:39AM -0400, Leo Famulari wrote:

Toggle quote (3 lines)

> Okay, thanks for looking. We can add a dependency on python-pyyaml and

> it should work.

I sent a patch:

https://issues.guix.gnu.org/issue/70343

And CI will test it here:

https://ci.guix.gnu.org/eval/1241100

Leo Famulari wrote on 13 Apr 21:18 +0200

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 70324-done@debbugs.gnu.org)

Message-ID:ZhradPUivr2HxSB8@jasmine.lan

On Thu, Apr 11, 2024 at 03:18:49PM -0400, Leo Famulari wrote:

Toggle quote (4 lines)

> I sent a patch:

> https://issues.guix.gnu.org/issue/70343

This should be fixed with commit cc38699cf0cfd804a43ca1b6c8602cfc84e06117

Please let us know if you see more problems. Thanks for the report!

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 70324@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 70324

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date