[PATCH] gnu: Add nfs4-acl-tools

DoneSubmitted by Lars-Dominik Braun.
Details
3 participants
  • Lars-Dominik Braun
  • Marius Bakke
  • Michael Rohleder
Owner
unassigned
Severity
normal
L
L
Lars-Dominik Braun wrote on 10 Jul 2020 11:21
(address . guix-patches@gnu.org)
20200710092101.GA22947@zpidnp36
* gnu/packages/acl.scm (nfs4-acl-tools): New variable.* gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.* gnu/local.mk: Add it.--- gnu/local.mk | 1 + gnu/packages/acl.scm | 45 ++++++++++++ .../nfs4-acl-tools-0.3.7-fixpaths.patch | 73 +++++++++++++++++++ 3 files changed, 119 insertions(+) create mode 100644 gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch
Toggle diff (165 lines)diff --git a/gnu/local.mk b/gnu/local.mkindex 5c3b391960..1acb5c1f94 100644--- a/gnu/local.mk+++ b/gnu/local.mk@@ -1315,6 +1315,7 @@ dist_patch_DATA = \ %D%/packages/patches/netsurf-system-utf8proc.patch \ %D%/packages/patches/netsurf-y2038-tests.patch \ %D%/packages/patches/netsurf-longer-test-timeout.patch \+ %D%/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch \ %D%/packages/patches/ngircd-handle-zombies.patch \ %D%/packages/patches/network-manager-plugin-path.patch \ %D%/packages/patches/nsis-env-passthru.patch \diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scmindex bcab125164..c9ea335615 100644--- a/gnu/packages/acl.scm+++ b/gnu/packages/acl.scm@@ -5,6 +5,7 @@ ;;; Copyright © 2017 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net> ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>+;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org> ;;; ;;; This file is part of GNU Guix. ;;;@@ -24,11 +25,14 @@ (define-module (gnu packages acl) #:use-module (guix licenses) #:use-module (gnu packages attr)+ #:use-module (gnu packages autotools) #:use-module (gnu packages base)+ #:use-module (gnu packages bash) #:use-module (gnu packages gettext) #:use-module (gnu packages perl) #:use-module (guix packages) #:use-module (guix download)+ #:use-module (guix git-download) #:use-module (gnu packages) #:use-module (guix build-system gnu)) @@ -89,3 +93,44 @@ (description "Library and tools for manipulating access control lists.") (license (list gpl2+ lgpl2.1+))))++(define-public nfs4-acl-tools+ (package+ (name "nfs4-acl-tools")+ (version "0.3.7")+ (source (origin+ (method git-fetch)+ ;; tarballs are available here:+ ;; http://linux-nfs.org/~bfields/nfs4-acl-tools/+ (uri (git-reference+ (url "git://git.linux-nfs.org/projects/bfields/nfs4-acl-tools.git")+ (commit (string-append name "-" version))))+ (file-name (git-file-name name version))+ (sha256+ (base32+ "0lq9xdaskxysggs918vs8x42xvmg9nj7lla21ni2scw5ljld3h1i"))+ (patches (search-patches "nfs4-acl-tools-0.3.7-fixpaths.patch"))))+ (build-system gnu-build-system)+ (arguments+ `(#:tests? #f ; no tests+ #:phases+ (modify-phases %standard-phases+ (add-after 'unpack 'fix-bin-sh+ (lambda* (#:key inputs native-inputs #:allow-other-keys)+ (substitute* "include/buildmacros"+ (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh")))+ #t)))))+ (native-inputs+ `(("automake" ,automake)+ ("autoconf" ,autoconf)+ ("bash-minimal" ,bash-minimal)+ ("libtool" ,libtool)))+ (inputs+ `(("attr" ,attr)))+ (home-page "http://linux-nfs.org/wiki/index.php/Main_Page")+ (synopsis "This package contains commandline ACL utilities for the Linux+NFSv4 client")+ (description "Provides the commandline utilities nfs4_setfacl and+nfs4_getfacl, which are similar to their POSIX equivalents.")+ (license bsd-3)))+diff --git a/gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch b/gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patchnew file mode 100644index 0000000000..23cb586766--- /dev/null+++ b/gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch@@ -0,0 +1,73 @@+Remove fixed search paths from autotools.++--- a/m4/package_utilies.m4 1970-01-01 01:00:01.000000000 +0100++++ b/m4/package_utilies.m4 2020-07-07 12:41:48.871661042 +0200+@@ -23,32 +23,32 @@+ AC_PACKAGE_NEED_UTILITY($1, "$cc", cc, [C compiler])+ + if test -z "$MAKE"; then+- AC_PATH_PROG(MAKE, gmake,, /usr/bin:/usr/freeware/bin)++ AC_PATH_PROG(MAKE, gmake)+ fi+ if test -z "$MAKE"; then+- AC_PATH_PROG(MAKE, make,, /usr/bin)++ AC_PATH_PROG(MAKE, make)+ fi+ make=$MAKE+ AC_SUBST(make)+ AC_PACKAGE_NEED_UTILITY($1, "$make", make, [GNU make])+ + if test -z "$LIBTOOL"; then+- AC_PATH_PROG(LIBTOOL, glibtool,, /usr/bin)++ AC_PATH_PROG(LIBTOOL, glibtool)+ fi+ if test -z "$LIBTOOL"; then+- AC_PATH_PROG(LIBTOOL, libtool,, /usr/bin:/usr/local/bin:/usr/freeware/bin)++ AC_PATH_PROG(LIBTOOL, libtool)+ fi+ libtool=$LIBTOOL+ AC_SUBST(libtool)+ AC_PACKAGE_NEED_UTILITY($1, "$libtool", libtool, [GNU libtool])+ + if test -z "$TAR"; then+- AC_PATH_PROG(TAR, tar,, /usr/freeware/bin:/bin:/usr/local/bin:/usr/bin)++ AC_PATH_PROG(TAR, tar)+ fi+ tar=$TAR+ AC_SUBST(tar)+ if test -z "$ZIP"; then+- AC_PATH_PROG(ZIP, gzip,, /bin:/usr/local/bin:/usr/freeware/bin)++ AC_PATH_PROG(ZIP, gzip)+ fi+ + zip=$ZIP+@@ -61,25 +61,25 @@+ AC_SUBST(makedepend)+ + if test -z "$AWK"; then+- AC_PATH_PROG(AWK, awk,, /bin:/usr/bin)++ AC_PATH_PROG(AWK, awk)+ fi+ awk=$AWK+ AC_SUBST(awk)+ + if test -z "$SED"; then+- AC_PATH_PROG(SED, sed,, /bin:/usr/bin)++ AC_PATH_PROG(SED, sed)+ fi+ sed=$SED+ AC_SUBST(sed)+ + if test -z "$ECHO"; then+- AC_PATH_PROG(ECHO, echo,, /bin:/usr/bin)++ AC_PATH_PROG(ECHO, echo)+ fi+ echo=$ECHO+ AC_SUBST(echo)+ + if test -z "$SORT"; then+- AC_PATH_PROG(SORT, sort,, /bin:/usr/bin)++ AC_PATH_PROG(SORT, sort)+ fi+ sort=$SORT+ AC_SUBST(sort)-- 2.20.1
-----BEGIN PGP SIGNATURE-----
iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8IMvoACgkQQhN3ARo3hEYN/Av+PopZHUdtHs9vAgbUpsUaokmZ+qd44kjS1jXGF9zUr6RzmBMXzN+qzFYYKxf2PP0+evXznV/RuGCTSI7LdYoXYexoZMZcrqlVoPCkfNb8pk3Xx+hRpN33VpLy/OoaqPALDDaP7paijJfsQGhqN2F9TM3KJzOWdFl0XNOwNnMJj9PFpuZsRcOhvAQyvHhmePivW1XLXgZ8QeujfrX+X/b0teZM2aVcyI6vtcBe2FldkcHn5Vba/vsnDYws3bU4B2ch/6DorDHkWL14M4iYo0bnHJ3D9LEYqPzZco37dKxUSJ/9SgJaM5WnYSwDx1bLwjWkYqIWnenp/8JzD27DAzXRVlCruL5zC1BPNw5XCdhVaDs7GKCS7USkfeGH7HClfEpdsXC0GaHHj3Lt0xSWFx26LQy/hnhbt5IXq5lUni7rqBvJZNA1WkegtTHSy758BThk9O9Mop2q/fUfoX/BZxfvqeHzB82Di4SPazNUsT+uF7QW4u+o3Xz2PjCQbqMr3U6D=q4xV-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 25 Jul 2020 17:20
87blk3vcyn.fsf@gnu.org
Hello!
Sorry for the late reply...
The patch mostly LGTM, but no longer applies. Can you rebase it oncurrent master? Meanwhile, a few comments:
Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:
Toggle quote (4 lines)> * gnu/packages/acl.scm (nfs4-acl-tools): New variable.> * gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.> * gnu/local.mk: Add it.
[...]
Toggle quote (3 lines)> + (synopsis "This package contains commandline ACL utilities for the Linux> +NFSv4 client")
Just "Command line ACL utilities for NFS"
Toggle quote (3 lines)> + (description "Provides the commandline utilities nfs4_setfacl and> +nfs4_getfacl, which are similar to their POSIX equivalents.")
Descriptions OTOH should be complete sentences, something like:
"This package provides the command line utilities@command{nfs4_setfacl} and @command{nfs4_getfacl} [...]".
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cTaAACgkQoqBt8qM6VPofawf/fjD9NyvMgoSYOqw0QIE9iMERiNKK4SzuhvTWDRmacnXB9I5GZU8pJRGTrMdqTA7MnX0Vmk2UaLuwoTk/didj93vri0Xfzen7PlHVAoOiCM022kj07HFnrCyRcZaDip+NcBViRodP8Eetojvka5YXKWrUTQLyAGssDe22rk+rzKKNA6a9KKqXLhdmPZsZmailxzeVq+9iP75V1qWTC9xFLrY4iLtz2gw1RM44jpPGZC7nwyAS0GdXGhMreWjhXZ4MlQWA6eCY5ufb+B6MWx1Ye888YHUxdwcjuytC4mJcU5fQ+hmuZfytXhqH8MmmjtQgX3rRNpNx15Iq/ZeYfmpzlg===kSzK-----END PGP SIGNATURE-----
L
L
Lars-Dominik Braun wrote on 27 Jul 2020 09:11
(name . Marius Bakke)(address . marius@gnu.org)(address . 42306@debbugs.gnu.org)
20200727071139.GB3225@zpidnp36
Hey Marius,
Toggle quote (1 lines)> Sorry for the late reply...
no problem.
Toggle quote (2 lines)> The patch mostly LGTM, but no longer applies. Can you rebase it on> current master? Meanwhile, a few comments:
Sure, see attached patch, which (hopefully) also improves the description.
I noticed linting fails with a pattern matching error, because git:// protocolURI’s are not supported. The second patch fixes it, but I’m not sure that’s a“proper” solution.
Cheers,Lars
From 41e8245fe4f5629a2382ca8dfa1558785d67ef78 Mon Sep 17 00:00:00 2001From: Lars-Dominik Braun <ldb@leibniz-psychology.org>Date: Fri, 10 Jul 2020 11:15:58 +0200Subject: [PATCH 1/2] gnu: Add nfs4-acl-tools
* gnu/packages/acl.scm (nfs4-acl-tools): New variable.* gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.* gnu/local.mk: Add it.--- gnu/local.mk | 1 + gnu/packages/acl.scm | 46 ++++++++++++ .../nfs4-acl-tools-0.3.7-fixpaths.patch | 73 +++++++++++++++++++ 3 files changed, 120 insertions(+) create mode 100644 gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch
Toggle diff (166 lines)diff --git a/gnu/local.mk b/gnu/local.mkindex 8274e158d0..34be1b02e8 100644--- a/gnu/local.mk+++ b/gnu/local.mk@@ -1321,6 +1321,7 @@ dist_patch_DATA = \ %D%/packages/patches/netsurf-system-utf8proc.patch \ %D%/packages/patches/netsurf-y2038-tests.patch \ %D%/packages/patches/netsurf-longer-test-timeout.patch \+ %D%/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch \ %D%/packages/patches/ngircd-handle-zombies.patch \ %D%/packages/patches/network-manager-plugin-path.patch \ %D%/packages/patches/nsis-env-passthru.patch \diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scmindex bcab125164..128afc52c2 100644--- a/gnu/packages/acl.scm+++ b/gnu/packages/acl.scm@@ -5,6 +5,7 @@ ;;; Copyright © 2017 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net> ;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com>+;;; Copyright © 2020 Lars-Dominik Braun <ldb@leibniz-psychology.org> ;;; ;;; This file is part of GNU Guix. ;;;@@ -24,11 +25,14 @@ (define-module (gnu packages acl) #:use-module (guix licenses) #:use-module (gnu packages attr)+ #:use-module (gnu packages autotools) #:use-module (gnu packages base)+ #:use-module (gnu packages bash) #:use-module (gnu packages gettext) #:use-module (gnu packages perl) #:use-module (guix packages) #:use-module (guix download)+ #:use-module (guix git-download) #:use-module (gnu packages) #:use-module (guix build-system gnu)) @@ -89,3 +93,45 @@ (description "Library and tools for manipulating access control lists.") (license (list gpl2+ lgpl2.1+))))++(define-public nfs4-acl-tools+ (package+ (name "nfs4-acl-tools")+ (version "0.3.7")+ (source (origin+ (method git-fetch)+ ;; tarballs are available here:+ ;; http://linux-nfs.org/~bfields/nfs4-acl-tools/+ (uri (git-reference+ (url "git://git.linux-nfs.org/projects/bfields/nfs4-acl-tools.git")+ (commit (string-append name "-" version))))+ (file-name (git-file-name name version))+ (sha256+ (base32+ "0lq9xdaskxysggs918vs8x42xvmg9nj7lla21ni2scw5ljld3h1i"))+ (patches (search-patches "nfs4-acl-tools-0.3.7-fixpaths.patch"))))+ (build-system gnu-build-system)+ (arguments+ `(#:tests? #f ; no tests+ #:phases+ (modify-phases %standard-phases+ (add-after 'unpack 'fix-bin-sh+ (lambda* (#:key inputs native-inputs #:allow-other-keys)+ (substitute* "include/buildmacros"+ (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh")))+ #t)))))+ (native-inputs+ `(("automake" ,automake)+ ("autoconf" ,autoconf)+ ("bash-minimal" ,bash-minimal)+ ("libtool" ,libtool)))+ (inputs+ `(("attr" ,attr)))+ (home-page "https://linux-nfs.org/wiki/index.php/Main_Page")+ (synopsis "Commandline ACL utilities for the Linux NFSv4 client")+ (description "This package provides the commandline utilities+@command{nfs4_getfacl} and @command{nfs4_setfacl}, which are similar to their+POSIX equivalents @command{getfacl} and @command{setfacl}. They fetch and+manipulate access control lists for files and directories on NFSv4 mounts.")+ (license bsd-3)))+diff --git a/gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch b/gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patchnew file mode 100644index 0000000000..23cb586766--- /dev/null+++ b/gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch@@ -0,0 +1,73 @@+Remove fixed search paths from autotools.++--- a/m4/package_utilies.m4 1970-01-01 01:00:01.000000000 +0100++++ b/m4/package_utilies.m4 2020-07-07 12:41:48.871661042 +0200+@@ -23,32 +23,32 @@+ AC_PACKAGE_NEED_UTILITY($1, "$cc", cc, [C compiler])+ + if test -z "$MAKE"; then+- AC_PATH_PROG(MAKE, gmake,, /usr/bin:/usr/freeware/bin)++ AC_PATH_PROG(MAKE, gmake)+ fi+ if test -z "$MAKE"; then+- AC_PATH_PROG(MAKE, make,, /usr/bin)++ AC_PATH_PROG(MAKE, make)+ fi+ make=$MAKE+ AC_SUBST(make)+ AC_PACKAGE_NEED_UTILITY($1, "$make", make, [GNU make])+ + if test -z "$LIBTOOL"; then+- AC_PATH_PROG(LIBTOOL, glibtool,, /usr/bin)++ AC_PATH_PROG(LIBTOOL, glibtool)+ fi+ if test -z "$LIBTOOL"; then+- AC_PATH_PROG(LIBTOOL, libtool,, /usr/bin:/usr/local/bin:/usr/freeware/bin)++ AC_PATH_PROG(LIBTOOL, libtool)+ fi+ libtool=$LIBTOOL+ AC_SUBST(libtool)+ AC_PACKAGE_NEED_UTILITY($1, "$libtool", libtool, [GNU libtool])+ + if test -z "$TAR"; then+- AC_PATH_PROG(TAR, tar,, /usr/freeware/bin:/bin:/usr/local/bin:/usr/bin)++ AC_PATH_PROG(TAR, tar)+ fi+ tar=$TAR+ AC_SUBST(tar)+ if test -z "$ZIP"; then+- AC_PATH_PROG(ZIP, gzip,, /bin:/usr/local/bin:/usr/freeware/bin)++ AC_PATH_PROG(ZIP, gzip)+ fi+ + zip=$ZIP+@@ -61,25 +61,25 @@+ AC_SUBST(makedepend)+ + if test -z "$AWK"; then+- AC_PATH_PROG(AWK, awk,, /bin:/usr/bin)++ AC_PATH_PROG(AWK, awk)+ fi+ awk=$AWK+ AC_SUBST(awk)+ + if test -z "$SED"; then+- AC_PATH_PROG(SED, sed,, /bin:/usr/bin)++ AC_PATH_PROG(SED, sed)+ fi+ sed=$SED+ AC_SUBST(sed)+ + if test -z "$ECHO"; then+- AC_PATH_PROG(ECHO, echo,, /bin:/usr/bin)++ AC_PATH_PROG(ECHO, echo)+ fi+ echo=$ECHO+ AC_SUBST(echo)+ + if test -z "$SORT"; then+- AC_PATH_PROG(SORT, sort,, /bin:/usr/bin)++ AC_PATH_PROG(SORT, sort)+ fi+ sort=$SORT+ AC_SUBST(sort)-- 2.20.1
From 5c9dddd0d4b54ca73f4fe4ebac37789bde0e54ce Mon Sep 17 00:00:00 2001From: Lars-Dominik Braun <ldb@leibniz-psychology.org>Date: Mon, 27 Jul 2020 09:09:24 +0200Subject: [PATCH 2/2] =?UTF-8?q?guix:=20lint:=20Ignore=20unsupported=20sour?= =?UTF-8?q?ce=20URL=E2=80=99s.?=MIME-Version: 1.0Content-Type: text/plain; charset=UTF-8Content-Transfer-Encoding: 8bit
* guix/lint.scm (check-source): Add match case for #f.--- guix/lint.scm | 3 +++ 1 file changed, 3 insertions(+)
Toggle diff (16 lines)diff --git a/guix/lint.scm b/guix/lint.scmindex 8a55f3e744..395630aa1c 100644--- a/guix/lint.scm+++ b/guix/lint.scm@@ -794,6 +794,9 @@ descriptions maintained upstream." (#t ;; We found a working URL, so stop right away. '())+ (#f+ ;; Unsupported URL or other error, skip.+ (loop rest '())) ((? lint-warning? warning) (loop rest (cons warning warnings)))))))) -- 2.20.1
-----BEGIN PGP SIGNATURE-----
iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8eficACgkQQhN3ARo3hEYQvgv/Z54B3HgqnwiFYhQmH/0JxRJ9Qf3RnjsJ7fJVxPmZzHpAOBmhSd2xXgCWYvJn1xbzWcanX1gmi4nANQsVd4Bq5ILKe1dW5MQMsBhxxqMyznaxHlXHdVXxa/yfziEbsX8BWJeSFIiVTmm1VxDC+DNHp6al8fJAN9LAHesoJa30BI5JNZMsv5/Mr/voJmIL7u9anpG5MB+5AomTkfHvDAjVVk6DrSKVK+OG/16pcItAUDPMsLxixLU9LqkCMBlIkpqPb5XYQBI4myf/goY+RLS0OsqXX0mpKsRTgGoKT8BtN982FxwEJteKgyZnkGqFMRkC2T0SOEh6OFr3PpGnXBf6aBKrb8Xkod/ZuVEGgiFA9DZfGFGytJwaaC7Cz5mUiw3A/uCr5wQmMS12NMUnk97//4i89R4yyI0Q24oxqvRWUrKLEoh17lqjIsFFjifOUD5vM+KqmGkywg7wBZJFmZOi+RpRHlDUh3kf0Bdz0/2NiNInYBxSew2gPSc6iUSGmRNv=xPhs-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 30 Jul 2020 00:01
(name . Lars-Dominik Braun)(address . ldb@leibniz-psychology.org)(address . 42306@debbugs.gnu.org)
87k0ymq8uf.fsf@gnu.org
Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:
Toggle quote (9 lines)> Hey Marius,>>> Sorry for the late reply...> no problem.>>> The patch mostly LGTM, but no longer applies. Can you rebase it on>> current master? Meanwhile, a few comments:> Sure, see attached patch, which (hopefully) also improves the description.
Thanks! FYI I had to convert the patch from ISO-8859-1 encoding toUTF-8 in order to make it apply.
Applied with the following changes:
Toggle diff (34 lines)diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scmindex 128afc52c2..a6409765ff 100644--- a/gnu/packages/acl.scm+++ b/gnu/packages/acl.scm@@ -27,7 +27,6 @@ #:use-module (gnu packages attr) #:use-module (gnu packages autotools) #:use-module (gnu packages base)- #:use-module (gnu packages bash) #:use-module (gnu packages gettext) #:use-module (gnu packages perl) #:use-module (guix packages)@@ -116,14 +115,13 @@ #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-bin-sh- (lambda* (#:key inputs native-inputs #:allow-other-keys)+ (lambda _ (substitute* "include/buildmacros"- (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh")))+ (("/bin/sh") (which "sh"))) #t))))) (native-inputs `(("automake" ,automake) ("autoconf" ,autoconf)- ("bash-minimal" ,bash-minimal) ("libtool" ,libtool))) (inputs `(("attr" ,attr)))@@ -134,4 +132,3 @@ POSIX equivalents @command{getfacl} and @command{setfacl}. They fetch and manipulate access control lists for files and directories on NFSv4 mounts.") (license bsd-3)))-
...however I also decided to move it to (gnu packages nfs).
Toggle quote (4 lines)> I noticed linting fails with a pattern matching error, because git:// protocol> URI’s are not supported. The second patch fixes it, but I’m not sure that’s a> “proper” solution.
Me neither and I don't feel like jumping on that one right away. :-)
It seems we already have a number of git:// URLs around so it would begood to fix it, can you submit the second patch to a separate issue?
Thanks!
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8h8bgACgkQoqBt8qM6VPouAgf9F38mmXe+AMpLcKeitAgwBdIqlYk/0sOa+qKDJZhfwmPwjK2VAw4Hl+GpodoJgz6SzVStp78pKfWSmcSMCb3GETIV/0rG2xm4upG3c4L+l4t33opFERWvy+nYlqdbhFyCVSZ4JAaElx1R1VbXLUXEamKoYpQgkIFR4H77oiDrrb16b23zzcbFmyLI6ONprl2q8KVhwDIv76a2mDmPzu5ZfXASOMr9wQ8SdgkV+kHczBMMiCDKtQZyO7/ktNAc2GmCqjCQmd0a5nCYOBnuQWr4an7ktEt2ienH7FcTGuR36nHUZJ6uiBFhso2w8ItbQB2yezTtEbcc25OqiqpPTPdwqQ===ywmL-----END PGP SIGNATURE-----
L
L
Lars-Dominik Braun wrote on 30 Jul 2020 09:17
(name . Marius Bakke)(address . marius@gnu.org)(address . 42306@debbugs.gnu.org)
20200730071738.GB3210@zpidnp36
Hey,
Toggle quote (2 lines)> Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to> UTF-8 in order to make it apply.
hm, that’s weird, it worked for me.
Toggle quote (2 lines)> It seems we already have a number of git:// URLs around so it would be> good to fix it, can you submit the second patch to a separate issue?
Done, see bug#42615
Thank you,Lars
-----BEGIN PGP SIGNATURE-----
iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8idA8ACgkQQhN3ARo3hEYzBwwAgYxqHrWtRafO3oIC6BLKJGZf09Ms4k+tsz+07zErf58kJbekNtpTbvVTUGpcp3uSmOUIPKX7hE960k10gW5NE+vspqnIzyEBlIjRirHkRCTEMnYqltfXV84mVFmmri4ulNxEL7IKdNVJC0s3jBwvoSHeuqmkjPngMl1UXz20OoFzNPVkKhsKgg9cAjSyYCyaWcEr4p+OoitYP1ni5ERXkj5ruWm7oBw+hzaGeQL1ZbkXr//8ar9JsCygp6obyP7G8ooLwB4rYcXPKyRBiPjellTiplD6g5ewCY70xiA2co6MsE5OCcO1Xso+GC3q+vgtsuxdFyKdtT4wWfPRVIOIlTj51MaqtqERKhoWdoXtHlIIIqov327SQJqYd4dVtAvjvd8KFl6DxCZjajRxGxIY2SkNHkMPBn7XeJVrCMIcOi3Wus3sEo4zWiTwczWSqFoRdf2Fh7Uv+dhrpHJH76X/FvAmy8/7UNftIrCUiluPKJBuymgKogvUU7XD34ivKCRJ=Hk9p-----END PGP SIGNATURE-----

M
M
Michael Rohleder wrote on 9 Sep 2020 16:11
control message for bug #42306
(address . control@debbugs.gnu.org)
87tuw7jb0g.fsf@rohleder.de
tags 42306 fixedclose 42306 quit
?