[PATCH] gnu: gsettings-desktop-schemas: patch monospace font.

DoneSubmitted by Leo Prikler.
Details
2 participants
  • Leo Prikler
  • Marius Bakke
Owner
unassigned
Severity
normal
L
L
Leo Prikler wrote on 25 Feb 2020 15:59
(address . guix-patches@gnu.org)
20200225145910.26066-1-leo.prikler@student.tugraz.at
* gnu/packages/gnome.scm (gsettings-desktop-schemas)[arguments]<phases>:
Rename `set-adwaita-theme-file-name' to the more generic `patch-schemas'.
Add patch for the monospace font (Source Code Pro 10 -> Monospace 11).
Adjust comments.
---
gnu/packages/gnome.scm | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

Toggle diff (28 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index af45ceb505..e066b4c93c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1575,15 +1575,17 @@ on the GNOME Desktop with a single simple application.")
     (build-system meson-build-system)
     (arguments
      '(#:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'set-adwaita-theme-file-name
+                  (add-after 'unpack 'patch-schemas
                     (lambda* (#:key inputs #:allow-other-keys)
-                      ;; Provide the correct file name of the default GNOME
-                      ;; background, 'adwaita-timed.xml'.
                       (let ((theme (assoc-ref inputs "gnome-backgrounds")))
                         (substitute* (find-files "schemas"
                                                  "\\.gschema\\.xml\\.in$")
+                          ;; Provide the correct file name of the default GNOME
+                          ;; background, 'adwaita-timed.xml'.
                           (("@datadir@/backgrounds/gnome")
-                           (string-append theme "/share/backgrounds/gnome")))
+                           (string-append theme "/share/backgrounds/gnome"))
+                          ;; Do not reference fonts, that may not exist.
+                          (("'Source Code Pro 10'") "'Monospace 11'"))
                         #t))))))
     (inputs
      `(("glib" ,glib)
-- 
2.25.1
L
L
Leo Prikler wrote on 15 Mar 2020 14:41
(address . 39783@debbugs.gnu.org)
2e3dc55b871505bd41d298e66d89a641aeb75245.camel@student.tugraz.at
It appears this has fallen under the radar.
To perhaps clarify the intent of this patch, it fixes the bug, where
GNOME Terminal and other stuff that relies on the Monospace font being
defined appears quite ugly with the default settings.

Regards,
Leo
M
M
Marius Bakke wrote on 20 Mar 2020 19:02
87a74a9a67.fsf@devup.no
Leo Prikler <leo.prikler@student.tugraz.at> writes:

Toggle quote (5 lines)
> * gnu/packages/gnome.scm (gsettings-desktop-schemas)[arguments]<phases>:
> Rename `set-adwaita-theme-file-name' to the more generic `patch-schemas'.
> Add patch for the monospace font (Source Code Pro 10 -> Monospace 11).
> Adjust comments.

Thanks for finding the root cause of the broken default gnome-terminal
font. Since there has been no feedback in a couple of weeks, I went
ahead and applied it.

I also updated your copyright header. Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl51BUAACgkQoqBt8qM6
VPr7kQf/TBofwNhjXsY36cOV4SpwlLMZyh4U7m8OLruF81lOCKDPSMC+YSyNNkRt
JssfrCwX4tLPz2FwHwo/Z5h/P21D8KqekOyp/0xFJk/5FFoZCDYCSLm5gy/V0Gzw
ZEh8nfIMjpI5caYNANfiALV0usGF50Wy2vRkZIcENpkReebaDaGhq5u7JC8wa7v8
Ep94iYxmx0sMOnPHAorOOqNU2Z6IHrWJQ6Nd/8dTTuhBMf/XEKiPM6RjBekpBmNf
v1CTNYAxzCqHnYT5AyW3rtwMEmddQyNUNutVJQtaa1r+vzx771M7pnvioctPnEUr
+BGWjnE/mF5eEl393lPqgVNphlARdw==
=huNB
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 39783@debbugs.gnu.org