[PATCH] go: update to 1.13

  • Done
  • quality assurance status badge
Details
3 participants
  • Alex Griffin
  • Jack Hill
  • Leo Famulari
Owner
unassigned
Submitted by
Jack Hill
Severity
normal
J
J
Jack Hill wrote on 11 Feb 2020 20:45
go: update to 1.13
(address . guix-patches@gnu.org)
alpine.DEB.2.20.2002111413020.11123@marsh.hcoop.net
Hi Guix,

The following is the minimal patch to update Go to 1.13. I'm motivated to
do this, in part, because of the go modules transition [0]. In the short
term, this will allow users of the go tooling to use the newest modules
behavior. The Guix go tooling, however, is not ready for modules [1], so
in this commit, I configure the go-build-system to use the old behavior.
Eventually the switch to do so will go away upstream, so we'll need to
update the build system.

Some things to be aware of when reviewing:

I believe that in Go 1.13, the upstream issued that lead to excessive
references being maintained in go programs [2] has been fixed, but I did
not undo our workaround.

With 1.13 the behavior of `go get` changed to download packages from
Google's mirror at proxy.golang.org by default [3] as opposed to directly
from upstream. This is configurable by users, and I don't think it is a
FSDG issue (if it is, I think it would be on privacy grounds), but we
could change the default behavior if needed.

I replaced the go-1.12 package with go-1.13, rather than having both.

guix refresh -l go says that "Building the following 51 packages would
ensure 175 dependent packages are rebuilt," so I have prepared the commit
against master.

I tested the commit by building syncthing and restic on my x86_64 system.


Thanks,
Jack
J
J
Jack Hill wrote on 11 Feb 2020 20:48
[PATCH] gnu: go: update to 1.13.2
(address . 39570@debbugs.gnu.org)(address . jackhill@jackhill.us)
20200211194820.24012-1-jackhill@jackhill.us
* gnu/packages/golang.scm (go-1.12): Rename to go-1.13, [version]: Update to
1.13.7
(go): Update to go-1.13
* guix/build/go-build-system.scm (setup-go-environment): Set GO111MODULE to
off.
---
gnu/packages/golang.scm | 9 ++++-----
guix/build/go-build-system.scm | 4 ++++
2 files changed, 8 insertions(+), 5 deletions(-)

Toggle diff (61 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 9102469749..798600f680 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -216,11 +216,11 @@ in the style of communicating sequential processes (@dfn{CSP}).")
(supported-systems '("x86_64-linux" "i686-linux" "armhf-linux" "aarch64-linux"))
(license license:bsd-3)))
-(define-public go-1.12
+(define-public go-1.13
(package
(inherit go-1.4)
(name "go")
- (version "1.12.16")
+ (version "1.13.7")
(source
(origin
(method url-fetch)
@@ -228,7 +228,7 @@ in the style of communicating sequential processes (@dfn{CSP}).")
name version ".src.tar.gz"))
(sha256
(base32
- "1y0x10fsvgpc1x24b9q9y6kv9b0kwf7879am3p0gym2abgc5wvnf"))))
+ "1x21kfpzfkvmqd42pan6nl862m7jjl4niqxxpcgm46awbz645bg4"))))
(arguments
(substitute-keyword-arguments (package-arguments go-1.4)
((#:phases phases)
@@ -367,7 +367,6 @@ in the style of communicating sequential processes (@dfn{CSP}).")
(docs (string-append doc_out "/share/doc/" ,name "-" ,version))
(src (string-append
(assoc-ref outputs "tests") "/share/" ,name "-" ,version)))
- (delete-file-recursively "../pkg/bootstrap")
;; Prevent installation of the build cache, which contains
;; store references to most of the tools used to build Go and
;; would unnecessarily increase the size of Go's closure if it
@@ -405,7 +404,7 @@ in the style of communicating sequential processes (@dfn{CSP}).")
,@(package-native-inputs go-1.4)))
(supported-systems %supported-systems)))
-(define-public go go-1.12)
+(define-public go go-1.13)
(define-public go-github-com-alsm-ioprogress
(let ((commit "063c3725f436e7fba0c8f588547bee21ffec7ac5")
diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm
index 4bc0156a88..3337552d96 100644
--- a/guix/build/go-build-system.scm
+++ b/guix/build/go-build-system.scm
@@ -141,6 +141,10 @@ dependencies, so it should be self-contained."
;; Using the current working directory as GOPATH makes it easier for packagers
;; who need to manipulate the unpacked source code.
(setenv "GOPATH" (getcwd))
+ ;; Go 1.13 uses go modules by default. The go build system does not
+ ;; currently support modules, so turn modules off to continue using the old
+ ;; GOPATH behavior.
+ (setenv "GO111MODULE" "off")
(setenv "GOBIN" (string-append (assoc-ref outputs "out") "/bin"))
(let ((tmpdir (tmpnam)))
(match (go-inputs inputs)
--
2.25.0
A
A
Alex Griffin wrote on 11 Feb 2020 21:24
(address . control@debbugs.gnu.org)
26ba5b3f-41df-4b19-a92d-ce1ecef175c8@www.fastmail.com
retitle 39570 [PATCH] go: update to 1.13
tags 39570 patch
A
A
Alex Griffin wrote on 11 Feb 2020 23:55
(address . 39570-done@debbugs.gnu.org)
015e137d-a3ca-469c-9f43-509cdef80917@www.fastmail.com
I just split this up into 2 patches and committed to master. Thanks for contributing!

--
Alex Griffin
Closed
J
J
Jack Hill wrote on 12 Feb 2020 03:45
[PATCH] go: update to 1.13
(address . 39570@debbugs.gnu.org)
alpine.DEB.2.20.2002112144490.11123@marsh.hcoop.net
Alex,

Awesome, thanks for fixing it up and pushing.

Best,
Jack
L
L
Leo Famulari wrote on 12 Feb 2020 22:43
Re: [bug#39570] go: update to 1.13
(name . Jack Hill)(address . jackhill@jackhill.us)(address . 39570@debbugs.gnu.org)
20200212214302.GA20114@jasmine.lan
On Tue, Feb 11, 2020 at 02:45:27PM -0500, Jack Hill wrote:
Toggle quote (4 lines)
> I believe that in Go 1.13, the upstream issued that lead to excessive
> references being maintained in go programs [2] has been fixed, but I did not
> undo our workaround.

I wonder, should it be a goal to undo it? It's not idiomatic for Guix,
but it is for Go. I had stopped thinking of it as a workaround.

Toggle quote (6 lines)
> With 1.13 the behavior of `go get` changed to download packages from
> Google's mirror at proxy.golang.org by default [3] as opposed to directly
> from upstream. This is configurable by users, and I don't think it is a FSDG
> issue (if it is, I think it would be on privacy grounds), but we could
> change the default behavior if needed.

I don't see any issues here.
J
J
Jack Hill wrote on 12 Feb 2020 23:01
(name . Leo Famulari)(address . leo@famulari.name)(address . 39570@debbugs.gnu.org)
alpine.DEB.2.20.2002121653390.11123@marsh.hcoop.net
On Wed, 12 Feb 2020, Leo Famulari wrote:

Toggle quote (8 lines)
> On Tue, Feb 11, 2020 at 02:45:27PM -0500, Jack Hill wrote:
>> I believe that in Go 1.13, the upstream issued that lead to excessive
>> references being maintained in go programs [2] has been fixed, but I did not
>> undo our workaround.
>
> I wonder, should it be a goal to undo it? It's not idiomatic for Guix,
> but it is for Go. I had stopped thinking of it as a workaround.

Perhaps not. I don't see a strong need to revert, but wanted to point out
that the original reason for doing that had changed.

Best,
Jack
?
Your comment

This issue is archived.

To comment on this conversation send an email to 39570@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 39570
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch