Upgrade mallard-ducktype to 1.0.2

Done

Details

2 participants

Efraim Flashner
Jack Hill

Owner: unassigned

Submitted by: Jack Hill

Severity: normal

Jack Hill wrote on 22 Jul 2019 02:05

Recipients:(address . guix-patches@gnu.org)

Message-ID:alpine.DEB.2.20.1907211953410.9756@marsh.hcoop.net

Hi Guix,

mallard-ducktype 1.0.2 has been released, so I've prepared the following

patch to update our package definition.

Notable in this release is the availability of a source tarball on pypi,

so I've updated the package definition to use that instead of a git

reference.

[0] http://projectmallard.org/pipermail/mallard-list/2019-July/000295.html

Best,

Jack

Jack Hill wrote on 22 Jul 2019 02:08

[PATCH] gnu: mallard-ducktype: Update to 1.0.2.

Recipients:(address . 36755@debbugs.gnu.org)(name . Jack Hill)(address . jackhill@jackhill.us)

Message-ID:20190722000800.28933-1-jackhill@jackhill.us

With this release a source tarball is newly available on PyPI.

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.

[source] Use pypi uri.

---

gnu/packages/python-xyz.scm | 13 ++++---------

1 file changed, 4 insertions(+), 9 deletions(-)

Toggle diff (30 lines)diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6e90c9a933..43bcc377e7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,14 @@ and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
-       (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
-       (uri (git-reference
-             (url "https://github.com/projectmallard/mallard-ducktype.git")
-             (commit version)))
-       (file-name (git-file-name name version))
+       (method url-fetch)
+       (uri (pypi-uri name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1xxx8jqsqais91li2wl9jbc9fzhgq1gbi24lf9kx43j6fjck25cf"))))
     (build-system python-build-system)
     (home-page "http://projectmallard.org")
     (synopsis "Convert Ducktype to Mallard documentation markup")
-- 
2.22.0

Efraim Flashner wrote on 22 Jul 2019 08:50

Recipients:(name . Jack Hill)(address . jackhill@jackhill.us)(address . 36755@debbugs.gnu.org)

Message-ID:20190722065056.GL1034@macbook41

The patch applies cleanly but it turns out the test suite doesn't run.

Digging a little further, the test suite isn't included with the pypi

release, so I'd prefer to stay with the git checkout so we can run the

test suite.

Can you send an updated patch that keeps the git checkout?

Thanks

Efraim Flashner <efraim@flashner.co.il> ????? ?????

GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351

Confidentiality cannot be guaranteed on emails sent or received unencrypted

Jack Hill wrote on 22 Jul 2019 15:27

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 36755@debbugs.gnu.org)

Message-ID:alpine.DEB.2.20.1907220925300.9756@marsh.hcoop.net

On Mon, 22 Jul 2019, Efraim Flashner wrote:

Toggle quote (5 lines)

> The patch applies cleanly but it turns out the test suite doesn't run.

> Digging a little further, the test suite isn't included with the pypi

> release, so I'd prefer to stay with the git checkout so we can run the

> test suite.

Thanks for the review and catching that. I agree that sticking with the

git checkout sounds like the correct course of action.

Toggle quote (2 lines)

> Can you send an updated patch that keeps the git checkout?

Sure, new patch coming shortly.

Jack Hill wrote on 22 Jul 2019 15:33

[PATCH v2] gnu: mallard-ducktype: Update to 1.0.2.

Recipients:(address . 36755@debbugs.gnu.org)

Message-ID:20190722133301.21156-1-jackhill@jackhill.us

* gnu/packages/python-xyz.scm (mallard-ducktype) Update to 1.0.2.

---

gnu/packages/python-xyz.scm | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

Toggle diff (30 lines)diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d8f144893d..362ab7f031 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3122,19 +3122,19 @@ and is very extensible.")
 (define-public mallard-ducktype
   (package
     (name "mallard-ducktype")
-    (version "1.0.1")
+    (version "1.0.2")
     (source
      (origin
        (method git-fetch)
-       ;; git-reference because a proper source tarball is not available
-       ;; https://lists.gnu.org/archive/html/guix-devel/2019-05/msg00209.html
+       ;; git-reference because tests are not included in pypi source tarball
+       ;; https://issues.guix.gnu.org/issue/36755#2
        (uri (git-reference
              (url "https://github.com/projectmallard/mallard-ducktype.git")
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0crland0kmpsyjfmnflcw7gaqy5b87b6ah17cmr9d5z1kyazf54n"))))
+         "1jk9bfz7g04ip78s03b0xak6d54rj4h9zpgadkziy1ji216g6y4c"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
-- 
2.22.0

Efraim Flashner wrote on 23 Jul 2019 08:10

Recipients:(name . Jack Hill)(address . jackhill@jackhill.us)(address . 36755-done@debbugs.gnu.org)

Message-ID:20190723061044.GA780@macbook41

patch pushed. Thanks!

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 36755@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date