import: github: Sort releases before picking the latest one.

Done

Details

2 participants

Arun Isaac
Ludovic Courtès

Owner: unassigned

Submitted by: Arun Isaac

Severity: normal

Arun Isaac wrote on 11 May 2019 13:23

Recipients:(address . guix-patches@gnu.org)

Message-ID:cu7h8a19qvq.fsf@systemreboot.net

Prior to this, for some packages (e.g., osc in (gnu packages
build-tools)), `guix refresh' could not find the latest version
correctly.

From 33f42ea8a33c6e502062708336a5ab8be871c92b Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sat, 11 May 2019 16:40:38 +0530
Subject: [PATCH] import: github: Sort releases before picking the latest one.

* guix/import/github.scm (latest-released-version): Sort releases before
picking the first one as the latest.
---
 guix/import/github.scm | 55 ++++++++++++++++++++++--------------------
 1 file changed, 29 insertions(+), 26 deletions(-)

Toggle diff (68 lines)diff --git a/guix/import/github.scm b/guix/import/github.scm
index 4d12339204..a8af318bc8 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -183,32 +183,35 @@ API when using a GitHub token")
 API. This may be fixed by using an access token and setting the environment
 variable GUIX_GITHUB_TOKEN, for instance one procured from
 https://github.com/settings/tokens"))
-        (any
-         (lambda (release)
-           (let ((tag (or (hash-ref release "tag_name") ;a "release"
-                          (hash-ref release "name")))   ;a tag
-                 (name-length (string-length package-name)))
-             (cond
-              ;; some tags include the name of the package e.g. "fdupes-1.51"
-              ;; so remove these
-              ((and (< name-length (string-length tag))
-                    (string=? (string-append package-name "-")
-                              (substring tag 0 (+ name-length 1))))
-               (substring tag (+ name-length 1)))
-              ;; some tags start with a "v" e.g. "v0.25.0"
-              ;; where some are just the version number
-              ((string-prefix? "v" tag)
-               (substring tag 1))
-              ;; Finally, reject tags that don't start with a digit:
-              ;; they may not represent a release.
-              ((and (not (string-null? tag))
-                    (char-set-contains? char-set:digit
-                                        (string-ref tag 0)))
-               tag)
-              (else #f))))
-         (match (remove pre-release? json)
-           (() json) ; keep everything
-           (releases releases))))))
+        (first
+         (sort
+          (filter-map
+           (lambda (release)
+             (let ((tag (or (hash-ref release "tag_name") ;a "release"
+                            (hash-ref release "name")))   ;a tag
+                   (name-length (string-length package-name)))
+               (cond
+                ;; some tags include the name of the package e.g. "fdupes-1.51"
+                ;; so remove these
+                ((and (< name-length (string-length tag))
+                      (string=? (string-append package-name "-")
+                                (substring tag 0 (+ name-length 1))))
+                 (substring tag (+ name-length 1)))
+                ;; some tags start with a "v" e.g. "v0.25.0"
+                ;; where some are just the version number
+                ((string-prefix? "v" tag)
+                 (substring tag 1))
+                ;; Finally, reject tags that don't start with a digit:
+                ;; they may not represent a release.
+                ((and (not (string-null? tag))
+                      (char-set-contains? char-set:digit
+                                          (string-ref tag 0)))
+                 tag)
+                (else #f))))
+           (match (remove pre-release? json)
+             (() json) ; keep everything
+             (releases releases)))
+          version>?)))))
 
 (define (latest-release pkg)
   "Return an <upstream-source> for the latest release of PKG."
-- 
2.21.0

Ludovic Courtès wrote on 12 May 2019 23:47

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 35684@debbugs.gnu.org)

Message-ID:87mujrs5ut.fsf@gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

Toggle quote (4 lines)

> Prior to this, for some packages (e.g., osc in (gnu packages

> build-tools)), `guix refresh' could not find the latest version

> correctly.

Good catch.

Toggle quote (8 lines)

> From 33f42ea8a33c6e502062708336a5ab8be871c92b Mon Sep 17 00:00:00 2001

> From: Arun Isaac <arunisaac@systemreboot.net>

> Date: Sat, 11 May 2019 16:40:38 +0530

> Subject: [PATCH] import: github: Sort releases before picking the latest one.

> * guix/import/github.scm (latest-released-version): Sort releases before

> picking the first one as the latest.

[...]

Toggle quote (30 lines)> +        (first
> +         (sort
> +          (filter-map
> +           (lambda (release)
> +             (let ((tag (or (hash-ref release "tag_name") ;a "release"
> +                            (hash-ref release "name")))   ;a tag
> +                   (name-length (string-length package-name)))
> +               (cond
> +                ;; some tags include the name of the package e.g. "fdupes-1.51"
> +                ;; so remove these
> +                ((and (< name-length (string-length tag))
> +                      (string=? (string-append package-name "-")
> +                                (substring tag 0 (+ name-length 1))))
> +                 (substring tag (+ name-length 1)))
> +                ;; some tags start with a "v" e.g. "v0.25.0"
> +                ;; where some are just the version number
> +                ((string-prefix? "v" tag)
> +                 (substring tag 1))
> +                ;; Finally, reject tags that don't start with a digit:
> +                ;; they may not represent a release.
> +                ((and (not (string-null? tag))
> +                      (char-set-contains? char-set:digit
> +                                          (string-ref tag 0)))
> +                 tag)
> +                (else #f))))
> +           (match (remove pre-release? json)
> +             (() json) ; keep everything
> +             (releases releases)))
> +          version>?)))))

LGTM, but…

… while you’re at it, would you mind cleaning this up a bit? :-)

Namely, I think this big ‘lambda’ could be given a name and moved out of

the way to make ‘latest-released-version’ easier to read. Also, it

would probably be reasonable to avoid ‘first’ and instead write:

(match (sort …)

((first . _) first)

(()

(leave (G_ "no releases found etc.~%"))))

WDYT? :-)

If you’d rather leave that for later, you can also just go ahead and

commit your patch.

Thanks,

Ludo’.

Arun Isaac wrote on 13 May 2019 10:08

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 35684@debbugs.gnu.org)

Message-ID:cu7zhnq93p6.fsf@systemreboot.net

Toggle quote (14 lines)> Namely, I think this big ‘lambda’ could be given a name and moved out of
> the way to make ‘latest-released-version’ easier to read.  Also, it
> would probably be reasonable to avoid ‘first’ and instead write:
>
>   (match (sort …)
>     ((first . _) first)
>     (()
>      (leave (G_ "no releases found etc.~%"))))
>
> WDYT?  :-)
>
> If you’d rather leave that for later, you can also just go ahead and
> commit your patch.

No problem! :-) Here is the updated patch.

From d3f28de8fedc41732a07edf2ea91222208ccc73f Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sat, 11 May 2019 16:40:38 +0530
Subject: [PATCH] import: github: Sort releases before picking the latest one.

* guix/import/github.scm (latest-released-version): Sort releases before
picking the first one as the latest.
---
 guix/import/github.scm | 56 ++++++++++++++++++++++--------------------
 1 file changed, 30 insertions(+), 26 deletions(-)

Toggle diff (76 lines)diff --git a/guix/import/github.scm b/guix/import/github.scm
index 4d12339204..cdac70420a 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -174,6 +174,29 @@ the package e.g. 'bedtools2'.  Return #f if there is no releases"
   (define (pre-release? x)
     (hash-ref x "prerelease"))
 
+  (define (release->version release)
+    (let ((tag (or (hash-ref release "tag_name") ;a "release"
+                   (hash-ref release "name")))   ;a tag
+          (name-length (string-length package-name)))
+      (cond
+       ;; some tags include the name of the package e.g. "fdupes-1.51"
+       ;; so remove these
+       ((and (< name-length (string-length tag))
+             (string=? (string-append package-name "-")
+                       (substring tag 0 (+ name-length 1))))
+        (substring tag (+ name-length 1)))
+       ;; some tags start with a "v" e.g. "v0.25.0"
+       ;; where some are just the version number
+       ((string-prefix? "v" tag)
+        (substring tag 1))
+       ;; Finally, reject tags that don't start with a digit:
+       ;; they may not represent a release.
+       ((and (not (string-null? tag))
+             (char-set-contains? char-set:digit
+                                 (string-ref tag 0)))
+        tag)
+       (else #f))))
+
   (let* ((json (fetch-releases-or-tags url)))
     (if (eq? json #f)
         (if (%github-token)
@@ -183,32 +206,13 @@ API when using a GitHub token")
 API. This may be fixed by using an access token and setting the environment
 variable GUIX_GITHUB_TOKEN, for instance one procured from
 https://github.com/settings/tokens"))
-        (any
-         (lambda (release)
-           (let ((tag (or (hash-ref release "tag_name") ;a "release"
-                          (hash-ref release "name")))   ;a tag
-                 (name-length (string-length package-name)))
-             (cond
-              ;; some tags include the name of the package e.g. "fdupes-1.51"
-              ;; so remove these
-              ((and (< name-length (string-length tag))
-                    (string=? (string-append package-name "-")
-                              (substring tag 0 (+ name-length 1))))
-               (substring tag (+ name-length 1)))
-              ;; some tags start with a "v" e.g. "v0.25.0"
-              ;; where some are just the version number
-              ((string-prefix? "v" tag)
-               (substring tag 1))
-              ;; Finally, reject tags that don't start with a digit:
-              ;; they may not represent a release.
-              ((and (not (string-null? tag))
-                    (char-set-contains? char-set:digit
-                                        (string-ref tag 0)))
-               tag)
-              (else #f))))
-         (match (remove pre-release? json)
-           (() json) ; keep everything
-           (releases releases))))))
+        (match (sort (filter-map release->version
+                                 (match (remove pre-release? json)
+                                   (() json) ; keep everything
+                                   (releases releases)))
+                     version>?)
+          ((latest-release . _) latest-release)
+          (() #f)))))
 
 (define (latest-release pkg)
   "Return an <upstream-source> for the latest release of PKG."
-- 
2.21.0

Ludovic Courtès wrote on 13 May 2019 15:42

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 35684@debbugs.gnu.org)

Message-ID:87d0kmsc66.fsf@gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

Toggle quote (8 lines)

> From d3f28de8fedc41732a07edf2ea91222208ccc73f Mon Sep 17 00:00:00 2001

> From: Arun Isaac <arunisaac@systemreboot.net>

> Date: Sat, 11 May 2019 16:40:38 +0530

> Subject: [PATCH] import: github: Sort releases before picking the latest one.

> * guix/import/github.scm (latest-released-version): Sort releases before

> picking the first one as the latest.

Very nice, LGTM! If you don’t mind, you can make it two patches for

clarity (one that defines ‘release->version’, and one that adds the call

to ‘sort’); otherwise just amend the commit log above to mention

‘release->version’.

Thank you!

Ludo’.

Arun Isaac wrote on 14 May 2019 12:19

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 35684@debbugs.gnu.org)

Message-ID:cu7y3398hk3.fsf@systemreboot.net

Toggle quote (3 lines)

> If you don’t mind, you can make it two patches for clarity (one that

> defines ‘release->version’, and one that adds the call to ‘sort’)

Sure, pleae find attached.

From c96956bc6e944f9691773640e402c15215078943 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Tue, 14 May 2019 15:44:46 +0530
Subject: [PATCH 1/2] import: github: Improve readability.

* guix/import/github.scm (latest-released-version)[release->version]: Separate
out release->version as a new function.
---
 guix/import/github.scm | 53 +++++++++++++++++++++---------------------
 1 file changed, 27 insertions(+), 26 deletions(-)

Toggle diff (73 lines)diff --git a/guix/import/github.scm b/guix/import/github.scm
index 4d12339204..5f4d9c7267 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -174,6 +174,29 @@ the package e.g. 'bedtools2'.  Return #f if there is no releases"
   (define (pre-release? x)
     (hash-ref x "prerelease"))
 
+  (define (release->version release)
+    (let ((tag (or (hash-ref release "tag_name") ;a "release"
+                   (hash-ref release "name")))   ;a tag
+          (name-length (string-length package-name)))
+      (cond
+       ;; some tags include the name of the package e.g. "fdupes-1.51"
+       ;; so remove these
+       ((and (< name-length (string-length tag))
+             (string=? (string-append package-name "-")
+                       (substring tag 0 (+ name-length 1))))
+        (substring tag (+ name-length 1)))
+       ;; some tags start with a "v" e.g. "v0.25.0"
+       ;; where some are just the version number
+       ((string-prefix? "v" tag)
+        (substring tag 1))
+       ;; Finally, reject tags that don't start with a digit:
+       ;; they may not represent a release.
+       ((and (not (string-null? tag))
+             (char-set-contains? char-set:digit
+                                 (string-ref tag 0)))
+        tag)
+       (else #f))))
+
   (let* ((json (fetch-releases-or-tags url)))
     (if (eq? json #f)
         (if (%github-token)
@@ -183,32 +206,10 @@ API when using a GitHub token")
 API. This may be fixed by using an access token and setting the environment
 variable GUIX_GITHUB_TOKEN, for instance one procured from
 https://github.com/settings/tokens"))
-        (any
-         (lambda (release)
-           (let ((tag (or (hash-ref release "tag_name") ;a "release"
-                          (hash-ref release "name")))   ;a tag
-                 (name-length (string-length package-name)))
-             (cond
-              ;; some tags include the name of the package e.g. "fdupes-1.51"
-              ;; so remove these
-              ((and (< name-length (string-length tag))
-                    (string=? (string-append package-name "-")
-                              (substring tag 0 (+ name-length 1))))
-               (substring tag (+ name-length 1)))
-              ;; some tags start with a "v" e.g. "v0.25.0"
-              ;; where some are just the version number
-              ((string-prefix? "v" tag)
-               (substring tag 1))
-              ;; Finally, reject tags that don't start with a digit:
-              ;; they may not represent a release.
-              ((and (not (string-null? tag))
-                    (char-set-contains? char-set:digit
-                                        (string-ref tag 0)))
-               tag)
-              (else #f))))
-         (match (remove pre-release? json)
-           (() json) ; keep everything
-           (releases releases))))))
+        (any release->version
+             (match (remove pre-release? json)
+               (() json) ; keep everything
+               (releases releases))))))
 
 (define (latest-release pkg)
   "Return an <upstream-source> for the latest release of PKG."
-- 
2.21.0

From 8192712f8108d0abcd527ff6b16af073c453b780 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Tue, 14 May 2019 15:46:19 +0530
Subject: [PATCH 2/2] import: github: Sort releases before picking the latest
 one.

* guix/import/github.scm (latest-released-version): Sort releases before
picking the first one as the latest.
---
 guix/import/github.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Toggle diff (24 lines)diff --git a/guix/import/github.scm b/guix/import/github.scm
index 5f4d9c7267..cdac70420a 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -206,10 +206,13 @@ API when using a GitHub token")
 API. This may be fixed by using an access token and setting the environment
 variable GUIX_GITHUB_TOKEN, for instance one procured from
 https://github.com/settings/tokens"))
-        (any release->version
-             (match (remove pre-release? json)
-               (() json) ; keep everything
-               (releases releases))))))
+        (match (sort (filter-map release->version
+                                 (match (remove pre-release? json)
+                                   (() json) ; keep everything
+                                   (releases releases)))
+                     version>?)
+          ((latest-release . _) latest-release)
+          (() #f)))))
 
 (define (latest-release pkg)
   "Return an <upstream-source> for the latest release of PKG."
-- 
2.21.0

Ludovic Courtès wrote on 14 May 2019 22:59

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 35684@debbugs.gnu.org)

Message-ID:87tvdwwy4p.fsf@gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

Toggle quote (5 lines)

>> If you don’t mind, you can make it two patches for clarity (one that

>> defines ‘release->version’, and one that adds the call to ‘sort’)

> Sure, pleae find attached.

Thank you, it still LGTM. :-)

Ludo’.

Arun Isaac wrote on 15 May 2019 10:25

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 35684-done@debbugs.gnu.org)

Message-ID:cu77eas86ps.fsf@systemreboot.net

Pushed to master, thanks!

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 35684@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date