Web server: response bodies systematically loaded in memory

OpenSubmitted by Ludovic Courtès.
Details
2 participants
  • Ludovic Courtès
  • Andy Wingo
Owner
unassigned
Severity
normal
L
L
Ludovic Courtès wrote on 20 Jul 2015 00:10
(address . bug-guile@gnu.org)
87a8uriysr.fsf@gnu.org
The ‘sanitize-response’ procedure systematically loads the whole
response body in memory, which causes obvious scalability issues (this
is in 2.0.11.)

In particular, when a request handler returns a port-taking procedure as
its second return value, ‘sanitize-request’ will just call that
procedure passing it a string output port.

This procedure should instead be called from the server implementation’s
‘write’ hook, but that would necessitate an API change.

Thoughts?

Ludo’.
A
A
Andy Wingo wrote on 24 Jun 2016 10:15
(name . Ludovic Courtès)(address . ludo@gnu.org)
874m8jhuj7.fsf@pobox.com
On Mon 20 Jul 2015 00:10, ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (13 lines)
> The ‘sanitize-response’ procedure systematically loads the whole
> response body in memory, which causes obvious scalability issues (this
> is in 2.0.11.)
>
> In particular, when a request handler returns a port-taking procedure as
> its second return value, ‘sanitize-request’ will just call that
> procedure passing it a string output port.
>
> This procedure should instead be called from the server implementation’s
> ‘write’ hook, but that would necessitate an API change.
>
> Thoughts?

How would you set the Content-Length? Just leave it off and set
Connection: close ? Set it in the headers perhaps? Then you have to
verify later, which I dunno how nice that is. Maybe it is OK.

I would be happy to review patches :) Cc guile-devel.

Andy
L
L
Ludovic Courtès wrote on 24 Jun 2016 10:58
(name . Andy Wingo)(address . wingo@pobox.com)
87r3bn7yky.fsf@gnu.org
Andy Wingo <wingo@pobox.com> skribis:

Toggle quote (19 lines)
> On Mon 20 Jul 2015 00:10, ludo@gnu.org (Ludovic Courtès) writes:
>
>> The ‘sanitize-response’ procedure systematically loads the whole
>> response body in memory, which causes obvious scalability issues (this
>> is in 2.0.11.)
>>
>> In particular, when a request handler returns a port-taking procedure as
>> its second return value, ‘sanitize-request’ will just call that
>> procedure passing it a string output port.
>>
>> This procedure should instead be called from the server implementation’s
>> ‘write’ hook, but that would necessitate an API change.
>>
>> Thoughts?
>
> How would you set the Content-Length? Just leave it off and set
> Connection: close ? Set it in the headers perhaps? Then you have to
> verify later, which I dunno how nice that is. Maybe it is OK.

I think it could work this way:

1. By default, provide no ‘Content-Length’ and force chunked encoding
(so that the recipient can make sure it received everything.)

This is useful for data generated on the fly.

2. Provide an optional mechanism allowing the user to specify the
content length upfront.

Useful for statically-generated data that cannot fit in memory.

I haven’t thought yet about the actual API (I’ll be happy to do so as
time permits; to be clear, I don’t consider it a 2.0.12 blocker.)

Ludo’.
?