[PATCH v1] gnu: ntp: Fix crash.

  • Open
  • quality assurance status badge
Details
3 participants
  • Ian Eure
  • Jakob Kirsch
  • Leo Famulari
Owner
unassigned
Submitted by
Jakob Kirsch
Severity
normal

Debbugs page

Jakob Kirsch wrote 3 days ago
(address . guix-patches@gnu.org)
Z82xl1Cr97F_x0S3@kernelpanicroom
ntpd segfaults at boot so here is a patch to fix that.
Attachment: v1-0001-gnu-ntp-Fix-crash.patch
Leo Famulari wrote 3 days ago
(name . Jakob Kirsch via Guix-patches via)(address . guix-patches@gnu.org)(address . 76892@debbugs.gnu.org)
Z84JzmCqe0J5Nzsa@jasmine.lan
On Sun, Mar 09, 2025 at 04:19:51PM +0100, Jakob Kirsch via Guix-patches via wrote:
Toggle quote (12 lines)
> ntpd segfaults at boot so here is a patch to fix that.

> From 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17 00:00:00 2001
> Message-ID: <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob.kirsch@web.de>
> From: Jakob Kirsch <jakob.kirsch@web.de>
> Date: Sun, 9 Mar 2025 16:16:43 +0100
> Subject: [PATCH v1] gnu: ntp: Fix crash.
>
> * gnu/packages/ntp.scm (ntp): Add patch.
> * gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch: Add patch.
> * gnu/local.mk (dist_patch_DATA): Register patch.

Is the only change in this patch that we build ntp with the new patch
file? And the rest of it is changes to indentation? Or are there other
changes too?
Jakob Kirsch wrote 3 days ago
(no subject)
(address . 76892@debbugs.gnu.org)
Z84NkYrU8f0ep_Np@kernelpanicroom
Yes I only added the patch to fix the crash (it's a typo where ep should be ep2) and ran `guix style ntp` on it.
Ian Eure wrote 2 days ago
Re: [bug#76892] [PATCH v1] gnu: ntp: Fix crash.
(name . Leo Famulari)(address . leo@famulari.name)(address . 76892@debbugs.gnu.org)
871pv5cwz9.fsf@retrospec.tv
Hi Jakob, Leo,

Leo Famulari <leo@famulari.name> writes:

Toggle quote (24 lines)
> On Sun, Mar 09, 2025 at 04:19:51PM +0100, Jakob Kirsch via
> Guix-patches via wrote:
>> ntpd segfaults at boot so here is a patch to fix that.
>
>> From 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17
>> 00:00:00 2001
>> Message-ID:
>> <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob.kirsch@web.de>
>> From: Jakob Kirsch <jakob.kirsch@web.de>
>> Date: Sun, 9 Mar 2025 16:16:43 +0100
>> Subject: [PATCH v1] gnu: ntp: Fix crash.
>>
>> * gnu/packages/ntp.scm (ntp): Add patch.
>> *
>> gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch:
>> Add patch.
>> * gnu/local.mk (dist_patch_DATA): Register patch.
>
> Is the only change in this patch that we build ntp with the new
> patch
> file? And the rest of it is changes to indentation? Or are there
> other
> changes too?

Here’s the upstream bug(s):

I think this patch is fine, we might also consider rolling back to
4.2.8p17.

-- Ian
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76892@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76892
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help