gdk-pixbuf GDK_PIXBUF_MODULE_FILES search path breaks some packages

  • Done
  • quality assurance status badge
Details
3 participants
  • Morgan Smith
  • 宋文武
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Morgan Smith
Severity
normal

Debbugs page

Morgan Smith wrote 1 weeks ago
(address . bug-guix@gnu.org)
CH3PR84MB342465ED7C3B560B326146E8C5C92@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
I tried to reopen this bug instead of making a new one but I guess it's
archived or something? bug#75795

Changing the search-path-specification of gdk-pixbuf has broken the
build of transmission as this phase now errors out:

=========
(wrap-program (string-append #$output:gui "/bin/transmission-gtk")
;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
;; its own icons in pure environments.
`("GDK_PIXBUF_MODULE_FILE" =
(,(getenv "GDK_PIXBUF_MODULE_FILE"))))
=========

Doing a quick search it looks like there at least 10 packages that need
to be adjusted
宋文武 wrote 1 weeks ago
(name . Morgan Smith)(address . Morgan.J.Smith@outlook.com)
87ikoq3e1n.fsf@envs.net
Morgan Smith <Morgan.J.Smith@outlook.com> writes:

Toggle quote (17 lines)
> I tried to reopen this bug instead of making a new one but I guess it's
> archived or something? bug#75795
>
> Changing the search-path-specification of gdk-pixbuf has broken the
> build of transmission as this phase now errors out:
>
> =========
> (wrap-program (string-append #$output:gui "/bin/transmission-gtk")
> ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
> ;; its own icons in pure environments.
> `("GDK_PIXBUF_MODULE_FILE" =
> (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
> =========
>
> Doing a quick search it looks like there at least 10 packages that need
> to be adjusted

Hello, I had pushed fixes for transmission and xournalpp. Other using
glib-or-gtk or meson build system still works as GDK_PIXBUF_MODULE_FILE
was set in the generate-gdk-pixbuf-loaders-cache-file phase.

Wrap binaries with GUIX_GDK_PIXBUF_MODULE_FILES is not ideal currently,
since it would contain duplicated loaders from cache files. After we
remove the generate-gdk-pixbuf-loaders-cache-file phase, we can wrap
with GUIX_GDK_PIXBUF_MODULE_FILES, which should mostly only contains
gdk-pixbuf and librsvg.

Thanks.
Closed
Maxim Cournoyer wrote 1 weeks ago
(name . Morgan Smith)(address . Morgan.J.Smith@outlook.com)
87eczdeink.fsf@gmail.com
Hi Morgan,

Morgan Smith <Morgan.J.Smith@outlook.com> writes:

Toggle quote (3 lines)
> I tried to reopen this bug instead of making a new one but I guess it's
> archived or something? bug#75795

Yes, after a while issues get archived and become comment-only. There's
an 'unarchive' action for Debbugs along a 'reopen', which can be used
like so at the top of the email body, making sure to cc 'GNU Debbugs
<control@debbugs.gnu.org>' to act on it:

Toggle snippet (5 lines)
unarchive 75697
reopen 75697
quit

Toggle quote (14 lines)
> Changing the search-path-specification of gdk-pixbuf has broken the
> build of transmission as this phase now errors out:
>
> =========
> (wrap-program (string-append #$output:gui "/bin/transmission-gtk")
> ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
> ;; its own icons in pure environments.
> `("GDK_PIXBUF_MODULE_FILE" =
> (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
> =========
>
> Doing a quick search it looks like there at least 10 packages that need
> to be adjusted

Thanks for reporting that. So could the adjustments needed simply be
made with just:

Toggle snippet (4 lines)
git grep -l GDK_PIXBUF_MODULE_FILE |
xargs sed 's/GDK_PIXBUF_MODULE_FILE/s/GDK_PIXBUF_MODULE_FILES/' -i

?

--
Maxim
Maxim Cournoyer wrote 1 weeks ago
(name . 宋文武)(address . iyzsong@envs.net)
87a5a1eimf.fsf@gmail.com
Hi,

宋文武 <iyzsong@envs.net> writes:

Toggle quote (29 lines)
> Morgan Smith <Morgan.J.Smith@outlook.com> writes:
>
>> I tried to reopen this bug instead of making a new one but I guess it's
>> archived or something? bug#75795
>>
>> Changing the search-path-specification of gdk-pixbuf has broken the
>> build of transmission as this phase now errors out:
>>
>> =========
>> (wrap-program (string-append #$output:gui "/bin/transmission-gtk")
>> ;; Wrapping GDK_PIXBUF_MODULE_FILE allows Transmission to load
>> ;; its own icons in pure environments.
>> `("GDK_PIXBUF_MODULE_FILE" =
>> (,(getenv "GDK_PIXBUF_MODULE_FILE"))))
>> =========
>>
>> Doing a quick search it looks like there at least 10 packages that need
>> to be adjusted
>
> Hello, I had pushed fixes for transmission and xournalpp. Other using
> glib-or-gtk or meson build system still works as GDK_PIXBUF_MODULE_FILE
> was set in the generate-gdk-pixbuf-loaders-cache-file phase.
>
> Wrap binaries with GUIX_GDK_PIXBUF_MODULE_FILES is not ideal currently,
> since it would contain duplicated loaders from cache files. After we
> remove the generate-gdk-pixbuf-loaders-cache-file phase, we can wrap
> with GUIX_GDK_PIXBUF_MODULE_FILES, which should mostly only contains
> gdk-pixbuf and librsvg.

Thanks for the explanation and acting on the report!

--
Thanks,
Maxim
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76697@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76697
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help