[PATCH 0/1] dir-locals: Add copyrights.

  • Open
  • quality assurance status badge
Details
2 participants
  • Denis 'GNUtoo' Carikli
  • Tomas Volf
Owner
unassigned
Submitted by
Denis 'GNUtoo' Carikli
Severity
normal

Debbugs page

Denis 'GNUtoo' Carikli wrote 3 weeks ago
(address . guix-patches@gnu.org)(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)
cover.1740605156.git.GNUtoo@cyberdimension.org
Hi,

I'd like to reuse .dir-locals.el in another package (GNU Boot), and already
having correct copyright ownership on .dir-locals.el makes it easier to do
that.

Denis 'GNUtoo' Carikli (1):
dir-locals: Add copyrights.

.dir-locals.el | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)


base-commit: 8bc831325a905dbd9015739b58e3a5138d2217da
--
2.46.0
Denis 'GNUtoo' Carikli wrote 3 weeks ago
[PATCH 1/1] dir-locals: Add copyrights.
(address . 76601@debbugs.gnu.org)(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)
e0eee50e021b34bb47bcfc1024a6bd58c2aaccb7.1740605156.git.GNUtoo@cyberdimension.org
* .dir-locals.el: Add copyrights.

The list was first generated with the 'git log --reverse --oneline
--pretty=";;; Copyright © %ad %an <%ae>" --follow --date="format:%Y" --
.dir-locals.el' command, and then the lines were regrouped together by hand,
and finally the names and mails were updated to the ones currently used with
the help of git grep.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Change-Id: I010f1e5e3afc8b646da39dc6341f7870f0c9bf45
---
.dir-locals.el | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)

Toggle diff (43 lines)
diff --git a/.dir-locals.el b/.dir-locals.el
index d629b51c8a..b215f53227 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,5 +1,35 @@
-;; Per-directory local variables for GNU Emacs 23 and later.
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2012-2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2013,2014 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
+;;; Copyright © 2015 David Thompson <davet@gnu.org>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
+;;; Copyright © 2018-2020 Caleb Ristvedt <caleb.ristvedt@cune.org>
+;;; Copyright © 2020-2023 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Miguel Ángel Arruga Vivas <rosen644835@gmail.com>
+;;; Copyright © 2020 Christine Lemmer-Webber <cwebber@dustycloud.org>
+;;; Copyright © 2022 Liliana Marie Prikler <liliana.prikler@gmail.com>
+;;; Copyright © 2022 Andrew Tropin <andrew@trop.in>
+;;; Copyright © 2022 Brian Cully <bjc@kublai.com>
+;;; Copyright © 2023 (unmatched-parenthesis ew syntax <paren@disroot.org>
+;;; Copyright © 2024 Christopher Baines <mail@cbaines.net>
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+;; Per-directory local variables for GNU Emacs 23 and later.
((nil
. ((fill-column . 78)
(tab-width . 8)
--
2.46.0
Tomas Volf wrote 3 weeks ago
(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 76601@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(name . jgart)(address . jgart@dismail.de)(name . Mathieu Othacehe)(address . othacehe@gnu.org)(name . Christopher Baines)(address . guix@cbaines.net)
871pvkqlbr.fsf@wolfsden.cz
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> writes:

Toggle quote (37 lines)
> * .dir-locals.el: Add copyrights.
>
> The list was first generated with the 'git log --reverse --oneline
> --pretty=";;; Copyright © %ad %an <%ae>" --follow --date="format:%Y" --
> .dir-locals.el' command, and then the lines were regrouped together by hand,
> and finally the names and mails were updated to the ones currently used with
> the help of git grep.
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> Change-Id: I010f1e5e3afc8b646da39dc6341f7870f0c9bf45
> ---
> .dir-locals.el | 32 +++++++++++++++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index d629b51c8a..b215f53227 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,5 +1,35 @@
> -;; Per-directory local variables for GNU Emacs 23 and later.
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2012-2023 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2013,2014 Mark H Weaver <mhw@netris.org>
> +;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
> +;;; Copyright © 2015 David Thompson <davet@gnu.org>
> +;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
> +;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
> +;;; Copyright © 2018-2020 Caleb Ristvedt <caleb.ristvedt@cune.org>
> +;;; Copyright © 2020-2023 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2020 Miguel Ángel Arruga Vivas <rosen644835@gmail.com>
> +;;; Copyright © 2020 Christine Lemmer-Webber <cwebber@dustycloud.org>
> +;;; Copyright © 2022 Liliana Marie Prikler <liliana.prikler@gmail.com>
> +;;; Copyright © 2022 Andrew Tropin <andrew@trop.in>
> +;;; Copyright © 2022 Brian Cully <bjc@kublai.com>
> +;;; Copyright © 2023 (unmatched-parenthesis ew syntax <paren@disroot.org>
> +;;; Copyright © 2024 Christopher Baines <mail@cbaines.net>

Interesting, for some reason I am missing here. I wonder why your
command missed these two commits.

Toggle snippet (4 lines)
350be583d4 .dir-locals.el: Configure indentation for home-environment.
9dce86b1cb .dir-locals: Configure indentation for swap-space.

Actually, it look like for example Nicolas Graves is also missing.

Toggle quote (20 lines)
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
>
> +;; Per-directory local variables for GNU Emacs 23 and later.
> ((nil
> . ((fill-column . 78)
> (tab-width . 8)

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
Denis 'GNUtoo' Carikli wrote 24 hours ago
(name . Tomas Volf)(address . ~@wolfsden.cz)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 76601@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(name . jgart)(address . jgart@dismail.de)(name . Mathieu Othacehe)(address . othacehe@gnu.org)(name . Christopher Baines)(address . guix@cbaines.net)
20250316032830.721a298d@primary_laptop
Hi,

On Thu, 27 Feb 2025 01:32:08 +0100
Tomas Volf <~@wolfsden.cz> wrote:
Toggle quote (2 lines)
> Interesting, for some reason I am missing here. I wonder why your
> command missed these two commits.
Thanks a lot for spotting that. I had the same issue with GNU Boot few
days ago and there, using --reverse also missed some commits (the ones
you found and also one from Maxim Cournoyer in 2025).

I'll send a v2 with the missing commits/copyrights.

Denis.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmfWN1oACgkQX138wUF3
4mOhlQ/+JNavzf46xhiNjmWqszzRRTBotpzsEActSrjlpuy3XqA5zi0orbSSyahV
j5qKGT5VXGLJaLETHRDL8PLNLIpxld9f4RUzp92CN5+52l567xh7pzudyIVq9sSt
LS1gWABLMJ+TLnaJYX8pSEOxLvg51+BDfdiUOsgXcOq3WlsvVzake/6pZkEjOZN6
orqaAqkb6D9gKuy7evh7Kbq07+2iQvgwksG54fAX6P5O3i9LH6H+0z52qSsiiEH/
Jk5/DPitENb/f3BSqoy/CSU70WC0ZjxejgU/GHT/jKqZJg84UKJuQzbrnibJO+CS
zvWPN2eSQe10h0iSQfI5CTnR54HfSYpahDbnRtRRYYub7Pd/tMy/FZOmv03oG6/b
vFHQSzH09T/TEdcjHMJPV4+A4WY0f/a5TrB5C2V3kJZMXeu3WdssYvKo2JZv+UUe
qjJQv23hN0e9PcimEvMk06Gs2cDUGvQNntL4gBqB+4d0+STY9A3ovjBsmwsYSzpy
YpgHHu/4jfkoBtQrp7Yh0IsQWQ9V0PZZTFc4+8aHmzz+9Xscy/kI+Sw3yRzKN5K5
xqtQ/cU4xQSV15OfeaS3iW0GGwuq+MTqV0rlcJkF3Ko7Gidf+6EjxlV79RFYqdvx
st9mAxbNum56/90Vktx+uk+5pp1bpcV9NvC0Qi6MTYQ2J5k6V0M=
=akx1
-----END PGP SIGNATURE-----


Denis 'GNUtoo' Carikli wrote 24 hours ago
[PATCH v2] dir-locals: Add copyrights.
(address . 76601@debbugs.gnu.org)(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)
31fa271a10a3142204bfe3e0a43c59c52e3846e7.1742092173.git.GNUtoo@cyberdimension.org
* .dir-locals.el: Add copyrights.

The list was first generated with the 'git log --oneline
--pretty=";;; Copyright © %ad %an <%ae>" --follow --date="format:%Y" --
.dir-locals.el' command, and then the lines were regrouped together by hand,
and finally the names and mails were updated to the ones currently used with
the help of git grep.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Change-Id: I010f1e5e3afc8b646da39dc6341f7870f0c9bf45
---
ChangeLog v1->v2:
=================
* Fixed the command in the commit log (it didn't list all the commits).
* Added missing Copyrights (Tomas Volf, Nicolas Graves, and 2025 for Maxim
Cournoyer). Thanks to Tomas Volf who found the issue.
---
.dir-locals.el | 34 +++++++++++++++++++++++++++++++++-
1 file changed, 33 insertions(+), 1 deletion(-)

Toggle diff (47 lines)
diff --git a/.dir-locals.el b/.dir-locals.el
index 76c9e12992..983a92f5a6 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,5 +1,37 @@
-;; Per-directory local variables for GNU Emacs 23 and later.
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2012-2023 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2013,2014 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
+;;; Copyright © 2015 David Thompson <davet@gnu.org>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
+;;; Copyright © 2018-2020 Caleb Ristvedt <caleb.ristvedt@cune.org>
+;;; Copyright © 2020-2023,2025 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Miguel Ángel Arruga Vivas <rosen644835@gmail.com>
+;;; Copyright © 2020 Christine Lemmer-Webber <cwebber@dustycloud.org>
+;;; Copyright © 2022 Liliana Marie Prikler <liliana.prikler@gmail.com>
+;;; Copyright © 2022 Andrew Tropin <andrew@trop.in>
+;;; Copyright © 2022 Brian Cully <bjc@kublai.com>
+;;; Copyright © 2023 (unmatched-parenthesis ew syntax <paren@disroot.org>
+;;; Copyright © 2024 Christopher Baines <mail@cbaines.net>
+;;; Copyright © 2024 Tomas Volf <~@wolfsden.cz>
+;;; Copyright © 2024 Nicolas Graves <ngraves@ngraves.fr>
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+;; Per-directory local variables for GNU Emacs 23 and later.
((nil
. ((fill-column . 78)
(tab-width . 8)

base-commit: 51c28379d64ab361473964f8f634224f0dfb24c1
--
2.46.0
Tomas Volf wrote 11 hours ago
(name . Denis 'GNUtoo' Carikli)(address . GNUtoo@cyberdimension.org)(address . 76601@debbugs.gnu.org)
87iko9uhd4.fsf@wolfsden.cz
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> writes:

Toggle quote (8 lines)
> * .dir-locals.el: Add copyrights.
>
> The list was first generated with the 'git log --oneline
> --pretty=";;; Copyright © %ad %an <%ae>" --follow --date="format:%Y" --
> .dir-locals.el' command, and then the lines were regrouped together by hand,
> and finally the names and mails were updated to the ones currently used with
> the help of git grep.

I have used the following command to verify the content of the patch:

Toggle snippet (6 lines)
git log --pretty='format:%as %an %ae' orig-master -- .dir-locals.el \
| sed -E 's/-[0-9]{2}-[0-9]{2}//' \
| sed -E 's/(....) (.*)/\2 \1/' \
| sort -u

Toggle quote (38 lines)
>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> Change-Id: I010f1e5e3afc8b646da39dc6341f7870f0c9bf45
> ---
> ChangeLog v1->v2:
> =================
> * Fixed the command in the commit log (it didn't list all the commits).
> * Added missing Copyrights (Tomas Volf, Nicolas Graves, and 2025 for Maxim
> Cournoyer). Thanks to Tomas Volf who found the issue.
> ---
> .dir-locals.el | 34 +++++++++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 76c9e12992..983a92f5a6 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,5 +1,37 @@
> -;; Per-directory local variables for GNU Emacs 23 and later.
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2012-2023 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2013,2014 Mark H Weaver <mhw@netris.org>
> +;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
> +;;; Copyright © 2015 David Thompson <davet@gnu.org>
> +;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
> +;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
> +;;; Copyright © 2018-2020 Caleb Ristvedt <caleb.ristvedt@cune.org>
> +;;; Copyright © 2020-2023,2025 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2020 Miguel Ángel Arruga Vivas <rosen644835@gmail.com>
> +;;; Copyright © 2020 Christine Lemmer-Webber <cwebber@dustycloud.org>
> +;;; Copyright © 2022 Liliana Marie Prikler <liliana.prikler@gmail.com>
> +;;; Copyright © 2022 Andrew Tropin <andrew@trop.in>
> +;;; Copyright © 2022 Brian Cully <bjc@kublai.com>
> +;;; Copyright © 2023 (unmatched-parenthesis ew syntax <paren@disroot.org>
> +;;; Copyright © 2024 Christopher Baines <mail@cbaines.net>
> +;;; Copyright © 2024 Tomas Volf <~@wolfsden.cz>
> +;;; Copyright © 2024 Nicolas Graves <ngraves@ngraves.fr>

Hi, me again :) I think you are missing David Elsing. I am not sure how
fresh your git checkout is, but on current master I see:

Toggle snippet (5 lines)
commit 30e51cb6b42e86f9f94d6380f69a1020ee99ff39
Author: David Elsing <david.elsing@posteo.net>
Date: Tue Mar 4 20:33:08 2025 +0000

One more nitpick could be that paren@disroot.org is known under multiple
names in our git history, and I am not sure which one is preferred.
Edits to .dir-locals.el were made under two of them, you picked the last
name used. However last commit to Guix repository itself uses different
name (just `(unmatched-parenthesis').

Other than that LGTM.

Tomas

Reviewed-by: Tomas Volf <~@wolfsden.cz>

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmfW7ZcOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wamALA/9ELrKXkE4wDaNxaq9UgvLmW4B5StjJI43OkJq
tbzsbTVpKsW4nzrL1DNniXAxQQMU+WrXCfotfOg3upLc5DX/NcmK/wSe0jUKksDW
aJ5B7vgzasmTsG8adu+Le+wzNLaPj5hx3i0RiFRE/YER/yPOvoENbBNs2AfJnDQt
sN2kXANjkdRy5XJ1poDp6TqC1HAWzhbcnbmbyhOobtUzj4PHL9J9s/OVRaO0DpZm
psZrX5xSoqC2Mm7eOCH7azSdeA2oR625ozDpWDRdYz0AP59enDRmNU8wlVfCgXy7
SiA3rGvabnz1W+VNDUcDWxL6lkugG/TOdkLP7wlpOOYyIHYF/XMvqpC4MJh7YqKv
SR005WjcMWN3RAGERJwOEvXj/9re4CS0neiYxHFWASpBXgjmJRHsK7K+40WkaOQW
l93fbpjNKmWV0REXHmIb49KFPUGvysP3HDmHU6bXSacqOBmsikaqF2gJrOsS08Za
prLmtIu8orfJbJABwGbk8Ft6n1T6XSrhBEGkl32xHKJHnE132Kz0uF2pUyXSgum1
+25cmsxh2pV6+9w0GRFcm4dml0NTeKrwfVfQnAW5cpSmdrvVr0utr/kZ6L6eUw85
Kzz00mq0QviHsRoOJwhVmnwm/h47+J7R83quR9nf6HMayrFzjPWFfr/pcFN/Mih5
FWGcebs=
=Jexb
-----END PGP SIGNATURE-----

?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76601@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76601
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help