[PATCH] gnu: emacs-elfeed-org: Update to latest.

  • Done
  • quality assurance status badge
Details
3 participants
  • Cayetano Santos
  • Ian Eure
  • Sergey Trofimov
Owner
unassigned
Submitted by
Sergey Trofimov
Severity
normal

Debbugs page

Sergey Trofimov wrote 3 weeks ago
(address . guix-patches@gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
992242237f7755573d897ba14f05f131d589b302.1739963065.git.sarg@sarg.org.ru
* gnu/packages/emacs-xyz.scm (emacs-elfeed-org): Update to latest.
[arguments]: Remove obsolete testing tweaks.
[propagated-inputs]: Remove unused dependencies.
---
gnu/packages/emacs-xyz.scm | 32 +++++++-------------------------
1 file changed, 7 insertions(+), 25 deletions(-)

Toggle diff (62 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5e48fab7e8..d888657cfa 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15911,10 +15911,12 @@ (define-public emacs-elfeed-goodies
(license license:gpl3+))))
(define-public emacs-elfeed-org
- (let ((commit "77b6bbf222487809813de260447d31c4c59902c9"))
+ (let ((commit "1197cf29f6604e572ec604874a8f50b58081176a")
+ (version "0.1")
+ (revision "2"))
(package
(name "emacs-elfeed-org")
- (version (git-version "0.1" "1" commit))
+ (version (git-version version revision commit))
(source
(origin
(method git-fetch)
@@ -15923,33 +15925,13 @@ (define-public emacs-elfeed-org
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "0a2ibka82xq1dhy2z7rd2y9zhcj8rna8357881yz49wf55ccgm53"))))
+ (base32 "0giwnzlqk2s5hb6fs8a0l4dxcmn2fvkngpj1fayzwj0qnvds1kri"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #t
- #:test-command '("ert-runner" "-L" "org-mode/lisp")
- #:phases
- (modify-phases %standard-phases
- (add-before 'check 'chmod
- (lambda _
- (chmod "test/fixture-mark-feed-ignore.org" #o644)))
- (add-before 'check 'xt-number-tests
- (lambda _
- ((lambda (file test-name) ; variant of ert-number-tests
- (emacs-batch-edit-file file
- `(let ((i 0))
- (while (re-search-forward ,(string-append "xt-deftest "
- test-name)
- nil t)
- (goto-char (match-beginning 0))
- (kill-region (match-beginning 0) (match-end 0))
- (insert (format "xt-deftest %s-%d" ,test-name i))
- (setq i (+ i 1)))
- (basic-save-buffer))))
- "test/elfeed-org-test.el"
- "rmh-elfeed-org-convert-headline-to-tagger-params"))))))
+ #:test-command '("ert-runner" "-L" "org-mode/lisp")))
(propagated-inputs
- (list emacs-elfeed emacs-org emacs-dash emacs-s))
+ (list emacs-elfeed emacs-org))
(native-inputs
(list emacs-ert-runner emacs-xtest))
(home-page "https://github.com/remyhonig/elfeed-org")

base-commit: 27ae140024b6d05506cdf0d9fd5b91c25466f295
prerequisite-patch-id: f9cc903b8048c8c6fde576fbf38ab110263020e3
prerequisite-patch-id: d09c064d38df73405d505b90d222dccfd7be09b9
--
2.48.1
Cayetano Santos wrote 3 weeks ago
control message for bug #76412
87wmdhj7jw.fsf@inventati.org
user guix
usertag 76412 + waiting-on-contributor
thanks

Guix QA review form submission:

Items marked as checked:

- Package builds
- Lint warnings
- Package tests
- List dependent packages build

Please review:

- commit message
- apply package style
- version is 20250104.0
- no need of emacs-org as propagated-input
-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCZ7r0AxccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgnnAAQDzpDimJS0dnODjPoZ3tIiFLLXV
SO+/58Jm64l1mpL4EQD8DBOKDRg5uvZe5TAYQM/aMyVzKt/94++lXeBQhX10Iw4=
=i4LR
-----END PGP SIGNATURE-----

Sergey Trofimov wrote 2 weeks ago
[PATCH v1] gnu: emacs-elfeed-org: Update to 20250104.0.
(address . 76412@debbugs.gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
5974fa2ec284363d452932f0e8d49ddc1cceea2a.1740330697.git.sarg@sarg.org.ru
* gnu/packages/emacs-xyz.scm (emacs-elfeed-org): Update to 20250104.0.
[arguments]: Remove obsolete testing tweaks.
[propagated-inputs]: Remove unused dependencies.
---
gnu/packages/emacs-xyz.scm | 36 ++++++++----------------------------
1 file changed, 8 insertions(+), 28 deletions(-)

Toggle diff (65 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 59c1927135..9ec816920a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15933,10 +15933,12 @@ (define-public emacs-elfeed-goodies
(license license:gpl3+))))
(define-public emacs-elfeed-org
- (let ((commit "77b6bbf222487809813de260447d31c4c59902c9"))
+ (let ((commit "1197cf29f6604e572ec604874a8f50b58081176a")
+ (version "20250104.0")
+ (revision "0"))
(package
(name "emacs-elfeed-org")
- (version (git-version "0.1" "1" commit))
+ (version (git-version version revision commit))
(source
(origin
(method git-fetch)
@@ -15945,35 +15947,13 @@ (define-public emacs-elfeed-org
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "0a2ibka82xq1dhy2z7rd2y9zhcj8rna8357881yz49wf55ccgm53"))))
+ (base32 "0giwnzlqk2s5hb6fs8a0l4dxcmn2fvkngpj1fayzwj0qnvds1kri"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #t
- #:test-command '("ert-runner" "-L" "org-mode/lisp")
- #:phases
- (modify-phases %standard-phases
- (add-before 'check 'chmod
- (lambda _
- (chmod "test/fixture-mark-feed-ignore.org" #o644)))
- (add-before 'check 'xt-number-tests
- (lambda _
- ((lambda (file test-name) ; variant of ert-number-tests
- (emacs-batch-edit-file file
- `(let ((i 0))
- (while (re-search-forward ,(string-append "xt-deftest "
- test-name)
- nil t)
- (goto-char (match-beginning 0))
- (kill-region (match-beginning 0) (match-end 0))
- (insert (format "xt-deftest %s-%d" ,test-name i))
- (setq i (+ i 1)))
- (basic-save-buffer))))
- "test/elfeed-org-test.el"
- "rmh-elfeed-org-convert-headline-to-tagger-params"))))))
- (propagated-inputs
- (list emacs-elfeed emacs-org emacs-dash emacs-s))
- (native-inputs
- (list emacs-ert-runner emacs-xtest))
+ #:test-command '("ert-runner" "-L" "org-mode/lisp")))
+ (propagated-inputs (list emacs-elfeed))
+ (native-inputs (list emacs-ert-runner emacs-xtest))
(home-page "https://github.com/remyhonig/elfeed-org")
(synopsis "Configure Elfeed with an Org-mode file")
(description

base-commit: 23b068c036223e70bdea9d7d579850a1cffc02a7
prerequisite-patch-id: f9cc903b8048c8c6fde576fbf38ab110263020e3
prerequisite-patch-id: d09c064d38df73405d505b90d222dccfd7be09b9
--
2.48.1
Sergey Trofimov wrote 2 weeks ago
Re: control message for bug #76412
(name . Cayetano Santos)(address . csantosb@inventati.org)(address . 76412@debbugs.gnu.org)
8734g4tw10.fsf@sarg.org.ru
Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (7 lines)
> Please review:
>
> - commit message
> - apply package style
> - version is 20250104.0
> - no need of emacs-org as propagated-input

I've applied the suggested changes. However I'm not sure emacs-org
should be removed - it is listed in `Package-Requires`.
Cayetano Santos wrote 2 weeks ago
(name . Sergey Trofimov)(address . sarg@sarg.org.ru)(address . 76412@debbugs.gnu.org)
87v7t0h4rm.fsf@inventati.org
Toggle quote (14 lines)
>dim. 23 févr. 2025 at 18:23, Sergey Trofimov <sarg@sarg.org.ru> wrote:

> Cayetano Santos <csantosb@inventati.org> writes:
>
>> Please review:
>>
>> - commit message
>> - apply package style
>> - version is 20250104.0
>> - no need of emacs-org as propagated-input
>
> I've applied the suggested changes. However I'm not sure emacs-org
> should be removed - it is listed in `Package-Requires`.

Sure, but guix packages emacs-29.4, which already includes emacs-org.

Let’s committers decide about this point.
-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCZ7tunRccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgnHjAQD0nNjhqvCi8ra7rBm8wR1BIJ4Y
pgsqPst2hqStNUIOTQD+LhkIm+WOUyqobtdOTBn06r7VENSPuSyi+SvXQKcEmw0=
=d2Tt
-----END PGP SIGNATURE-----

Cayetano Santos wrote 2 weeks ago
Re: [bug#76412] [PATCH v1] gnu: emacs-elfeed-org: Update to 20250104.0.
(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
87h64kh4dp.fsf@inventati.org
Toggle quote (4 lines)
>dim. 23 févr. 2025 at 18:11, Sergey Trofimov <sarg@sarg.org.ru> wrote:

> * gnu/packages/emacs-xyz.scm (emacs-elfeed-org): Update to 20250104.0.

Look at equivalent emacs update messages, corresponding to packages with
no releases, as this is the case.

I think message must be rather (version-revision-commit):

Update to 20250104.0-0.1197cf2.
-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCZ7twkhccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgtJhAQDk+Lp9QhhsNvaZfLyrm56RKlmo
lRjxp/C9/qPFhCJqdgD9EAdeVAgBao3m7sXsZTdNKptqS+jb1pDLVvpMquLPOwk=
=NCo8
-----END PGP SIGNATURE-----

Ian Eure wrote 2 weeks ago
Re: [bug#76412] control message for bug #76412
(name . Cayetano Santos)(address . csantosb@inventati.org)
87ikosd3am.fsf@retrospec.tv
Cayetano Santos <csantosb@inventati.org> writes:

Toggle quote (21 lines)
>>dim. 23 févr. 2025 at 18:23, Sergey Trofimov <sarg@sarg.org.ru>
>>wrote:
>
>> Cayetano Santos <csantosb@inventati.org> writes:
>>
>>> Please review:
>>>
>>> - commit message
>>> - apply package style
>>> - version is 20250104.0
>>> - no need of emacs-org as propagated-input
>>
>> I've applied the suggested changes. However I'm not sure
>> emacs-org
>> should be removed - it is listed in `Package-Requires`.
>
> Sure, but guix packages emacs-29.4, which already includes
> emacs-org.
>
> Let’s committers decide about this point.

It definitely shouldn’t propagate emacs-org. Org Mode has been
bundled with Emacs for a long time, so this is unlikely to cause
breakage due to a missing dependency; but mixing Org Mode versions
can cause all sorts of problems. Best to let the user decide
whether they use bundled or external Org Mode.

-- Ian
Ian Eure wrote 2 weeks ago
Re: [bug#76412] [PATCH v1] gnu: emacs-elfeed-org: Update to 20250104.0.
(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
87cyf0d32m.fsf@retrospec.tv
Hi Sergey,

Pushed as 352e037539 with some minor changelog editing.

Thanks,
-- Ian
Ian Eure wrote 2 weeks ago
control message for bug #76412
(address . control@debbugs.gnu.org)
87bjukd32h.fsf_-_@retrospec.tv
close 76412
quit
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76412@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 76412
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help