[PATCH 1/1] gnu: mpv: Add support for pipewire.

  • Done
  • quality assurance status badge
Details
3 participants
  • Gabriel Wicki
  • Leo Famulari
  • soeren
Owner
unassigned
Submitted by
soeren
Severity
normal
S
S
soeren wrote on 18 Jan 23:37 +0100
(address . guix-patches@gnu.org)
20250118223756.14755-1-soeren@soeren-tempel.net
From: Sören Tempel <soeren@soeren-tempel.net>

* gnu/packages/video.scm (mpv): Add pipewire audio output support.
[propagated-inputs]: Add pipewire dependency.
---
gnu/packages/video.scm | 1 +
1 file changed, 1 insertion(+)

Toggle diff (12 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b113bcd254..b6754153f4 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2737,6 +2737,7 @@ (define-public mpv
;; XXX: lua > 5.2 is not currently supported; see meson.build
lua-5.2
mesa
+ pipewire
pulseaudio
shaderc
wayland
L
L
Leo Famulari wrote on 20 Jan 03:39 +0100
(address . soeren@soeren-tempel.net)
Z423eYWxlVUU1mZN@jasmine.lan
On Sat, Jan 18, 2025 at 11:37:56PM +0100, soeren@soeren-tempel.net wrote:
Toggle quote (5 lines)
> From: S�ren Tempel <soeren@soeren-tempel.net>
>
> * gnu/packages/video.scm (mpv): Add pipewire audio output support.
> [propagated-inputs]: Add pipewire dependency.

Thanks! Pushed as c247697a61aece2bca8f95d05bac84084c763775
Closed
G
G
Gabriel Wicki wrote on 20 Jan 12:51 +0100
Pipewire for MPV support
cjcrzn36mckyid3feis6pgg6fzakwdpwkhsklp2qdixhvajtb5@kmygvzce5bjh
Hi you two!

Was this patch actually necessary? I run mpv with pipewire regularly
and never run into issues (IIUC mpv connects to pipewire through
pipewire's pulseaudio interface). Does this patch really solve anything
or just expand the number of inputs?

Thanks for your work nevertheless and thank you for an explication,

gabber
S
S
Sören Tempel wrote on 20 Jan 17:04 +0100
(name . Gabriel Wicki)(address . gabriel@erlikon.ch)
2A2QTBNP6I13W.22T15Y0OHEVO8@8pit.net
Hi,

I use pipewire without the pulseaudio emulation layer (which is a
supported configuration in Guix), in this setup mpv (without my patch)
doesn't work with pipewire. Other Linux distributions, e.g. Alpine
Linux, also build mpv with pipewire support.

Greetings
Sören

Gabriel Wicki <gabriel@erlikon.ch> wrote:
Toggle quote (10 lines)
> Hi you two!
>
> Was this patch actually necessary? I run mpv with pipewire regularly
> and never run into issues (IIUC mpv connects to pipewire through
> pipewire's pulseaudio interface). Does this patch really solve anything
> or just expand the number of inputs?
>
> Thanks for your work nevertheless and thank you for an explication,
>
> gabber
L
L
Leo Famulari wrote on 20 Jan 20:48 +0100
(name . Sören Tempel)(address . soeren@soeren-tempel.net)
Z46oeY3p6ivuhNpN@jasmine.lan
On Mon, Jan 20, 2025 at 05:04:01PM +0100, S�ren Tempel wrote:
Toggle quote (5 lines)
> I use pipewire without the pulseaudio emulation layer (which is a
> supported configuration in Guix), in this setup mpv (without my patch)
> doesn't work with pipewire. Other Linux distributions, e.g. Alpine
> Linux, also build mpv with pipewire support.

Thanks for the explanation, S�ren!

I pushed this without any particular knowledge about the subject of
pipewire and mpv --- I've never even used pipewire. But I figure it was
safe since mpv still worked. If it causes some problem, please let us
know.
G
G
Gabriel Wicki wrote 4 days ago
(name . Leo Famulari)(address . leo@famulari.name)
877c642gtx.fsf@erlikon.ch
On Mon, Jan 20, 2025 at 05:04:01PM +0100, Sören Tempel wrote:
Toggle quote (4 lines)
> I use pipewire without the pulseaudio emulation layer (which is a
> supported configuration in Guix), in this setup mpv (without my patch)
> doesn't work with pipewire. Other Linux distributions, e.g. Alpine
> Linux, also build mpv with pipewire support.
Interesting! I must have missed the introduction of
home-pipewire-service-type, which I guess you're referring to here.

In general - and that's why I interjected in the first place - we try to
keep inputs of packages as minimalist as possible. Without a (short)
statement of the necessity of adding one or a full-fledged bug report it
is hard for a reviewer to know why it is happening - especially for
someone like myself who is using pipewire and mpv on a regular basis
(without issues).

So, thanks for clarifying and the patch itself and the hint towards the
new home-service that I have now installed (and can finally drop
pipewire-pulse)!

Have a nice week!
g
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 75659@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 75659
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch