guix import go package definition is not valid

Done

Details

2 participants

MSavoritias
Sharlatan Hellseher

Owner: unassigned

Submitted by: MSavoritias

Severity: normal

Debbugs page

MSavoritias wrote 3 months ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:d971cdc3-b960-49e7-93a3-6393fc0e5b64@msavoritias.me

Doing:

@localhost ~$ guix import go code.forgejo.org/f3/gof3/v3
guix import: Importing package "code.forgejo.org/f3/gof3/v3"...
guix import: varoitus: Unable to determine repository root of 
'code.forgejo.org/f3/gof3'. Guessing 'code.forgejo.org/f3/gof3'.
(define-public go-code-forgejo-org-f3-gof3
   (package
     (name "go-code-forgejo-org-f3-gof3")
     (version "3.10.1")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://code.forgejo.org/f3/gof3.git")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
         (base32 "1ysqlj5aa7bhsyghzhycngg45wclc1j2yhq1l27d5crb0pq0wfwg"))))
     (build-system go-build-system)
     (arguments
      (list
       #:go 1.22
       #:import-path "code.forgejo.org/f3/gof3/v3"
       #:unpack-path "code.forgejo.org/f3/gof3"))
     (propagated-inputs (list go-golang-org-x-crypto
                              go-github-com-xanzy-go-gitlab
                              go-github-com-urfave-cli-v2
                              go-github-com-stretchr-testify
go-github-com-santhosh-tekuri-jsonschema-v6
                              go-github-com-hashicorp-go-version
                              go-github-com-google-go-cmp
                              go-github-com-davidmz-go-pageant
                              go-github-com-42wim-httpsig))
     (home-page "https://code.forgejo.org/f3/gof3")
     (synopsis "gof3")
     (description
      "As a CLI or as a library, @code{GoF3} provides a single 
operation: mirroring.
The origin and destination are designated by the URL of a forge and a 
path to
the resource.  For instance, @@code{mirror --from-type forgejo --from
https://code.forgejo.org/forgejo/lxc-helpers--to-type F3 --to 
/some/directory}
will mirror a project in a local directory using the F3 format.")
     (license license:expat)))

This package definition is not valid.

#:go 1.22 should be written like #:go go-1.22

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure struct-vtable: Wrong type argument in position 1 (expecting 
struct): 1.22


MSavoritias

Sharlatan Hellseher wrote 3 months ago

Recipients:(address . 74992@debbugs.gnu.org)

Message-ID:87ttaxoqk9.fsf@gmail.com

Hi MSavoritias,

Thank you for reporting that!

It's known issue with importer which might need some after math manual

adjustment anyway (check license, check synopsis, check description,

check native/propagated inputs) which are not 100% accurate.

Summing all above adjust #go to correct one or remove it completely (the

current build go version is 1.21), should be not a big deal.

But, you may improve it! Take a look at the importer's code and maybe

implement the adjustment, WDYT?

Oleg,

go-team

Sharlatan Hellseher wrote 3 months ago

Recipients:(address . 74992@debbugs.gnu.org)

Message-ID:CAO+9K5oAwj5a6t2kKpCqo3GQzs2R+xtvZ+NKDVW2c_RVXJKH4A@mail.gmail.com

This is that part of importer which produces the guess:

,@(if (version>? min-go-version (package-version (go-package)))

`(#:go ,(string->number min-go-version))

'())

Attachment: file

Sharlatan Hellseher wrote 3 months ago

[PATCH] import/go: Fix #:go formation.

Recipients:(address . 74992@debbugs.gnu.org)(name . Sharlatan Hellseher)(address . sharlatanus@gmail.com)

Message-ID:18f7d731f7d9e3f3003cf9ef4f8d9aca5b7c8a90.1734922057.git.sharlatanus@gmail.com

Reported by MSavoritias <email@msavoritias.me> in #74992 "guix import go

package definition is not valid". This change fixes it: instead of

"#:go 1.22" will produce "#:go go-1.22".

* guix/import/go.scm (go-module->guix-package): Fix format for #:go key

argument.

Change-Id: I9db0688b8e2970f5e90b415966d39b45505b7c8e

---

guix/import/go.scm | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (19 lines)diff --git a/guix/import/go.scm b/guix/import/go.scm
index 32cba25b33..915846bed1 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -704,7 +704,9 @@ (define* (go-module->guix-package module-path #:key
         (build-system go-build-system)
         (arguments
          (list ,@(if (version>? min-go-version (package-version (go-package)))
-                     `(#:go ,(string->number min-go-version))
+                     `(#:go ,(string->symbol
+                              (format #f "go-~a"
+                                      (string->number min-go-version))))
                      '())
                #:import-path ,module-path
                ,@(if (string=? module-path root-module-path)

base-commit: 30fdffc4b5605431b28a23b03330e850b2184a76
-- 
2.46.0

Sharlatan Hellseher wrote 3 months ago

(no subject)

Recipients:(address . 74992@debbugs.gnu.org)(address . poptsov.artyom@gmail.com)(name . Simon Tournier)(address . zimon.toutoune@gmail.com)

Message-ID:87ldw6oi33.fsf@gmail.com

CC interested guixers

This change is a quite trivial but would improve large scale import task.

I need to fix the package variable formation as well, where the

#:import-path contain /v[0-9] suffix.

Oleg

Sharlatan Hellseher wrote 2 months ago

guix import go package definition is not valid

Recipients:(address . 74992-done@debbugs.gnu.org)

Message-ID:87a5bvkd7j.fsf@gmail.com

Hi,

Adjustment is pushed as f0adcca9db6e52aed1148a507085f4088633153a to

master.

Thanks,

Oleg

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 74992@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 74992

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date