[PATCH] gnu: cgit: Update to 1.2.3-7.751a5b5.

Done

Details

2 participants

Maxim Cournoyer
Tomas Volf

Owner: unassigned

Submitted by: Tomas Volf

Severity: normal

Tomas Volf wrote on 12 Dec 12:46 +0100

Recipients:(address . guix-patches@gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)

Message-ID:1a8790d643cc3171d765ec483e99fe1e831747e5.1734003995.git.~@wolfsden.cz

* gnu/packages/version-control.scm (cgit): Update to 1.2.3-7.751a5b5.

Change-Id: I3f4d27246065d67a258a8cf3b3dea2e0b2d2bc9f

---

gnu/packages/version-control.scm | 10 +++++-----

1 file changed, 5 insertions(+), 5 deletions(-)

Toggle diff (38 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 3339e79390..28afcfa2ff 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1345,8 +1345,8 @@ (define-public git-remote-gcrypt
    (license license:gpl3+)))
 
 (define-public cgit
-  (let ((commit "2a13177f3dce660954b1ce78bc83338fe64f6b33")
-        (rev "6"))
+  (let ((commit "751a5b527de07dde30a69709c2d6fc6f05fafd06")
+        (rev "7"))
     (package
       (name "cgit")
       ;; Update the ‘git-source’ input as well.
@@ -1358,7 +1358,7 @@ (define-public cgit
                       (commit commit)))
                 (sha256
                  (base32
-                  "0g02rghwx6gda15ip1pd3rli6smis1mrcb904zlxfqmm6dlc7lca"))
+                  "0rfflh7fnfhchd7pdspn2r416c5kaya37cad918f7ldidzwvmp37"))
                 (file-name (git-file-name name version))))
       (build-system gnu-build-system)
       (arguments
@@ -1434,9 +1434,9 @@ (define-public cgit
              (method url-fetch)
              ;; cgit is tightly bound to git.  Use GIT_VER from the Makefile,
              ;; which may not match the current (package-version git).
-             (uri "mirror://kernel.org/software/scm/git/git-2.46.2.tar.xz")
+             (uri "mirror://kernel.org/software/scm/git/git-2.47.1.tar.xz")
              (sha256
-              (base32 "18rcmvximgyg3v1a9papi9djfamiak0ys5cmgx7ll29nhp3a3s2y"))))
+              (base32 "046kdr5dhg31hjcg6wpfqnwwbaqdjyax7n8wx5s26fdf4fxzkn7k"))))
          ("bash-minimal" ,bash-minimal)
          ("openssl" ,openssl)
          ("python" ,python)
-- 
2.46.0

Maxim Cournoyer wrote on 17 Dec 02:24 +0100

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 74821@debbugs.gnu.org)

Message-ID:87msgvrtid.fsf@gmail.com

Hi Tomas,

Tomas Volf <~@wolfsden.cz> writes:

Toggle quote (15 lines)> * gnu/packages/version-control.scm (cgit): Update to 1.2.3-7.751a5b5.
>
> Change-Id: I3f4d27246065d67a258a8cf3b3dea2e0b2d2bc9f
> ---
>  gnu/packages/version-control.scm | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index 3339e79390..28afcfa2ff 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -1345,8 +1345,8 @@ (define-public git-remote-gcrypt
>     (license license:gpl3+)))
>

Usually, we request that a comment is added to explain why a particular
unreleased commit must be used instead of the latest release.  Would it
be possible to remove the commit/rev variables and switch back to use
the latest release?  It's not clear why we aren't doing that.

-- 
Thanks,
Maxim

Tomas Volf wrote 7 days ago

Recipients:(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 74821@debbugs.gnu.org)

Message-ID:87y10d9ie3.fsf@wolfsden.cz

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

Toggle quote (22 lines)> Hi Tomas,
>
> Tomas Volf <~@wolfsden.cz> writes:
>
>> * gnu/packages/version-control.scm (cgit): Update to 1.2.3-7.751a5b5.
>>
>> Change-Id: I3f4d27246065d67a258a8cf3b3dea2e0b2d2bc9f
>> ---
>>  gnu/packages/version-control.scm | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
>> index 3339e79390..28afcfa2ff 100644
>> --- a/gnu/packages/version-control.scm
>> +++ b/gnu/packages/version-control.scm
>> @@ -1345,8 +1345,8 @@ (define-public git-remote-gcrypt
>>     (license license:gpl3+)))
>>
>
> Usually, we request that a comment is added to explain why a particular
> unreleased commit must be used instead of the latest release.

This was not requested 11 months back when I did the initial upgrade,

but fair enough. Shall I send a separate patch adding the comment?

Toggle quote (4 lines)

> Would it be possible to remove the commit/rev variables and switch

> back to use the latest release? It's not clear why we aren't doing

> that.

Possible? Sure. Good idea? Not in my opinion. Last release is from 5

years ago, and there were many bug fixes since then. Even sites like

git.kernel.org do not use the last release.

Have a nice day,

Tomas Volf

There are only two hard things in Computer Science:

cache invalidation, naming things and off-by-one errors.

Maxim Cournoyer wrote 6 days ago

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 74821-done@debbugs.gnu.org)

Message-ID:874j30mdpx.fsf@gmail.com

Hi Tomas,

I've added a comment mentioning why we use the latest commit (no tagged

releases in 5 years) and pushed.

Thanks,

Maxim

Closed

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 74821@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 74821

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date