[PATCH] gnu: libgit2: Update to 1.8.4.

  • Done
  • quality assurance status badge
Details
4 participants
  • Aaron Covrig
  • ashish.is
  • Ludovic Courtès
  • Maxim Cournoyer
Owner
unassigned
Submitted by
ashish.is
Severity
normal
A
A
ashish.is wrote on 3 Dec 11:20 +0100
(address . guix-patches@gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
d9b7f4576f162a5b2231895bbae008d8e3e87b11.1733221230.git.ashish.is@lostca.se
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.

Change-Id: I6a200a1b490962a0083e78008b5be763fd0439ed
---
gnu/packages/version-control.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 289b981911..333548d54f 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1174,7 +1174,7 @@ (define-public libgit2-1.7
(define-public libgit2-1.8
(package
(inherit libgit2-1.7)
- (version "1.8.3")
+ (version "1.8.4")
(source (origin
(inherit (package-source libgit2-1.7))
(uri (git-reference
@@ -1183,7 +1183,7 @@ (define-public libgit2-1.8
(file-name (git-file-name "libgit2" version))
(sha256
(base32
- "11jyxy6ckl19ayqpq5s3nlbcd0s1q4sdy8884m4pjrbzgxg6y1ds"))
+ "0jydckwn0bbrp2kbcr1ih1bz4sc6yhx7lrl22lqcgnf2v6ml6n01"))
(patches
(search-patches "libgit2-uninitialized-proxy-settings.patch"))
(snippet

base-commit: 58a134224e327cfc0af105314598d080dfc0392d
--
2.47.1
A
A
Aaron Covrig wrote on 5 Dec 04:02 +0100
(address . 74664@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
20241205030401.1994615-1-aaron.covrig.us@ieee.org
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.
---
I went ahead and re-applied/rebased your commit, for some reason
it seems it looks like it was applied against a different base or
master just received a bunch of changes.

gnu/packages/version-control.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 289b981911..333548d54f 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1174,7 +1174,7 @@ (define-public libgit2-1.7
(define-public libgit2-1.8
(package
(inherit libgit2-1.7)
- (version "1.8.3")
+ (version "1.8.4")
(source (origin
(inherit (package-source libgit2-1.7))
(uri (git-reference
@@ -1183,7 +1183,7 @@ (define-public libgit2-1.8
(file-name (git-file-name "libgit2" version))
(sha256
(base32
- "11jyxy6ckl19ayqpq5s3nlbcd0s1q4sdy8884m4pjrbzgxg6y1ds"))
+ "0jydckwn0bbrp2kbcr1ih1bz4sc6yhx7lrl22lqcgnf2v6ml6n01"))
(patches
(search-patches "libgit2-uninitialized-proxy-settings.patch"))
(snippet

base-commit: 006679d1e6ca7acea0629b4f019c8cf89cde08be
--
2.47.0
A
A
Aaron Covrig wrote on 6 Dec 23:25 +0100
[PATCH v3] gnu: libgit2: Update to 1.8.4.
(address . 74664@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
20241206222723.2405986-1-aarcov@gmail.com
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.
---
It seems I forgot to attach the revision tag to the prior patch...

gnu/packages/version-control.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 289b981911..333548d54f 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1174,7 +1174,7 @@ (define-public libgit2-1.7
(define-public libgit2-1.8
(package
(inherit libgit2-1.7)
- (version "1.8.3")
+ (version "1.8.4")
(source (origin
(inherit (package-source libgit2-1.7))
(uri (git-reference
@@ -1183,7 +1183,7 @@ (define-public libgit2-1.8
(file-name (git-file-name "libgit2" version))
(sha256
(base32
- "11jyxy6ckl19ayqpq5s3nlbcd0s1q4sdy8884m4pjrbzgxg6y1ds"))
+ "0jydckwn0bbrp2kbcr1ih1bz4sc6yhx7lrl22lqcgnf2v6ml6n01"))
(patches
(search-patches "libgit2-uninitialized-proxy-settings.patch"))
(snippet

base-commit: 0972a27572a12158c0cb5a3bbc28a86eaf82dc33
--
2.46.0
A
A
Aaron Covrig wrote on 7 Dec 02:06 +0100
CI seems to be building against old commit
(address . 74664@debbugs.gnu.org)
20241206200632.38371500@mobile-dev
For whatever reason the CI is building against a fairly old
commit... (maybe this is how the CI is enforcing the current package
build suspension till aarch64 substitutes get caught up).

For reference, based on the qa error message, it looks to be building
against a commit from Nov. 19:
```
commit f129a6cc591817c5c51770d5b8712eeb344ba4e4
Author: Lars Bilke <lars.bilke@ufz.de>
Date: Tue Nov 19 15:18:06 2024 +0100
```

I may try to rebase against this commit and see what happens...

v/r,

Aaron
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQSPXVwROJGaYSBOwhhfTkc5aZTD/QUCZ1OfmAAKCRBfTkc5aZTD
/TolAP4m0evQ46YNVqn9nY4OnWrDhMfr/elT9CDvDm6YsWp79wEAi8OH2Sn4TW1C
Hc5helNSpJrwr2+nVcRwJHOBR9ud5wU=
=a8FG
-----END PGP SIGNATURE-----


A
A
Aaron Covrig wrote on 7 Dec 02:08 +0100
[PATCH v4] gnu: libgit2: Update to 1.8.4.
(address . 74664@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
20241207010839.2536093-1-aaron.covrig.us@ieee.org
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.
---
Applying against the old commit that the CI seems to be using

gnu/packages/version-control.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index c892a83a98..eca8ebc42c 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1170,7 +1170,7 @@ (define-public libgit2-1.7
(define-public libgit2-1.8
(package
(inherit libgit2-1.7)
- (version "1.8.1")
+ (version "1.8.4")
(source (origin
(inherit (package-source libgit2-1.7))
(uri (git-reference
@@ -1179,7 +1179,7 @@ (define-public libgit2-1.8
(file-name (git-file-name "libgit2" version))
(sha256
(base32
- "1mh55804cvxl2cyl4clinajzgfn3zmlhacnv1pdvdj4w6z2w4si7"))
+ "0jydckwn0bbrp2kbcr1ih1bz4sc6yhx7lrl22lqcgnf2v6ml6n01"))
(patches
(search-patches "libgit2-uninitialized-proxy-settings.patch"))
(snippet

base-commit: f129a6cc591817c5c51770d5b8712eeb344ba4e4
--
2.46.0
A
A
Aaron Covrig wrote on 14 Dec 01:15 +0100
[PATCH v5] gnu: libgit2: Update to 1.8.4.
(address . 74664@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
20241214001655.110304-1-aaron.covrig.us@ieee.org
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.
---
Restoring the original reference base as the build system hasn't picked
this up and it looks like the arm64 substitute count is getting close to
being enough for the CI instance to start processing other architectures
again.

- Aaron

gnu/packages/version-control.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 3339e79390..330072e575 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1174,7 +1174,7 @@ (define-public libgit2-1.7
(define-public libgit2-1.8
(package
(inherit libgit2-1.7)
- (version "1.8.3")
+ (version "1.8.4")
(source (origin
(inherit (package-source libgit2-1.7))
(uri (git-reference
@@ -1183,7 +1183,7 @@ (define-public libgit2-1.8
(file-name (git-file-name "libgit2" version))
(sha256
(base32
- "11jyxy6ckl19ayqpq5s3nlbcd0s1q4sdy8884m4pjrbzgxg6y1ds"))
+ "0jydckwn0bbrp2kbcr1ih1bz4sc6yhx7lrl22lqcgnf2v6ml6n01"))
(patches
(search-patches "libgit2-uninitialized-proxy-settings.patch"))
(snippet

base-commit: 0787a180b3ca64d3958438920ca1b58a2a27fba4
--
2.46.0
L
L
Ludovic Courtès wrote on 16 Dec 19:45 +0100
(name . Aaron Covrig)(address . aaron.covrig.us@ieee.org)
87msgveabq.fsf@gnu.org
Hi,

(Cc: Maxim for libjami questions.)

Aaron Covrig <aaron.covrig.us@ieee.org> skribis:

Toggle quote (9 lines)
> From: Ashish SHUKLA <ashish.is@lostca.se>
>
> * gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.
> ---
> Restoring the original reference base as the build system hasn't picked
> this up and it looks like the arm64 substitute count is getting close to
> being enough for the CI instance to start processing other architectures
> again.

The upgrade apparently breaks libjami:

Toggle snippet (30 lines)
jamidht/conversationrepository.cpp: In member function ‘std::string jami::ConversationRepository::Impl::createMergeCommit(git_index*, const string&)’:
jamidht/conversationrepository.cpp:801:34: error: invalid conversion from ‘git_commit* const*’ to ‘const git_commit**’ [-fpermissive]
801 | &parents_ptr[0])
| ^~~~~~~~~~~~~~~
| |
| git_commit* const*
In file included from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/repository.h:14,
from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/annotated_commit.h:11,
from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2.h:11,
from jamidht/conversationrepository.h:21,
from jamidht/conversationrepository.cpp:18:
/gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/commit.h:515:27: note: initializing argument 9 of ‘int git_commit_create_buffer(git_buf*, git_repository*, const git_signature*, const git_signature*, const char*, const char*, const git_tree*, size_t, const git_commit**)’
515 | const git_commit *parents[]);
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~
jamidht/conversationrepository.cpp: In member function ‘std::string jami::ConversationRepository::Impl::commit(const string&, bool)’:
jamidht/conversationrepository.cpp:1887:34: error: invalid conversion from ‘git_commit* const*’ to ‘const git_commit**’ [-fpermissive]
1887 | &head_ref[0])
| ^~~~~~~~~~~~
| |
| git_commit* const*
In file included from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/repository.h:14,
from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/annotated_commit.h:11,
from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2.h:11,
from jamidht/conversationrepository.h:21,
from jamidht/conversationrepository.cpp:18:
/gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/commit.h:515:27: note: initializing argument 9 of ‘int git_commit_create_buffer(git_buf*, git_repository*, const git_signature*, const git_signature*, const char*, const char*, const git_tree*, size_t, const git_commit**)’
515 | const git_commit *parents[]);
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~


Can we “just” upgrade libjami? Is there a patch upstream we can take?
What would you recommend, Maxim?

Ludo’.
M
M
Maxim Cournoyer wrote on 18 Dec 08:18 +0100
(name . Ludovic Courtès)(address . ludo@gnu.org)
87h671pigc.fsf@gmail.com
Hi,

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (51 lines)
> Hi,
>
> (Cc: Maxim for libjami questions.)
>
> Aaron Covrig <aaron.covrig.us@ieee.org> skribis:
>
>> From: Ashish SHUKLA <ashish.is@lostca.se>
>>
>> * gnu/packages/version-control.scm (libgit2-1.8): Update to 1.8.4.
>> ---
>> Restoring the original reference base as the build system hasn't picked
>> this up and it looks like the arm64 substitute count is getting close to
>> being enough for the CI instance to start processing other architectures
>> again.
>
> The upgrade apparently breaks libjami:
>
> jamidht/conversationrepository.cpp: In member function ‘std::string jami::ConversationRepository::Impl::createMergeCommit(git_index*, const string&)’:
> jamidht/conversationrepository.cpp:801:34: error: invalid conversion from ‘git_commit* const*’ to ‘const git_commit**’ [-fpermissive]
> 801 | &parents_ptr[0])
> | ^~~~~~~~~~~~~~~
> | |
> | git_commit* const*
> In file included from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/repository.h:14,
> from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/annotated_commit.h:11,
> from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2.h:11,
> from jamidht/conversationrepository.h:21,
> from jamidht/conversationrepository.cpp:18:
> /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/commit.h:515:27: note: initializing argument 9 of ‘int git_commit_create_buffer(git_buf*, git_repository*, const git_signature*, const git_signature*, const char*, const char*, const git_tree*, size_t, const git_commit**)’
> 515 | const git_commit *parents[]);
> | ~~~~~~~~~~~~~~~~~~^~~~~~~~~
> jamidht/conversationrepository.cpp: In member function ‘std::string jami::ConversationRepository::Impl::commit(const string&, bool)’:
> jamidht/conversationrepository.cpp:1887:34: error: invalid conversion from ‘git_commit* const*’ to ‘const git_commit**’ [-fpermissive]
> 1887 | &head_ref[0])
> | ^~~~~~~~~~~~
> | |
> | git_commit* const*
> In file included from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/repository.h:14,
> from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/annotated_commit.h:11,
> from /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2.h:11,
> from jamidht/conversationrepository.h:21,
> from jamidht/conversationrepository.cpp:18:
> /gnu/store/1bwhw59mfrs2zk98l31ymhr6qw7cp45p-libgit2-1.8.4/include/git2/commit.h:515:27: note: initializing argument 9 of ‘int git_commit_create_buffer(git_buf*, git_repository*, const git_signature*, const git_signature*, const char*, const char*, const git_tree*, size_t, const git_commit**)’
> 515 | const git_commit *parents[]);
> | ~~~~~~~~~~~~~~~~~~^~~~~~~~~
>
> (From <https://ci.guix.gnu.org/build/7230853/details>.)
>
> Can we “just” upgrade libjami? Is there a patch upstream we can take?
> What would you recommend, Maxim?

There may be a commit that could be cherry picked, but ideally we should
just update all Jami components to its latest nightly, if it supports
the latest libgit2 1.8.x.

I have an upgrade of Jami on a local branch, but it's not finished, and
I haven't checked yet if it would resolve that particular problem.

--
Thanks,
Maxim
L
L
Ludovic Courtès wrote 7 days ago
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
878qsdkqut.fsf@gnu.org
Hi!

It turns out libjami was already working around a change introduced in
1.8.0 and that was reverted in 1.8.4. I pushed a fix along with the
libgit2 upgrade:

a34c9713e2 gnu: libgit2: Update to 1.8.4.
011bf3280b gnu: libjami: Prepare for libgit2 1.8.4.

Thanks,
Ludo’.
Closed
M
M
Maxim Cournoyer wrote 6 days ago
(name . Ludovic Courtès)(address . ludo@gnu.org)
874j30o2t4.fsf@gmail.com
Hi Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (9 lines)
> Hi!
>
> It turns out libjami was already working around a change introduced in
> 1.8.0 and that was reverted in 1.8.4. I pushed a fix along with the
> libgit2 upgrade:
>
> a34c9713e2 gnu: libgit2: Update to 1.8.4.
> 011bf3280b gnu: libjami: Prepare for libgit2 1.8.4.

Well done!

--
Thanks,
Maxim
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 74664@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74664
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch