[PATCH] Update SwayFX version to 0.4

  • Done
  • quality assurance status badge
Details
3 participants
  • Hilton Chain
  • Josep Bigorra
  • Rodion Goritskov
Owner
unassigned
Submitted by
Josep Bigorra
Severity
normal
J
J
Josep Bigorra wrote on 2 Dec 09:38 +0100
(address . guix-patches@gnu.org)
CAM_04A0Q24ESXwXvioud5D8qjXpmKY3jiFMQ6s2C5H5TYDR3Zg@mail.gmail.com
Hi all, after having added the scenefx dependency, now we can update
to SwayFX 0.4 ! :D

Here is a patch for that, I hope I didn't miss anything.

Regards,
Joe
From b32067ee9de094541980bfac157872c73c1ace43 Mon Sep 17 00:00:00 2001
Message-ID: <b32067ee9de094541980bfac157872c73c1ace43.1733128178.git.jjbigorra@gmail.com>
From: Josep Bigorra <jjbigorra@gmail.com>
Date: Mon, 2 Dec 2024 09:28:56 +0100
Subject: [PATCH] update swayfx version to 0.4

---
gnu/packages/wm.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Toggle diff (36 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 2ab6f88cd5..f7bb77c23c 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1960,7 +1960,7 @@ (define-public swayfx
(package
(inherit sway)
(name "swayfx")
- (version "0.3.2")
+ (version "0.4")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -1969,7 +1969,7 @@ (define-public swayfx
(file-name (git-file-name name version))
(sha256
(base32
- "13d8icd45j937jgkidr7cyjys4nnvxh4ilp7ml0i2ml39ipv01qv"))))
+ "0651gbkszc8wwkiiw983m3815cfyk4c9v4mpd1nqf27a0f6qjgsm"))))
(build-system meson-build-system)
(inputs (list basu
cairo
@@ -1980,9 +1980,10 @@ (define-public swayfx
libxkbcommon
pango
pcre2
+ scenefx
swaybg
wayland
- wlroots-0.16))
+ wlroots-0.17))
(home-page "https://github.com/WillPower3309/swayfx")
(synopsis "Sway Fork with extra options and effects")
(description
--
2.46.0
R
R
Rodion Goritskov wrote on 5 Dec 22:35 +0100
(address . 74644@debbugs.gnu.org)(name . Josep Bigorra)(address . jjbigorra@gmail.com)
87h67hdd8r.fsf@bumblebee-old.mail-host-address-is-not-set
Hi!

Patch applies, SwayFX builds and starts successfully.
Haven't tested SwayFX-specific functionality, but it starts and manages
windows just fine.

The only thing that (as I think) could be changed in this patch is
commit message.

Currently it has the whole cover letter in commit message, while it
could be something like this (according to the usual commit format in
this repo):

Toggle quote (4 lines)
> gnu: swayfx: Update to 0.4.
>
> * gnu/packages/wm.scm (swayfx): Update to 0.4.

Thank you for the patch, wanted to take a look on actual SwayFX for some time!
J
J
Josep Bigorra wrote on 9 Dec 11:56 +0100
SwayFX
(address . 74644@debbugs.gnu.org)
CAM_04A27uJvwt+TcoVk8TjONPtpz-iFgE=CHBh1DTse6QL0GrQ@mail.gmail.com
Hi Rodion, I am happy to see your answer.
I am daily driving this for a few days, with nice stability, more so than 0.3
I hope we can merge it in soon to upstream :)

I am confused about your mention of the commit message.
I am unexperienced with patches, so bear with me. My commit message
was real short as I remember, and opening the patch i see no commit
message.
Is there a way you could fix this one, before merging in?

Thanks in advance,
Regards
H
H
Hilton Chain wrote on 11 Dec 02:32 +0100
Re: [bug#74644] [PATCH] Update SwayFX version to 0.4
(name . Josep Bigorra)(address . jjbigorra@gmail.com)(address . 74644-done@debbugs.gnu.org)
87ttbb6m3f.wl-hako@ultrarare.space
Hi Josep,

On Mon, 02 Dec 2024 16:38:44 +0800,
Josep Bigorra wrote:
Toggle quote (20 lines)
>
> [1 <text/plain; UTF-8 (7bit)>]
> Hi all, after having added the scenefx dependency, now we can update
> to SwayFX 0.4 ! :D
>
> Here is a patch for that, I hope I didn't miss anything.
>
> Regards,
> Joe
> [2 0001-update-swayfx-version-to-0.4.patch <text/x-patch; US-ASCII (base64)>]
> From b32067ee9de094541980bfac157872c73c1ace43 Mon Sep 17 00:00:00 2001
> Message-ID: <b32067ee9de094541980bfac157872c73c1ace43.1733128178.git.jjbigorra@gmail.com>
> From: Josep Bigorra <jjbigorra@gmail.com>
> Date: Mon, 2 Dec 2024 09:28:56 +0100
> Subject: [PATCH] update swayfx version to 0.4
>
> ---
> gnu/packages/wm.scm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

Added changelog to commit message and applied as
e24adc3bdf7cfeacc6aa7788d4a8292df425f6b2, thanks!
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 74644@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74644
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch