[PATCH] gnu: lcov: disable parallel tests

  • Done
  • quality assurance status badge
Details
2 participants
  • Ryan Sundberg
  • Zheng Junjie
Owner
unassigned
Submitted by
Ryan Sundberg
Severity
normal

Debbugs page

Ryan Sundberg wrote 3 months ago
(address . guix-patches@gnu.org)(name . Ryan Sundberg)(address . ryan@arctype.co)
8afcc0bf2961c2b93a41289a8cec7e5a28957b70.1732951981.git.ryan@arctype.co
`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.

* gnu/packages/code (lcov): Set #:parallel-tests? #f

Signed-off-by: Ryan Sundberg <ryan@arctype.co>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
gnu/packages/code.scm | 1 +
1 file changed, 1 insertion(+)

Toggle diff (16 lines)
diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..6ac514a5b5 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,7 @@ (define-public lcov
'(#:test-target "test"
#:make-flags (list (string-append "PREFIX="
(assoc-ref %outputs "out")))
+ #:parallel-tests? #f
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'patch-references-to-commands

base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
--
2.41.0
Zheng Junjie wrote 3 months ago
(name . Ryan Sundberg via Guix-patches via)(address . guix-patches@gnu.org)
87zflfof5j.fsf@iscas.ac.cn
Ryan Sundberg via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (3 lines)
> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.

Please also write this in the comments of the code. Make it easy for
people to know later

Toggle quote (23 lines)
>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
> gnu/packages/code.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..6ac514a5b5 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,7 @@ (define-public lcov
> '(#:test-target "test"
> #:make-flags (list (string-append "PREFIX="
> (assoc-ref %outputs "out")))
> + #:parallel-tests? #f
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmdMPkgACgkQO1qpk+Gi
3/CaExAAptLTLzVaGPdp3PJ3Y0n6+8YREIEFlzVvj6pnNs8PnDi/jv9NEVnV91n/
jT+pGPlM7/ToPVc3eHdmXRqHoTOeVhrsP69vGm0f+7flnZau3gRvQwzNEW96uurq
IJJCIMmUnfxDyq0HwQys9hbCIX9528a0P3g519Scxt/9LQDAS/tdJt7wJ9X2PDxn
82z/s38EZ3YaYbMdMlsSKSVIR4M0I5jjTQm36q723MhpymjOP8yfedlYvMbNHzOd
w7f3PmkyKZIXfMqNxG37luQ+2+UQxpmcLyP1YkMaSHjo8YTObpPtw1UYLyHXUq7u
6da5rfvYqgWpcN+sOo74b50L7I23qbAc/Rhp0HgrN0qoF5YuD0IVAzIp0jW34p/3
oDtTb0XlEtQ878auVJN9mGyWAYV4811iuH5NdnyZy+YfTuthFCFIsdJvz5hCpAFS
c0POMJ46nQAkerpSZ8wfIIUmHBQrJSIueQrwZhIg7BkexTePqdIBqEa9XHoLUmar
EOI01sqX6SZKuVX3rRFecGu7HaYgETzEo965t0x2R/jHFryuRDfhgnkg6k8K0F4I
fbPjC+dMeuj4NN39hKd07d3TAKS1yuNaq6r3R8WdrSqUCS+72IrAo5jV6vnex1qI
TrY9Q0HDKPHK8yBxyWmqvOO/SWReUNzuW1ZT5E3HNzOBCecapgI=
=yn7A
-----END PGP SIGNATURE-----

Ryan Sundberg wrote 3 months ago
[PATCH] gnu: lcov: disable parallel tests
(address . 74618@debbugs.gnu.org)(name . Ryan Sundberg)(address . ryan@arctype.co)
20abb9b1d79ab562fba8e6282d33de853cd78f05.1733117293.git.ryan@arctype.co
`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.

* gnu/packages/code (lcov): Set #:parallel-tests? #f

Signed-off-by: Ryan Sundberg <ryan@arctype.co>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
gnu/packages/code.scm | 3 +++
1 file changed, 3 insertions(+)

Toggle diff (18 lines)
diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..2ad1d8616a 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,9 @@ (define-public lcov
'(#:test-target "test"
#:make-flags (list (string-append "PREFIX="
(assoc-ref %outputs "out")))
+ ;; This test suite has race conditions in its scripts which make it
+ ;; unreliable when run in parallel.
+ #:parallel-tests? #f
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'patch-references-to-commands

base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
--
2.41.0
Zheng Junjie wrote 3 months ago
(name . Ryan Sundberg via Guix-patches via)(address . guix-patches@gnu.org)
871pykclsj.fsf@iscas.ac.cn
please use [PATCH v2] next.

Ryan Sundberg via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (28 lines)
> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.
>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <ryan@arctype.co>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
> gnu/packages/code.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..2ad1d8616a 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,9 @@ (define-public lcov
> '(#:test-target "test"
> #:make-flags (list (string-append "PREFIX="
> (assoc-ref %outputs "out")))
> + ;; This test suite has race conditions in its scripts which make it
> + ;; unreliable when run in parallel.
> + #:parallel-tests? #f
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf

pushed, closing.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmdTp6wACgkQO1qpk+Gi
3/BlchAAt8XfbwbZuy22xlpWt+6ZKzYIn+/uR5jYUUqcf7xBxKZWtv7cnD3ufe27
ueya1QNGYY+NAw/sO9uufTLMbiRzy9F7t6Tw3bEmHQRDHTk2EIxUyMg/GEBHF2nF
s0tGdLyLbtdCO3yZxw1iVa8tOCED6vTosb8QwlP5hAmkzaQ8+yERtC4D1YSbp+hz
Tg7GotHf3dKAEMa5SNIH1XVtnrOCgpsMY5iR8ZzngGJ6V+4Ws77d3W8ovvyNpjrg
DaXA3ua/J7o2ZP+IMHP8+ROSH/X7n21PBAeEOF2K4b8MfL7JzVpR3iitz02K6kYf
dV11gySfl2F9A4DIPnW4do/LuC7NXGAPIAKRMi3hF8LUeWwCBZgh/WPsiThw5RS5
MViWiARIRbUz0NjAxSmFMfixdqyOSf6fFVYwoxc+ZiqwhAhIT9COK1G4rV6ZmnQK
Nu0c2jMO3YFPQPdWJdJOfhXzIIP9J8uO1wAFIfySmBmDTItI+G/dcyYokQRcjjB7
3va7WiSsmmsPNi/mj3HXlYRSTshcCheUBdjQODWQdGkYbfOCcTxXKuROsVdHFq6Z
sbASN90z2sQoD0Ji6N2azd/ZJbil2F1bKr1kkrRAKLQP/XC/O1epeBf51v+/HJQX
52K3hxSxll33DQMPbmDjPd51kfjv2R6i7Ihhdc0zKZ7FkQNecYs=
=JijN
-----END PGP SIGNATURE-----

?
Your comment

This issue is archived.

To comment on this conversation send an email to 74618@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74618
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help