‘guix git authenticate’ pre-push hook unsuitable in some cases

  • Open
  • quality assurance status badge
Details
One participant
  • Ludovic Courtès
Owner
unassigned
Submitted by
Ludovic Courtès
Severity
normal
L
L
Ludovic Courtès wrote on 28 Nov 2024 09:19
(address . bug-guix@gnu.org)
87mshj7otp.fsf@gnu.org
As reported by Sébastien¹, the ‘pre-push’ hook installed by ‘guix git
authenticate’ fails when pushing the keyring branch because that branch
is not authenticated.

I’ve seen other situations where it fails, and IIRC one of them is when
pushing a tag.

We should list these corner cases and have ‘guix git authenticate’
install a fixed hook.

Ludo’.

L
L
Ludovic Courtès wrote on 30 Nov 2024 21:42
Re: bug#74583: ‘guix git authentica te’ pre-push hook unsuitable in some cases
(address . 74583@debbugs.gnu.org)
877c8kxxlh.fsf@gnu.org
Ludovic Courtès <ludo@gnu.org> skribis:

Toggle quote (4 lines)
> As reported by Sébastien¹, the ‘pre-push’ hook installed by ‘guix git
> authenticate’ fails when pushing the keyring branch because that branch
> is not authenticated.

Here’s what happens when running ‘git pull’ from the ‘keyring’ branch:

Toggle snippet (31 lines)
$ git pull
remote: Enumerating objects: 9963, done.
remote: Counting objects: 100% (9063/9063), done.
remote: Compressing objects: 100% (1920/1920), done.
remote: Total 8838 (delta 7033), reused 8721 (delta 6918), pack-reused 0
Receiving objects: 100% (8838/8838), 3.83 MiB | 5.14 MiB/s, done.
Resolving deltas: 100% (7033/7033), completed with 150 local objects.
From ssh://git.sv.gnu.org/srv/git/guix
1d5caad391..f8868dd56b keyring -> origin/keyring
00fda872d0..b9afd0ae5e go-team -> origin/go-team
+ 34344d8e24...77e3ebbfe2 gsl-upgrade -> origin/gsl-upgrade (forced update)
b51632cfa4..a36fe3204b hurd-team -> origin/hurd-team
+ 00f0b26fa8...022819af80 kde-team -> origin/kde-team (forced update)
+ 2104837001...7853ffd6ff kernel-updates -> origin/kernel-updates (forced update)
+ 566cd207a8...cf6a849f1b python-team -> origin/python-team (forced update)
86f14d70d7..77e98a5546 r-team -> origin/r-team
+ e40a906933...31e7d5d0d7 rust-team -> origin/rust-team (forced update)
+ 47a0a24991...aa3960c15e wip-zig-bootstrap -> origin/wip-zig-bootstrap (forced update)
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Updating 1d5caad391..f8868dd56b
Fast-forward
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
ekaitz-3F7356D6.key | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 ekaitz-3F7356D6.key
Authenticating commits 9edb3f6 to f8868dd (28 new commits)...
guix git: error: commit f8868dd56bff0f282329a33abb62262b2fc584b6 is not a descendant of introductory commit 9edb3f66fd807b096b48283debdcddccfea34bad

Ludo’.
L
L
Ludovic Courtès wrote on 30 Nov 2024 21:54
(address . 74583@debbugs.gnu.org)
87y110wifz.fsf@gnu.org
And when pushing tags:

Toggle snippet (4 lines)
$ git … push origin --tags
guix git: .[1;31merror: .[0mGit error: the requested type does not match the type in the ODB
error: failed to push some refs to 'ssh://git.sv.gnu.org/srv/git/shepherd.git'
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 74583@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74583
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch