[PATCH] gnu: xterm: Update to 395.

  • Open
  • quality assurance status badge
Details
3 participants
  • kiasoc5
  • Maxim Cournoyer
  • Zheng Junjie
Owner
unassigned
Submitted by
kiasoc5
Severity
normal

Debbugs page

kiasoc5 wrote 3 months ago
(address . guix-patches@gnu.org)(name . kiasoc5)(address . kiasoc5@disroot.org)
e5dbfe05d754bbf9e50a5504844f0d105f991764.1732749716.git.kiasoc5@disroot.org
* gnu/packages/xorg.scm (xterm): Update to 395.

Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
---
gnu/packages/xorg.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 554dc21ba7..470e8f1bc3 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -5969,7 +5969,7 @@ (define-public xmessage
(define-public xterm
(package
(name "xterm")
- (version "390")
+ (version "395")
(source
(origin
(method url-fetch)
@@ -5979,7 +5979,7 @@ (define-public xterm
(string-append "ftp://ftp.invisible-island.net/xterm/"
"xterm-" version ".tgz")))
(sha256
- (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
+ (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
(patches
(search-patches "xterm-370-explicit-xcursor.patch"))))
(build-system gnu-build-system)

base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
--
2.46.0
Zheng Junjie wrote 3 months ago
(name . kiasoc5 via Guix-patches via)(address . guix-patches@gnu.org)
87h67qtl68.fsf@iscas.ac.cn
kiasoc5 via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (32 lines)
> * gnu/packages/xorg.scm (xterm): Update to 395.
>
> Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
> ---
> gnu/packages/xorg.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index 554dc21ba7..470e8f1bc3 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -5969,7 +5969,7 @@ (define-public xmessage
> (define-public xterm
> (package
> (name "xterm")
> - (version "390")
> + (version "395")
> (source
> (origin
> (method url-fetch)
> @@ -5979,7 +5979,7 @@ (define-public xterm
> (string-append "ftp://ftp.invisible-island.net/xterm/"
> "xterm-" version ".tgz")))
> (sha256
> - (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
> + (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
> (patches
> (search-patches "xterm-370-explicit-xcursor.patch"))))
> (build-system gnu-build-system)
>
> base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4

Now the xvfb-run test depends on xterm, so we can't simply update xterm,
we might add a new xterm package and hide the original xterm for
xvfb-run only.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmdJkI8ACgkQO1qpk+Gi
3/AMkA/8C7jH54Av607m2AzXJPucvTctkuBZt3lXqkqo7JX3gRLE0e0QPxQHjMNu
Eq3sLMY0bbaZHooTqCMsgKdmDINQTT+zxMRUKxbR8uwxV1/VM7ZJ0mib5dwqlkQG
lhw+8rjeNr9zQnBiWGMWKs7ZOIRnwiWdw+gYIQkL6CccbXYF1rvlejo/XI4lZhco
pVSHPAWA1tTi5bHzkUjtgZfB898Dgq0otMDqBVQFMrnwaNdh4W0HHCA3Y60GUTPW
yvD8//MwZvDWJ04Jw4RejYsljKsW9lKoTd3cdVxJrFtI6fFKqIC+yR9auFPeBM16
GPxJhNg40R8kkcaSPtZ6fD2eBJM7ReoxGgufViiC67c0ar4qGGFssZLAfF1KMTip
WeQMnSgBSnkO6EfuYwT/m/m5hc7ALMdmOi2cAEoN7vZpU++zjXCdFRSP6Qn3RgIp
unBQmEbhH4YQ/tZRII3ofrK2//INwfYQMNRuDyoBDPXSAyTiKF8SFMBV8qO674U1
ZwmnNn5vIao3AwfvGBkavL+QmG36jvR2zZR/kHAKdAPrdF2/Tof2xcO0Da1Kcan2
3HkcXvw54IN+cKqsuGvbv+j+B75S+DQRHpuM6QetrdLT5cb+F+NjBf0rn11T1ujm
H21gGTLCKTp69sgSRZ7k1JfHLQxcRcnxifOwZi0SwrZXa2n26YE=
=05pb
-----END PGP SIGNATURE-----

Maxim Cournoyer wrote 3 months ago
(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)
87ikrvk26j.fsf@gmail.com
Hi Zheng,

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

Toggle quote (38 lines)
> kiasoc5 via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/xorg.scm (xterm): Update to 395.
>>
>> Change-Id: If8434c5d5055fa0a3163a7018b4c0ba5e5280935
>> ---
>> gnu/packages/xorg.scm | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
>> index 554dc21ba7..470e8f1bc3 100644
>> --- a/gnu/packages/xorg.scm
>> +++ b/gnu/packages/xorg.scm
>> @@ -5969,7 +5969,7 @@ (define-public xmessage
>> (define-public xterm
>> (package
>> (name "xterm")
>> - (version "390")
>> + (version "395")
>> (source
>> (origin
>> (method url-fetch)
>> @@ -5979,7 +5979,7 @@ (define-public xterm
>> (string-append "ftp://ftp.invisible-island.net/xterm/"
>> "xterm-" version ".tgz")))
>> (sha256
>> - (base32 "03wwdwnpj5dg1ah5sfp00ppzawjd81lnw47g4p20jjhpqly7q4bm"))
>> + (base32 "1j1x16c1789w845hgs49wsmgx7b2cwan49r8427f7siqb6m3qvi8"))
>> (patches
>> (search-patches "xterm-370-explicit-xcursor.patch"))))
>> (build-system gnu-build-system)
>>
>> base-commit: c6d15cf27a137051ccd8f301330a70dd0eecc3d4
>
> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
> we might add a new xterm package and hide the original xterm for
> xvfb-run only.

Yes, we could rename the current 'xterm' variable to xterm/pinned, make
it hidden, then proceed to add a new 'xterm' package which inherits from
it, at its latest version.

--
Thanks,
Maxim
kiasoc5 wrote 3 months ago
(address . 74570@debbugs.gnu.org)
941572ba-501e-4f9b-b7e0-3b580f17f175@disroot.org
On 12/7/24 09:17, Maxim Cournoyer wrote:
Toggle quote (13 lines)
> Hi Zheng,
>
> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>
>> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
>> we might add a new xterm package and hide the original xterm for
>> xvfb-run only.
>
> Yes, we could rename the current 'xterm' variable to xterm/pinned, make
> it hidden, then proceed to add a new 'xterm' package which inherits from
> it, at its latest version.
>

I agree with making a separate xterm package for tests. Since naming is
one of the hardest things in computer science, how about naming the
pinned version 'xterm-for-tests' instead?
Maxim Cournoyer wrote 3 months ago
(name . kiasoc5)(address . kiasoc5@disroot.org)
87cyi1it35.fsf@gmail.com
Hi,

kiasoc5 <kiasoc5@disroot.org> writes:

Toggle quote (17 lines)
> On 12/7/24 09:17, Maxim Cournoyer wrote:
>> Hi Zheng,
>> Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:
>>
>>> Now the xvfb-run test depends on xterm, so we can't simply update xterm,
>>> we might add a new xterm package and hide the original xterm for
>>> xvfb-run only.
>> Yes, we could rename the current 'xterm' variable to xterm/pinned,
>> make
>> it hidden, then proceed to add a new 'xterm' package which inherits from
>> it, at its latest version.
>>
>
> I agree with making a separate xterm package for tests. Since naming
> is one of the hardest things in computer science, how about naming the
> pinned version 'xterm-for-tests' instead?

I don't have a strong preference, but note that in general I think
naming things based on what they *are*, rather than what they are *used*
for, is a better practice, as we can't reasonably foresee all future use
cases.

There is also a recent convention to use the '/pinned' suffix for
packages that shouldn't be updated often such as with our
git-minimal/pinned one [0]


--
Thanks,
Maxim
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 74570@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74570
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help