Bug: guile-fibers@1.1.1 arm crosscompile fails due to patch on 1.3.1 version

  • Done
  • quality assurance status badge
Details
2 participants
  • janneke
  • Razvan Lixandru
Owner
unassigned
Submitted by
Razvan Lixandru
Severity
normal
R
R
Razvan Lixandru wrote on 22 Nov 09:46 +0100
(address . bug-guix@gnu.org)
CAEZ231AzCeRQfFc4mC=CyQMwmQB7wFxsxN-7Azjyqg_eHiqP_A@mail.gmail.com
Hello,

It looks like this commit:
causes guile-fiber@1.1.1 which is pulled by shepherd to fail:

phase `unpack' succeeded after 0.0 seconds
starting phase `apply-cross-build-fix-patch'
patching file build-aux/guile.am
Hunk #1 FAILED at 22.
1 out of 1 hunk FAILED -- saving rejects to file build-aux/guile.am.rej
error: in phase 'apply-cross-build-fix-patch': uncaught exception:
%exception #<&invoke-error program: "patch" arguments: ("--force"
"-p1" "-i" "/gnu/store/97r1rrxa9ghrj5qp3din1pg6p2lcpzyv-guile-fibers-cross-build-fix.patch")
exit-status: 1 term-signal: #f stop-signal: #f>
phase `apply-cross-build-fix-patch' failed after 0.0 seconds
command "patch" "--force" "-p1" "-i"
"/gnu/store/97r1rrxa9ghrj5qp3din1pg6p2lcpzyv-guile-fibers-cross-build-fix.patch"
failed with status 1
build process 18 exited with status 256

This happens on both arm-linux-gnueabihf and arm64-linux-gnu.
I think it is happening because the 1.1.1 version inherits 1.3.1.
package and it overrides the source, but the patch is still being
applied.

I guess this brakes all arm* crossbuilds.

Cheers,
Razvan
J
J
janneke wrote on 22 Nov 13:15 +0100
(name . Razvan Lixandru)(address . razlix77@gmail.com)(address . 74470@debbugs.gnu.org)
87plmnxy4h.fsf@gnu.org
Razvan Lixandru writes:

Hi,

Toggle quote (3 lines)
> It looks like this commit:
> https://git.savannah.gnu.org/cgit/guix.git/commit/gnu/packages/guile-xyz.scm?id=20c7b8dd04e421a139a02438cf1ddfdfe544a446
> causes guile-fiber@1.1.1 which is pulled by shepherd to fail:
[..]
Toggle quote (4 lines)
> starting phase `apply-cross-build-fix-patch'
> patching file build-aux/guile.am
> Hunk #1 FAILED at 22.

Oops. What about something like this patch (untested)

Toggle snippet (20 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 044a491259..a21289d368 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -937,6 +937,13 @@ (define-public guile-fibers-1.1
guile-3.0 ;for 'guild compile
;; Gettext brings 'AC_LIB_LINKFLAGS_FROM_LIBS'
gettext-minimal))
+ (arguments
+ (if (%current-target-system)
+ (substitute-keyword-arguments (package-arguments guile-fibers)
+ ((#:phases phases)
+ #~(modify-phases #$phases
+ (delete 'apply-cross-build-fix-patch))))
+ (package-arguments guile-fibers)))
(inputs
(list guile-3.0)) ;for libguile-3.0.so
(supported-systems

Toggle quote (5 lines)
> This happens on both arm-linux-gnueabihf and arm64-linux-gnu.
> I think it is happening because the 1.1.1 version inherits 1.3.1.
> package and it overrides the source, but the patch is still being
> applied.

Yes.

Toggle quote (2 lines)
> I guess this brakes all arm* crossbuilds.

Sorry!

Greetings,
Janneke

--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com| Avatar® https://AvatarAcademy.com
J
J
janneke wrote on 22 Nov 22:21 +0100
(name . Razvan Lixandru)(address . razlix77@gmail.com)(address . 74470-done@debbugs.gnu.org)
8734jjt154.fsf@gnu.org
Razvan Lixandru writes:

Toggle quote (4 lines)
> This patch seems to fix the problem, I was able to crosscompile the
> package wit it added in my own channel, I could not get guix to use it
> but that is another issue :)

Ah, that's both good and bad :)

Toggle quote (2 lines)
> Hope to see this merged soon :)

Pushed to master as 02477c6a4fe84058c6e06e3065363835c5be8f57.

Thanks for your report.
Greetings,
Janneke

--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com| Avatar® https://AvatarAcademy.com
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74470@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74470
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch