[PATCH 0/2] Improve piem package

  • Done
  • quality assurance status badge
Details
3 participants
  • Liam Hupfer
  • Nicolas Graves
  • Noé Lopez
Owner
unassigned
Submitted by
Liam Hupfer
Severity
normal
L
L
Liam Hupfer wrote on 11 Nov 03:13 +0100
(address . guix-patches@gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
cover.1731291038.git.liam@hpfr.net
Hi all, new contributor here. Please let me know if there are any issues
with commit message conventions or mail etiquette.

Liam Hupfer (2):
gnu: emacs-piem: Build Info manual
gnu: emacs-piem: Canonicalize home-page URL

gnu/packages/emacs-xyz.scm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)


base-commit: 9cdcfb52ace77fe3b497b21deb639a3027ff02f0
--
2.46.0
L
L
Liam Hupfer wrote on 11 Nov 03:52 +0100
[PATCH 2/2] gnu: emacs-piem: Canonicalize home-page URL
(address . 74305@debbugs.gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
06f19d53c6255f9b779b93c5ede178c1a5c6c915.1731291038.git.liam@hpfr.net
guix lint warns about a permanent redirect.

* gnu/packages/emacs-xyz.scm (emacs-piem): Canonicalize home-page URL.

Change-Id: I8362436789a7e4736fc4572963a817b3532ca58a
---
gnu/packages/emacs-xyz.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7772a80192..ddd691faa3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9797,7 +9797,7 @@ (define-public emacs-piem
emacs-debbugs
emacs-elfeed
emacs-notmuch))
- (home-page "https://docs.kyleam.com/piem")
+ (home-page "https://docs.kyleam.com/piem/")
(synopsis "Glue for working with public-inbox archives")
(description "This package provides a collection of Emacs libraries for
working with public-inbox archives. As much of the hard work here is already
--
2.46.0
L
L
Liam Hupfer wrote on 11 Nov 03:52 +0100
[PATCH 1/2] gnu: emacs-piem: Build Info manual
(address . 74305@debbugs.gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
da7e05fdc2d64bc5042f05737c5713746ff61320.1731291038.git.liam@hpfr.net
* gnu/packages/emacs-xyz (emacs-piem): Build Info manual

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
gnu/packages/emacs-xyz.scm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

Toggle diff (21 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 88e1ab89a9..7772a80192 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9785,7 +9785,13 @@ (define-public emacs-piem
(lambda* (#:key inputs #:allow-other-keys)
(emacs-substitute-variables "piem-b4.el"
("piem-b4-b4-executable"
- (search-input-file inputs "/bin/b4"))))))))
+ (search-input-file inputs "/bin/b4")))))
+ (add-after 'install 'makeinfo
+ (lambda _
+ (invoke "makeinfo" "Documentation/piem.texi")
+ (install-file "piem.info"
+ (string-append #$output "/share/info")))))))
+ (native-inputs (list texinfo))
(inputs
(list b4
emacs-debbugs
--
2.46.0
N
N
Noé Lopez wrote on 14 Nov 00:38 +0100
Re: [PATCH 0/2] Improve piem package
(address . 74305@debbugs.gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
87jzd63dsg.fsf@xn--no-cja.eu
Hi,

Thanks for your patch,

Everything is great, you just forgot a dot at the end of your commit
messages and description :P You can check the git log for examples.

Can you send an updated patch?

Have a good day,
Noé Lopez


Toggle quote (28 lines)
> * gnu/packages/emacs-xyz (emacs-piem): Build Info manual
>
> Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
> ---
> gnu/packages/emacs-xyz.scm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 88e1ab89a9..7772a80192 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9785,7 +9785,13 @@ (define-public emacs-piem
> (lambda* (#:key inputs #:allow-other-keys)
> (emacs-substitute-variables "piem-b4.el"
> ("piem-b4-b4-executable"
> - (search-input-file inputs "/bin/b4"))))))))
> + (search-input-file inputs "/bin/b4")))))
> + (add-after 'install 'makeinfo
> + (lambda _
> + (invoke "makeinfo" "Documentation/piem.texi")
> + (install-file "piem.info"
> + (string-append #$output "/share/info")))))))
> + (native-inputs (list texinfo))
> (inputs
> (list b4
> emacs-debbugs
> --
> 2.46.0
L
L
Liam Hupfer wrote on 15 Nov 06:54 +0100
[PATCH v2 1/2] gnu: emacs-piem: Build Info manual.
(address . 74305@debbugs.gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
45268e8a4ad67dc0a1c7078192e459a6886ef186.1731649950.git.liam@hpfr.net
* gnu/packages/emacs-xyz (emacs-piem): Build Info manual.

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
gnu/packages/emacs-xyz.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b3517b7bd9..39f43824b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -147,6 +147,7 @@
;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom@gmail.com>
;;; Copyright © 2024 Spencer King <spencer.king@nursiapress.com>
;;; Copyright © 2024 emma thompson <bigbookofbug@proton.me>
+;;; Copyright © 2024 Liam Hupfer <liam@hpfr.net>
;;;
;;; This file is part of GNU Guix.
@@ -9785,7 +9786,13 @@ (define-public emacs-piem
(lambda* (#:key inputs #:allow-other-keys)
(emacs-substitute-variables "piem-b4.el"
("piem-b4-b4-executable"
- (search-input-file inputs "/bin/b4"))))))))
+ (search-input-file inputs "/bin/b4")))))
+ (add-after 'install 'makeinfo
+ (lambda _
+ (invoke "makeinfo" "Documentation/piem.texi")
+ (install-file "piem.info"
+ (string-append #$output "/share/info")))))))
+ (native-inputs (list texinfo))
(inputs
(list b4
emacs-debbugs
--
2.46.0
L
L
Liam Hupfer wrote on 15 Nov 06:54 +0100
[PATCH v2 0/2] Improve piem package
(address . 74305@debbugs.gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
cover.1731649950.git.liam@hpfr.net
Thanks Noé, I fixed the commit message punctuation and added a copyright
notice now.

Liam Hupfer (2):
gnu: emacs-piem: Build Info manual.
gnu: emacs-piem: Canonicalize home-page URL.

gnu/packages/emacs-xyz.scm | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)


base-commit: 1592f1ac3b39ba7217d3e0d43f589ead8818c449
--
2.46.0
L
L
Liam Hupfer wrote on 15 Nov 06:54 +0100
[PATCH v2 2/2] gnu: emacs-piem: Canonicalize home-page URL.
(address . 74305@debbugs.gnu.org)(name . Liam Hupfer)(address . liam@hpfr.net)
fcb64e7810cb030a45ce7f27a46a66d2b8c581a4.1731649950.git.liam@hpfr.net
guix lint warns about a permanent redirect.

* gnu/packages/emacs-xyz.scm (emacs-piem): Canonicalize home-page URL.

Change-Id: I8362436789a7e4736fc4572963a817b3532ca58a
---
gnu/packages/emacs-xyz.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 39f43824b8..850c22863b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9798,7 +9798,7 @@ (define-public emacs-piem
emacs-debbugs
emacs-elfeed
emacs-notmuch))
- (home-page "https://docs.kyleam.com/piem")
+ (home-page "https://docs.kyleam.com/piem/")
(synopsis "Glue for working with public-inbox archives")
(description "This package provides a collection of Emacs libraries for
working with public-inbox archives. As much of the hard work here is already
--
2.46.0
N
N
Nicolas Graves wrote on 24 Nov 19:08 +0100
control message for bug #74305
(address . control@debbugs.gnu.org)
87r070tsgw.fsf@ngraves.fr
close 74305
quit

Already merged.

--
Best regards,
Nicolas Graves
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74305@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74305
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch