[PATCH] Adding jack-mixer audio package

  • Done
  • quality assurance status badge
Details
3 participants
  • Andreas Enge
  • Divya Ranjan
  • Ekaitz Zarraga
Owner
unassigned
Submitted by
Divya Ranjan
Severity
normal
D
D
Divya Ranjan wrote on 8 Nov 01:01 +0100
(address . guix-patches@gnu.org)(name . Divya Ranjan)(address . divya@subvertising.org)
20241108000101.7394-1-divya@subvertising.org
---
gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)

Toggle diff (95 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..70477d1071 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages check)
#:use-module (gnu packages cdrom)
#:use-module (gnu packages compression)
+ #:use-module (gnu packages commencement)
#:use-module (gnu packages cpp)
#:use-module (gnu packages curl)
#:use-module (gnu packages dbm)
@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
#:use-module (guix build-system python)
#:use-module (guix build-system trivial)
#:use-module (guix build-system waf)
+ #:use-module (guix build utils)
#:use-module (guix download)
#:use-module (guix gexp)
#:use-module (guix git-download)
@@ -2772,6 +2774,72 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ ;; Replaces hardcoded path with /gnu/store
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+
+ ;; To wrap the paths for python and GTK
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs
+ (list gcc-toolchain
+ pkg-config
+ python-cython
+ python-docutils
+ gnu-gettext
+ glib))
+ (propagated-inputs
+ (list gtk+
+ `(,gtk+ "bin") ;; Required during runtime.
+ python
+ bash-minimal
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs ;; Required to save sessions.
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license license:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
D
D
Divya Ranjan wrote on 8 Nov 01:08 +0100
(address . guix-patches@gnu.org)(address . divya@subvertising.org)
BDC59CEA-B454-4A0C-856C-54B0C5858C31@subvertising.org
Hello Guix devs,

Apologies, I forgot to `--annotate` the git send-email, the following patch adds the jack-mixer application to the `(gnu packages audio)`. It's a python package built with meson, I've tested it with my system and it is deterministic.

Let me know if any changes need to be done.

P.S: CC me, since I'm not subscribed to the mailing list.

Regards,


On 8 November 2024 00:01:01 GMT, Divya Ranjan <divya@subvertising.org> wrote:
Toggle quote (101 lines)
>---
> gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
>diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
>index 467dc4a74f..70477d1071 100644
>--- a/gnu/packages/audio.scm
>+++ b/gnu/packages/audio.scm
>@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
> #:use-module (gnu packages check)
> #:use-module (gnu packages cdrom)
> #:use-module (gnu packages compression)
>+ #:use-module (gnu packages commencement)
> #:use-module (gnu packages cpp)
> #:use-module (gnu packages curl)
> #:use-module (gnu packages dbm)
>@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
> #:use-module (guix build-system python)
> #:use-module (guix build-system trivial)
> #:use-module (guix build-system waf)
>+ #:use-module (guix build utils)
> #:use-module (guix download)
> #:use-module (guix gexp)
> #:use-module (guix git-download)
>@@ -2772,6 +2774,72 @@ (define-public jacktrip
> audio signal streaming.")
> (license (list license:gpl3+ license:lgpl3 license:expat))))
>
>+(define-public jack-mixer
>+ (package
>+ (name "jack-mixer")
>+ (version "19")
>+ (source
>+ (origin
>+ (method git-fetch)
>+ (uri (git-reference
>+ (url "https://github.com/jack-mixer/jack_mixer")
>+ (commit (string-append "release-" version))))
>+ (sha256
>+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
>+ (build-system meson-build-system)
>+ (arguments
>+ (list
>+ #:build-type "release"
>+ #:phases #~(modify-phases %standard-phases
>+ ;; Replaces hardcoded path with /gnu/store
>+ (add-after 'unpack 'path-patch
>+ (lambda _
>+ (substitute* '("meson.build")
>+ (("'/', 'etc', 'xdg'")
>+ (string-append "'"
>+ #$output "'")))))
>+
>+ ;; To wrap the paths for python and GTK
>+ (add-after 'install 'wrap-path
>+ (lambda* (#:key outputs #:allow-other-keys)
>+ (let* ((out (assoc-ref outputs "out"))
>+ (bin (string-append out "/bin/"))
>+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
>+ (version #$(version-major+minor (package-version
>+ (this-package-input
>+ "python"))))
>+ (lib (string-append out "/lib/python" version
>+ "/site-packages")))
>+ (wrap-program (string-append bin "jack_mixer")
>+ `("GUIX_PYTHONPATH" ":" prefix
>+ (,(getenv "GUIX_PYTHONPATH") ,lib))
>+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
>+ (native-inputs
>+ (list gcc-toolchain
>+ pkg-config
>+ python-cython
>+ python-docutils
>+ gnu-gettext
>+ glib))
>+ (propagated-inputs
>+ (list gtk+
>+ `(,gtk+ "bin") ;; Required during runtime.
>+ python
>+ bash-minimal
>+ python-wrapper
>+ python-pygobject
>+ python-pycairo
>+ python-platformdirs ;; Required to save sessions.
>+ jack-2))
>+ (synopsis
>+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
>+ (description
>+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
>+similar to hardware mixing desks. It has lot of useful features, apart
>+from being able to mix multiple JACK audio streams.")
>+ (home-page "https://rdio.space/jackmixer/")
>+ (license license:gpl2+)))
>+
> (define-public jalv
> (package
> (name "jalv")
>--
>2.46.0
>

Divya Ranjan, Mathematics, Philosophy and Libre Software
Attachment: file
E
E
Ekaitz Zarraga wrote on 9 Nov 19:20 +0100
(address . 74251@debbugs.gnu.org)(name . Divya Ranjan)(address . divya@subvertising.org)
c9994053-8d09-4ced-9a65-edd5ed23b50d@elenq.tech
Hi,

The commit message should follow the Changelog format as described the
Submitting-Patches section of the manual.

That said:

Toggle quote (26 lines)
> Hello Guix devs,
>
> Apologies, I forgot to `--annotate` the git send-email, the following patch adds the jack-mixer application to the `(gnu packages audio)`. It's a python package built with meson, I've tested it with my system and it is deterministic.
>
> Let me know if any changes need to be done.
>
> P.S: CC me, since I'm not subscribed to the mailing list.
>
> Regards,
>
>
> On 8 November 2024 00:01:01 GMT, Divya Ranjan <divya@subvertising.org> wrote:
> >---
> > gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> >
> >diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> >index 467dc4a74f..70477d1071 100644
> >--- a/gnu/packages/audio.scm
> >+++ b/gnu/packages/audio.scm
> >@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
> > #:use-module (gnu packages check)
> > #:use-module (gnu packages cdrom)
> > #:use-module (gnu packages compression)
> >+ #:use-module (gnu packages commencement)

This is already included in the `build-system` so you don't need to add
it. In fact, it breaks Guix when you do :)

Toggle quote (58 lines)
> > #:use-module (gnu packages cpp)
> > #:use-module (gnu packages curl)
> > #:use-module (gnu packages dbm)
> >@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
> > #:use-module (guix build-system python)
> > #:use-module (guix build-system trivial)
> > #:use-module (guix build-system waf)
> >+ #:use-module (guix build utils)
> > #:use-module (guix download)
> > #:use-module (guix gexp)
> > #:use-module (guix git-download)
> >@@ -2772,6 +2774,72 @@ (define-public jacktrip
> > audio signal streaming.")
> > (license (list license:gpl3+ license:lgpl3 license:expat))))
> >
> >+(define-public jack-mixer
> >+ (package
> >+ (name "jack-mixer")
> >+ (version "19")
> >+ (source
> >+ (origin
> >+ (method git-fetch)
> >+ (uri (git-reference
> >+ (url "https://github.com/jack-mixer/jack_mixer")
> >+ (commit (string-append "release-" version))))
> >+ (sha256
> >+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
> >+ (build-system meson-build-system)
> >+ (arguments
> >+ (list
> >+ #:build-type "release"
> >+ #:phases #~(modify-phases %standard-phases
> >+ ;; Replaces hardcoded path with /gnu/store
> >+ (add-after 'unpack 'path-patch
> >+ (lambda _
> >+ (substitute* '("meson.build")
> >+ (("'/', 'etc', 'xdg'")
> >+ (string-append "'"
> >+ #$output "'")))))
> >+
> >+ ;; To wrap the paths for python and GTK
> >+ (add-after 'install 'wrap-path
> >+ (lambda* (#:key outputs #:allow-other-keys)
> >+ (let* ((out (assoc-ref outputs "out"))
> >+ (bin (string-append out "/bin/"))
> >+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
> >+ (version #$(version-major+minor (package-version
> >+ (this-package-input
> >+ "python"))))
> >+ (lib (string-append out "/lib/python" version
> >+ "/site-packages")))
> >+ (wrap-program (string-append bin "jack_mixer")
> >+ `("GUIX_PYTHONPATH" ":" prefix
> >+ (,(getenv "GUIX_PYTHONPATH") ,lib))
> >+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
> >+ (native-inputs
> >+ (list gcc-toolchain

As said, remove gcc-toolchain

Toggle quote (30 lines)
> >+ pkg-config
> >+ python-cython
> >+ python-docutils
> >+ gnu-gettext
> >+ glib))
> >+ (propagated-inputs
> >+ (list gtk+
> >+ `(,gtk+ "bin") ;; Required during runtime.
> >+ python
> >+ bash-minimal
> >+ python-wrapper
> >+ python-pygobject
> >+ python-pycairo
> >+ python-platformdirs ;; Required to save sessions.
> >+ jack-2))
> >+ (synopsis
> >+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
> >+ (description
> >+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
> >+similar to hardware mixing desks. It has lot of useful features, apart
> >+from being able to mix multiple JACK audio streams.")
> >+ (home-page "https://rdio.space/jackmixer/")
> >+ (license license:gpl2+)))
> >+
> > (define-public jalv
> > (package
> > (name "jalv")
> >--
> >2.46.0

Also when running `./pre-inst-env guix lint jack-mixer` there are
several problems with the package.

Some you can fix with `./pre-inst-env style jack-mixer` but some others
you have to fix by hand:

guix/gnu/packages/audio.scm:2777:2: jack-mixer@19: 'gettext' should
probably switched for its minimal variant
gnu/packages/audio.scm:2777:2: jack-mixer@19: "bash-minimal" should be
in 'inputs' when 'wrap-program' is used
...

Please, run the linter and fix the problems.

Thanks for the patch!
D
D
Divya Ranjan wrote on 11 Nov 02:17 +0100
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 74251@debbugs.gnu.org)
87r07ibmcs.fsf@subvertising.org
Ekaitz Zarraga <ekaitz@elenq.tech> writes:

Toggle quote (139 lines)
> Hi,
>
> The commit message should follow the Changelog format as described the
> Submitting-Patches section of the manual.
>
> That said:
>
>> Hello Guix devs,
>> Apologies, I forgot to `--annotate` the git send-email, the
>> following patch adds the jack-mixer application to the `(gnu
>> packages audio)`. It's a python package built with meson, I've
>> tested it with my system and it is deterministic.
>> Let me know if any changes need to be done.
>> P.S: CC me, since I'm not subscribed to the mailing list.
>> Regards,
>> On 8 November 2024 00:01:01 GMT, Divya Ranjan
>> <divya@subvertising.org> wrote:
>> >---
>> > gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++
>> > 1 file changed, 68 insertions(+)
>> >
>> >diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
>> >index 467dc4a74f..70477d1071 100644
>> >--- a/gnu/packages/audio.scm
>> >+++ b/gnu/packages/audio.scm
>> >@@ -79,6 +79,7 @@ (define-module (gnu packages audio)
>> > #:use-module (gnu packages check)
>> > #:use-module (gnu packages cdrom)
>> > #:use-module (gnu packages compression)
>> >+ #:use-module (gnu packages commencement)
>
> This is already included in the `build-system` so you don't need to
> add it. In fact, it breaks Guix when you do :)
>
>> > #:use-module (gnu packages cpp)
>> > #:use-module (gnu packages curl)
>> > #:use-module (gnu packages dbm)
>> >@@ -160,6 +161,7 @@ (define-module (gnu packages audio)
>> > #:use-module (guix build-system python)
>> > #:use-module (guix build-system trivial)
>> > #:use-module (guix build-system waf)
>> >+ #:use-module (guix build utils)
>> > #:use-module (guix download)
>> > #:use-module (guix gexp)
>> > #:use-module (guix git-download)
>> >@@ -2772,6 +2774,72 @@ (define-public jacktrip
>> > audio signal streaming.")
>> > (license (list license:gpl3+ license:lgpl3 license:expat))))
>> > >+(define-public jack-mixer
>> >+ (package
>> >+ (name "jack-mixer")
>> >+ (version "19")
>> >+ (source
>> >+ (origin
>> >+ (method git-fetch)
>> >+ (uri (git-reference
>> >+ (url "https://github.com/jack-mixer/jack_mixer")
>> >+ (commit (string-append "release-" version))))
>> >+ (sha256
>> >+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
>> >+ (build-system meson-build-system)
>> >+ (arguments
>> >+ (list
>> >+ #:build-type "release"
>> >+ #:phases #~(modify-phases %standard-phases
>> >+ ;; Replaces hardcoded path with /gnu/store
>> >+ (add-after 'unpack 'path-patch
>> >+ (lambda _
>> >+ (substitute* '("meson.build")
>> >+ (("'/', 'etc', 'xdg'")
>> >+ (string-append "'"
>> >+ #$output "'")))))
>> >+
>> >+ ;; To wrap the paths for python and GTK
>> >+ (add-after 'install 'wrap-path
>> >+ (lambda* (#:key outputs #:allow-other-keys)
>> >+ (let* ((out (assoc-ref outputs "out"))
>> >+ (bin (string-append out "/bin/"))
>> >+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
>> >+ (version #$(version-major+minor (package-version
>> >+ (this-package-input
>> >+ "python"))))
>> >+ (lib (string-append out "/lib/python" version
>> >+ "/site-packages")))
>> >+ (wrap-program (string-append bin "jack_mixer")
>> >+ `("GUIX_PYTHONPATH" ":" prefix
>> >+ (,(getenv "GUIX_PYTHONPATH") ,lib))
>> >+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
>> >+ (native-inputs
>> >+ (list gcc-toolchain
>
> As said, remove gcc-toolchain
>
>> >+ pkg-config
>> >+ python-cython
>> >+ python-docutils
>> >+ gnu-gettext
>> >+ glib))
>> >+ (propagated-inputs
>> >+ (list gtk+
>> >+ `(,gtk+ "bin") ;; Required during runtime.
>> >+ python
>> >+ bash-minimal
>> >+ python-wrapper
>> >+ python-pygobject
>> >+ python-pycairo
>> >+ python-platformdirs ;; Required to save sessions.
>> >+ jack-2))
>> >+ (synopsis
>> >+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
>> >+ (description
>> >+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
>> >+similar to hardware mixing desks. It has lot of useful features, apart
>> >+from being able to mix multiple JACK audio streams.")
>> >+ (home-page "https://rdio.space/jackmixer/")
>> >+ (license license:gpl2+)))
>> >+
>> > (define-public jalv
>> > (package
>> > (name "jalv")
>> >-- >2.46.0
>
> Also when running `./pre-inst-env guix lint jack-mixer` there are
> several problems with the package.
>
> Some you can fix with `./pre-inst-env style jack-mixer` but some
> others you have to fix by hand:
>
> guix/gnu/packages/audio.scm:2777:2: jack-mixer@19: 'gettext'
> should probably switched for its minimal variant
> gnu/packages/audio.scm:2777:2: jack-mixer@19: "bash-minimal"
> should be in 'inputs' when 'wrap-program' is used
> ...
>
> Please, run the linter and fix the problems.
>
> Thanks for the patch!
>

Thank you for reminding me about the linter issues and the fact that gcc stuff doesn’t need to be added, I’ve made the changes in the attached patch. Also, let me know if the commit message is okay.

Regards,
From cd0d5e07739357d1bbb5e979746a4663a5000433 Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Mon, 11 Nov 2024 01:11:15 +0000
Subject: [PATCH] gnu: audio: Add jack-mixer

---
gnu/packages/audio.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)

Toggle diff (73 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..f97bbb4126 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2772,6 +2772,66 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs (list pkg-config
+ python-cython
+ python-docutils
+ gnu-gettext-minimal
+ glib))
+ (inputs (list bash-minimal))
+ (propagated-inputs (list gtk+
+ `(,gtk+ "bin")
+ python
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license licens:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
E
E
Ekaitz Zarraga wrote on 11 Nov 17:01 +0100
(name . Divya Ranjan)(address . divya@subvertising.org)(address . 74251@debbugs.gnu.org)
4258e857-4d68-4692-81c4-099fb4adc1fe@elenq.tech
Hi,

Toggle quote (5 lines)
>
> Thank you for reminding me about the linter issues and the fact that gcc stuff doesn’t need to be added, I’ve made the changes in the attached patch. Also, let me know if the commit message is okay.
>
> Regards,

The commit message is missing the body.
It should have something like:

* gnu/packages/audio.scm (jack-mixer): New variable.

Please add that and I'll do a further review.

Cheers,
Ekaitz
D
D
Divya Ranjan wrote on 11 Nov 17:18 +0100
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 74251@debbugs.gnu.org)
87jzd9zqv5.fsf@subvertising.org
Ekaitz Zarraga <ekaitz@elenq.tech> writes:

Toggle quote (18 lines)
> Hi,
>
>> Thank you for reminding me about the linter issues and the fact that
>> gcc stuff doesn’t need to be added, I’ve made the changes in the
>> attached patch. Also, let me know if the commit message is okay.
>> Regards,
>
> The commit message is missing the body.
> It should have something like:
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>
> Please add that and I'll do a further review.
>
> Cheers,
> Ekaitz
>

Does this look good?
From d0b5f7c3dd96ae9c84db41e1e9044b9e4fd9a078 Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Mon, 11 Nov 2024 01:11:15 +0000
Subject: [PATCH] gnu/packages/audio.scm (jack-mixer): New variable

---
gnu/packages/audio.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)

Toggle diff (73 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..f97bbb4126 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2772,6 +2772,66 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs (list pkg-config
+ python-cython
+ python-docutils
+ gnu-gettext-minimal
+ glib))
+ (inputs (list bash-minimal))
+ (propagated-inputs (list gtk+
+ `(,gtk+ "bin")
+ python
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license licens:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
Regards,
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
E
E
Ekaitz Zarraga wrote on 11 Nov 17:23 +0100
(name . Divya Ranjan)(address . divya@subvertising.org)(address . 74251@debbugs.gnu.org)
51729a6a-e1f9-48e6-814a-b1a28f0558df@elenq.tech
Sorry mate I didn't explain it properly.

The commit message has two parts: a title and a body.

The title you used before was correct, you were only missing the body.
This is how the whole commit message should look like:

gnu: audio: Add jack-mixer

* gnu/packages/audio.scm (jack-mixer): New variable.
D
D
Divya Ranjan wrote on 11 Nov 17:32 +0100
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 74251@debbugs.gnu.org)
87cyj1zq6v.fsf@subvertising.org
Ekaitz Zarraga <ekaitz@elenq.tech> writes:

Toggle quote (12 lines)
> Sorry mate I didn't explain it properly.
>
> The commit message has two parts: a title and a body.
>
> The title you used before was correct, you were only missing the
> body. This is how the whole commit message should look like:
>
> gnu: audio: Add jack-mixer
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>

Apologies I was confused with the title and the body, I usually only have titles in commit messages. Confirm if this one is appropriate.
From 44110f38a40f673bd0d69dd68b11d3f3e555be77 Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Mon, 11 Nov 2024 01:11:15 +0000
Subject: [PATCH] gnu: audio: Add jack-mixer

* gnu/packages/audio.scm (jack-mixer): New variable
---
gnu/packages/audio.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)

Toggle diff (73 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..f97bbb4126 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2772,6 +2772,66 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs (list pkg-config
+ python-cython
+ python-docutils
+ gnu-gettext-minimal
+ glib))
+ (inputs (list bash-minimal))
+ (propagated-inputs (list gtk+
+ `(,gtk+ "bin")
+ python
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license licens:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
Regards,
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
D
D
Divya Ranjan wrote on 11 Nov 20:42 +0100
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 74251@debbugs.gnu.org)
877c99zhen.fsf@subvertising.org
Ekaitz Zarraga <ekaitz@elenq.tech> writes:

Toggle quote (12 lines)
> Sorry mate I didn't explain it properly.
>
> The commit message has two parts: a title and a body.
>
> The title you used before was correct, you were only missing the
> body. This is how the whole commit message should look like:
>
> gnu: audio: Add jack-mixer
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>

Okay, I think this is the final patch.


Regards,
From 81db499ec6702efb38e56447b9ccc1253a6ee62c Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Mon, 11 Nov 2024 19:38:20 +0000
Subject: [PATCH] gnu: audio: Add jack-mixer

* gnu/packages/audio.scm (jack-mixer): New variable

Signed-off-by: Divya Ranjan <divya@subvertising.org>
---
gnu/packages/audio.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)

Toggle diff (73 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..8548b2d8ed 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2772,6 +2772,66 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs (list pkg-config
+ python-cython
+ python-docutils
+ gettext-minimal
+ glib))
+ (inputs (list bash-minimal))
+ (propagated-inputs (list gtk+
+ `(,gtk+ "bin")
+ python
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license license:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
D
D
Divya Ranjan wrote on 11 Nov 20:42 +0100
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 74251@debbugs.gnu.org)
875xotzhdx.fsf@subvertising.org
Ekaitz Zarraga <ekaitz@elenq.tech> writes:

Toggle quote (12 lines)
> Sorry mate I didn't explain it properly.
>
> The commit message has two parts: a title and a body.
>
> The title you used before was correct, you were only missing the
> body. This is how the whole commit message should look like:
>
> gnu: audio: Add jack-mixer
>
> * gnu/packages/audio.scm (jack-mixer): New variable.
>

Okay, I think this is the final patch.


Regards,
From 81db499ec6702efb38e56447b9ccc1253a6ee62c Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Mon, 11 Nov 2024 19:38:20 +0000
Subject: [PATCH] gnu: audio: Add jack-mixer

* gnu/packages/audio.scm (jack-mixer): New variable

Signed-off-by: Divya Ranjan <divya@subvertising.org>
---
gnu/packages/audio.scm | 60 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)

Toggle diff (73 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..8548b2d8ed 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2772,6 +2772,66 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs (list pkg-config
+ python-cython
+ python-docutils
+ gettext-minimal
+ glib))
+ (inputs (list bash-minimal))
+ (propagated-inputs (list gtk+
+ `(,gtk+ "bin")
+ python
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license license:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
E
E
Ekaitz Zarraga wrote on 11 Nov 22:19 +0100
(name . Divya Ranjan)(address . divya@subvertising.org)(address . 74251@debbugs.gnu.org)
e9a7b4f7-9b6a-4c1f-a4a6-c08903b32254@elenq.tech
On 2024-11-11 20:42, Divya Ranjan wrote:
Toggle quote (19 lines)
> Ekaitz Zarraga <ekaitz@elenq.tech> writes:
>
>> Sorry mate I didn't explain it properly.
>>
>> The commit message has two parts: a title and a body.
>>
>> The title you used before was correct, you were only missing the
>> body. This is how the whole commit message should look like:
>>
>> gnu: audio: Add jack-mixer
>>
>> * gnu/packages/audio.scm (jack-mixer): New variable.
>>
>
> Okay, I think this is the final patch.
>
>
> Regards,

Yes, this is almost there but there are still a couple of warnings by
`guix lint`:

jack-mixer@19: the source file name should contain the package name

This is complaining because when it clones the source code it is called
"jack_mixer" but your package is called "jack-mixer" instead. You could
fix it using something like this in the `origin`:

(file-name (git-file-name name version))

If you add that and fix the indentation (you can use `guix style` for
that), I think this is ready to go.

You are almost there!

PS: The other warning I think we can ignore for the moment. We have some
other packages with the same warning I think it's because of the
expansion of the `(,gtk+ "bin")
D
D
Divya Ranjan wrote on 12 Nov 02:21 +0100
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 74251@debbugs.gnu.org)
87y11pxn4a.fsf@subvertising.org
Ekaitz Zarraga <ekaitz@elenq.tech> writes:

Toggle quote (38 lines)
> On 2024-11-11 20:42, Divya Ranjan wrote:
>> Ekaitz Zarraga <ekaitz@elenq.tech> writes:
>>
>>> Sorry mate I didn't explain it properly.
>>>
>>> The commit message has two parts: a title and a body.
>>>
>>> The title you used before was correct, you were only missing the
>>> body. This is how the whole commit message should look like:
>>>
>>> gnu: audio: Add jack-mixer
>>>
>>> * gnu/packages/audio.scm (jack-mixer): New variable.
>>>
>> Okay, I think this is the final patch.
>> Regards,
>
> Yes, this is almost there but there are still a couple of warnings by
> `guix lint`:
>
> jack-mixer@19: the source file name should contain the package name
>
> This is complaining because when it clones the source code it is
> called "jack_mixer" but your package is called "jack-mixer"
> instead. You could fix it using something like this in the `origin`:
>
> (file-name (git-file-name name version))
>
> If you add that and fix the indentation (you can use `guix style` for
> that), I think this is ready to go.
>
> You are almost there!
>
> PS: The other warning I think we can ignore for the moment. We have
> some other packages with the same warning I think it's because of the
> expansion of the `(,gtk+ "bin")
>

Added the necessary changes.

Regards,
From df1ddf6d262f432f6b777cd6b9999679679749a8 Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Mon, 11 Nov 2024 23:44:44 +0000
Subject: [PATCH] gnu: audio: Add jack-mixer

* gnu/packages/audio.scm (jack-mixer): New variable

Change-Id: I0b278f8674c84a4f43f9d23afc900b0a53e11f7c
---
gnu/packages/audio.scm | 59 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)

Toggle diff (72 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 467dc4a74f..8ef87264a0 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2772,6 +2772,65 @@ (define-public jacktrip
audio signal streaming.")
(license (list license:gpl3+ license:lgpl3 license:expat))))
+(define-public jack-mixer
+ (package
+ (name "jack-mixer")
+ (version "19")
+ (source
+ (origin
+ (file-name (git-file-name name version))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jack-mixer/jack_mixer")
+ (commit (string-append "release-" version))))
+ (sha256
+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:build-type "release"
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'path-patch
+ (lambda _
+ (substitute* '("meson.build")
+ (("'/', 'etc', 'xdg'")
+ (string-append "'"
+ #$output "'")))))
+ (add-after 'install 'wrap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin/"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH"))
+ (version #$(version-major+minor (package-version
+ (this-package-input
+ "python"))))
+ (lib (string-append out "/lib/python" version
+ "/site-packages")))
+ (wrap-program (string-append bin "jack_mixer")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH") ,lib))
+ `("GI_TYPELIB_PATH" ":" prefix
+ (,gi-typelib-path)))))))))
+ (native-inputs (list pkg-config python-cython python-docutils
+ gettext-minimal glib))
+ (inputs (list bash-minimal))
+ (propagated-inputs (list gtk+
+ `(,gtk+ "bin")
+ python
+ python-wrapper
+ python-pygobject
+ python-pycairo
+ python-platformdirs
+ jack-2))
+ (synopsis
+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit")
+ (description
+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling
+similar to hardware mixing desks. It has lot of useful features, apart
+from being able to mix multiple JACK audio streams.")
+ (home-page "https://rdio.space/jackmixer/")
+ (license license:gpl2+)))
+
(define-public jalv
(package
(name "jalv")
--
2.46.0
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
E
E
Ekaitz Zarraga wrote on 12 Nov 11:42 +0100
QA review for 74251
68a4e15b-09ef-4879-a39b-a8d6472d6580@elenq.tech
user guix
usertag 74251 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked: Lint warnings, Package builds, Commit messages,
New package licenses, New package tests, New package synopsis and
descriptions
--
ElenQ Technology
E
E
Ekaitz Zarraga wrote on 12 Nov 11:42 +0100
84fcb9f3-af31-469c-8406-d665c495aa6b@elenq.tech
user guix
usertag 74251 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked: Lint warnings, Package builds, Commit messages,
New package licenses, New package tests, New package synopsis and
descriptions
--
ElenQ Technology
A
A
Andreas Enge wrote on 13 Nov 14:02 +0100
Close
(address . 74251-done@debbugs.gnu.org)
ZzSjeLaMWtxSHLVi@jurong
Pushed, thanks for the patch and the reviewing work!

Andreas
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74251@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74251
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch