[PATCH 0/2] gnu: Add knights.

Done

Details

2 participants

Sughosha
Z572

Owner: unassigned

Submitted by: Sughosha

Severity: normal

Sughosha wrote on 1 Nov 2024 16:11

Recipients:(address . guix-patches@gnu.org)(name . Sughosha)(address . sughosha@disroot.org)

Message-ID:cover.1730473876.git.sughosha@disroot.org

This patch series adds knights and adds it to kde-games.

Sughosha (2):

gnu: Add knights.

gnu: kde-games: Add knights to propagated-inputs.

gnu/packages/kde-games.scm | 63 +++++++++++++++++++++++++++++++++++++-

1 file changed, 62 insertions(+), 1 deletion(-)

base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718

2.46.0

Sughosha wrote on 1 Nov 2024 16:14

[PATCH 1/2] gnu: Add knights.

Recipients:(address . 74161@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)

Message-ID:17883d35f56b5d5020d1abf542aacfd965baee35.1730474100.git.sughosha@disroot.org

* gnu/packages/kde-games.scm (knights): New variable.

Change-Id: I86346750c28fefd5b2a02cbda8dcc458907766fa

---

gnu/packages/kde-games.scm | 60 ++++++++++++++++++++++++++++++++++++++

1 file changed, 60 insertions(+)

Toggle diff (75 lines)diff --git a/gnu/packages/kde-games.scm b/gnu/packages/kde-games.scm
index 10c26e1d8e..75c6038189 100644
--- a/gnu/packages/kde-games.scm
+++ b/gnu/packages/kde-games.scm
@@ -1594,6 +1594,66 @@ (define-public kjumpingcube
 This package is part of the KDE games module.")
     (license (list license:gpl2+ license:fdl1.2+))))
 
+(define-public knights
+  (package
+    (name "knights")
+    (version "24.05.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/release-service/" version
+                           "/src/knights-" version ".tar.xz"))
+       (sha256
+        (base32 "19xsa79p0ad3cgm1zz2ykbm4487fyizshn7ir8f5azhkr1bi6l8k"))))
+    (build-system qt-build-system)
+    (arguments
+     (list #:qtbase qtbase))
+    (native-inputs
+     (list extra-cmake-modules kdoctools))
+    (inputs
+     (list kconfigwidgets
+           kcoreaddons
+           kcrash
+           kdbusaddons
+           ki18n
+           kio
+           kplotting
+           ksvg
+           ktextwidgets
+           kwallet
+           kxmlgui
+           libkdegames
+           libplasma
+           qtspeech
+           qtsvg))
+    (home-page "https://apps.kde.org/knights/")
+    (synopsis "Chess game")
+    (description "KNights is a chess game, featuring:
+
+@itemize
+@item local play between two players on the same computer
+@item play against any computer program that supports the XBoard protocol
+@item play on the Free Internet Chess Server (FICS)
+@item watching two computer engines play against each other
+@item support for legal move checking
+@item markers for possible moves, opponent’s last move and sources of check
+@item board borders and site notations
+@item complete time control, with Plasma-styled clocks
+@item several themes, with the possibility of downloading new ones from within
+ the program
+@item animated moves (configurable)
+@item views for playing on a chess server, including a seek graph, text
+ console, and chat widget
+@item option to undo and redo moves
+@item graphic interface for making and receiving offers from remote players
+@item support for the UCI protocol (used by Stockfish, Chessbase, and many
+ others)
+@item support for saving and loading Portable game notation (PGN) files
+@item use of Jovie, the KDE text-to-speak program, to speak opponent’s moves
+@item ability to control the program via a D-Bus interface
+@end itemize")
+    (license license:gpl2+)))
+
 (define-public kde-games
   (package
     (name "kde-games")

base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718
-- 
2.46.0

Sughosha wrote on 1 Nov 2024 16:15

[PATCH 2/2] gnu: kde-games: Add knights to propagated-inputs.

Recipients:(address . 74161@debbugs.gnu.org)(name . Sughosha)(address . sughosha@disroot.org)

Message-ID:9569953f4d21a93c0d4d45442ba5fca69d87e2ea.1730474100.git.sughosha@disroot.org

* gnu/packages/kde-games (kde-games)[propagated-inputs]: Add knights.

Change-Id: I36666852175ba76d69f800e195dc6679ec3d621b

---

gnu/packages/kde-games.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (23 lines)diff --git a/gnu/packages/kde-games.scm b/gnu/packages/kde-games.scm
index 75c6038189..e9e25c9e88 100644
--- a/gnu/packages/kde-games.scm
+++ b/gnu/packages/kde-games.scm
@@ -1663,7 +1663,7 @@ (define-public kde-games
     (arguments
      (list #:builder #~(mkdir #$output)))
     (propagated-inputs
-     ;; TODO: kpat, klickety, katomic, knights.
+     ;; TODO: kpat, klickety, katomic.
      (list bomber
            bovo
            granatier
@@ -1685,6 +1685,7 @@ (define-public kde-games
            kmines
            knavalbattle
            knetwalk
+           knights
            kolf
            kollision
            konquest
-- 
2.46.0

Z572 wrote on 1 Nov 2024 17:53

Re: [bug#74161] [PATCH 1/2] gnu: Add knights.

Recipients:(name . Sughosha via Guix-patches via)(address . guix-patches@gnu.org)

Message-ID:871pzulwuj.fsf@iscas.ac.cn

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (19 lines)> * gnu/packages/kde-games.scm (knights): New variable.
>
> Change-Id: I86346750c28fefd5b2a02cbda8dcc458907766fa
> ---
>  gnu/packages/kde-games.scm | 60 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
>
> diff --git a/gnu/packages/kde-games.scm b/gnu/packages/kde-games.scm
> index 10c26e1d8e..75c6038189 100644
> --- a/gnu/packages/kde-games.scm
> +++ b/gnu/packages/kde-games.scm
> @@ -1594,6 +1594,66 @@ (define-public kjumpingcube
>  This package is part of the KDE games module.")
>      (license (list license:gpl2+ license:fdl1.2+))))
>  
> +(define-public knights
> +  (package
> +    (name "knights")

We already have a package called knights, so maybe we need a new name here

Toggle quote (62 lines)> +    (version "24.05.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://kde/stable/release-service/" version
> +                           "/src/knights-" version ".tar.xz"))
> +       (sha256
> +        (base32 "19xsa79p0ad3cgm1zz2ykbm4487fyizshn7ir8f5azhkr1bi6l8k"))))
> +    (build-system qt-build-system)
> +    (arguments
> +     (list #:qtbase qtbase))
> +    (native-inputs
> +     (list extra-cmake-modules kdoctools))
> +    (inputs
> +     (list kconfigwidgets
> +           kcoreaddons
> +           kcrash
> +           kdbusaddons
> +           ki18n
> +           kio
> +           kplotting
> +           ksvg
> +           ktextwidgets
> +           kwallet
> +           kxmlgui
> +           libkdegames
> +           libplasma
> +           qtspeech
> +           qtsvg))
> +    (home-page "https://apps.kde.org/knights/")
> +    (synopsis "Chess game")
> +    (description "KNights is a chess game, featuring:
> +
> +@itemize
> +@item local play between two players on the same computer
> +@item play against any computer program that supports the XBoard protocol
> +@item play on the Free Internet Chess Server (FICS)
> +@item watching two computer engines play against each other
> +@item support for legal move checking
> +@item markers for possible moves, opponent%e2?%99s last move and sources of check
> +@item board borders and site notations
> +@item complete time control, with Plasma-styled clocks
> +@item several themes, with the possibility of downloading new ones from within
> + the program
> +@item animated moves (configurable)
> +@item views for playing on a chess server, including a seek graph, text
> + console, and chat widget
> +@item option to undo and redo moves
> +@item graphic interface for making and receiving offers from remote players
> +@item support for the UCI protocol (used by Stockfish, Chessbase, and many
> + others)
> +@item support for saving and loading Portable game notation (PGN) files
> +@item use of Jovie, the KDE text-to-speak program, to speak opponent%e2?%99s moves
> +@item ability to control the program via a D-Bus interface
> +@end itemize")
> +    (license license:gpl2+)))
> +
>  (define-public kde-games
>    (package
>      (name "kde-games")
>
> base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718

Sughosha wrote on 3 Nov 2024 08:08

Recipients:(address . 74161@debbugs.gnu.org)

Message-ID:D9114A98-DE83-48C7-A2FA-A5400B067BF7@disroot.org

I think renaming the existing "knights" package (old one) with "knightsgame" would be fine. It's home page also says this name.

On 1 November 2024 10:23:08 pm IST, Z572 <zhengjunjie@iscas.ac.cn> wrote:

Toggle quote (86 lines)>Sughosha via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/kde-games.scm (knights): New variable.
>>
>> Change-Id: I86346750c28fefd5b2a02cbda8dcc458907766fa
>> ---
>>  gnu/packages/kde-games.scm | 60 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 60 insertions(+)
>>
>> diff --git a/gnu/packages/kde-games.scm b/gnu/packages/kde-games.scm
>> index 10c26e1d8e..75c6038189 100644
>> --- a/gnu/packages/kde-games.scm
>> +++ b/gnu/packages/kde-games.scm
>> @@ -1594,6 +1594,66 @@ (define-public kjumpingcube
>>  This package is part of the KDE games module.")
>>      (license (list license:gpl2+ license:fdl1.2+))))
>>  
>> +(define-public knights
>> +  (package
>> +    (name "knights")
>
>We already have a package called knights, so maybe we need a new name here
>
>> +    (version "24.05.2")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "mirror://kde/stable/release-service/" version
>> +                           "/src/knights-" version ".tar.xz"))
>> +       (sha256
>> +        (base32 "19xsa79p0ad3cgm1zz2ykbm4487fyizshn7ir8f5azhkr1bi6l8k"))))
>> +    (build-system qt-build-system)
>> +    (arguments
>> +     (list #:qtbase qtbase))
>> +    (native-inputs
>> +     (list extra-cmake-modules kdoctools))
>> +    (inputs
>> +     (list kconfigwidgets
>> +           kcoreaddons
>> +           kcrash
>> +           kdbusaddons
>> +           ki18n
>> +           kio
>> +           kplotting
>> +           ksvg
>> +           ktextwidgets
>> +           kwallet
>> +           kxmlgui
>> +           libkdegames
>> +           libplasma
>> +           qtspeech
>> +           qtsvg))
>> +    (home-page "https://apps.kde.org/knights/")
>> +    (synopsis "Chess game")
>> +    (description "KNights is a chess game, featuring:
>> +
>> +@itemize
>> +@item local play between two players on the same computer
>> +@item play against any computer program that supports the XBoard protocol
>> +@item play on the Free Internet Chess Server (FICS)
>> +@item watching two computer engines play against each other
>> +@item support for legal move checking
>> +@item markers for possible moves, opponent%e2?%99s last move and sources of check
>> +@item board borders and site notations
>> +@item complete time control, with Plasma-styled clocks
>> +@item several themes, with the possibility of downloading new ones from within
>> + the program
>> +@item animated moves (configurable)
>> +@item views for playing on a chess server, including a seek graph, text
>> + console, and chat widget
>> +@item option to undo and redo moves
>> +@item graphic interface for making and receiving offers from remote players
>> +@item support for the UCI protocol (used by Stockfish, Chessbase, and many
>> + others)
>> +@item support for saving and loading Portable game notation (PGN) files
>> +@item use of Jovie, the KDE text-to-speak program, to speak opponent%e2?%99s moves
>> +@item ability to control the program via a D-Bus interface
>> +@end itemize")
>> +    (license license:gpl2+)))
>> +
>>  (define-public kde-games
>>    (package
>>      (name "kde-games")
>>
>> base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718

Sughosha

Attachment: file

Z572 wrote on 3 Nov 2024 14:20

Recipients:(name . Sughosha via Guix-patches via)(address . guix-patches@gnu.org)

Message-ID:87zfmgihc4.fsf@iscas.ac.cn

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (3 lines)

> I think renaming the existing "knights" package (old one) with "knightsgame" would be fine. It's home page also says this name.

Can you send out v2 to make this change?

Sughosha wrote on 4 Nov 2024 03:56

[PATCH v2 0/3] gnu: Rename knights with knightsgame and add knights.

Recipients:(name . Z572)(address . zhengjunjie@iscas.ac.cn)

Message-ID:cover.1730689009.git.sughosha@disroot.org

This patch series rename the existing knights package with knightsgame and adds

knights.

Sughosha (3):

gnu: Rename knights with knightsgame.

gnu: Add knights.

gnu: kde-games: Add knights to propagated-inputs.

gnu/packages/games.scm | 4 +--

gnu/packages/kde-games.scm | 63 +++++++++++++++++++++++++++++++++++++-

2 files changed, 64 insertions(+), 3 deletions(-)

base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718

2.46.0

Sughosha wrote on 4 Nov 2024 03:56

[PATCH v2 1/3] gnu: Rename knights with knightsgame.

Recipients:(name . Z572)(address . zhengjunjie@iscas.ac.cn)

Message-ID:984dd0add9a6c4d7fe7ad4fc90c45f69974e2e75.1730689009.git.sughosha@disroot.org

Rename knights with knightsgame to package knights from KDE games module.

* gnu/packages/games.scm (knights): Rename with knightsgame.

Change-Id: I6eec8189fd29fe2ede67d98c26fdd9cafe4c2aef

---

gnu/packages/games.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (18 lines)diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index bb97332b6d..c503be2378 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1977,9 +1977,9 @@ (define-public opensurge
            license:public-domain
            license:silofl1.1))))
 
-(define-public knights
+(define-public knightsgame
   (package
-    (name "knights")
+    (name "knightsgame")
     (version "025")
     (source (origin
               (method url-fetch)
-- 
2.46.0

Sughosha wrote on 4 Nov 2024 03:56

[PATCH v2 3/3] gnu: kde-games: Add knights to propagated-inputs.

Recipients:(name . Z572)(address . zhengjunjie@iscas.ac.cn)

Message-ID:0a27d5d5c212c59605d616216300fb4cb32e6f14.1730689009.git.sughosha@disroot.org

* gnu/packages/kde-games.scm (kde-games)[propagated-inputs]: Add knights.

Change-Id: Id91a05d481774b94296d869bebf9bd7d8db1dccb

---

gnu/packages/kde-games.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (23 lines)diff --git a/gnu/packages/kde-games.scm b/gnu/packages/kde-games.scm
index 75c6038189..e9e25c9e88 100644
--- a/gnu/packages/kde-games.scm
+++ b/gnu/packages/kde-games.scm
@@ -1663,7 +1663,7 @@ (define-public kde-games
     (arguments
      (list #:builder #~(mkdir #$output)))
     (propagated-inputs
-     ;; TODO: kpat, klickety, katomic, knights.
+     ;; TODO: kpat, klickety, katomic.
      (list bomber
            bovo
            granatier
@@ -1685,6 +1685,7 @@ (define-public kde-games
            kmines
            knavalbattle
            knetwalk
+           knights
            kolf
            kollision
            konquest
-- 
2.46.0

Sughosha wrote on 4 Nov 2024 03:56

[PATCH v2 2/3] gnu: Add knights.

Recipients:(name . Z572)(address . zhengjunjie@iscas.ac.cn)

Message-ID:c421e45dba765b236cc4a8655748dde94e29b28d.1730689009.git.sughosha@disroot.org

* gnu/packages/kde-games.scm (knights): New variable.

Change-Id: Iad32bd00c2c42caba078e49b8e0b205be4a3fcc1

---

gnu/packages/kde-games.scm | 60 ++++++++++++++++++++++++++++++++++++++

1 file changed, 60 insertions(+)

Toggle diff (73 lines)diff --git a/gnu/packages/kde-games.scm b/gnu/packages/kde-games.scm
index 10c26e1d8e..75c6038189 100644
--- a/gnu/packages/kde-games.scm
+++ b/gnu/packages/kde-games.scm
@@ -1594,6 +1594,66 @@ (define-public kjumpingcube
 This package is part of the KDE games module.")
     (license (list license:gpl2+ license:fdl1.2+))))
 
+(define-public knights
+  (package
+    (name "knights")
+    (version "24.05.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://kde/stable/release-service/" version
+                           "/src/knights-" version ".tar.xz"))
+       (sha256
+        (base32 "19xsa79p0ad3cgm1zz2ykbm4487fyizshn7ir8f5azhkr1bi6l8k"))))
+    (build-system qt-build-system)
+    (arguments
+     (list #:qtbase qtbase))
+    (native-inputs
+     (list extra-cmake-modules kdoctools))
+    (inputs
+     (list kconfigwidgets
+           kcoreaddons
+           kcrash
+           kdbusaddons
+           ki18n
+           kio
+           kplotting
+           ksvg
+           ktextwidgets
+           kwallet
+           kxmlgui
+           libkdegames
+           libplasma
+           qtspeech
+           qtsvg))
+    (home-page "https://apps.kde.org/knights/")
+    (synopsis "Chess game")
+    (description "KNights is a chess game, featuring:
+
+@itemize
+@item local play between two players on the same computer
+@item play against any computer program that supports the XBoard protocol
+@item play on the Free Internet Chess Server (FICS)
+@item watching two computer engines play against each other
+@item support for legal move checking
+@item markers for possible moves, opponent’s last move and sources of check
+@item board borders and site notations
+@item complete time control, with Plasma-styled clocks
+@item several themes, with the possibility of downloading new ones from within
+ the program
+@item animated moves (configurable)
+@item views for playing on a chess server, including a seek graph, text
+ console, and chat widget
+@item option to undo and redo moves
+@item graphic interface for making and receiving offers from remote players
+@item support for the UCI protocol (used by Stockfish, Chessbase, and many
+ others)
+@item support for saving and loading Portable game notation (PGN) files
+@item use of Jovie, the KDE text-to-speak program, to speak opponent’s moves
+@item ability to control the program via a D-Bus interface
+@end itemize")
+    (license license:gpl2+)))
+
 (define-public kde-games
   (package
     (name "kde-games")
-- 
2.46.0

Zheng Junjie wrote on 6 Nov 2024 15:17

Re: [bug#74161] [PATCH v2 0/3] gnu: Rename knights with knightsgame and add knights.

Recipients:(name . Sughosha via Guix-patches via)(address . guix-patches@gnu.org)

Message-ID:87bjyszbts.fsf@iscas.ac.cn

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (15 lines)> This patch series rename the existing knights package with knightsgame and adds
> knights.
>
> Sughosha (3):
>   gnu: Rename knights with knightsgame.
>   gnu: Add knights.
>   gnu: kde-games: Add knights to propagated-inputs.
>
>  gnu/packages/games.scm     |  4 +--
>  gnu/packages/kde-games.scm | 63 +++++++++++++++++++++++++++++++++++++-
>  2 files changed, 64 insertions(+), 3 deletions(-)
>
>
> base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718

push, close.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 74161@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 74161

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date