[PATCH] gnu: tree-sitter: Update to 0.24.3.

  • Done
  • quality assurance status badge
Details
3 participants
  • Andreas Enge
  • Noé Lopez
  • Doğan Çeçen
Owner
unassigned
Submitted by
Doğan Çeçen
Severity
normal

Debbugs page

Doğan Çeçen wrote 4 months ago
(address . guix-patches@gnu.org)(name . Doğan Çeçen)(address . sepeth@fastmail.com)
cover.1730412151.git.sepeth@fastmail.com
This is needed to update neovim to a newer version.

Doğan Çeçen (1):
gnu: tree-sitter: Update to 0.24.3.

gnu/packages/tree-sitter.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718
prerequisite-patch-id: 92d7009719a2df665b401eb25ee08f8d276be4bb
prerequisite-patch-id: 20902e145fdee43b599da928d596390abaa69805
--
2.46.0
Noé Lopez wrote 4 months ago
(address . 74147@debbugs.gnu.org)
87plnebn0z.fsf@xn--no-cja.eu
Hi Doğan,

Thank you for your patch, here are a few suggestions:

Toggle quote (7 lines)
> (uri (git-reference
> (url "https://github.com/tree-sitter/tree-sitter")
>- (commit "0e4ff0bb27edf37b76fc7d35aa768b02cf4392ad")))
>+ (commit "v0.24.3")))
> (file-name (git-file-name name version))
> (sha256

You can use “string-append” to avoid repeating the version:
(commit (string-append "v" commit))

As a result of updating tree-sitter, the ”tree-sitter-cli” package has
stopped building for me, it is recommended that you check that
dependencies of tree-sitter don’t fail to build as a result of the
update, see “info (guix) Submitting Patches” step 9.

Can you send an updated patch?

Thanks for your work,
Noé Lopez

Disclaimer: I am not a guix committer, just a random person trying to help.
Noé Lopez wrote 4 months ago
(no subject)
(address . control@debbugs.gnu.org)
87cyjdg7mr.fsf@xn--no-cja.eu
merge 74148 74147
thanks
Andreas Enge wrote 3 months ago
Unmerge
(address . control@debbugs.gnu.org)
Z0cLmOiNAOTbNYEd@jurong
unmerge 74147
thanks
Andreas Enge wrote 3 months ago
Close
(address . 74147-done@debbugs.gnu.org)
Z0cMRtUX2DPGCFM_@jurong
Closing this bug, since 71748 contains the v2.

Thanks, Noￜ, for the review!

Andreas
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74147@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74147
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help