[PATCH 1/2] gnu: Improve emacs-popwin definition.

  • Open
  • quality assurance status badge
Details
2 participants
  • Nicolas Goaziou
  • Rostislav Svoboda
Owner
unassigned
Submitted by
Rostislav Svoboda
Severity
normal
R
R
Rostislav Svoboda wrote on 31 Oct 14:42 +0100
(address . guix-patches@gnu.org)(name . Rostislav Svoboda)(address . Rostislav.Svoboda@gmail.com)
2205123045e70a7cfb11d78405f48586e77df80e.1730382156.git.Rostislav.Svoboda@gmail.com
gnu/packages/emacs-xyz.scm (emacs-popwin): No need to switch off tests during
build and no native-inputs needed.

Change-Id: If0242b306a15ddb3a2598651a23519f56ca757d7
---
gnu/packages/emacs-xyz.scm | 44 +++++++++++++++++---------------------
1 file changed, 20 insertions(+), 24 deletions(-)

Toggle diff (335 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 488b4cb5d7..46fee0b7d6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15770,32 +15770,28 @@ (define-public emacs-find-file-in-project
(license license:gpl3+)))
(define-public emacs-popwin
- (package
- (name "emacs-popwin")
- (version "1.0.2")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/emacsorphanage/popwin")
- (commit version)))
- (file-name (git-file-name name version))
- (sha256
- (base32 "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
- (build-system emacs-build-system)
- (arguments
- (list
- #:tests? #f ; requires an attached terminal
- ))
- (native-inputs
- (list emacs-ert-runner))
- (home-page "https://github.com/emacsorphanage/popwin")
- (synopsis "Popup window manager for Emacs")
- (description
- "This package provides utilities for treating certain windows as @dfn{pop
+ (let ((commit "215d6cb509b11c63394a20666565cd9e9b2c2eab")
+ (revision "1"))
+ (package
+ (name "emacs-popwin")
+ (version (git-version "1.0.2" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacsorphanage/popwin")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/emacsorphanage/popwin")
+ (synopsis "Popup window manager for Emacs")
+ (description
+ "This package provides utilities for treating certain windows as @dfn{pop
up windows}, which close automatically when quitting a command or selecting
another window.")
- (license license:gpl3+)))
+ (license license:gpl3+))))
(define-public emacs-pyvenv
(package

base-commit: 6ea75bb9bcc52521f0bb3f121799745fdc17f1c9
prerequisite-patch-id: d25195b4e1177b65c112f12ce6a8c6fd677d430f
prerequisite-patch-id: 21c9b22cf88720a3866c89eff457a620d4f46a49
prerequisite-patch-id: 597a68483d6b4508fad8a4169c0501772c52f0ee
prerequisite-patch-id: 276433312238328ddcc97f19cbeeba6e867910da
prerequisite-patch-id: 8fdaabc01b62313e7f712839adfc7d904760af9b
prerequisite-patch-id: 0d5a7950362d4623c5496fd25e53b312e5097cbd
prerequisite-patch-id: be592100aaf9376b65933557ef9c6f59229fc7b7
prerequisite-patch-id: 19c3a74488dca2b33171d68e37514156193cf7f0
prerequisite-patch-id: 73d5f0016ba4258f5124ef5a9450b72c0e189890
prerequisite-patch-id: 02ec2a5f913dceed7e8be5862fba4a5a24f55e6e
prerequisite-patch-id: cbd06ca60a11bc8dbbe056e278caea1fd38c3932
prerequisite-patch-id: 40ef2785ff9d3af0b71b1d9ea5ab571b50dc32b0
prerequisite-patch-id: e1e9373db1e0bb4471ad109d2d91845344aef081
prerequisite-patch-id: 3321465efed19531278776e1a891918db7149b90
prerequisite-patch-id: afb7caef327efc72253e229c5ae8a29eae330d75
prerequisite-patch-id: 3f843145ec235609420081bf3d0f021ff4b7e416
prerequisite-patch-id: cbfe4a44a6244df4c020d359661c7136061b7762
prerequisite-patch-id: 6d0602e7fa34879329c2455a490718785e2d679a
prerequisite-patch-id: 7b741cff2798c899859e1753c1e84052334e0e1b
prerequisite-patch-id: ebac6a14e82dcbdcae893e636d138ddbabad2bd0
prerequisite-patch-id: 88ef4e6f60f4da630f5052dca85ae99c91f6b339
prerequisite-patch-id: f543a2c9ff19a545460c0db43ee89cfee7b44ca7
prerequisite-patch-id: d84f722e4cd118285d676d62b02a9b1c040c2aa5
prerequisite-patch-id: 089eb942f40700fc246a53e9a64ad5164a52d0f9
prerequisite-patch-id: 7c63bb6ebd610ca3562d0c8a72e7d2a6b7669528
prerequisite-patch-id: 70567c5ee0257426bb0705681c637593ad9cb064
prerequisite-patch-id: a801facc4c12041064e16416bd8a9d659f84e2d6
prerequisite-patch-id: 1ee4a4dfecd0490c87daa8ac7581aa77ffc079e4
prerequisite-patch-id: c16e7f0034056b0342e0a9f29abd5b882cbd5cf6
prerequisite-patch-id: 52be20d44ccd8d5913f82b7036a72d9dbe5ae758
prerequisite-patch-id: cf90ddb14f707f33fa810d6f0f95dc988355ac2e
prerequisite-patch-id: 647e65940238f5a44f6ad3335386b88731f0b6a6
prerequisite-patch-id: 1dd741cd0180b0ef07a2fa2eec17f2dccbd6c227
prerequisite-patch-id: 04f01b1bda33033c103870779df3f21b6661a19b
prerequisite-patch-id: fadfcf5469a22529e1fdf9841786aefc230a1fea
prerequisite-patch-id: faee615f71887a885a7b0c045e2dd9774bbfa4ea
prerequisite-patch-id: 32e7cbe3f6634d8e4ff0bc29f5292615dd04ee07
prerequisite-patch-id: b15bf320628b8459996857fb5f80ae4baab698ed
prerequisite-patch-id: 27e8c85adf182620f8b71d04bc7911f85d4561a2
prerequisite-patch-id: ed044763167bab61999f2d5758c873c5337ac353
prerequisite-patch-id: 902bfa63a4e0d1c9a8b837ee5c9c4c5ca7381b6e
prerequisite-patch-id: 433286031494682dd8ac3c3e3b8dcb4415d34c5c
prerequisite-patch-id: 38c9b7375e20b88ac6ae426160d7320b38d9ea01
prerequisite-patch-id: 4234229f6f49df071f5dde92bc6c23b44bf35c29
prerequisite-patch-id: 935fc55a8e245ad46c09f967656139fe71004668
prerequisite-patch-id: bdb56ce49c77a0b246c40304e743f10234ff8a24
prerequisite-patch-id: bb4e5e69f71129b2fa6b8f2aad6a7a1904fd5467
prerequisite-patch-id: 75acd53e40f3d66b7f8c5c7d58955f29a190202d
prerequisite-patch-id: 650eab1fd36209baeb920eb1c7dd5d617347bfe3
prerequisite-patch-id: e99124954ff7d485c938594d310e154f9d92c1b3
prerequisite-patch-id: 00e9fb9a93690249fec8d998ecd2d76cea0e2123
prerequisite-patch-id: 656444f35b1fb2a7f7a8b7167ac21f9341c15a39
prerequisite-patch-id: 087fdd1591997d0225ba99061a1adf6a999419aa
prerequisite-patch-id: 014bf2bf4474430079427107fdcd1c4268f0f5ea
prerequisite-patch-id: 197b762dee2c311bb54220c5407a183f4d0d4c54
prerequisite-patch-id: b59d3b3c9e127650eb3b567d2b550dac17716d1b
prerequisite-patch-id: 4ad951047bffe498a24044027f5d2a40dfcc9de6
prerequisite-patch-id: 4788586e708202ac13719c5ee36b10cfaa5eb37a
prerequisite-patch-id: 864df7e17a86116fab218d3de6c7ff36661344fe
prerequisite-patch-id: 493621dec54a00ecc157479992a40365cda15ada
prerequisite-patch-id: 2fe8806f1ef4ac43ba5481924bcbbca53b4f7122
prerequisite-patch-id: d264d531341e20a84ad7bc2372dbc602efb5f358
prerequisite-patch-id: 8ca0303fbc4036e18ae2216611469c0d606785a1
prerequisite-patch-id: c92428b5d7500926ef8202b418bba7582c71efd2
prerequisite-patch-id: 834c389f428eb5747c8a5691cde22701e9d64c89
prerequisite-patch-id: 4270147339d893d738ee9d09c582cd0b55016dec
prerequisite-patch-id: adac4f2a8bbe05d419384aba2dad791b5a6986d9
prerequisite-patch-id: aaff5ca11fdea6b3ebcfaf375014c60b6297f96c
prerequisite-patch-id: 2b001af0d496426eb2b128b72ce63016a7fd7d87
prerequisite-patch-id: 31e653786fa1669714e401de7a804bf2310736ea
prerequisite-patch-id: 8548f6a5480fa472852fb6809bd2c70af1c5f0de
prerequisite-patch-id: 6c3fbbeff25f643c8c441b36ef3fc758c8c5b084
prerequisite-patch-id: 52fe126179d3238a8be12808197da881619f5ec5
prerequisite-patch-id: 6a712e85b3b115f8e024d9fad70d7122cf1e89f2
prerequisite-patch-id: fb24a3ac8ded334654b135fa8f1fa1c2fb8321a5
prerequisite-patch-id: ee9a689c528b50e5f93b2221e4736913249f471a
prerequisite-patch-id: cff68383652c16b73893ecc603109d030449eea1
prerequisite-patch-id: 6bfc50b0d6b131a12b904c16823303596a0795f7
prerequisite-patch-id: ad5b1894a6ffe426911bf4232e98b59bf17456dc
prerequisite-patch-id: f921438e1d3a9e74b06118fb31dc2a474f284b2c
prerequisite-patch-id: 223075435a968a0f6fbeced33d8b5c4d0de6cbfb
prerequisite-patch-id: 2f04494f1cf9d3e15e5a9a8aa6b8d1f91cfeaa3b
prerequisite-patch-id: d60a1db7c1552c7c94364310e64e8bc74dc48bf9
prerequisite-patch-id: 080243871111a83817d0e1c982e91c9787e3f885
prerequisite-patch-id: b1fc6defb6733389038cc6fabd1efe98b14b7fb4
prerequisite-patch-id: ffd3f7137059999cd46aa6fc7242421129e1a846
prerequisite-patch-id: 9ee2fec33e40360e4dd80aa0a20279db605d671b
prerequisite-patch-id: 4830625efd958369eeb9986f0c9ed3ef5b0e1491
prerequisite-patch-id: 9b4842f46304b6d620589119383fb8d75ec90f39
prerequisite-patch-id: f71077d759d872af6065c842078231c3eb71fac4
prerequisite-patch-id: ffc232f3f3d79220008b3e7ee29c07462c98f76a
prerequisite-patch-id: 9d2cfdd3c2ed70238aeb03657a0a98bb8a85c60c
prerequisite-patch-id: 4773c18404dd82441636402df9544cfb78bbe697
prerequisite-patch-id: e9c1ae6a44d9249ddcd2ef0a7d33753130e88ff2
prerequisite-patch-id: 0dc9945eb97fffa8328791e39e0e2468a320281b
prerequisite-patch-id: c153d16863a4bb0e8a1d48f9d5f222c1fdb01680
prerequisite-patch-id: 4aef7fe2e51bc5fe736603a3ff43035678ad89e6
prerequisite-patch-id: 9337e317c9a237fb33298c24d9f19b7c855fddcd
prerequisite-patch-id: 38f7168b8c4763657c59388616e557264fdfae7f
prerequisite-patch-id: b7f4856fd95b93ec7035dc72fd8e2a59a2802aed
prerequisite-patch-id: baddcf56994bea0f252bdbe92676334306af7aeb
prerequisite-patch-id: 6b689daff2c114e0ba4a0fa43bf361850363b8c7
prerequisite-patch-id: 71abd53f3295fa8139bb63280364a3bb788daf7e
prerequisite-patch-id: ca74b8d4fc5b8141495722535a44f78cb2e81ccf
prerequisite-patch-id: ff7eddb035687769b9b17360e07a66e9a7934978
prerequisite-patch-id: ac0d6e69a3e63360527cb5b277bc5af1fa10da61
prerequisite-patch-id: fc7b3bc531e473694e61236f35a80418757cb3e2
prerequisite-patch-id: ba37e6d3e1572aa3fe6df2808f732a5176d4e080
prerequisite-patch-id: c7991c2f165e2e42e304af29ff27c1f5f32f3c11
prerequisite-patch-id: cfe263cf069fa59d9d5ef53ec57b3891c6ac8ed5
prerequisite-patch-id: 515adfc489341a72bace7f85e95b23d1aa7cfa6a
prerequisite-patch-id: 0fd1449d63563109e1efe2514cd82d4274d14387
prerequisite-patch-id: 5a62e8df1f674ea314ae6c7da67a8b2ad54fc386
prerequisite-patch-id: c9789ea8b04c4e7f4d5c307aef6e7c18efebe11c
prerequisite-patch-id: 5489dc7fae43ac5a2f12dd58185c577f7e9a20a1
prerequisite-patch-id: fa9e753d2681de640ababe5600cfa9b53ee3858f
prerequisite-patch-id: 7098083bea3591012ea722222e24e43f03a6110b
prerequisite-patch-id: 1915e17f71f70410fe729a8cecb0ddd26dab4daa
prerequisite-patch-id: 5d6860b7dd9934f193b3a01c7114cb9b48f06f80
prerequisite-patch-id: dcf3753df67b2ab20c6ac3de30546a61e71b54fb
prerequisite-patch-id: 9c2f3a193dd17c708d9562c4792908e6abb36829
prerequisite-patch-id: fa15864cfa3755121720d973df82fb816befa4d5
prerequisite-patch-id: e4b6ced9496c9d2f0ef699242dbafc306f83ad24
prerequisite-patch-id: 08b739a39ec1348f5f6677dac659d5c345dee0ff
prerequisite-patch-id: b3b881fe334d0c38833c8900e57ab64f2bbe9f78
prerequisite-patch-id: a98327e790788d1050e2a001434c4f4bff588823
prerequisite-patch-id: 43df9a6ea87619bde1e8f2231ef7f65504b1d2e4
prerequisite-patch-id: c5688fa2fbf9c0bd9b38fef13c396809beb85a8b
prerequisite-patch-id: 872146e1bfbdea7471f6b86d51db8508eb823cf6
prerequisite-patch-id: 8fcf721baad40cd72f9abbcc8b816910dd43547c
prerequisite-patch-id: 6ad1ebd4bc5429af9b3dd6e17a62a37bcfadc6e8
prerequisite-patch-id: d6ceb70f2f9ab29bde40322fdc88000ba914fb9f
prerequisite-patch-id: 7e62cdc2862a79c5cd23306ac649bb453271ffcd
prerequisite-patch-id: 672f4d0233dc4853ba0ca65260da8964fde0f796
prerequisite-patch-id: 62527d3f8d725a71a43e93f560007ba6da65ae72
prerequisite-patch-id: b7fa7f2d153e404286d2a080a5cd34dfc1bdeeb5
prerequisite-patch-id: 265e866fdc53539711ea7cff4a6d046b8bba1a2a
prerequisite-patch-id: aae8ff190143c1ebce074c879f7f98cfdc8d606c
prerequisite-patch-id: 5624a32dc64d7a65b3a8e236c89449389ba33ab9
prerequisite-patch-id: 79b33f082d99083f9fb40948c2c86f8708262330
prerequisite-patch-id: b9e6abf0282c670256590890fd6d2814322ef45f
prerequisite-patch-id: 085e01071e6e9e3ff371562519f4e999f845a50c
prerequisite-patch-id: 3c8920fe5e959620c81ed2c79491dff632cd0769
prerequisite-patch-id: 5e9a9f40673ef0df002065048e13ae8ca9c62f37
prerequisite-patch-id: f5e76a4fb38d76a48d1708a0dc2b39e0179f623d
prerequisite-patch-id: 4c1e8c700eec791ca6b0a61fa3a2af8c5fab154d
prerequisite-patch-id: b338c8cc81a8db74a77613f37109c643d9022b91
prerequisite-patch-id: b746d3e5dbf1884f3cfa102be3a6c7add75a727f
prerequisite-patch-id: e227f0a84f32969f0065564d7ba5f0d56cf6169f
prerequisite-patch-id: 26d3d86ab08a59358bd0ef5a06e30b5bc6fe7d0a
prerequisite-patch-id: 7cafcfa44f6a66fdddfc3337ed7f19bb99c706b7
prerequisite-patch-id: 71a3ff761ab9cd08c522ac285ed899b747aee0b8
prerequisite-patch-id: 57dddcbc16bc889782439ead8b9ecc820c5db48c
prerequisite-patch-id: 801365569ca84d7d8eb3fcac27b375714e234dc6
prerequisite-patch-id: a382575fd0c5bdc13984ef9c829f07c82277fa18
prerequisite-patch-id: ba1691b5ba8170e7430e8c69e2572e5420e88a7e
prerequisite-patch-id: 670d983956d542aa4af2fdb7847c48ea8ea4d639
prerequisite-patch-id: 516c9dafd0cc0b786ccde4ee5764bb7b0c9e804e
prerequisite-patch-id: 40994af87a72f9b4b85b1d1c131050b58726c8b6
prerequisite-patch-id: b79fd3a091c236d233d932365a9163405dd87fec
prerequisite-patch-id: 82177091daeda97800752f131fadb715650ef2c1
prerequisite-patch-id: 63db4d6bd6d750781de666256134ff784e2e7847
prerequisite-patch-id: 3c9c25a1a746f4f380f9065efed11b1b557d9795
prerequisite-patch-id: 34148f53ef605b5a9bb0f001b375e72d8a1711dc
prerequisite-patch-id: 299df20288084ad1304e1b9de7f24eb4e5aa712a
prerequisite-patch-id: dd42cfa6f62e6ffd5f525ceab1db9c72e2107abd
prerequisite-patch-id: 5505a24afbfa99d4ce2d4072ecb3b8a7788525f2
prerequisite-patch-id: 453943f5951ee3fb9411bb4d87c27c4565d856ba
prerequisite-patch-id: 1518cc6590a2be2c6989251d257fd0f299486a96
prerequisite-patch-id: 0373905f21f60d8aac61be9f813e6b3e93982241
prerequisite-patch-id: 45cfcfd330ab0ee1d84c3bfc91bd8273e07b1532
prerequisite-patch-id: 41cc06d537278baaf4eac9fcb330ad08b0a7d8d7
prerequisite-patch-id: 246a683ad6063f26d3164b70a25946d0ff195493
prerequisite-patch-id: 6c0f660eac5296ae90b823a4d474fb83e229350c
prerequisite-patch-id: 033bba8c5bd5605cedd7efe3e036d4d213ccb9cd
prerequisite-patch-id: 554991b5c023199e381a98f33497bac458bf2d54
prerequisite-patch-id: c5acba5ebae1cfc40d37d05681c4580fe8d0da0f
prerequisite-patch-id: adfb2929254f03549ed7e90817af5da519d15e5c
prerequisite-patch-id: 2938ec3d54c56f93986c48dd62ef19110086041e
prerequisite-patch-id: e16ca9b71559dfe0a7fcad0dae8fcc2f12db6ca5
prerequisite-patch-id: cdf92dc7b5626f686639f804ffef4c3c8cca7da5
prerequisite-patch-id: 902b4d0eaea5d224f9a6f74fab3fe5fbe7391a41
prerequisite-patch-id: 8cc252c67115c1e3c371063ed913af3c0cb9d86b
prerequisite-patch-id: 666eb27f012599a2c1022330d3f3ac29ef4d35c8
prerequisite-patch-id: c7c90d4cf2f4e8ba3ccb402237de5b466dea0e9f
prerequisite-patch-id: eb1ca693ef1b444b7167ff83ed7f2bc657997b42
prerequisite-patch-id: bf3600a9f05de1153d3e067730fe5cda65d1c313
prerequisite-patch-id: cdb81cd74771366cd87be8603128f779d23b7df1
prerequisite-patch-id: 914944c14201b729c14200242ee0c97ec0c148ef
prerequisite-patch-id: 1a9983afce81b7c6b8409ee49dc017fb20e4a207
prerequisite-patch-id: aa8ce596de0c607938fdad7301253bce93d19b4e
prerequisite-patch-id: 9ed12461b4f94fa602a8dff4369fbb8c55eee1bf
prerequisite-patch-id: 08c6255ca67b9f69b2c837e7058e31cc451dc57a
prerequisite-patch-id: 35f1b8f8e5ea1ab3532f2fd83bdf071849a35f4a
prerequisite-patch-id: b0ac07405c43a184d1983ae780ebd5414fa9e0e9
prerequisite-patch-id: ce1cb57b342129c6402803863db472c39806fd36
prerequisite-patch-id: a20fbbf3c79930b0c834c298569c8f9a34b4c9ee
prerequisite-patch-id: 91bb86d29a711166c4a78613bbd5151aace59937
prerequisite-patch-id: 999a7ecfcfe963278a99d18bcbd0840fc48cc015
prerequisite-patch-id: 9f92cea1632b6efc48dd9b78c48035e469c462ac
prerequisite-patch-id: 68735c6bfafe7618c7b04c15906a76268078d3a4
prerequisite-patch-id: 5de5b98f72f067b59463bb5b513902c1bdd016dd
prerequisite-patch-id: b1316aadd920dba74ec21395d90e3bf608e2ab39
prerequisite-patch-id: cebc6a69e824393686c1bb669ba66b47888f4854
prerequisite-patch-id: f7a19c1e03613c709f4334fffa8db06d512dac2f
prerequisite-patch-id: e8b14dd33ab4fc1c0e2e1032c96c48895b0136be
prerequisite-patch-id: efe086ceb5c89139058a43969a7e4d23a227e290
prerequisite-patch-id: c83dac00227c473d12d777e30b3ee08c87210a6d
prerequisite-patch-id: 2ae6a595c88f9825f5e1a56a6f3d996eaaa7cc60
prerequisite-patch-id: ed8990ba5e3e65bed89650827a4036ed394e44a3
prerequisite-patch-id: 16228096f32c8ea63343b577d59596d04a9cb37f
prerequisite-patch-id: a330f8ea62bab8907311fe4b3f28b79e1378567b
prerequisite-patch-id: 813909996c1e881552c4c984017ed44097fdba3f
prerequisite-patch-id: d1c4bd00a7be41d5e301019b7d96e3f9f793bda6
prerequisite-patch-id: 0b2b333d40d62ff02a0c0f02c2c933942925c53f
prerequisite-patch-id: 8e904e54a5047a8e67e83d0a90b3484630545bc8
prerequisite-patch-id: 8c0930082ecb060b3edd7fd52d08c3c051ffa147
prerequisite-patch-id: 647ff7a8b4dc910fc28a6e7171f9e05110606fe9
prerequisite-patch-id: de07804ce7d3fc846b7a2b9f0c97a9afdf3184ed
prerequisite-patch-id: ddd400d0006070185392ce3e91b3e6013f82e0a7
prerequisite-patch-id: ac3d661e922064a91546e4de8fd81b3cd9088491
prerequisite-patch-id: 82450c8c1d907a7b08720078e943948ea8746b35
prerequisite-patch-id: b477783beed57a079431d03e861c43b8ad0b6a6b
prerequisite-patch-id: 25c4eb8ea1fdb7314ebcba3091b6d36d15a3ce99
prerequisite-patch-id: cda589295e28c411d8f277d18c83c9eb9b5ee304
prerequisite-patch-id: f8eb489918fac5a318b4cf55599dda5af80b5106
prerequisite-patch-id: 7b3fa52d4f66630ff1595a349fe111dd08497298
prerequisite-patch-id: 9b8f03cfdad000631155145923241cb2cc9dc680
prerequisite-patch-id: 5abf83c643609c7f68bcf143c611facbbc3b487a
prerequisite-patch-id: 278c0c2b5d275306727b573cac2ebd8e2c488fe3
prerequisite-patch-id: 6f1a94f5834abbd79b37b307a329287eb2ac7878
prerequisite-patch-id: c730f18457d7250093493407a3734e1ff31f7856
prerequisite-patch-id: c6145b8fa7db83f563e9e22e58ab9a3d2baffae2
prerequisite-patch-id: d173ceaaaf85c52622597e6bed0bd40164f1a168
prerequisite-patch-id: fd98e9e593c16674576c0062a115c54586cfb961
prerequisite-patch-id: 8ff974515776deaf576acf73c22ef34fec60b6cc
prerequisite-patch-id: e0aaa58dfcf299b29c8e1b10487d3f990a086acc
prerequisite-patch-id: 201aacbddebb9d5bbdc34c61f7a74934e7faf92a
prerequisite-patch-id: d22a3f1c07f4fdcafbda33f8f31fafc79962ac4e
prerequisite-patch-id: 27f171efbd646d20583b66a5baa935ceba94fd53
prerequisite-patch-id: afaa76ff19d7ae80d4f5e9ae7c09ad0b86384945
prerequisite-patch-id: 3030ba96ddd28f90dcfd144a0173754a8b20b7f0
prerequisite-patch-id: d26f393b04326aef46c64ca720fadb9b02639c66
prerequisite-patch-id: ab30e2fc869d902e0dc5c53b073da36a6ea05d6e
prerequisite-patch-id: 37a1107a723304111cac005269b69529b0d804c8
prerequisite-patch-id: 732359f1d3b209cdf35f1944d5722536ff3170c3
prerequisite-patch-id: b983326e8cb920db636205d19f7ac7c202de7d44
prerequisite-patch-id: 4fbef4a33642d43bf7352b7b85785315e422b47b
prerequisite-patch-id: 63134e2f16a0622f9f8daeaea4690f7ebf479376
prerequisite-patch-id: a37fe956987a1f899f786157af26051387d55ddf
prerequisite-patch-id: d09212c97281b2da4657dfd801169d564d045751
prerequisite-patch-id: 62c3dfdbc693f03def7b037fe9f05323da1115ed
prerequisite-patch-id: 33468b59bcf95ea0c1c8df5c15dc4afa45b2c514
prerequisite-patch-id: 11021919c3356a7581505943b654959b49fb28f6
prerequisite-patch-id: 0e74de7d573d7ff0bcf6c0082bd0c07dd847ed8b
prerequisite-patch-id: 4c19da117c8b878dbd6625f6a25b27ac02ebe5c8
prerequisite-patch-id: 48dbed89caa7fd3f006fc4501c7fc5c5469e50df
prerequisite-patch-id: 63134e2f16a0622f9f8daeaea4690f7ebf479376
prerequisite-patch-id: 3190abdce2555d46688f1a92a3023c142fbb8e8e
prerequisite-patch-id: e7c33740c5bb45b71bfbcd2d0d1e68dfad4916c0
prerequisite-patch-id: 2a319d1a4410e81b899e94983546eacece14394d
prerequisite-patch-id: a884acdc24a9169d7334b380adcc91081abbf7a0
prerequisite-patch-id: ecf705fc92c174566f728932c3b0da910d39f764
prerequisite-patch-id: 59f387fc39960741df8ae4cebaa7b6df45269f99
prerequisite-patch-id: 1c7738efa08bed6a3cda7befd22457f1d710e76e
prerequisite-patch-id: 54e2286584aedafe81702559bfb20a22357f7e98
prerequisite-patch-id: a3272af6c9c78d115a245b219276bf7ea48ffc04
prerequisite-patch-id: 2fc630edc0d256bdb546be3f3493a77a5acbc2c7
prerequisite-patch-id: d474960e891f17bea4b39555a3557bc67085eeb8
prerequisite-patch-id: a0a6b5aeb5135a2ee9a3e3e4bd9c7f5c5388b6d4
prerequisite-patch-id: ea85bd6bd9e741a4e5fd3ce969d09468608d8e10
prerequisite-patch-id: f94cfa34d2c19c94285cf04fd9edea5af011b69c
prerequisite-patch-id: d1ef91608ad8e338d8f02bfeb530fd3303375623
prerequisite-patch-id: 006b319edaac1eb9b2755104321f6a63af2eb76d
prerequisite-patch-id: bdb4ae23860656533e1b824d14e65ea2b4540903
pr
This message was truncated. Download the full message here.
N
N
Nicolas Goaziou wrote on 1 Nov 15:28 +0100
(name . Rostislav Svoboda)(address . rostislav.svoboda@gmail.com)
87o72zkozl.fsf@nicolasgoaziou.fr
Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

Toggle quote (3 lines)
> gnu/packages/emacs-xyz.scm (emacs-popwin): No need to switch off tests during
> build and no native-inputs needed.

Thank you.

I disagree with the removal of "#:tests? #f". It is more meaningful than
simply omitting the keyword. It tells us that the package has tests, but
they are difficult or even impossible to run. Without the keyword, it
could as well mean: "I didn't bother to check if there are tests".
I have no opinion about the removal of native inputs.

I also think the change to version should go in the second patch.

Regards,
--
Nicolas Goaziou
R
R
Rostislav Svoboda wrote on 1 Nov 18:54 +0100
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
CAEtmmezbyKpHW4yTUu312Au5SXPhBE9yANErws8z-BxE06ni5g@mail.gmail.com
Hello Nicolas,

Toggle quote (5 lines)
> I disagree with the removal of "#:tests? #f". It is more meaningful than
> simply omitting the keyword. It tells us that the package has tests, but
> they are difficult or even impossible to run. Without the keyword, it
> could as well mean: "I didn't bother to check if there are tests".

Which is, in fact, the default behavior of the #:tests parameter. By
default, we do not run any tests, so why bother verifying their
existence when they’re unnecessary by default?

Toggle quote (2 lines)
> I have no opinion about the removal of native inputs.

Including emacs-ert-runner - a package designed for "Emacs projects
tested using ERT" - among native inputs is pointless if no tests are
executed.

Toggle quote (2 lines)
> I also think the change to version should go in the second patch.

In the first patch, I intended to fix the Guix package definition
without updating the package itself. That's why I incremented the
revision number from its default (presumably 0) to 1. The v1.0.2 tag
corresponds to commit 215d6cb509b11c63394a20666565cd9e9b2c2eab.

In the second patch, I then proceeded with updating the Emacs package.

Cheers,
Bost
R
R
Rostislav Svoboda wrote on 1 Nov 18:58 +0100
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
CAEtmmeyiKX+iKc0GjwXgQOdKSbjV1Yxuzz+LqamK4zGgnQyZGA@mail.gmail.com
Toggle quote (2 lines)
> The tests are unnecessary by default

Which I find to be a very bad policy, BTW.

Cheers,
Bost
N
N
Nicolas Goaziou wrote on 1 Nov 19:19 +0100
(name . Rostislav Svoboda)(address . rostislav.svoboda@gmail.com)
874j4qlsul.fsf@nicolasgoaziou.fr
Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

Toggle quote (9 lines)
>> I disagree with the removal of "#:tests? #f". It is more meaningful than
>> simply omitting the keyword. It tells us that the package has tests, but
>> they are difficult or even impossible to run. Without the keyword, it
>> could as well mean: "I didn't bother to check if there are tests".
>
> Which is, in fact, the default behavior of the #:tests parameter. By
> default, we do not run any tests, so why bother verifying their
> existence when they’re unnecessary by default?

By default, the `emacs' build system does not run any test, but many
packages run them nevertheless. Some people, including me, try to run
tests from Emacs packages whenever it is possible. As pointed out, in
this situation, "#:tests? #f" with a reason brings some valuable
information. I simply suggest to keep that line.

Toggle quote (6 lines)
>> I have no opinion about the removal of native inputs.
>
> Including emacs-ert-runner - a package designed for "Emacs projects
> tested using ERT" - among native inputs is pointless if no tests are
> executed.

OTOH, it might help anyone trying to make the tests run someday (not all
tests require emacs-ert-runner). But in this package, this may not be
possible ultimately, hence "I have no opinion".

Toggle quote (7 lines)
>> I also think the change to version should go in the second patch.
>
> In the first patch, I intended to fix the Guix package definition
> without updating the package itself. That's why I incremented the
> revision number from its default (presumably 0) to 1. The v1.0.2 tag
> corresponds to commit 215d6cb509b11c63394a20666565cd9e9b2c2eab.

There is nothing to "fix". The first version correctly uses the tag
instead of the commit hash. Of course, you can update it in the second
patch. The first version change is unnecessary, please keep the second
one only.

Regards,
R
R
Rostislav Svoboda wrote on 1 Nov 20:40 +0100
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
CAEtmmexvP5c_Uj5++h4OOyar6iT=FS0KbwH+_yUCUHXYJy3f6w@mail.gmail.com
Hello Nicolas,

Toggle quote (10 lines)
> (arguments
> (list
> #:tests? #f ; requires an attached terminal
> ))
> (native-inputs
> (list emacs-ert-runner))
>
> "#:tests? #f" with a reason brings some valuable information. I simply suggest
> to keep that line.

If the default for #:tests? ever flips to #t, an explicit #:tests? #f
if overlooked, would prevent tests from running, even though everyone
might assume they are.

Until such a flip occurs, this snippet simply adds to the list of
native inputs without serving any real purpose, leading to unnecessary
use of electricity and computational resources. If the original author
intended to leave a note for future readers, a comment would be a more
suitable approach.

I'm sending you *two* patches: the first removes this redundancy, and
the second updates the emacs-popwin package.

Cheers,
Bost
From b6aab8d4f274e8b3535b2af5915eadd6371cd137 Mon Sep 17 00:00:00 2001
Message-ID: <b6aab8d4f274e8b3535b2af5915eadd6371cd137.1730488859.git.Rostislav.Svoboda@gmail.com>
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Thu, 31 Oct 2024 14:11:04 +0100
Subject: [PATCH 1/2] gnu: Strip unnecessary clutter from emacs-popwin.

* gnu/packages/emacs-xyz.scm (emacs-popwin): Remove redundant '#:tests? #f'
and unnecessary `emacs-ert-runner` from native inputs.

Change-Id: I684edc52c83221e8fe407d7c1fbc107cb4721da7
---
gnu/packages/emacs-xyz.scm | 46 ++++++++++++++++++--------------------
1 file changed, 22 insertions(+), 24 deletions(-)

Toggle diff (63 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 488b4cb5d7..3f72c1fd18 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15770,32 +15770,30 @@ (define-public emacs-find-file-in-project
(license license:gpl3+)))
(define-public emacs-popwin
- (package
- (name "emacs-popwin")
- (version "1.0.2")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/emacsorphanage/popwin")
- (commit version)))
- (file-name (git-file-name name version))
- (sha256
- (base32 "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
- (build-system emacs-build-system)
- (arguments
- (list
- #:tests? #f ; requires an attached terminal
- ))
- (native-inputs
- (list emacs-ert-runner))
- (home-page "https://github.com/emacsorphanage/popwin")
- (synopsis "Popup window manager for Emacs")
- (description
- "This package provides utilities for treating certain windows as @dfn{pop
+ (let ((commit "215d6cb509b11c63394a20666565cd9e9b2c2eab")
+ (revision "1"))
+ (package
+ (name "emacs-popwin")
+ (version (git-version "1.0.2" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacsorphanage/popwin")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
+ (build-system emacs-build-system)
+ ;; Testing this package requires an attached terminal and possibly
+ ;; emacs-ert-runner among its native inputs.
+ (home-page "https://github.com/emacsorphanage/popwin")
+ (synopsis "Popup window manager for Emacs")
+ (description
+ "This package provides utilities for treating certain windows as @dfn{pop
up windows}, which close automatically when quitting a command or selecting
another window.")
- (license license:gpl3+)))
+ (license license:gpl3+))))
(define-public emacs-pyvenv
(package

base-commit: cd9ac7d96b3634a7e1ec8da988dd3ac2dd186018
--
2.46.0
From 2c4cd774261f88f806e7b05faaf8621ca4a9afba Mon Sep 17 00:00:00 2001
Message-ID: <2c4cd774261f88f806e7b05faaf8621ca4a9afba.1730488859.git.Rostislav.Svoboda@gmail.com>
In-Reply-To: <b6aab8d4f274e8b3535b2af5915eadd6371cd137.1730488859.git.Rostislav.Svoboda@gmail.com>
References: <b6aab8d4f274e8b3535b2af5915eadd6371cd137.1730488859.git.Rostislav.Svoboda@gmail.com>
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Thu, 31 Oct 2024 14:35:39 +0100
Subject: [PATCH 2/2] gnu: Update emacs-popwin to 1.0.2.-2.58adcd0.

* gnu/packages/emacs-xyz.scm (emacs-popwin): Update to 1.0.2.-2.58adcd0.

Change-Id: Ie7ee892b737310a002a6e74bd5138b041eaf30bd
---
gnu/packages/emacs-xyz.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3f72c1fd18..003ede63bd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15770,8 +15770,8 @@ (define-public emacs-find-file-in-project
(license license:gpl3+)))
(define-public emacs-popwin
- (let ((commit "215d6cb509b11c63394a20666565cd9e9b2c2eab")
- (revision "1"))
+ (let ((commit "58adcd0ca7c3dbd58626ec7019252d64cbc73042")
+ (revision "2"))
(package
(name "emacs-popwin")
(version (git-version "1.0.2" revision commit))
@@ -15783,7 +15783,7 @@ (define-public emacs-popwin
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1x1iimzbwb5izbia6aj6xv49jybzln2qxm5ybcrcq7xync5swiv1"))))
+ (base32 "1mqwzc6fwhwq1kl8b3i1hm2ylfh8blrxrw6mzr5wyifbwpg7dq10"))))
(build-system emacs-build-system)
;; Testing this package requires an attached terminal and possibly
;; emacs-ert-runner among its native inputs.
--
2.46.0
N
N
Nicolas Goaziou wrote on 1 Nov 23:33 +0100
(name . Rostislav Svoboda)(address . rostislav.svoboda@gmail.com)
87v7x6k2i6.fsf@nicolasgoaziou.fr
Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

Toggle quote (14 lines)
>> (arguments
>> (list
>> #:tests? #f ; requires an attached terminal
>> ))
>> (native-inputs
>> (list emacs-ert-runner))
>>
>> "#:tests? #f" with a reason brings some valuable information. I simply suggest
>> to keep that line.
>
> If the default for #:tests? ever flips to #t, an explicit #:tests? #f
> if overlooked, would prevent tests from running, even though everyone
> might assume they are.

I disagree. When that Great Flip happens, explicit "#:tests? #f" will
prevent this package to fail because Guix cannot run its tests properly.

Toggle quote (6 lines)
> Until such a flip occurs, this snippet simply adds to the list of
> native inputs without serving any real purpose, leading to unnecessary
> use of electricity and computational resources. If the original author
> intended to leave a note for future readers, a comment would be a more
> suitable approach.

Again, I have nothing against removing the native inputs in this package
definition. And I'm all for saving electricity and other resources.

Toggle quote (3 lines)
> I'm sending you *two* patches: the first removes this redundancy, and
> the second updates the emacs-popwin package.

Since neither of them applies any of my suggestions, I'll consider that
we failed to reach any consensus. Having nothing more to suggest, I'll
let other reviewers chime in.

Regards,
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 74135@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74135
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch