[PATCH] gnu: Add r-shinyvalidate.

  • Done
  • quality assurance status badge
Details
2 participants
  • Ricardo Wurmus
  • King, Spencer
Owner
unassigned
Submitted by
King, Spencer
Severity
normal

Debbugs page

King, Spencer wrote 4 months ago
(name . King, Spencer via Guix-patches via)(address . guix-patches@gnu.org)
CH3PR02MB97469A1816DB9BBBD60CFC3290542@CH3PR02MB9746.namprd02.prod.outlook.com

Attachment: 0001-gnu-Add-r-shinyvalidate.patch (.00 MiB)
King, Spencer wrote 2 months ago
(name . 74124@debbugs.gnu.org)(address . 74124@debbugs.gnu.org)(name . rekado@elephly.net)(address . rekado@elephly.net)(name . laurent.gatto@gmail.com)(address . laurent.gatto@gmail.com)(name . zimon.toutoune@gmail.com)(address . zimon.toutoune@gmail.com)
CH3PR02MB9746785B12FB191671588AAD90152@CH3PR02MB9746.namprd02.prod.outlook.com
Pinging the R team since this patch has been unreviewed for a couple months. This is my first time pinging a specific team so please let me know if this is inappropriate or if there is something else I should do in the future.

Best,
Spencer
Ricardo Wurmus wrote 2 months ago
(address . 74124-done@debbugs.gnu.org)(name . King, Spencer)(address . spencer.king@wustl.edu)(name . laurent.gatto@gmail.com)(address . laurent.gatto@gmail.com)(name . zimon.toutoune@gmail.com)(address . zimon.toutoune@gmail.com)
87o70n69o4.fsf@elephly.net
Hi Spencer,

Toggle quote (5 lines)
> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay. I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do. It is also recommended to Cc the team when submitting the
patch. (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

--
Ricardo
Closed
King, Spencer wrote 2 months ago
(name . Ricardo Wurmus)(address . rekado@elephly.net)(name . 74124-done@debbugs.gnu.org)(address . 74124-done@debbugs.gnu.org)(name . laurent.gatto@gmail.com)(address . laurent.gatto@gmail.com)(name . zimon.toutoune@gmail.com)(address . zimon.toutoune@gmail.com)
CH3PR02MB974602EDECD4A2135FC9D79390152@CH3PR02MB9746.namprd02.prod.outlook.com
Hi Ricardo,

Thank you for the quick response. Is r-testthat now necessary across the board for all R packages? I do have a couple of other outstanding R patches that I can update if needed and ping the team.

Best,
Spencer
________________________________
From: Ricardo Wurmus <rekado@elephly.net>
Sent: Friday, January 3, 2025 12:20 PM
To: 74124-done@debbugs.gnu.org <74124-done@debbugs.gnu.org>
Cc: King, Spencer <spencer.king@wustl.edu>; laurent.gatto@gmail.com <laurent.gatto@gmail.com>; zimon.toutoune@gmail.com <zimon.toutoune@gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.

Hi Spencer,

Toggle quote (5 lines)
> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay. I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do. It is also recommended to Cc the team when submitting the
patch. (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

--
Ricardo
Attachment: file
Closed
Ricardo Wurmus wrote 2 months ago
(name . King, Spencer)(address . spencer.king@wustl.edu)(name . 74124-done@debbugs.gnu.org)(address . 74124-done@debbugs.gnu.org)(name . laurent.gatto@gmail.com)(address . laurent.gatto@gmail.com)(name . zimon.toutoune@gmail.com)(address . zimon.toutoune@gmail.com)
87ikqv658s.fsf@elephly.net
"King, Spencer" <spencer.king@wustl.edu> writes:

Toggle quote (2 lines)
> Is r-testthat now necessary across the board for all R packages?

That depends on the package. Some use r-runit, others r-testit, some
use a combination of these packages, some use none at all.

Prior to my changes the build system would ignore test failures. Most
test suites simply weren't run at all due to missing inputs.

--
Ricardo
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74124@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74124
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help