[PATCH 0/2] Remove outdated faust-0.9.67 package.

  • Done
  • quality assurance status badge
Details
2 participants
  • Nicolas Graves
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Nicolas Graves
Severity
normal

Debbugs page

Nicolas Graves wrote 4 months ago
(address . guix-patches@gnu.org)(name . Nicolas Graves)(address . ngraves@ngraves.fr)
20241026223406.27194-1-ngraves@ngraves.fr
Nicolas Graves (2):
gnu: sorcer: Update to 1.1.3-2.94107b2.
gnu: Remove faust-0.9.67.

gnu/packages/audio.scm | 34 ----------------------------------
gnu/packages/music.scm | 14 +++++---------
2 files changed, 5 insertions(+), 43 deletions(-)

--
2.46.0
Nicolas Graves wrote 4 months ago
[PATCH 1/2] gnu: sorcer: Update to 1.1.3-2.94107b2.
(address . 74036@debbugs.gnu.org)(name . Nicolas Graves)(address . ngraves@ngraves.fr)
20241026224535.32181-1-ngraves@ngraves.fr
* gnu/packages/music.scm (sorcer): Update to 1.1.3-2.94107b2.
[arguments]<#:phases>: Remove 'remove-architecture-specific-flags
phase. Adapt 'build-faust-sources to faust-2.
[native-inputs]: Replace faust-0.9.67 by faust-2. Add which.
---
gnu/packages/music.scm | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)

Toggle diff (50 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 548836abeb..92283d0218 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5837,11 +5837,11 @@ (define-public fabla
(license license:gpl2+)))
(define-public sorcer
- (let ((revision "1")
+ (let ((revision "2")
;; The last release was in 2016. Since then a couple of commits have
;; been added to fix build problems, so we take this arbitrary recent
;; commit.
- (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
+ (commit "94107b26e3e00e32504c8fb3fbf7572514d3b6bc"))
(package
(name "sorcer")
(version (git-version "1.1.3" revision commit))
@@ -5853,7 +5853,7 @@ (define-public sorcer
(file-name (git-file-name name version))
(sha256
(base32
- "0ryaglp2pzln2bm0pwc5p9lb2nk0x4wmrs4c4cp6d2m2hhk82yk7"))
+ "0md3d9h63ngrlh53mj1fmwhmnlxr7bqzpfb3wk9427v5n0y6yn48"))
(snippet
'(delete-file "faust/main.cpp"))))
(build-system cmake-build-system)
@@ -5861,18 +5861,14 @@ (define-public sorcer
`(#:tests? #f ;no tests included
#:phases
(modify-phases %standard-phases
- (add-after 'unpack 'remove-architecture-specific-flags
- (lambda _
- (substitute* "CMakeLists.txt"
- (("-msse2 -mfpmath=sse") ""))))
(add-after 'unpack 'build-faust-sources
(lambda* (#:key inputs #:allow-other-keys)
(with-directory-excursion "faust"
(invoke "faust" "-i"
- "-a" "lv2synth.cpp"
+ "-a" "lv2.cpp"
"-o" "main.cpp" "main.dsp")))))))
(inputs (list boost lv2 ntk))
- (native-inputs (list faust-0.9.67 pkg-config))
+ (native-inputs (list faust-2 pkg-config which))
(home-page "http://openavproductions.com/sorcer/")
(synopsis "Wavetable LV2 plugin synth")
(description "Sorcer is a wavetable LV2 plugin synthesizer, targeted at
--
2.46.0
Nicolas Graves wrote 4 months ago
[PATCH 2/2] gnu: Remove faust-0.9.67.
(address . 74036@debbugs.gnu.org)(name . Nicolas Graves)(address . ngraves@ngraves.fr)
20241026224535.32181-2-ngraves@ngraves.fr
* gnu/packages/audio.scm (faust-0.9.67): Delete variable.
---
gnu/packages/audio.scm | 34 ----------------------------------
1 file changed, 34 deletions(-)

Toggle diff (47 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 1ab0cbdd05..1bb7c1c314 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2231,40 +2231,6 @@ (define-public faust
"Faust is a programming language for realtime audio signal processing.")
(license license:gpl2+)))
-;; This version is needed to build older synths that require the lv2synth.cpp
-;; architecture file, such as sorcer.
-(define-public faust-0.9.67
- (package
- (inherit faust)
- (name "faust")
- (version "0.9.67")
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/grame-cncm/faust")
- (commit (string-append "v"
- (string-map (lambda (c)
- (if (char=? c #\.) #\- c))
- version)))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "0856x666s6ymzk8v15f9gy402dbr8c9v2s40hyfadhraqljmqrm0"))
- (snippet
- ;; Remove prebuilt library
- '(delete-file "architecture/android/libs/armeabi-v7a/libfaust_dsp.so"))))
- (build-system gnu-build-system)
- (arguments
- (list
- #:make-flags
- #~(list (string-append "prefix=" #$output))
- #:tests? #f
- #:phases
- '(modify-phases %standard-phases
- ;; no "configure" script
- (delete 'configure))))
- (native-inputs (list unzip))))
-
(define-public faust-2
(package
(inherit faust)
--
2.46.0
Sharlatan Hellseher wrote 4 months ago
[PATCH 0/2] Remove outdated faust-0.9.67 package.
(address . 74036-done@debbugs.gnu.org)
87ses8ts6o.fsf@gmail.com
Hi,

Thanks for the patches.

I've applied, build and lint it locally on x86_64 machine all passed
just well!

Pushed a0cb16ddd7..8964dfdb84 to master.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmcnbQ8ACgkQdtcnv/Ys
0rUv+A/+Ju/NHXMlxZV4T+a7NhjIoalbZy6p203Pl6a+FQTRRWh4ViNEA+//zlHk
BAWj2LPXoltUCvkW+AMBpIeL3XeQZWgmkSACR4TVpQCz0m4YGBaRpyHZYVCu9Wkz
VOZtox+FkN2mFIslw/M6KOtq+r/MDUtcletn2LkeYvgw8oGc2NL5Y5rc1urd7k9A
i3/FMqDRRFqifFAimULNJZWpliRbjLuI7uK7t7jq1mOmiPXmiCIZTS4n5Ik5P9Of
QEZuaFRt2uvqw2W2D1QP+Y5l1kNVX924SkZNUHhqAE3L/Vryjx0TZcZ9dECl84n8
sq9a9KKNh2WUA3Nxixt7y5EQwN+bFSJ9N8FbUYKiF1guHiDAMAinl2+hZWxUuiaF
5dA5ASGiEliSaT8ph3uz08GvZ+bvz9vsn2aiM4WzEXqioCMuNnulsOd8nu1nJLzt
023OwV468PCd3ueCRNIR8GmUhTsCEO1zgxojj/A84nnQzeaJDGIPuF02kYubqwga
R8SOAI4CLlcf52BN/p/LvQnR2Dkpdzs+SYbn1c2wSKbxB2fD+NU84UG771u65Tkf
mM+nGGSmir4yzK2ej0mOV4gCIwXy2o5B+p00NPrRNjmYaRfd0TFade1maY1IrF2x
NK9QjHL0BWCnU1nh0GZvHStFtQSK6HYIfp7BOrnkh9bjh73VXzs=
=fTX3
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 74036@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 74036
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help