[PATCH]: Update Nyxt to 3.12.0

  • Open
  • quality assurance status badge
Details
2 participants
  • André A. Gomes
  • Guillaume Le Vaillant
Owner
unassigned
Submitted by
André A. Gomes
Severity
normal
Merged with
A
A
André A. Gomes wrote on 21 Oct 21:16 +0200
(address . guix-patches@gnu.org)
87a5ex2rnp.fsf@gmail.com
Hello Guix,

Attached, thanks.

Please note that I am one of the Nyxt developers. The changes reflect
that fact that the Lisp dependencies are pinned as git submodules. The
tests are temporarily disabled since they fail due to undocumented
exported symbols (which is unreasonable). I only noticed it after the
release, but I'll fix it for the next release.


--
André A. Gomes
"You cannot even find the ruins..."
A
A
André A. Gomes wrote on 22 Oct 12:00 +0200
control message for bug #72412
(address . control@debbugs.gnu.org)
87v7xk8nkt.fsf@gmail.com
merge 72412 73937
quit
G
G
Guillaume Le Vaillant wrote on 23 Oct 14:02 +0200
Re: [bug#73937] [PATCH]: Update Nyxt to 3.12.0
(name . André A. Gomes)(address . andremegafone@gmail.com)(address . 73937@debbugs.gnu.org)
87ttd3t4b0.fsf@kitej
André A. Gomes <andremegafone@gmail.com> skribis:

Toggle quote (10 lines)
> Hello Guix,
>
> Attached, thanks.
>
> Please note that I am one of the Nyxt developers. The changes reflect
> that fact that the Lisp dependencies are pinned as git submodules. The
> tests are temporarily disabled since they fail due to undocumented
> exported symbols (which is unreasonable). I only noticed it after the
> release, but I'll fix it for the next release.

Hi.
We usually try to avoid taking libraries from git submodules unless the
software can't be made to compile with system libraries.
Can't Nyxt 3.12.0 work with the libraries packaged in Guix?
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZxjl8w8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/MlgD/fZ3xuyOZEQfk7daimdq+dmqdttKQBIYme8Wo
YDTnJcMA/iEvJDomXqyVOYoZL93bBGff7gqNmtR5W573vN663b9O
=M49t
-----END PGP SIGNATURE-----

A
A
André A. Gomes wrote on 23 Oct 14:33 +0200
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 73937@debbugs.gnu.org)
87msiv80e7.fsf@gmail.com
Guillaume Le Vaillant <glv@posteo.net> writes:

Toggle quote (17 lines)
> André A. Gomes <andremegafone@gmail.com> skribis:
>
>> Hello Guix,
>>
>> Attached, thanks.
>>
>> Please note that I am one of the Nyxt developers. The changes reflect
>> that fact that the Lisp dependencies are pinned as git submodules. The
>> tests are temporarily disabled since they fail due to undocumented
>> exported symbols (which is unreasonable). I only noticed it after the
>> release, but I'll fix it for the next release.
>
> Hi.
> We usually try to avoid taking libraries from git submodules unless the
> software can't be made to compile with system libraries.
> Can't Nyxt 3.12.0 work with the libraries packaged in Guix?

Nyxt pins Common Lisp libraries versions as to ensure everything works
as expected. Concretely, there's an issue related to sbcl-alexandria
since the commit Guix is using breaks Nyxt's functionality (see [1]).

You may argue that a sbcl-alexandria variant could be defined (see [2]),
but it seems brittle from Nyxt's perspective and probably undesirable
from Guix's perspective.

All package managers are using the git submodules to build Nyxt,
including Nix. From Nyxt's perspective, any build that won't use the
pinned CL libraries versions isn't Nyxt per se, but a custom build (or
perhaps a "variation" in Guix's parlance).

Happy to know your thoughts.



--
André A. Gomes
"You cannot even find the ruins..."
G
G
Guillaume Le Vaillant wrote on 23 Oct 21:31 +0200
(name . André A. Gomes)(address . andremegafone@gmail.com)(address . 73937@debbugs.gnu.org)
87plnqty4o.fsf@kitej
André A. Gomes <andremegafone@gmail.com> skribis:

Toggle quote (25 lines)
> Guillaume Le Vaillant <glv@posteo.net> writes:
>
>> Hi.
>> We usually try to avoid taking libraries from git submodules unless the
>> software can't be made to compile with system libraries.
>> Can't Nyxt 3.12.0 work with the libraries packaged in Guix?
>
> Nyxt pins Common Lisp libraries versions as to ensure everything works
> as expected. Concretely, there's an issue related to sbcl-alexandria
> since the commit Guix is using breaks Nyxt's functionality (see [1]).
>
> You may argue that a sbcl-alexandria variant could be defined (see [2]),
> but it seems brittle from Nyxt's perspective and probably undesirable
> from Guix's perspective.
>
> All package managers are using the git submodules to build Nyxt,
> including Nix. From Nyxt's perspective, any build that won't use the
> pinned CL libraries versions isn't Nyxt per se, but a custom build (or
> perhaps a "variation" in Guix's parlance).
>
> Happy to know your thoughts.
>
> [1] https://github.com/atlas-engineer/nyxt/issues/3503
> [2] https://github.com/aadcg/aadcg-guix-channel/blob/284a62f30b91642b08a66d02679611655d0bfb51/packages/aadcg-nyxt.scm#L20

If I understand correctly, the issue comes from the fact that the
read-stream-content-into-string function from recent versions of
alexandria doesn't accept an octet stream as argument instead of
a character stream anymore.

Wouldn't it be possible to replace

(alexandria:read-stream-content-into-string connection)

by something like

(map 'string
#'code-char
(alexandria:read-stream-content-into-byte-vector connection))

in Nyxt? If it works it would allow us to continue using the system
libraries (some of which might have patches to work well in Guix).
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZxlO9w8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/lNQD/UiAlBDWwOGE4Sv7XKSWDvV8PlLL+3icJ759y
ezQG2IUA/RYiLTBQOxYcpUXyu2SS11AZZSbpQn7v9zEIk2RTszoy
=CbNw
-----END PGP SIGNATURE-----

?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 73937@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 73937
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch