Remove phase 'skip-gtk-update-icon-cache from Tilix

  • Open
  • quality assurance status badge
Details
One participant
  • Ashvith Shetty
Owner
unassigned
Submitted by
Ashvith Shetty
Severity
normal
A
A
Ashvith Shetty wrote on 13 Sep 15:02 +0200
(address . guix-patches@gnu.org)(address . jgart@dismail.de)
TK5RJS.4ZEUYUN0KEB11@gmail.com
Hello,
I should've made this clearer in the previous issue that I've opened.
There is no to keep the phase 'skip-gtk-update-icon-cache, as the two
new native-inputs I've added respectively, `(,glib "bin") and `(,gtk+
"bin") fixes the issues with meson's post-install Python script.
Attachment: file
A
A
Ashvith Shetty wrote on 13 Sep 16:01 +0200
[PATCH v1] gnu: tilix: Remove phase 'skip-gtk-update-icon-cache.
(address . 73227@debbugs.gnu.org)(name . Ashvith Shetty)(address . ashvithshetty10@gmail.com)
a25eb24f19a7a3dcd00fa68092ecf1819a725edc.1726236102.git.ashvithshetty10@gmail.com
* gnu/packages/terminals.scm (tilix)[arguments]<#:phases>: Remove
phase 'skip-gtk-update-icon-cache.

Change-Id: I7eb068764f67fd047854e65c9dcdecd45ac18dd3
---
gnu/packages/terminals.scm | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index eadf58fbf3..30a64acb36 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -1451,17 +1451,11 @@ (define-public tilix
(arguments
(list
#:glib-or-gtk? #t
- #:phases
- #~(modify-phases %standard-phases
- (add-after 'unpack 'set-env-variables
- (lambda _
- (setenv "CC"
- #$(cc-for-target))))
- (add-after 'unpack 'skip-gtk-update-icon-cache
- (lambda _
- (substitute* "meson_post_install.py"
- (("gtk-update-icon-cache") (which "true"))
- (("update-desktop-database") (which "true"))))))))
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'set-env-variables
+ (lambda _
+ (setenv "CC"
+ #$(cc-for-target)))))))
(inputs (list dbus
dconf
gettext-minimal
--
2.46.0
A
A
Ashvith Shetty wrote on 3 Dec 18:45 +0100
Re: Remove phase 'skip-gtk-update-icon-cache from Tilix
(address . 73227@debbugs.gnu.org)
CA+n6Bx8cNh0ey=iv1mfsXpXSUVe7XaXXWhz4ZuKMBVDTrgSfNA@mail.gmail.com
Hello,

Just wanted to ping about this patch I had created around September, which
removes the need for having to substitute text unnecessarily. This is
actually a follow-up to the previous patch at

Regards,
Ashvith
Attachment: file
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 73227@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 73227
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch