[PATCH] gnu: gsl: Add debug output.

  • Open
  • quality assurance status badge
Details
4 participants
  • jgart
  • John Kehayias
  • Ludovic Courtès
  • Artyom Bologov
Owner
unassigned
Submitted by
Artyom Bologov
Severity
normal
A
A
Artyom Bologov wrote on 5 Sep 21:28 +0200
(name . Guix Patches)(address . guix-patches@gnu.org)
875xr9ew8e.fsf@aartaka.me
Hello Guix,

This patch adds a debug output for GSL. Encountered the absence of debug
output while debugging a GSL-reliant program. Tested, produces the
proper debugging file with the right symbols.
From c8e5967de674c5eec61f9686902ea6fe568531bf Mon Sep 17 00:00:00 2001
From: Artyom Bologov <mail@aartaka.me>
Date: Thu, 5 Sep 2024 23:24:28 +0400
Subject: [PATCH] gnu: gsl: Add debug output.

* gnu/packages/maths.scm (gsl)[outputs]: Add "debug".
---
gnu/packages/maths.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 2fe64d4aee..92244ed5f8 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -725,7 +725,7 @@ (define-public gsl
(sha256
(base32
"0jxkxrnpys2j3rh8bzx0bmnh4w6xm28jd57rgxsjp0s863agpc6w"))))
- (outputs '("out" "static"))
+ (outputs '("out" "static" "debug"))
(build-system gnu-build-system)
(arguments
(list ;; FIXME: Setting CFLAGS=-fPIC is not only unnecessary, it's also
--
2.41.0
Thanks,
--
Artyom Bologov
J
J
jgart wrote on 6 Sep 02:13 +0200
(address . 73058-done@debbugs.gnu.org)(name . Artyom Bologov)(address . mail@aartaka.me)
1d8535123292a4db1821bfd74a0e36b4083e56fb@dismail.de
LGTM!

all the best,

jgart

Closed
J
J
John Kehayias wrote on 6 Sep 04:28 +0200
Re: bug#73058: closed (Re: [PATCH] gnu: gsl: Add debug output.)
(name . jgart)(address . jgart@dismail.de)
87le05ldn1.fsf@protonmail.com
Hello,

On Fri, Sep 06, 2024 at 12:15 AM, GNU bug Tracking System wrote:

Toggle quote (29 lines)
> Your bug report
>
> #73058: [PATCH] gnu: gsl: Add debug output.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 73058@debbugs.gnu.org.
>
> --
> 73058: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73058
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>
> From: "jgart" <jgart@dismail.de>
> Subject: Re: [PATCH] gnu: gsl: Add debug output.
> To: 73058-done@debbugs.gnu.org
> Cc: Artyom Bologov <mail@aartaka.me>
> Date: Fri, 06 Sep 2024 00:13:28 +0000 (2 hours, 12 minutes, 9 seconds ago)
>
> LGTM!
>
> all the best,
>
> jgart
>
> https://whereis.xn--q9jyb4c/
>

Did you mean to push this to master? I see a lot of rebuilds on Cuirass.
Though perhaps a good chunk done by now.

If it needs to be reverted (I wasn't sure), we could take it (and an
update?) on mesa-updates or maybe gnome-team if they are quicker?

John

Toggle quote (17 lines)
> ----------
>
> From: Artyom Bologov <mail@aartaka.me>
> Subject: [PATCH] gnu: gsl: Add debug output.
> To: Guix Patches <guix-patches@gnu.org>
> Date: Thu, 05 Sep 2024 23:28:17 +0400
> Date: Thu, 05 Sep 2024 23:28:17 +0400 (6 hours, 57 minutes, 20 seconds ago)
>
> Hello Guix,
>
> This patch adds a debug output for GSL. Encountered the absence of debug
> output while debugging a GSL-reliant program. Tested, produces the
> proper debugging file with the right symbols.
>
>
>
> Thanks,
L
L
Ludovic Courtès wrote on 6 Sep 09:03 +0200
control message for bug #73058
(address . control@debbugs.gnu.org)
87plph4623.fsf@gnu.org
reopen 73058
tags 73058 - fixed patch
quit
L
L
Ludovic Courtès wrote on 6 Sep 09:05 +0200
Re: [bug#73058] closed (Re: [PATCH] gnu: gsl: Add debug output.)
(name . John Kehayias)(address . john.kehayias@protonmail.com)
87jzfp45yq.fsf@gnu.org
Hi John and jgart,

John Kehayias <john.kehayias@protonmail.com> skribis:

Toggle quote (2 lines)
> On Fri, Sep 06, 2024 at 12:15 AM, GNU bug Tracking System wrote:

[...]

Toggle quote (18 lines)
>> From: "jgart" <jgart@dismail.de>
>> Subject: Re: [PATCH] gnu: gsl: Add debug output.
>> To: 73058-done@debbugs.gnu.org
>> Cc: Artyom Bologov <mail@aartaka.me>
>> Date: Fri, 06 Sep 2024 00:13:28 +0000 (2 hours, 12 minutes, 9 seconds ago)
>>
>> LGTM!
>>
>> all the best,
>>
>> jgart
>>
>> https://whereis.xn--q9jyb4c/
>>
>
> Did you mean to push this to master? I see a lot of rebuilds on Cuirass.
> Though perhaps a good chunk done by now.

It’s a serious issue indeed: builders, in particular for Arm/RISC-V/PPC,
cannot be expected to catch up with such a change on ‘master’. Please
check out the rebuild scheduling policy, in this case for changes
impacting 300+ packages:


In fact, we have more important changes to ‘gsl’ that were noticed
during ‘core-updates’ but delayed due to the important cost of a
rebuild; see 4d8382ab840300ffe2a364d0e2a27b8db3d04fab and the discussion

Toggle quote (3 lines)
> If it needs to be reverted (I wasn't sure), we could take it (and an
> update?) on mesa-updates or maybe gnome-team if they are quicker?

I was planning to have a gsl-specific branch, where we could have this
patch too, and which could join a “merge train” with ‘mesa-updates’ or
similar. WDYT?

So I reverted this commit in c4a2b99f7d06ef5676d4148410a3b734c286f7cb
and canceled pending builds on ci.guix.

Thanks,
Ludo’.
J
J
jgart wrote on 6 Sep 19:01 +0200
ab4b1b02eb4014ece5dd3e52ec424ea4648b8070@dismail.de
hi ludo,

sorry for the disruption and thanks for reverting the commit. i didn't realize the amount of rebuilds that this would cause when i pushed it and i forgot to run `guix refresh -l gsl` before pushing ?

all the best,

jgart

https://whereis.???/
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 73058@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 73058
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch