[PATCH] gnu: libdjinterop: Update to 0.21.0.

  • Open
  • quality assurance status badge
Details
2 participants
  • Ferran Pujol Camins
  • Vinicius Monego
Owner
unassigned
Submitted by
Ferran Pujol Camins
Severity
normal
F
F
Ferran Pujol Camins wrote on 25 Jul 16:00 +0200
(address . guix-patches@gnu.org)(name . Ferran Pujol Camins)(address . ferranpujolcamins@gmail.com)
20240725140036.192638-1-ferranpujolcamins@gmail.com
* gnu/packages/audio.scm (libdjinterop): Update to 0.21.0.

Signed-off-by: Ferran Pujol Camins <ferranpujolcamins@gmail.com>
Change-Id: I2ec016a0b5851a780746802f8812f1829b50f5c7
---
gnu/packages/audio.scm | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

Toggle diff (39 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index b728220e1f..fa566696ab 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -47,6 +47,7 @@
;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
;;; Copyright © 2023 Parnikkapore <poomklao@yahoo.com>
;;; Copyright © 2024 hapster <o.rojon@posteo.net>
+;;; Copyright © 2024 Ferran Pujol Camins <me@ferranpujolcamins.cat>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1609,7 +1610,7 @@ (define-public swh-plugins-lv2
(define-public libdjinterop
(package
(name "libdjinterop")
- (version "0.20.2")
+ (version "0.21.0")
(source
(origin
(method git-fetch)
@@ -1618,12 +1619,10 @@ (define-public libdjinterop
(commit version)))
(file-name (git-file-name name version))
(sha256
- (base32 "0gbaji3d105vwshjfmnbxqrs42jjjxp41jqj5srncrfv3xmzsfkr"))))
+ (base32 "0rcvp3pwd354zd4rxvai5k14ncq1zvsplqfd37dyw8vx6z81x93v"))))
(build-system cmake-build-system)
- (native-inputs
- (list boost pkg-config))
- (inputs
- (list sqlite zlib))
+ (native-inputs (list boost pkg-config))
+ (inputs (list sqlite zlib))
(home-page "https://github.com/xsco/libdjinterop")
(synopsis "C++ library for access to DJ record libraries")
(description
--
2.45.2
V
V
Vinicius Monego wrote on 27 Jul 00:25 +0200
988ab2eeea2f7a3820b92818a347b78c701650e9.camel@posteo.net
Hi,

Em qui, 2024-07-25 às 16:00 +0200, Ferran Pujol Camins escreveu:
Toggle quote (3 lines)
> * gnu/packages/audio.scm (libdjinterop): Update to 0.21.0.
>

The current release of Mixxx, 2.4.1, expects libdjinterop at 0.20.2:


set(LIBDJINTEROP_VERSION 0.20.2)

QA is likely to break here, so this update should wait for the next
release of Mixxx, which will bump libdjinterop to 0.21.0.

Toggle quote (4 lines)
> Signed-off-by: Ferran Pujol Camins <ferranpujolcamins@gmail.com>
> Change-Id: I2ec016a0b5851a780746802f8812f1829b50f5c7
>

Commits are signed by the committer who pushes it, you don't sign your
own.

Regards,

Vinicius
V
V
Vinicius Monego wrote on 27 Jul 20:05 +0200
(name . Ferran Pujol Camins)(address . ferranpujolcamins@gmail.com)(address . 72297@debbugs.gnu.org)
d7f84ff68e60fc0597c6829ae3234cc392ae3334.camel@posteo.net
Em sáb, 2024-07-27 às 19:02 +0200, Ferran Pujol Camins escreveu:

[...]
Toggle quote (12 lines)
>

> > QA is likely to break here, so this update should wait for the next
> > release of Mixxx, which will bump libdjinterop to 0.21.0.
> >
>
>
> I see. My goal was precisely to have v0.21.0 packaged so I could set
> a guix shell to develop with mixxx main branch. How is this usually
> handled?
>

Given that this is simple version bump that doesn't need significant
changes, you can spawn a shell with --with-commit=package=version e.g.

guix shell -D mixxx --with-commit=libdjinterop=0.21.0

See "Package Transformation Options" in the manual:

But if you needed more complex changes in the inputs, you could use
your own packages defined in local files. Create a directory with
Scheme files containing package definitions and add that directory to
the GUIX_PACKAGE_PATH environment variable. Let's say you locally
define 'mylibdjinterop', then you can use a transformation like

guix shell -D mixxx --with-input=libdjinterop=mylibdjinterop

You can find a tutorial for this here:

Vinicius
F
F
Ferran Pujol Camins wrote on 27 Jul 19:02 +0200
(name . Vinicius Monego)(address . monego@posteo.net)(address . 72297@debbugs.gnu.org)
CAP9NH=EjjEA2SNsgBfMOE4DDuyiTWW-79+m0ZAVKY=edh_PaZw@mail.gmail.com
Toggle quote (5 lines)
>
> Commits are signed by the committer who pushes it, you don't sign your
> own.


Thanks for clarifying. I'll keep this in mind for the future.

QA is likely to break here, so this update should wait for the next
Toggle quote (3 lines)
> release of Mixxx, which will bump libdjinterop to 0.21.0.
>

I see. My goal was precisely to have v0.21.0 packaged so I could set a guix
shell to develop with mixxx main branch. How is this usually handled?


On Sat, 27 Jul 2024, 00:26 Vinicius Monego, <monego@posteo.net> wrote:

Toggle quote (27 lines)
> Hi,
>
> Em qui, 2024-07-25 às 16:00 +0200, Ferran Pujol Camins escreveu:
> > * gnu/packages/audio.scm (libdjinterop): Update to 0.21.0.
> >
>
> The current release of Mixxx, 2.4.1, expects libdjinterop at 0.20.2:
>
>
> https://github.com/mixxxdj/mixxx/blob/da261b6f006141fbca8b10490e73ad2211703d20/CMakeLists.txt#L2286
>
> set(LIBDJINTEROP_VERSION 0.20.2)
>
> QA is likely to break here, so this update should wait for the next
> release of Mixxx, which will bump libdjinterop to 0.21.0.
>
> > Signed-off-by: Ferran Pujol Camins <ferranpujolcamins@gmail.com>
> > Change-Id: I2ec016a0b5851a780746802f8812f1829b50f5c7
> >
>
> Commits are signed by the committer who pushes it, you don't sign your
> own.
>
> Regards,
>
> Vinicius
>
Attachment: file
F
F
Ferran Pujol Camins wrote on 28 Jul 11:56 +0200
(name . Vinicius Monego)(address . monego@posteo.net)(address . 72297@debbugs.gnu.org)
CAP9NH=E5u=UOG6cB3_WhqQDV1AGO=VVa5SXbET31WT6nem42Cw@mail.gmail.com
Awesome!

Thank you very much for the explanation!

Best regards, Ferran.

Missatge de Vinicius Monego <monego@posteo.net> del dia ds., 27 de jul.
2024 a les 20:06:

Toggle quote (37 lines)
> Em sáb, 2024-07-27 às 19:02 +0200, Ferran Pujol Camins escreveu:
>
> [...]
> >
>
> > > QA is likely to break here, so this update should wait for the next
> > > release of Mixxx, which will bump libdjinterop to 0.21.0.
> > >
> >
> >
> > I see. My goal was precisely to have v0.21.0 packaged so I could set
> > a guix shell to develop with mixxx main branch. How is this usually
> > handled?
> >
>
> Given that this is simple version bump that doesn't need significant
> changes, you can spawn a shell with --with-commit=package=version e.g.
>
> guix shell -D mixxx --with-commit=libdjinterop=0.21.0
>
> See "Package Transformation Options" in the manual:
>
> https://guix.gnu.org/manual/en/html_node/Package-Transformation-Options.html
>
> But if you needed more complex changes in the inputs, you could use
> your own packages defined in local files. Create a directory with
> Scheme files containing package definitions and add that directory to
> the GUIX_PACKAGE_PATH environment variable. Let's say you locally
> define 'mylibdjinterop', then you can use a transformation like
>
> guix shell -D mixxx --with-input=libdjinterop=mylibdjinterop
>
> You can find a tutorial for this here:
> https://guix.gnu.org/blog/2018/a-packaging-tutorial-for-guix/
>
> Vinicius
>
Attachment: file
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 72297@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 72297
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch