[PATCH] gnu: chicken: Update to 5.4.0.

  • Open
  • quality assurance status badge
Details
3 participants
  • ashish.is
  • jgart
  • Ludovic Courtès
Owner
unassigned
Submitted by
ashish.is
Severity
important
A
A
ashish.is wrote on 18 Jul 10:59 +0200
(address . guix-patches@gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
c8026dbdaa7d837ed8d471d22ecd90954ccb692d.1721293178.git.ashish.is@lostca.se
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/chicken.scm (chicken): Update to 5.4.0.

Change-Id: I448bdc25a5cb11e55c7ebb9d9e0cf1876ca958d8
---
gnu/packages/chicken.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (25 lines)
diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
index 8f5e8ce98d..d48a0c89c0 100644
--- a/gnu/packages/chicken.scm
+++ b/gnu/packages/chicken.scm
@@ -33,14 +33,14 @@ (define-module (gnu packages chicken)
(define-public chicken
(package
(name "chicken")
- (version "5.3.0")
+ (version "5.4.0")
(source (origin
(method url-fetch)
(uri (string-append "https://code.call-cc.org/releases/"
version "/chicken-" version ".tar.gz"))
(sha256
(base32
- "0xhdvcdwlv9vbhxh7k0fzd32ybhc7fn83y9fj48dhzp1z7c9kbf3"))))
+ "0pzcrnzkjw2sa44vy59wbygvlc3nva8zisprkdnvyrqi3jk4lp9w"))))
(build-system gnu-build-system)
(arguments
`(#:modules ((guix build gnu-build-system)

base-commit: ee7e5e00bf2b9257e67d785b37efddb008c5da37
--
2.45.2
A
A
Ashish SHUKLA wrote on 18 Jul 11:17 +0200
control message for bug 72173
(address . control@debbugs.gnu.org)
f30b142a445930084072b99890c6a987@lostca.se
severity 72173 important
tag 72173 security
quit
J
Re: [PATCH] gnu: chicken: Update to 5.4.0.
(address . 72173-done@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
877cdhuk8q.fsf@dismail.de
Applied, thanks!
--
all the best,
jgart
Closed
L
L
Ludovic Courtès wrote on 20 Jul 15:53 +0200
Re: [bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.
(address . 72173@debbugs.gnu.org)
87y15wp3ui.fsf@gnu.org
Hey jgart & Ashish,

ashish.is@lostca.se skribis:

Toggle quote (6 lines)
> From: Ashish SHUKLA <ashish.is@lostca.se>
>
> * gnu/packages/chicken.scm (chicken): Update to 5.4.0.
>
> Change-Id: I448bdc25a5cb11e55c7ebb9d9e0cf1876ca958d8

This caused a number of Chicken packages to fail to build:


In particular, ‘chicken-compile-file’ fails to build with:

Toggle snippet (11 lines)
starting phase `build'

Error: extension or version not found: "compile-file"
fetching compile-file
TCP connect timeout
TCP connect timeout
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "chicken-install" arguments: ("-cached" "-no-install" "compile-file") exit-status: 70 term-signal: #f stop-signal: #f>
phase `build' failed after 0.0 seconds


Could you take a look?

Thanks,
Ludo’.
J
(address . 72173@debbugs.gnu.org)
496724dba6db0fe71042b700b5593a1160f017d2@dismail.de
July 20, 2024 at 8:53 AM, "Ludovic Courtès" <ludo@gnu.org> wrote:

Hi Ludo,

Sorry, I forgot to check the dependent chicken packages ??

I will revert this commit immediately on Monday when I get back.

I don't think I'll have time to look into the chicken package failures this weekend or next week.

ashish, could you send a v2 with the dependent chicken packages passing in order for this to be merged properly by Monday?

all the best,

jgart
J
Re: [PATCH] gnu: chicken: Update to 5.4.0.
(address . 72173@debbugs.gnu.org)
871q3lv2f1.fsf@dismail.de
Hi all,

I've reverted this commit for now.

Hi ashish,

Feel free to send a v2 including the build passing dependents.

If you'd like to me to review it again please Cc me.
--
all the best,
jgart
A
A
Ashish wrote on 22 Jul 23:08 +0200
(name . jgart)(address . jgart@dismail.de)
53wavevla2bov4h4jt2aczrxux77widsu6jlu42s3k5nqdrp53@eqercl2fsthu
On Mon, Jul 22, 2024 at 11:04:18AM -0500, jgart wrote:
Toggle quote (14 lines)
>
> Hi all,
>
> I've reverted this commit for now.
>
> Hi ashish,
>
> Feel free to send a v2 including the build passing dependents.
>
> If you'd like to me to review it again please Cc me.
> --
> all the best,
> jgart

Sorry about the lack of proper testing, and lack of timely follow up on
my part. I'll work on a fix sometime this week, and will get back to
you.

Apologies again.

--
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)
-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmaeymNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2
ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP
pLAPLg/+NTR7QbBpOOe/ciTpkOpJdU7U/D4v9hF/O+7V77v2oo9s8ZVcL0mMFxmd
ePW58lG/vM5e7LejSnrzZ9Femz7GTLyWZa3NUUlG5uE/0J1ZeXFY8z9UMt/ZOam3
qM8E4JXnfjDznuwDVQ/yw+INNa0AEAGyfI184Uj06rfbV7kW9YYhnkmsZi3MneIJ
PeP68vG245NNju0B2vv+v4mrRdWAAWHHvoAYO/cIWU+QYgtF4fr7TEEQWWZhhOTM
Y2TC2Xncpsu0BQPUHB/71E05VvoeZgSyKjEhVtskbZk3ZjfFVzBZlqdzCL9Xz59a
ll4+nmEB7u9wwGW/x7TOEsRNJk8CpFhwRID8pZvPmuyCsZiHjWl408C+++CDj5G/
92aM/0/RSCt2MOCgbwadIbE1dVHk95rd0dxjlBaR3CfId38cLxffi11AtC/gR37r
8tRiTY+4AkKnVZkNDXJAQtXhgrtOBETdz12xXvkMipoEL0gGKSs7+ZLY/jvqp/YG
CWRZ1c55EEgBGAUwPSyk+y+D4fbP/EOtmbpkbD8l6uyGMIett72j2mCokshitXj0
KmuREVqS05WOeO//fKk4TBf4x0jERwCS2zLhObQjpxZqQ4Mp0eBW+QZXTT7HcOlu
ninRCsVWSMfUuetw8WzFJJKqLoSPNpx72dW0lkM9PQ7foQVLfbs=
=zowi
-----END PGP SIGNATURE-----


J
(name . Ashish)(address . ashish.is@lostca.se)
a2cc7b416a4a87e086dd432c889b2f96270cbccb@dismail.de
Toggle quote (8 lines)
> Sorry about the lack of proper testing, and lack of timely follow up on
>
> my part. I'll work on a fix sometime this week, and will get back to
>
> you.
>
> Apologies again.

No worries and thanks for contributing.

Keep us posted on the new version.

I can review and test again once ready.

all best,

jgart
L
L
Ludovic Courtès wrote on 25 Jul 09:53 +0200
control message for bug #72173
(address . control@debbugs.gnu.org)
87o76lewl8.fsf@gnu.org
reopen 72173
tags 72173 - fixed patch
quit
A
A
ashish.is wrote on 25 Jul 19:41 +0200
[PATCH v2 0/2] gnu: chicken: Update to 5.4.0.
(address . 72173@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
cover.1721929275.git.ashish.is@lostca.se
From: Ashish SHUKLA <ashish.is@lostca.se>

In this revision, I have updated the chicken-build-system. These
changes are based off the work in nixpkgs[0].

All of the failed dependents seem to build fine.

References:

Ashish SHUKLA (2):
gnu: chicken: Update to 5.4.0.
guix: chicken-build-system: Update for 5.4.0.

gnu/packages/chicken.scm | 4 ++--
guix/build/chicken-build-system.scm | 11 ++++++-----
2 files changed, 8 insertions(+), 7 deletions(-)


base-commit: 03062c7a9fd74d625639e1a325e9cb58d1cd74e3
--
2.45.2
A
A
ashish.is wrote on 25 Jul 19:41 +0200
[PATCH v2 1/2] gnu: chicken: Update to 5.4.0.
(address . 72173@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
f1f50290e002429f0f1b20288c16c502a3cfdb34.1721929275.git.ashish.is@lostca.se
From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/chicken.scm (chicken): Update to 5.4.0.

Change-Id: I448bdc25a5cb11e55c7ebb9d9e0cf1876ca958d8
---
gnu/packages/chicken.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
index 8f5e8ce98d..d48a0c89c0 100644
--- a/gnu/packages/chicken.scm
+++ b/gnu/packages/chicken.scm
@@ -33,14 +33,14 @@ (define-module (gnu packages chicken)
(define-public chicken
(package
(name "chicken")
- (version "5.3.0")
+ (version "5.4.0")
(source (origin
(method url-fetch)
(uri (string-append "https://code.call-cc.org/releases/"
version "/chicken-" version ".tar.gz"))
(sha256
(base32
- "0xhdvcdwlv9vbhxh7k0fzd32ybhc7fn83y9fj48dhzp1z7c9kbf3"))))
+ "0pzcrnzkjw2sa44vy59wbygvlc3nva8zisprkdnvyrqi3jk4lp9w"))))
(build-system gnu-build-system)
(arguments
`(#:modules ((guix build gnu-build-system)
--
2.45.2
A
A
ashish.is wrote on 25 Jul 19:41 +0200
[PATCH v2 2/2] guix: chicken-build-system: Update for 5.4.0.
(address . 72173@debbugs.gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)
b9662a0b62eceb56545f9d199b1c51aa17c1271a.1721929275.git.ashish.is@lostca.se
From: Ashish SHUKLA <ashish.is@lostca.se>

* guix/build/chicken-build-system (build): chdir to the directory containing
sources, and let chicken-install process the current directory.
(install): Switch to define as we do not need any keys.
(check): Remove unused egg-name from the arguments.

Change-Id: I4adf5e2378deab6e3f3b3c128c3cc75ce43f0e8a
---
guix/build/chicken-build-system.scm | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

Toggle diff (34 lines)
diff --git a/guix/build/chicken-build-system.scm b/guix/build/chicken-build-system.scm
index 8f9f59cc25..fd5a33fd22 100644
--- a/guix/build/chicken-build-system.scm
+++ b/guix/build/chicken-build-system.scm
@@ -93,13 +93,14 @@ (define* (unpack #:key source egg-name unpack-path #:allow-other-keys)
(define* (build #:key egg-name #:allow-other-keys)
"Build the Chicken egg named by EGG-NAME"
- (invoke "chicken-install" "-cached" "-no-install" egg-name))
+ (chdir egg-name)
+ (invoke "chicken-install" "-cached" "-no-install"))
-(define* (install #:key egg-name #:allow-other-keys)
+(define (install . _)
"Install the already built egg named by EGG-NAME"
- (invoke "chicken-install" "-cached" egg-name))
+ (invoke "chicken-install" "-cached"))
-(define* (check #:key egg-name tests? #:allow-other-keys)
+(define* (check #:key tests? #:allow-other-keys)
"Build and run tests for the Chicken egg EGG-NAME"
;; there is no "-test-only" option, but we've already run install
;; so this just runs tests.
@@ -109,7 +110,7 @@ (define* (check #:key egg-name tests? #:allow-other-keys)
":"
(getenv "CHICKEN_REPOSITORY_PATH")))
(when tests?
- (invoke "chicken-install" "-cached" "-test" "-no-install" egg-name)))
+ (invoke "chicken-install" "-cached" "-test" "-no-install")))
(define* (stamp-egg-version #:key egg-name name #:allow-other-keys)
"Check if EGG-NAME.egg contains version information and add some if not."
--
2.45.2
J
Re: [PATCH] gnu: chicken: Update to 5.4.0.
(address . 72173@debbugs.gnu.org)
87zfq5nqo5.fsf@dismail.de
Hi,

Thanks for the v2. I can't apply this patch series with mumi am.

Can you share the method that you used to send it?

Thanks,

jgart
A
A
Ashish wrote on 26 Jul 10:35 +0200
(name . jgart)(address . jgart@dismail.de)
ci2jm55werhqktggl3qjcpqm75gypdaiultlbp6vnldukcovdq@p5hw3imwhzav
On Thu, Jul 25, 2024 at 03:48:58PM -0500, jgart wrote:
Toggle quote (7 lines)
>
> Hi,
>
> Thanks for the v2. I can't apply this patch series with mumi am.
>
> Can you share the method that you used to send it?

Sure.

git send-email -2 -v2 \
--in-reply-to=a2cc7b416a4a87e086dd432c889b2f96270cbccb@dismail.de \
--to=72173@debbugs.gnu.org --cover-letter --annotate \
--base=origin/master

origin/master was 03062c7a9fd74d625639e1a325e9cb58d1cd74e3

Thanks!
--
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)
-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmajX8RfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2
ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP
pLDBOhAAwf3+JMainMqnW2CIaB2NW6UAPNjmatzqn6Pp+vEP20NsUGqioFn+T3j0
n4uSqpqndalCa7ZhOHt5uvnRwg1Yk6lPRf739jh3IpEnlCVe6l5x4czfCbZYyoNu
05m6QyJLjS8uQLhZvOXbRnEuIrxY9f1OiJSWeL7VuXI8a5sCPtaR1/k1nQt8up4T
Tyz82mKd/2cTw1rAZ9fXcwA5SJWeNvbh6NlRahnh7Ic8Ms7W7NhtDDYA7DVmXywF
AD+7vGvYI7OYdnIrgpZ/8uRbZMGN1TSM0fnRamvewMbtGwGeYcap+TUN+IqupBSV
mhXcjlpXu+OkY7I8wnEJO6aae6alwZqVssskdLJpC70CFL3DR5CgkgKstMC/4x3U
wwPCdx4fOsjcvuwkDyHbDrCq3fnc7rvmoA7GfcXp09qy2qMhE2/iIjIWC10l7ufF
eUCCbG5jNjSU2xQoUqSNu2f9/8tRnt1K2bpqtIlhuUV6nyl+T5cz82p0gRff0XHp
7h4J2nn2y/xOJ+FHtpRW9yFoJgzbGct7PkKqbWjPRbvuiz4byE+DZlwBlcZcrQaG
xc1RMRNT6prPT5hXmM51tnUerfJSAD6W0ot6HL3Z3oCC5dHYT1dglS3pPFzPvjCa
1RY8+nLi7mfqFN4PAMMff5PV7YpFU5I5eVROW9C7FDIZ4WIcDX0=
=Rox5
-----END PGP SIGNATURE-----


A
A
Ashish wrote on 26 Jul 10:44 +0200
(name . jgart)(address . jgart@dismail.de)
x2cz3myla4b6mdylf2tst4t4pmqnchcphwmqdo5xt33crrvxb4@cnzlfjo4p2tv
On Fri, Jul 26, 2024 at 08:35:21AM +0000, Ashish wrote:
Toggle quote (23 lines)
> On Thu, Jul 25, 2024 at 03:48:58PM -0500, jgart wrote:
> >
> > Hi,
> >
> > Thanks for the v2. I can't apply this patch series with mumi am.
> >
> > Can you share the method that you used to send it?
>
> Sure.
>
> git send-email -2 -v2 \
> --in-reply-to=a2cc7b416a4a87e086dd432c889b2f96270cbccb@dismail.de \
> --to=72173@debbugs.gnu.org --cover-letter --annotate \
> --base=origin/master
>
> origin/master was 03062c7a9fd74d625639e1a325e9cb58d1cd74e3
>
> Thanks!
> --
> Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0
>
> "If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

? git rev-parse HEAD
efc26826400762207cde9f23802cfe75a737963c

? git checkout -b testing-pr-72173
Switched to a new branch 'testing-pr-72173'

Applying: gnu: chicken: Update to 5.4.0.
Applying: guix: chicken-build-system: Update for 5.4.0.


Please note that the URLs above are not quite what are reflected in the
web UI, so my guess something in the upstream mumi DB is messed up.

your reply in the web UI, but if you download it, it's the one that
contains the message containing the patch.

My guess is this is why mumi is getting confused.

HTH
--
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)
-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmajYeRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2
ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP
pLA9iA/9GscR+cDSDnug6s60l3/njxmoY9KmKNdDm7aFvlLHLnwUtOkDfYQULvFu
8Zrkd71NFFtmxHGSryszXdgrHVQLrXe0K06topup+tqKX3Pa6vd0GWCIs/2CR61s
OqIi8fNOMzVc1ikbsKMaNnYQqdl7D4f7LX6NMss3NqMXPmjUTTqqgSXK9lkrP3kP
cdTNyTFNB6am2WeWQ7z9lzNXwasPw2xJcsqt/2HiL1gvCsQTw9WvOtd1e8rGzG4F
Sgd4gH0MgnnGFFCOB9DN+HmKYldrqYcZ9zulBi+fot50QbAq5W2s2KTo3fA1idL7
BAf/xoU9WaNMqauanj7IQDJLhPIcshitRF5YBpKaKpFDWvG8N/pRIVORhutk+5+b
4kkle8m8XfAQ/pfGvtrHWsb2CSnFd61+yDMzMFGr3PNqKJg3azddygR8QK5m1D27
W4LeZsSkLPtJWaCLkPT2SwH5iJ0d1/Rnwm4tgmMu6/S0uoAEZ51GZFLZp6/Q077M
ooh0akIngtxjy91xtIUuoFORK+T8eajKMtQ/RktdwZiUaAGON8uufjlgIM6o0Fbr
sbPg/faZyHu7GW2Sjiw/dq4vjRi0dPrOff2y69r0bLvZ8dwvbnD5AV2XWxunmY2l
IbK60gz+KmtssSY70DjBOVGZTBlN5w8Pv2ofowwI7bFWZzHjwD4=
=b+Yh
-----END PGP SIGNATURE-----


?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 72173@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 72173
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch