[core-updates] OpenImageIO fails to build

Done

Details

3 participants

Leo Famulari
Ricardo Wurmus
Zheng Junjie

Owner: unassigned

Submitted by: Leo Famulari

Severity: normal

Leo Famulari wrote on 10 Jul 21:47 +0200

Recipients:(address . bug-guix@gnu.org)

Message-ID:Zo7lbtoFxYTKv1t2@jasmine.lan

On core-updates commit 378e1d9b69b030a165, openimageio fails to build
like this:

------
[ 30%] Building CXX object src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/imageio.cpp.o
cd /tmp/guix-build-openimageio-2.5.13.0.drv-0/build/src/libOpenImageIO && /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/c++ -DEMBED_PLUGINS=1 -DOIIO_FREETYPE_VERSION=\"\" -DOIIO_INTERNAL=1 -DOIIO_OPENEXR_CORE_DEFAULT=1 -DOIIO_OpenCV_VERSION=\"\" -DOIIO_PYTHON_VERSION=\"3.10.7\" -DOIIO_QT_VERSION=\"\" -DOIIO_TBB_VERSION=\"\" -DOIIO_USE_EXR_C_API=1 -DOpenImageIO_EXPORTS -DUSE_BOOST_FILESYSTEM -DUSE_EXTERNAL_PUGIXML=1 -DUSE_GIF -DUSE_HEIF=1 -DUSE_JPEG_TURBO=1 -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/include/OpenImageIO -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/include -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/src/include -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/include -I/OpenEXR -isystem /gnu/store/mcyxqs4sxnb8r642q1l0gfmg86hrngqp-imath-3.1.3/include/Imath -isystem /gnu/store/p1rqc1ydnvcrn5ndjq9kn37l7fscilrv-openexr-3.2.4/include/OpenEXR -O2 -g -DNDEBUG -fPIC -fvisibility=hidden -Wall -Wno-unused-local-typedefs -Wno-unused-result -Wno-aligned-new -Wno-noexcept-type -fno-math-errno -std=c++14 -MD -MT src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/imageio.cpp.o -MF CMakeFiles/OpenImageIO.dir/imageio.cpp.o.d -o CMakeFiles/OpenImageIO.dir/imageio.cpp.o -c /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp
/tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp: In function ‘bool OpenImageIO_v2_5::getattribute(OpenImageIO_v2_5::string_view, OpenImageIO_v2_5::TypeDesc, void*)’:
/tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:623:33: error: expected primary-expression before ‘(’ token
  623 |         *(ustring*)val = ustring(OIIO_ALL_BUILD_DEPS_FOUND);
      |                                 ^
In file included from /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:24:
/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/include/imageio_pvt.h:229:377: error: expected ‘)’ before numeric constant
  229 | #define OIIO_ALL_BUILD_DEPS_FOUND "Boost 1.83.0;BZip2 1.0.8;DCMTK NONE;FFmpeg NONE;fmt 9.1.0;Freetype NONE;GIF 5.2.1;Libheif 1.17.6;libjpeg-turbo 2.1.4;LibRaw NONE;OpenColorIO NONE;OpenCV NONE;OpenEXR 3.2.4;OpenGL NONE;OpenJPEG NONE;PNG 1.6.39;Ptex NONE;Ptex NONE;pugixml 1.12;pybind11 2.8.1;Python 3.10.7;Robinmap;TBB NONE;TIFF 4.4.0;WebP NONE;ZLIB 1.3.#define ZLIB_VERSION "1.3""
      |                                                                                                                                                                                                                                                                                                                                                                                         ^~~
/tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:623:34: note: in expansion of macro ‘OIIO_ALL_BUILD_DEPS_FOUND’
  623 |         *(ustring*)val = ustring(OIIO_ALL_BUILD_DEPS_FOUND);
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:623:33: note: to match this ‘(’
  623 |         *(ustring*)val = ustring(OIIO_ALL_BUILD_DEPS_FOUND);
      |                                 ^
make[2]: *** [src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/build.make:387: src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/imageio.cpp.o] Error 1
make[2]: Leaving directory '/tmp/guix-build-openimageio-2.5.13.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:1703: src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-openimageio-2.5.13.0.drv-0/build'
make: *** [Makefile:169: all] Error 2
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("-j" "1") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `build' failed after 426.2 seconds
command "make" "-j" "1" failed with status 2
build process 14 exited with status 256
builder for `/gnu/store/zbb1ycg7q7iqsp8pa1dyvbsxvh2v94lx-openimageio-2.5.13.0.drv' failed with exit code 1
------

I can't find anything online related to this. Any ideas? Full log
attached.

Attachment: b1ycg7q7iqsp8pa1dyvbsxvh2v94lx-openimageio-2.5.13.0.drv.gz

Zheng Junjie wrote on 11 Jul 08:29 +0200

Recipients:(name . Leo Famulari)(address . leo@famulari.name)(address . 72046@debbugs.gnu.org)

Message-ID:87v81cphjs.fsf@iscas.ac.cn

Leo Famulari <leo@famulari.name> writes:

Toggle quote (73 lines)> On core-updates commit 378e1d9b69b030a165, openimageio fails to build
> like this:
>
> ------
> [ 30%] Building CXX object src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/imageio.cpp.o
> cd /tmp/guix-build-openimageio-2.5.13.0.drv-0/build/src/libOpenImageIO
> && /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/c++
> -DEMBED_PLUGINS=1 -DOIIO_FREETYPE_VERSION=\"\" -DOIIO_INTERNAL=1
> -DOIIO_OPENEXR_CORE_DEFAULT=1 -DOIIO_OpenCV_VERSION=\"\"
> -DOIIO_PYTHON_VERSION=\"3.10.7\" -DOIIO_QT_VERSION=\"\"
> -DOIIO_TBB_VERSION=\"\" -DOIIO_USE_EXR_C_API=1 -DOpenImageIO_EXPORTS
> -DUSE_BOOST_FILESYSTEM -DUSE_EXTERNAL_PUGIXML=1 -DUSE_GIF -DUSE_HEIF=1
> -DUSE_JPEG_TURBO=1 -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS
> -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/include/OpenImageIO
> -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/include
> -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/build/src/include
> -I/tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/include
> -I/OpenEXR -isystem
> /gnu/store/mcyxqs4sxnb8r642q1l0gfmg86hrngqp-imath-3.1.3/include/Imath
> -isystem
> /gnu/store/p1rqc1ydnvcrn5ndjq9kn37l7fscilrv-openexr-3.2.4/include/OpenEXR
> -O2 -g -DNDEBUG -fPIC -fvisibility=hidden -Wall
> -Wno-unused-local-typedefs -Wno-unused-result -Wno-aligned-new
> -Wno-noexcept-type -fno-math-errno -std=c++14 -MD -MT
> src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/imageio.cpp.o -MF
> CMakeFiles/OpenImageIO.dir/imageio.cpp.o.d -o
> CMakeFiles/OpenImageIO.dir/imageio.cpp.o -c
> /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp
> /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:
> In function ‘bool
> OpenImageIO_v2_5::getattribute(OpenImageIO_v2_5::string_view,
> OpenImageIO_v2_5::TypeDesc, void*)’:
> /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:623:33:
> error: expected primary-expression before ‘(’ token
>   623 |         *(ustring*)val = ustring(OIIO_ALL_BUILD_DEPS_FOUND);
>       |                                 ^
> In file included from /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:24:
> /tmp/guix-build-openimageio-2.5.13.0.drv-0/build/include/imageio_pvt.h:229:377:
> error: expected ‘)’ before numeric constant
>   229 | #define OIIO_ALL_BUILD_DEPS_FOUND "Boost 1.83.0;BZip2
> 1.0.8;DCMTK NONE;FFmpeg NONE;fmt 9.1.0;Freetype NONE;GIF 5.2.1;Libheif
> 1.17.6;libjpeg-turbo 2.1.4;LibRaw NONE;OpenColorIO NONE;OpenCV
> NONE;OpenEXR 3.2.4;OpenGL NONE;OpenJPEG NONE;PNG 1.6.39;Ptex NONE;Ptex
> NONE;pugixml 1.12;pybind11 2.8.1;Python 3.10.7;Robinmap;TBB NONE;TIFF
> 4.4.0;WebP NONE;ZLIB 1.3.#define ZLIB_VERSION "1.3""
>       |                                                                                                                                                                                                                                                                                                                                                                                         ^~~
> /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:623:34:
> note: in expansion of macro ‘OIIO_ALL_BUILD_DEPS_FOUND’
>   623 |         *(ustring*)val = ustring(OIIO_ALL_BUILD_DEPS_FOUND);
>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/guix-build-openimageio-2.5.13.0.drv-0/source/src/libOpenImageIO/imageio.cpp:623:33: note: to match this ‘(’
>   623 |         *(ustring*)val = ustring(OIIO_ALL_BUILD_DEPS_FOUND);
>       |                                 ^
> make[2]: ***
> [src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/build.make:387:
> src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/imageio.cpp.o] Error 1
> make[2]: Leaving directory '/tmp/guix-build-openimageio-2.5.13.0.drv-0/build'
> make[1]: *** [CMakeFiles/Makefile2:1703: src/libOpenImageIO/CMakeFiles/OpenImageIO.dir/all] Error 2
> make[1]: Leaving directory '/tmp/guix-build-openimageio-2.5.13.0.drv-0/build'
> make: *** [Makefile:169: all] Error 2
> error: in phase 'build': uncaught exception:
> %exception #<&invoke-error program: "make" arguments: ("-j" "1") exit-status: 2 term-signal: #f stop-signal: #f> 
> phase `build' failed after 426.2 seconds
> command "make" "-j" "1" failed with status 2
> build process 14 exited with status 256
> builder for `/gnu/store/zbb1ycg7q7iqsp8pa1dyvbsxvh2v94lx-openimageio-2.5.13.0.drv' failed with exit code 1
> ------
>
> I can't find anything online related to this. Any ideas? Full log
> attached.
>
> [2. application/x-gunzip; b1ycg7q7iqsp8pa1dyvbsxvh2v94lx-openimageio-2.5.13.0.drv.gz]...

see patch, as i known, because ours cmake too old, have a bug about zlib.

Toggle quote (2 lines)

> Found ZLIB 1.3.#define ZLIB_VERSION "1.3"

``` C

#define OIIO_ALL_BUILD_DEPS_FOUND "Boost 1.83.0;BZip2 1.0.8;DCMTK NONE;FFmpeg NONE;fmt 9.1.0;Freetype NONE;GIF 5.2.1;Libheif 1.17.6;libjpeg-turbo 2.1.4;LibRaw 0.20.0;OpenColorIO NONE;OpenCV NONE;OpenEXR 3.2.4;OpenGL NONE;OpenJPEG NONE;PNG 1.6.39;Ptex NONE;Ptex NONE;pugixml 1.12;pybind11 2.8.1;Python 3.10.7;Robinmap;TBB NONE;TIFF 4.4.0;WebP;ZLIB 1.3.#define ZLIB_VERSION "1.3""

```

shulde be

``` C

```

so is not a Not a qualified c file.

From 9c756204a49ce7bbfda7cbb2faa8e68bf56dfdc9 Mon Sep 17 00:00:00 2001

Message-ID: <9c756204a49ce7bbfda7cbb2faa8e68bf56dfdc9.1720679114.git.zhengjunjie@iscas.ac.cn>

* gnu/packages/graphics.scm (openimageio)[arguments]<#:phases>: Add

fix-zlib-version phase.

Change-Id: I7ea6e7b7da675bf11a85381cbe26c6992f2bd299

---

gnu/packages/graphics.scm | 8 +++++++-

1 file changed, 7 insertions(+), 1 deletion(-)

Toggle diff (23 lines)diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 89dae5a261..06341bc288 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -1349,7 +1349,13 @@ (define-public openimageio
     (arguments
      (list #:tests? #f ; half the tests require online data or use redirection
            #:configure-flags #~(list "-DUSE_EXTERNAL_PUGIXML=1"
-                                     "-DOIIO_BUILD_TESTS=false")))
+                                     "-DOIIO_BUILD_TESTS=false")
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'configure 'fix-zlib-version
+                          (lambda _
+                            (substitute* "include/imageio_pvt.h"
+                              (("#define ZLIB_VERSION \"1\\.3\"")
+                               "")))))))
     (native-inputs
      (list pkg-config))
     (inputs

base-commit: 378e1d9b69b030a165236323392a0a10684422c5
-- 
2.45.2

Leo Famulari wrote on 11 Jul 17:10 +0200

Recipients:(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)(address . 72046@debbugs.gnu.org)

Message-ID:Zo_10mwBr4kQsZFB@jasmine.lan

On Thu, Jul 11, 2024 at 02:29:59PM +0800, Zheng Junjie wrote:

Toggle quote (2 lines)

> see patch, as i known, because ours cmake too old, have a bug about zlib.

So, it's a problem with cmake?

Do you know if they've fixed it in later versions?

Toggle quote (7 lines)

> + #:phases #~(modify-phases %standard-phases

> + (add-after 'configure 'fix-zlib-version

> + (lambda _

> + (substitute* "include/imageio_pvt.h"

> + (("#define ZLIB_VERSION \"1\\.3\"")

> + "")))))))

Would this remove zlib support from openimageio?

Zheng Junjie wrote on 11 Jul 17:25 +0200

Recipients:(name . Leo Famulari)(address . leo@famulari.name)(address . 72046@debbugs.gnu.org)

Message-ID:87le28osr5.fsf@iscas.ac.cn

Leo Famulari <leo@famulari.name> writes:

Toggle quote (7 lines)

> On Thu, Jul 11, 2024 at 02:29:59PM +0800, Zheng Junjie wrote:

>> see patch, as i known, because ours cmake too old, have a bug about zlib.

> So, it's a problem with cmake?

> Do you know if they've fixed it in later versions?

see https://gitlab.kitware.com/cmake/cmake/-/issues/25200

Toggle quote (10 lines)>
>> +           #:phases #~(modify-phases %standard-phases
>> +                        (add-after 'configure 'fix-zlib-version
>> +                          (lambda _
>> +                            (substitute* "include/imageio_pvt.h"
>> +                              (("#define ZLIB_VERSION \"1\\.3\"")
>> +                               "")))))))
>
> Would this remove zlib support from openimageio?

no, just fix macro OIIO_ALL_BUILD_DEPS_FOUND to a right string.

Leo Famulari wrote on 11 Jul 17:32 +0200

Recipients:(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)(address . 72046@debbugs.gnu.org)

Message-ID:Zo_7JYilD7ggH-xD@jasmine.lan

On Thu, Jul 11, 2024 at 11:25:34PM +0800, Zheng Junjie wrote:

Toggle quote (6 lines)

> > So, it's a problem with cmake?

> >

> > Do you know if they've fixed it in later versions?

> see https://gitlab.kitware.com/cmake/cmake/-/issues/25200

Thanks!

Toggle quote (4 lines)

> > Would this remove zlib support from openimageio?

> no, just fix macro OIIO_ALL_BUILD_DEPS_FOUND to a right string.

Okay, great. I confirm your patch fixes the problem. I'll push it to

core-updates on your behalf.

Leo Famulari wrote on 11 Jul 17:50 +0200

Recipients:(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)(address . 72046-done@debbugs.gnu.org)

Message-ID:Zo__QNVbaOOD0TcW@jasmine.lan

On Thu, Jul 11, 2024 at 11:32:53AM -0400, Leo Famulari wrote:

Toggle quote (3 lines)

> Okay, great. I confirm your patch fixes the problem. I'll push it to

> core-updates on your behalf.

Pushed as 50243774824597dbd141a074a7be0117dc450cef

Thanks for your help!

Closed

Zheng Junjie wrote on 12 Jul 05:26 +0200

Recipients:(address . 72046@debbugs.gnu.org)(address . leo@famulari.name)

Message-ID:87h6cvp9yf.fsf@iscas.ac.cn

Leo Famulari <leo@famulari.name> writes:

Toggle quote (8 lines)

> On Thu, Jul 11, 2024 at 11:32:53AM -0400, Leo Famulari wrote:

>> Okay, great. I confirm your patch fixes the problem. I'll push it to

>> core-updates on your behalf.

> Pushed as 50243774824597dbd141a074a7be0117dc450cef

> Thanks for your help!

i think also need this patch.

From f781494940c801db6c63e22ea12c43ffec547456 Mon Sep 17 00:00:00 2001

Message-ID: <f781494940c801db6c63e22ea12c43ffec547456.1720754660.git.zhengjunjie@iscas.ac.cn>

* gnu/packages/image-processing.scm (opencolorio)[arguments]: Add

fix-OpenColorIOConfig phase.

Change-Id: I317870801f77dc59bcd07b0d11a750bbbb63b327

---

gnu/packages/image-processing.scm | 13 ++++++++++++-

1 file changed, 12 insertions(+), 1 deletion(-)

Toggle diff (29 lines)diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 32d5b8bb5c..4e83e5c26c 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -276,7 +276,18 @@ (define-public opencolorio
     (build-system cmake-build-system)
     (arguments
      ;; XXX: GPU tests are failing.
-     (list #:configure-flags #~(list "-DOCIO_BUILD_GPU_TESTS=false")))
+     (list #:configure-flags #~(list "-DOCIO_BUILD_GPU_TESTS=false")
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'install 'fix-OpenColorIOConfig
+                          (lambda _
+                            ;; Work around a CMake Zlib-detection bug:
+                            ;; https://gitlab.kitware.com/cmake/cmake/-/issues/25200
+                            ;; make OpenColorIOConfig.cmake is a normal cmake file
+                            (substitute*
+                                (string-append #$output
+                                               "/lib/cmake/OpenColorIO/OpenColorIOConfig.cmake")
+                              (("\\.#define ZLIB_VERSION \"1\\.3\"")
+                               "")))))))
     (native-inputs
      ;; XXX: OCIO has unit tests for OpenShadingLanguage, but they fail.
      ;; They also require OIIO, but OCIO is an optional dependency to it.

base-commit: 50243774824597dbd141a074a7be0117dc450cef
prerequisite-patch-id: 54dff8d31eca386fe3e0f90879bf9e98dade94d7
-- 
2.45.2

Zheng Junjie wrote on 12 Jul 05:43 +0200

Recipients:(address . 72046@debbugs.gnu.org)(address . leo@famulari.name)

Message-ID:87cynjp96h.fsf@iscas.ac.cn

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

Toggle quote (54 lines)> Leo Famulari <leo@famulari.name> writes:
>
>> On Thu, Jul 11, 2024 at 11:32:53AM -0400, Leo Famulari wrote:
>>> Okay, great. I confirm your patch fixes the problem. I'll push it to
>>> core-updates on your behalf.
>>
>> Pushed as 50243774824597dbd141a074a7be0117dc450cef
>>
>> Thanks for your help!
>
> i think also need this patch.
>
> From f781494940c801db6c63e22ea12c43ffec547456 Mon Sep 17 00:00:00 2001
> Message-ID: <f781494940c801db6c63e22ea12c43ffec547456.1720754660.git.zhengjunjie@iscas.ac.cn>
> From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
> Date: Fri, 12 Jul 2024 11:23:34 +0800
> Subject: [PATCH] gnu: opencolorio: Fix cmake file.
>
> * gnu/packages/image-processing.scm (opencolorio)[arguments]: Add
> fix-OpenColorIOConfig phase.
>
> Change-Id: I317870801f77dc59bcd07b0d11a750bbbb63b327
> ---
>  gnu/packages/image-processing.scm | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
> index 32d5b8bb5c..4e83e5c26c 100644
> --- a/gnu/packages/image-processing.scm
> +++ b/gnu/packages/image-processing.scm
> @@ -276,7 +276,18 @@ (define-public opencolorio
>      (build-system cmake-build-system)
>      (arguments
>       ;; XXX: GPU tests are failing.
> -     (list #:configure-flags #~(list "-DOCIO_BUILD_GPU_TESTS=false")))
> +     (list #:configure-flags #~(list "-DOCIO_BUILD_GPU_TESTS=false")
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'install 'fix-OpenColorIOConfig
> +                          (lambda _
> +                            ;; Work around a CMake Zlib-detection bug:
> +                            ;; https://gitlab.kitware.com/cmake/cmake/-/issues/25200
> +                            ;; make OpenColorIOConfig.cmake is a normal cmake file
> +                            (substitute*
> +                                (string-append #$output
> +                                               "/lib/cmake/OpenColorIO/OpenColorIOConfig.cmake")
> +                              (("\\.#define ZLIB_VERSION \"1\\.3\"")
> +                               "")))))))
>      (native-inputs
>       ;; XXX: OCIO has unit tests for OpenShadingLanguage, but they fail.
>       ;; They also require OIIO, but OCIO is an optional dependency to it.
>
> base-commit: 50243774824597dbd141a074a7be0117dc450cef
> prerequisite-patch-id: 54dff8d31eca386fe3e0f90879bf9e98dade94d7

and this

From dcf47a64e364fb3c59561d535325020368644223 Mon Sep 17 00:00:00 2001

Message-ID: <dcf47a64e364fb3c59561d535325020368644223.1720755723.git.zhengjunjie@iscas.ac.cn>

* gnu/packages/graphics.scm (openimageio)[arguments]: Add

fix-OpenImageIOConfig phase.

Change-Id: I0a923c8513069dde5cd3e42fde9279cbd177a10a

---

gnu/packages/graphics.scm | 7 +++++++

1 file changed, 7 insertions(+)

Toggle diff (24 lines)diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 22ef878972..7286d27b27 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -1359,6 +1359,13 @@ (define-public openimageio
                (add-after 'configure 'fix-zlib-version
                  (lambda _
                    (substitute* "include/imageio_pvt.h"
+                     (("#define ZLIB_VERSION \"1\\.3\"")
+                      ""))))
+               (add-after 'install 'fix-OpenImageIOConfig
+                 (lambda _
+                   (substitute* (string-append
+                                 #$output
+                                 "/lib/cmake/OpenImageIO/OpenImageIOConfig.cmake")
                      (("#define ZLIB_VERSION \"1\\.3\"")
                       "")))))))
     (native-inputs

base-commit: 50243774824597dbd141a074a7be0117dc450cef
prerequisite-patch-id: 54dff8d31eca386fe3e0f90879bf9e98dade94d7
prerequisite-patch-id: 2499d00ec9751650f8167724c59570ecbf99820d
-- 
2.45.2

Ricardo Wurmus wrote on 12 Jul 17:18 +0200

[core-updates] OpenImageIO fails to build

Recipients:(address . 72046-done@debbugs.gnu.org)

Message-ID:87ttgu63lw.fsf@elephly.net

Thank you for the additional patches. I've applied them and confirm

that Blender now builds fine.

Ricardo

Closed

Leo Famulari wrote on 12 Jul 23:15 +0200

Recipients:(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)(address . 72046@debbugs.gnu.org)

Message-ID:826f9e5c-6419-4f45-a084-590c5809705f@app.fastmail.com

On Thu, Jul 11, 2024, at 11:32, Leo Famulari wrote:

Toggle quote (16 lines)> On Thu, Jul 11, 2024 at 11:25:34PM +0800, Zheng Junjie wrote:
>> > So, it's a problem with cmake?
>> >
>> > Do you know if they've fixed it in later versions?
>> 
>> see https://gitlab.kitware.com/cmake/cmake/-/issues/25200
>
> Thanks!
>
>> > Would this remove zlib support from openimageio?
>> 
>> no, just fix macro OIIO_ALL_BUILD_DEPS_FOUND to a right string.
>
> Okay, great. I confirm your patch fixes the problem. I'll push it to
> core-updates on your behalf.

I made a mistake when I thought that this first revision of the patch fixed the build. I'm not sure what I did wrong, but I'm sorry to cause confusion.

Leo

Toggle quote (3 lines)

> Attachments:

> * signature.asc

Your comment

This issue is archived.

To comment on this conversation send an email to 72046@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 72046

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date