(file-name->module-name (location-file (package-location pkg))) returns wrong module

Tomas Volf wrote on 7 Jul 18:16 +0200

Recipients:(address . bug-guix@gnu.org)

Message-ID:Zoq_SpbfnQSd4S-1@ws

Hi,

when I try to use the above, it returns wrong module. The module returned is

prefixed by #{.}# symbol. Full reproducer:

(define-module (xx)

#:use-module (guix)

#:use-module (guix modules)

#:use-module (guix utils))

(define-public pkg

(package

(name "foo")

(version #f)

(source #f)

(build-system #f)

(synopsis #f)

(description #f)

(license #f)

(home-page #f)))

(pk (file-name->module-name (location-file (package-location pkg))))

Now just run it:

$ GUILE_AUTO_COMPILE=0 guile -L . -c '(use-modules (xx))'

;;; ((#{.}# xx))

Notice that the module is not just (xx) as it should have been.

The impact of this bug is broken guix pull for my channel (I will work around it

somehow, I hope) but still it would be nice if it worked properly, hence this report.

Have a nice day,

Tomas Volf

There are only two hard things in Computer Science:

cache invalidation, naming things and off-by-one errors.

Ludovic Courtès wrote on 18 Jul 17:34 +0200

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 71979-done@debbugs.gnu.org)

Message-ID:87ed7qvhn3.fsf@gnu.org

Hi Tomas,

Tomas Volf <~@wolfsden.cz> skribis:

Toggle quote (29 lines)> when I try to use the above, it returns wrong module.  The module returned is
> prefixed by #{.}# symbol.  Full reproducer:
>
>     (define-module (xx)
>       #:use-module (guix)
>       #:use-module (guix modules)
>       #:use-module (guix utils))
>
>     (define-public pkg
>       (package
>         (name "foo")
>         (version #f)
>         (source #f)
>         (build-system #f)
>         (synopsis #f)
>         (description #f)
>         (license #f)
>         (home-page #f)))
>
>     (pk (file-name->module-name (location-file (package-location pkg))))
>
> Now just run it:
>
>     $ GUILE_AUTO_COMPILE=0 guile -L . -c '(use-modules (xx))'
>
>     ;;; ((#{.}# xx))
>
> Notice that the module is not just (xx) as it should have been.

Oh, good catch.

I went ahead and pushed a fix as

e3dfed59d39ac60dd2e2b9ef9f4ef63a2a081f41. Let me know if you find

anything wrong!

Thanks,

Ludo’.

Closed

Tomas Volf wrote on 18 Jul 23:21 +0200

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 71979@debbugs.gnu.org)

Message-ID:ZpmHXCnJIhmjFftx@ws

Hello Ludo',

On 2024-07-18 17:34:08 +0200, Ludovic Courtès wrote:

Toggle quote (39 lines)> Hi Tomas,
>
> Tomas Volf <~@wolfsden.cz> skribis:
>
> > when I try to use the above, it returns wrong module.  The module returned is
> > prefixed by #{.}# symbol.  Full reproducer:
> >
> >     (define-module (xx)
> >       #:use-module (guix)
> >       #:use-module (guix modules)
> >       #:use-module (guix utils))
> >
> >     (define-public pkg
> >       (package
> >         (name "foo")
> >         (version #f)
> >         (source #f)
> >         (build-system #f)
> >         (synopsis #f)
> >         (description #f)
> >         (license #f)
> >         (home-page #f)))
> >
> >     (pk (file-name->module-name (location-file (package-location pkg))))
> >
> > Now just run it:
> >
> >     $ GUILE_AUTO_COMPILE=0 guile -L . -c '(use-modules (xx))'
> >
> >     ;;; ((#{.}# xx))
> >
> > Notice that the module is not just (xx) as it should have been.
>
> Oh, good catch.
>
> I went ahead and pushed a fix as
> e3dfed59d39ac60dd2e2b9ef9f4ef63a2a081f41.  Let me know if you find
> anything wrong!

Thank you for the fix. I can confirm (using the original reproducer) that it

works when run from guix repl:

$ GUILE_AUTO_COMPILE=0 guix repl -qL .

GNU Guile 3.0.9

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.

This program is free software, and you are welcome to redistribute it

under certain conditions; type `,show c' for details.

Enter `,help' for help.

scheme@(guix-user)> ,use (xx)

;;; ((xx))

However there seem to be few more edge cases that are still not working.

Dot multiple times:

$ GUILE_AUTO_COMPILE=0 guix repl -qL ././.

GNU Guile 3.0.9

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.

This program is free software, and you are welcome to redistribute it

under certain conditions; type `,show c' for details.

Enter `,help' for help.

scheme@(guix-user)> ,use (xx)

;;; ((#{.}# #{.}# xx))

Double-dot:

$ GUILE_AUTO_COMPILE=0 guix repl -qL ../tmp

GNU Guile 3.0.9

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.

This program is free software, and you are welcome to redistribute it

under certain conditions; type `,show c' for details.

Enter `,help' for help.

scheme@(guix-user)> ,use (xx)

;;; ((.. tmp xx))

Should I report those as separate bugs? Or do you think I should just re-open

this one?

Side-note: I have to say I am confused about behavior of guix repl with

/dev/stdin. Everything seems to work there:

$ echo '(use-modules (xx))' | GUILE_AUTO_COMPILE=0 guix repl -L . /dev/stdin

;;; ((xx))

$ echo '(use-modules (xx))' | GUILE_AUTO_COMPILE=0 guix repl -L ././. /dev/stdin

;;; ((xx))

$ echo '(use-modules (xx))' | GUILE_AUTO_COMPILE=0 guix repl -L ../tmp /dev/stdin

;;; ((xx))

I have no idea why. I would also try -c as I did in my original reproduces, but

guix repl does not support it (I wonder why).

For completeness' sake I am including original message I wrote before trying

`guix repl' and therefore writing the above text instead:

However I am unsure whether it works. I pulled the Guix channel:

$ guix describe

Generation 1 Jul 18 2024 18:44:20 (current)

guix e3dfed5

repository URL: https://git.savannah.gnu.org/git/guix.git

branch: master

commit: e3dfed59d39ac60dd2e2b9ef9f4ef63a2a081f41

As far as I can tell that commit should include your fix (or even better, that

commit is your fix). However when I try the reproducer from the original bug

report, I am still getting:

$ GUILE_AUTO_COMPILE=0 guile -L . -c '(use-modules (xx))'

;;; ((#{.}# xx))

Toggle quote (4 lines)

> Thanks,

> Ludo’.

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

Your comment

This issue is archived.

To comment on this conversation send an email to 71979@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 71979

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date