[PATCH] ui: Write down the unwritten rule.

  • Done
  • quality assurance status badge
Details
3 participants
  • jgart
  • Ludovic Courtès
  • Tomas Volf
Owner
unassigned
Submitted by
Tomas Volf
Severity
normal
T
T
Tomas Volf wrote on 27 Jun 13:44 +0200
(address . guix-patches@gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
a2ddbb6ee340a4b9fd1e638aed2827d045011aca.1719488650.git.~@wolfsden.cz
Quote from Ludovic:

Toggle quote (3 lines)
> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]

This commit turns it into a written rule.

* guix/ui.scm: Document the import policy.

Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
guix/ui.scm | 4 ++++
1 file changed, 4 insertions(+)

Toggle diff (17 lines)
diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
;;; You should have received a copy of the GNU General Public License
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
(define-module (guix ui)
#:use-module (guix i18n)
#:use-module (guix colors)
--
2.45.1
J
J
jgart wrote on 29 Jun 08:47 +0200
(address . 71793@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
87a5j4nt2f.fsf@dismail.de
Toggle quote (3 lines)
> Quote from Ludovic:
>

Hi Tomas,

Can you link me to the places where you are quoting that from? Thanks!

all best,

jgart
T
T
Tomas Volf wrote on 29 Jun 20:43 +0200
(name . jgart)(address . jgart@dismail.de)(address . 71793@debbugs.gnu.org)
ZoBV119O57sjZg_S@ws
On 2024-06-29 01:47:52 -0500, jgart wrote:
Toggle quote (8 lines)
>
> > Quote from Ludovic:
> >
>
> Hi Tomas,
>
> Can you link me to the places where you are quoting that from? Thanks!

Yes sure, it was given as a reason to not merge patch #2 in 70839:

It is always possible I just misunderstood.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmaAVdcACgkQL7/ufbZ/
wam3NxAAl468G7QHcZcohHDQBeC47UbSPwAQ6vfN5h4VyVtO31jARK6KHRZ4BwYn
NNPDaNz2PBliKuE4J0KkMmup8/U0Fm1Rlup1VEJd+x1q2X2VgtmsyMmbHdQV3NnS
znwMkK5RzFZ46uBtKieTd5UtIXYWOfFwxtyAyp6nKHTvKnxWK6pu3QIvzg96mBrk
D2/C/rWgA9ZCI00apWLW9+8hfIfyDMdzA+eodzuRCvz04uEIhZJPy/EJNvh62j7j
9gkMrC3StV+oQ+YCsEHPO8NKMnxmjsZEVOP1AA9w+PxKMBHBYeygOR5/sfVGye2+
BNXwd4Y+46wGMFwv3LLVIUvo3KM+l6baadByUxy+MJdl/QS3YP6q9aBFv1kz3y7b
woC0tr13UhJqiOT5tUAGN35qA2InbfR/+dElZElZ2FCUVFoY1n8MITmdJKhSLsp/
pD3FxVtf+5Yn99EKdIbUWCPDSOVuvC362mAroiQ/l/mD8DQbSSaLKp9vJsn5iPn0
zEymYFvKit+AMpeF6b/YlPxlkh39WPYMH0NHuZ8E7XgPtNlcm42Zdd+6ErJAqN37
pOM0TGjnk/WIpMII1KfMyW0hnVabXwc26Ig+AXR+TT4hy9K3+r0g8CYZvxdiWTdN
zVUkJ390iVUROPSFRe3hAhdteJDkE3UKLX13LCaVROPBGzBR0w4=
=2+yq
-----END PGP SIGNATURE-----


L
L
Ludovic Courtès wrote on 4 Sep 15:56 +0200
Re: [bug#71793] [PATCH] ui: Write down the unwritten rule.
(name . Tomas Volf)(address . ~@wolfsden.cz)
87o753cykj.fsf@gnu.org
Hi,

Tomas Volf <~@wolfsden.cz> skribis:

Toggle quote (11 lines)
> Quote from Ludovic:
>
>> [..] there’s the unwritten rule that non-UI modules should not load (guix
>> ui) [..]
>
> This commit turns it into a written rule.
>
> * guix/ui.scm: Document the import policy.
>
> Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2

I committed a variant of this patch, thanks.

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 71793@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 71793
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch