[PATCH] gnu: guile-ncurses unicode fix

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • tmarjeski
Owner
unassigned
Submitted by
tmarjeski
Severity
normal
T
T
tmarjeski wrote on 27 May 17:34 +0200
(address . guix-patches@gnu.org)
87r0dnp8tk.fsf@gmail.com
From 10c8622694ce0c6141b5a827e4ffddcd47f9d4b8 Mon Sep 17 00:00:00 2001
From: Trevor Arjeski <tmarjeski@gmail.com>
Date: Mon, 27 May 2024 18:22:33 +0300
Subject: [PATCH] gnu: guile-ncurses: fix configure-flags for unicode build

The flag "--with-ncursesw" doesn't seem to exist for guile-ncurses, and it
seemed to cause the build to not include unicode support. Building without it
produces the expected "with ncursesw" support.

This can be checked within the guile REPL using:
Toggle quote (3 lines)
> ,use (ncurses curses)
> %wide-ncurses
> #t ; has unicode and wide char support
---
gnu/packages/guile-xyz.scm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 44b4118e0a..8276380fc3 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2718,8 +2718,7 @@ (define-public guile-ncurses
(guix build utils))
#:imported-modules ((guix build guile-build-system)
,@%gnu-build-system-modules)
- #:configure-flags (list "--with-ncursesw" ; Unicode support
- "--with-gnu-filesystem-hierarchy")
+ #:configure-flags (list "--with-gnu-filesystem-hierarchy")
#:phases
(modify-phases %standard-phases
(add-before 'build 'fix-libguile-ncurses-file-name
--
2.45.1
T
T
tmarjeski wrote on 2 Jun 10:18 +0200
(address . 71228@debbugs.gnu.org)
87y17niwpc.fsf@trevarch.mail-host-address-is-not-set
Hi folks,
I recieved an email about someone else wanting this change and was
wondering if it could be looked at.

Thanks!
L
L
Ludovic Courtès wrote on 11 Jul 12:43 +0200
(address . tmarjeski@gmail.com)(address . 71228-done@debbugs.gnu.org)
87jzhs1a5k.fsf@gnu.org
Hi,

tmarjeski@gmail.com skribis:

Toggle quote (14 lines)
>>From 10c8622694ce0c6141b5a827e4ffddcd47f9d4b8 Mon Sep 17 00:00:00 2001
> From: Trevor Arjeski <tmarjeski@gmail.com>
> Date: Mon, 27 May 2024 18:22:33 +0300
> Subject: [PATCH] gnu: guile-ncurses: fix configure-flags for unicode build
>
> The flag "--with-ncursesw" doesn't seem to exist for guile-ncurses, and it
> seemed to cause the build to not include unicode support. Building without it
> produces the expected "with ncursesw" support.
>
> This can be checked within the guile REPL using:
>> ,use (ncurses curses)
>> %wide-ncurses
>> #t ; has unicode and wide char support

I tweaked the commit log to match our conventions and finally applied
it, thank you!

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 71228@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 71228
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch