Update vcmi to 1.5.1

  • Done
  • quality assurance status badge
Details
2 participants
  • 宋文武
  • Vagrant Cascadian
Owner
unassigned
Submitted by
Vagrant Cascadian
Severity
normal

Debbugs page

Vagrant Cascadian wrote 10 months ago
(address . guix-patches@gnu.org)
87fru8p2we.fsf@wireframe
Updated vcmi. Needed to disable a feature that requires an embedded copy
of innoextract via git submodules. Would require significant reworking
to use the guix-shipped innoextract.

Have not actually play-tested yet, but will get to that...

live well,
vagrant
From b202245d60130728b861df08a79e2450cd778ad3 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Thu, 23 May 2024 14:23:47 -0700
Subject: [PATCH] gnu: vcmi: Update to 1.5.1.

* gnu/packages/games.scm (vcmi): Update to 1.5.1.
[#:configure-flags]: Disable use of embedded innoextract.
---
gnu/packages/games.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (31 lines)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 03a36a8a6d..73d1ffc008 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -11467,7 +11467,7 @@ (define-public fheroes2
(define-public vcmi
(package
(name "vcmi")
- (version "1.4.5")
+ (version "1.5.1")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -11476,11 +11476,11 @@ (define-public vcmi
(file-name (git-file-name name version))
(sha256
(base32
- "1z4vy3drj6dra8rb243pyryr61jnlw3l7yxsxwl9rddv8cdk69lz"))
+ "1s3a23p9k081ccbkhvifx2rhg6rv82fkrsbjh6allmmsa1lhq6fd"))
(patches (search-patches "vcmi-disable-privacy-breach.patch"))))
(build-system cmake-build-system)
(arguments
- (list #:configure-flags #~(list "-DFORCE_BUNDLED_FL=OFF")
+ (list #:configure-flags #~(list "-DFORCE_BUNDLED_FL=OFF" "-DENABLE_INNOEXTRACT=OFF")
;; Test suites do not seem well supported upstream and are disabled by default.
;; Pass -DENABLE_TEST to configure to enable.
#:tests? #f))

base-commit: 9901416233867233192b63fde7f616751127b189
--
2.39.2
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZk/GEQAKCRDcUY/If5cW
qoOJAPwKjpnS7VyjUj/avdI7PJ4asdS4g4b5PWBZNqr1q9aZ2QEAl1CUyKWIef+6
Oh/Cj3LC0un3GiQVEIccpFMYK/fgfQ0=
=Nd5d
-----END PGP SIGNATURE-----

宋文武 wrote 10 months ago
(name . Vagrant Cascadian)(address . vagrant@debian.org)
87v833ha9n.fsf@envs.net
Vagrant Cascadian <vagrant@debian.org> writes:

Toggle quote (4 lines)
> Updated vcmi. Needed to disable a feature that requires an embedded copy
> of innoextract via git submodules. Would require significant reworking
> to use the guix-shipped innoextract.

Look good to me, please push, thank you!
Vagrant Cascadian wrote 10 months ago
(name . 宋文武)(address . iyzsong@envs.net)
874jalproq.fsf@wireframe
On 2024-05-24, 宋文武 wrote:
Toggle quote (8 lines)
> Vagrant Cascadian <vagrant@debian.org> writes:
>
>> Updated vcmi. Needed to disable a feature that requires an embedded copy
>> of innoextract via git submodules. Would require significant reworking
>> to use the guix-shipped innoextract.
>
> Look good to me, please push, thank you!

Thanks for the review!

Pushed as 94c8cec99969fe9f65777637fde1f05e1c576a3f.

live well,
vagrant
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZlJIlQAKCRDcUY/If5cW
qsi7AQDInnuRSsUYpJsiFhwnV3GPGKrIAi5IS1vZBI60uUP/mwEA5BlGttn/Rjf1
TIWkwBugP2mHqR3wQg8c9bTTTob6oAM=
=n/rg
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 71155@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 71155
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help