Emacs packages that override built-in features ignored when compiled

  • Open
  • quality assurance status badge
Details
3 participants
  • Jelle Licht
  • Nicolas Graves
  • Simon Tournier
Owner
unassigned
Submitted by
Jelle Licht
Severity
normal

Debbugs page

Jelle Licht wrote 10 months ago
(address . bug-guix@gnu.org)
87ttiudkhv.fsf@fsfe.org
Hi all,

What I think happens is that Emacs code that is compiled against an
(Emacs) feature that is available as both a built-in and provided
(propagated) input seems to 'compile' Emacs code against the built-in
version.

Case in point:
Built-in jsonrpc feature for Emacs 29.3 has the following slot:
-events-buffer-scrollback-size t 'eieio--unbound

The version of jsonrpc as packaged in emacs-jsonrpc (and also propagated by
our emacs-eglot package):
-events-buffer-config t '(:size nil :format full)

Reproducer:

Run:

guix shell --container --preserve=TERM emacs emacs-eglot -- emacs -nw -Q,
`M-x describe-symbol` -> jsonrpc-connection -> notice that the help
buffer lists the details from the built-in jsonrpc class, while the link
to "jsonrpc.el" at the top of the *Help* buffer links (correctly) to the
more recent version (as propagated by emacs-eglot), which makes me think
it's not a load-path issue.

AFAICT this means that we will run into issues once a library
(e.g. emacs-eglot) starts depending on slots present in the (propagated)
emacs-jsonrpc, but not the built-in jsonrpc version.

Thanks,
- Jelle
Nicolas Graves wrote 2 months ago
(address . liliana.prikler@gmail.com)
87plktvced.fsf@ngraves.fr
Hi Jelle,

I think this issue is fixed with the patches in 67292. Can you try them
and merge or close this issue after that? Thanks!

--
Best regards,
Nicolas Graves
Simon Tournier wrote 2 days ago
control message for bug #71065
(address . control@debbugs.gnu.org)
87senkkgsw.fsf@gmail.com
tags 71065 + moreinfo
quit
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 71065@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 71065
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help