[PATCH 0/9] Update fzf to 0.52.1

Hi Guix,

this patch series updates fzf to version 0.52.1. In the process, I had to

update the go version of some depending libraries, which resulted in some

other packages failing to build. I tried to fix all related packages, but the

amount of changes came to a point where I think I'll have missed some

more. I'm hoping guix ci to help me with this, as I'm willing to fix them all

myself.

*** BLURB HERE ***

Luis Higino (9):

gnu: Add go-github-com-charlievieth-fastwalk.

gnu: aerc: Update go version.

gnu: vale: Update go version.

gnu: senpai: Update go version.

gnu: chezmoi: Update go version.

gnu: games.scm: Update go versions.

gnu: golang-xyz.scm: Update go versions.

gnu: golang.scm: Update packages and go versions.

gnu: go-github-com-junegunn-fzf: Update to 0.52.1.

gnu/packages/configuration-management.scm | 67 +++++++++----------

gnu/packages/games.scm | 8 ++-

gnu/packages/golang-xyz.scm | 6 +-

gnu/packages/golang.scm | 78 +++++++++++++++++------

gnu/packages/mail.scm | 3 +-

gnu/packages/messaging.scm | 1 +

gnu/packages/terminals.scm | 15 +++--

gnu/packages/textutils.scm | 1 +

8 files changed, 120 insertions(+), 59 deletions(-)

base-commit: e4ee595999a3b0656f416d190b28ec6f1ad8a74d

--

2.41.0

Change-Id: Id51606ed3934c5ec46616d1c1d6db2f6c1e8124c

---

gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

Change-Id: I3a078f8b472c285429a8ada91480aebb01a19178

---

gnu/packages/mail.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Change-Id: I60b3bba02eb7a764c62fb2b8c0abc9a73e2be18b

---

gnu/packages/textutils.scm | 1 +

1 file changed, 1 insertion(+)

Change-Id: Ieafbc1d9bdc08233a7ea15189961975c8a98b8a6

---

gnu/packages/messaging.scm | 1 +

1 file changed, 1 insertion(+)

Change-Id: Iac2d344a4b48fc9296528bee84a59598ff45c61b

---

gnu/packages/configuration-management.scm | 67 ++++++++++++-----------

1 file changed, 35 insertions(+), 32 deletions(-)

Change-Id: I090bb7a41a9e42002a14ca509fc7292d609045cf

---

gnu/packages/games.scm | 8 ++++++--

1 file changed, 6 insertions(+), 2 deletions(-)

Change-Id: Ifc851b05d7c4d7fbb274e0753b562bc03103e040

---

gnu/packages/golang-xyz.scm | 6 ++++--

1 file changed, 4 insertions(+), 2 deletions(-)

Change-Id: Ib9532428ad4d5a4d6a480a4651ee7ffc70d0b059

---

gnu/packages/golang.scm | 52 +++++++++++++++++++++++++++--------------

1 file changed, 34 insertions(+), 18 deletions(-)

Change-Id: Ib2bdec1cd31dd7f848edb938399a93b40599fb09

---

gnu/packages/terminals.scm | 15 +++++++++++----

1 file changed, 11 insertions(+), 4 deletions(-)

Hi,

Thank you for the patches.

From the first glance, some of the changes need to be grouped as single commit

- [PATCH 8/9] gnu: golang.scm: Update packages and go versions.

A general cement to all of them - is everything related just to bump fzf

to the latest version or it's a collection of not related patches?

I'm on the way to update valve to the latest version which is quite a

massive change in dependencies tree.

Also try to avoid adding any new packages to golang.scm.

--

Oleg

Hi Oleg,

thanks for the feedback! I didn't know it was OK to group commits,

do you think all commits before the last one should be grouped?

So, to upgrade fzf I had to update some of its dependencies and,

due to it, had to update their go versions from 17 to 18. When I

checked if any other dependent packages were affected with =guix

refresh=, it showed to me that the packages were not building

because they were compiled with Go 17 and it seems the

=go-build-system= vendorizes all package dependencies before

building. I tried fixing only the packages that were broken, so I

guess they are all related in that sense. I'm totally open to

being convinced otherwise though :)

OK, I read some other packages there and it seemed to me that

=fastwalk= was similar in nature to the ones near it (where I

inserted it). Should I move it to =golang-xyz.scm= instead?

--

Luis H. Higino

Hello,

I think there has been some misunderstanding, it is the other way round:

Every package change needs its own commit, even if they are in the same

file. So commit 8/9 should be split into several ones.

When doing so, you may wish to use the ./etc/committer.scm script in the

source tree: Update a package and run the script, which often creates a

good commit.

Updating many packages at the same time can become a bit unwieldy; it

might be easier to update in smaller chunks, starting with only some

dependencies (if this is possible depends of course on how entangled

the situation is).

Andreas

Are you still working on this Luis? I would love to see fzf being updated (there's 0.54.1 now), the version 0.41 we currently is ancient and lacks many features, whcih sometimes makes it hard to re-use some of the many fzf ressources provided by the community in the wiki. Among other things, newer versions of fzf support sizel, which is a game changer if you are a terminal person who wants to preview files from there.

I have tried myself to update fzf before seeing your patch here, and failed miserably.