[BUG] Fail to buidl latest kitty

Open

Details

3 participants

Edison Ibáñez
Lucy Coleclough
Sharlatan Hellseher

Owner: unassigned

Submitted by: Edison Ibáñez

Severity: normal

Edison Ibáñez wrote on 17 May 14:43 +0200

Recipients:(address . bug-guix@gnu.org)

Message-ID:238cac50f9d0de7b468d977f96883e5d@riseup.net

Greetings, I am trying to update Kitty to the latest available version,

I already have the dependencies in golang solved, but when trying to

build gives the following error:

Toggle snippet (43 lines)[117/120] Compiling kitty/monotonic.c ...
[118/120] Compiling kitty/simd-string-128.c ...
[119/120] Compiling kitty/simd-string-256.c ...
[120/120] Compiling kitty/gl-wrapper.c ...
 done
[1/5] Linking kitty/fast_data_types ...
[2/5] Linking [x11] kitty/glfw-x11 ...
[3/5] Linking [wayland] kitty/glfw-wayland ...
[4/5] Linking kittens/transfer/rsync ...
[5/5] Linking launcher ...
 done
../github.com/alecthomas/chroma/v2/lexers/lexers.go:10:12: pattern
embedded: cannot embed directory embedded: contains no embeddable files
../github.com/alecthomas/chroma/v2/styles/api.go:11:12: pattern *.xml:
cannot embed irregular file abap.xml
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "python3" arguments: ("setup.py"
"linux-package" "--update-check-interval=0"
"--egl-library=/gnu/store/szs3c3l2bq4d7p17aixk2llffacpx7xd-mesa-24.0.4/lib/libEGL.so.1")
exit-status: 1 term-signal: #f stop-signal: #f> 
phase `build' failed after 23.6 seconds
command "python3" "setup.py" "linux-package" "--update-check-interval=0"
"--egl-library=/gnu/store/szs3c3l2bq4d7p17aixk2llffacpx7xd-mesa-24.0.4/lib/libEGL.so.1"
failed with status 1

Some deprecated features have been used.  Set the environment
variable GUILE_WARN_DEPRECATED to "detailed" and rerun the
program to get more information.  Set it to "no" to suppress
this message.
builder for
`/gnu/store/xmrkmglpgr93dz3many5amsd53f6z0rb-kitty-next-0.34.1-0.b3cc5ae.drv'
failed with exit code 1
build of
/gnu/store/xmrkmglpgr93dz3many5amsd53f6z0rb-kitty-next-0.34.1-0.b3cc5ae.drv
failed
View build log at
'/var/log/guix/drvs/xm/rkmglpgr93dz3many5amsd53f6z0rb-kitty-next-0.34.1-0.b3cc5ae.drv.gz'.
guix package: error: build of
`/gnu/store/xmrkmglpgr93dz3many5amsd53f6z0rb-kitty-next-0.34.1-0.b3cc5ae.drv'
failed

See chroma and Kitty's repos, but apparently the error is not there,

this can be a Guix problem, attached the definition of the package that

I am trying to build.

Thanks

Attachment: terminals.scm (.02 MiB)

Sharlatan Hellseher wrote on 21 May 22:51 +0200

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:87y18299cy.fsf@gmail.com

Hi Edison,

Thanks for reporting.

May you provide which commit you are on please?

Toggle snippet (2 lines)

guix describe

Sharlatan Hellseher wrote on 21 May 22:53 +0200

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:87seya999g.fsf@gmail.com

I could not reproduce it.

Toggle snippet (29 lines)(guix/linux-gnu)[sharlatan@guxtil ~]$: guix build kitty
substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
3.1 MB will be downloaded:
  /gnu/store/7h55d9yghc72q5lc43lrly9rvl59x39v-kitty-0.21.2
substituting /gnu/store/7h55d9yghc72q5lc43lrly9rvl59x39v-kitty-0.21.2...
downloading from https://bordeaux.guix.gnu.org/nar/lzip/7h55d9yghc72q5lc43lrly9rvl59x39v-kitty-0.21.2 ...
 kitty-0.21.2  2.9MiB                                                                                                                                                                                                                   5.3MiB/s 00:01 ???????????????????? 100.0%

The following graft will be made:
   /gnu/store/4izr3alrcnacspq4i55mvgc9axbmfbfd-kitty-0.21.2.drv
applying 20 grafts for kitty-0.21.2 ...
grafting '/gnu/store/7h55d9yghc72q5lc43lrly9rvl59x39v-kitty-0.21.2' -> '/gnu/store/9n4nnswkk844m1mhpzh6s3ndqwx4zr88-kitty-0.21.2'...
successfully built /gnu/store/4izr3alrcnacspq4i55mvgc9axbmfbfd-kitty-0.21.2.drv
/gnu/store/9n4nnswkk844m1mhpzh6s3ndqwx4zr88-kitty-0.21.2
(guix/linux-gnu)[sharlatan@guxtil ~]$: guix describe
Generation 24   May 21 2024 16:59:57    (current)
  guix 3fd9f25
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 3fd9f25bb385723c70d0bd6af21aeaf784d08049
(guix/linux-gnu)[sharlatan@guxtil ~]$: guix build kitty --check
The following graft will be made:
   /gnu/store/4izr3alrcnacspq4i55mvgc9axbmfbfd-kitty-0.21.2.drv
applying 20 grafts for kitty-0.21.2 ...
grafting '/gnu/store/7h55d9yghc72q5lc43lrly9rvl59x39v-kitty-0.21.2' -> '/gnu/store/9n4nnswkk844m1mhpzh6s3ndqwx4zr88-kitty-0.21.2'...
successfully built /gnu/store/4izr3alrcnacspq4i55mvgc9axbmfbfd-kitty-0.21.2.drv
successfully built /gnu/store/4izr3alrcnacspq4i55mvgc9axbmfbfd-kitty-0.21.2.drv
/gnu/store/9n4nnswkk844m1mhpzh6s3ndqwx4zr88-kitty-0.21.2

Edison Ibáñez wrote on 21 May 23:25 +0200

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:02702298c44a051efc9167d9c0d26787@riseup.net

Thanks for answering

Toggle snippet (13 lines)

Generation 568 May 21 2024 09:08:53 (current)

nonguix 34935b4

repository URL: https://gitlab.com/nonguix/nonguix

branch: master

commit: 34935b49ae20d236b0fc89943f0b1d0d5dea3a33

guix 3fd9f25

repository URL: https://git.savannah.gnu.org/git/guix.git

branch: master

commit: 3fd9f25bb385723c70d0bd6af21aeaf784d08049

GUIX_PACKAGE_PATH="/home/arkhan/.guix-pkgs"

I am trying to update kitty to version 0.34.1, the version found in the
repositories installs without problems, I attach again the definition I
am using.

Attachment: terminals.scm (.02 MiB)

Lucy Coleclough wrote on 22 May 14:27 +0200

[BUG] Fail to buidl latest kitty

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:76be3bf9-f57f-f1b8-10f6-3c17e2a902a3@gmail.com

I believe go-github-com-alecthomas-chroma-v2-13 is being compiled at the 
moment of failure no?
I am new to go and it~s compilation, perhaps there are no embadable 
files in the embedded directory in chroma/lexers/ because they all 
produce the same problem that abap.xml does.
Perhaps it is due to permissions, I could not find the "cannot embed 
irregular file" error quickly from a search engine search but will look 
again.

Lucy Coleclough wrote on 22 May 19:19 +0200

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:d3309268-8e2b-d4cb-95b1-1faa7ba6b6c2@gmail.com

OK yep that was fixed by making the symlinks at

src/github.com/alecthomas/chroma/v2/** into copys

Now there is this error as attached in error.log

i have attached the rough file that copys symlinks

Attachment: error.log

Attachment: terminals.scm

Edison Ibáñez wrote on 23 May 03:49 +0200

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:d05f7cbdf4c0808b9f1bf552c66e5192@riseup.net

Thank you, but I had to create a patch so as not to compile the

documentation, since it depends on several Python bookstores.

Attached the file with the final definition and the patch

Attachment: terminals.scm (.02 MiB)

From 6c314ab4acfe208dc3303debdb6ab1ed6a73436c Mon Sep 17 00:00:00 2001

---

setup.py | 19 +------------------

1 file changed, 1 insertion(+), 18 deletions(-)

Toggle diff (30 lines)diff --git a/setup.py b/setup.py
index 61352c2..560596e 100755
--- a/setup.py
+++ b/setup.py
@@ -1316,24 +1316,7 @@ def create_linux_bundle_gunk(ddir: str, args: Options) -> None:
     base = Path(ddir)
     in_src_launcher = base / (f'{libdir_name}/kitty/kitty/launcher/kitty')
     launcher = base / 'bin/kitty'
-    skip_docs = False
-    if not os.path.exists('docs/_build/html'):
-        kitten_exe = os.path.join(os.path.dirname(str(launcher)), 'kitten')
-        if os.path.exists(kitten_exe):
-            os.environ['KITTEN_EXE_FOR_DOCS'] = kitten_exe
-            make = 'gmake' if is_freebsd else 'make'
-            run_tool([make, 'docs'])
-        else:
-            if args.skip_building_kitten:
-                skip_docs = True
-                print('WARNING: You have chosen to skip building kitten.'
-                      ' This means docs could not be generated and will not be included in the linux package.'
-                      ' You should build kitten and then re-run this build.', file=sys.stderr)
-            else:
-                raise SystemExit(f'kitten binary not found at: {kitten_exe}')
-    if not skip_docs:
-        copy_man_pages(ddir)
-        copy_html_docs(ddir)
+
     for (icdir, ext) in {'256x256': 'png', 'scalable': 'svg'}.items():
         icdir = os.path.join(ddir, 'share', 'icons', 'hicolor', icdir, 'apps')
         safe_makedirs(icdir)

2.41.0

Lucy Coleclough wrote on 23 May 15:57 +0200

[BUG] Fail to buidl latest kitty

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:1f71215b-9831-f0ce-331b-20bafa15bcbb@gmail.com

Ok this works now but needs a lot of cleaning
One issue was that a dependant package `x-exp` needed to be compiled by 
go-1.22
It would probably be good to build them all off 1.22
I apply-ed the patch you sent
The function to make the symlink-s real would be better off as build 
utils or in some other standard location that can be pulled in
Perhaps they could be real-ise-ed in the go build system 
`setup-go-environment` which is where they are created
There are some runtime dependency-s such as libcanberra that are loaded 
with dlopen, they have been pointed to in `( invoke "python" "setup.py" 
...)`, perhaps there is some guix mechanism to give kitty a custom 
environment which allows auto detection with no absolute path.

Attachment: kitty.scm

Attachment: OpenPGP_0x144162DF4AD9D976.asc

Sharlatan Hellseher wrote on 29 Jun 18:14 +0200

Recipients:(address . 71011@debbugs.gnu.org)(name . Lucy Coleclough)(address . coleclough.lucy@gmail.com)

Message-ID:87v81r3evf.fsf@gmail.com

Hi Lucy,

Thank you for your work on trouble shooting the issue. The master has go

1.22 now and I would like to proceed with Kitty update. While updating

other packages requiring "github.com/alecthomas/chroma/v2" I've faced

with the similar issue when it tries to use "embed" from standard

library, see https://pkg.go.dev/embed

Oleg

Lucy Coleclough wrote on 1 Jul 21:49 +0200

Recipients:(address . 71011@debbugs.gnu.org)

Message-ID:cca57a1b-d16c-00ef-9be4-203e136be99d@gmail.com

Hey there Sharlatan
Embed was failing as the go build tree was symlinked
So the file i sent builds because i wrote a procedure to copy the tree
Although it could also be the case that some altered form of linking 
could function or that embed could be altered to accept the existing 
form of the go tree.
the linking occur-s in `setup-go-environment` so some sub function of 
this would see the changes although i do not understand the function and 
have not looked since

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 71011@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 71011

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date