[core-updates] Meson-build system fails to install license

Hi Guix,

I was trying to update a package using meson build system to its newest

version and noticed in the build log

starting phase `install-license-files'

installing 0 license files from '.'

phase `install-license-files' succeeded after 0.0 seconds

Also other packages built using meson don't seem to have license files

in the output.

I think the problem is that the "." directory is the "build" directory

and not the source directory because in meson configure phase we change

directory to the build-dir.

The install-license-files function has an argument for specifying

out-of-source builds and calling it with that set to #t seems to be able

to find license files in the source directory in my limited testing.

Another option would be to specify the build dir in the ninja

invocations without changing to it.

As meson only supports out-of-source builds I think this should be

changed though I am unsure how to best do this.

Hi Dariqq,

Dariqq <dariqq@posteo.net> skribis:

Yes, ‘meson-build-system’ should pass #:out-of-source? #t exactly like

‘cmake-build-system’ does. That should solve the problem.

Thanks,

Ludo’.

Meson currently supports only out-of-source builds. Add the argument out-of-source? with default to #t such that the install-license-files phase searches for the license files in the source directory.

(meson-cross-build): Likewise.

Change-Id: Ib59d9d93b34fd567f05f5f9a10293f6ab924e399

---

I have tested this with the tio package (both natively building and cross compiling) and seems to work. This will cause a lot of rebuild!

For the position of the argument I've put it above build-type to match the order in cmake-build-system.

guix/build-system/meson.scm | 5 ++++-

1 file changed, 4 insertions(+), 1 deletion(-)

retitle 70999 [core-updates] Meson-build system fails to install license

files

quit

Closing as the patch was resent in #71785 assigned to guix-patches and

is now included in core-updates as commit

473590fc4cd9d5a833913ce3f7835eeedcecac21