[PATCH 0/4] gnu: libsecp256k1: Update to 0.5.0.

  • Open
  • quality assurance status badge
Details
One participant
  • Jean-Pierre De Jesus DIAZ
Owner
unassigned
Submitted by
Jean-Pierre De Jesus DIAZ
Severity
normal
J
J
Jean-Pierre De Jesus DIAZ wrote on 15 May 19:55 +0200
(address . guix-patches@gnu.org)(name . Jean-Pierre De Jesus DIAZ)(address . jean@foundation.xyz)
cover.1715795603.git.jean@foundation.xyz
This patch series updates libsecp256k1 to 0.5.0 (latest version),
moves the location of home-page for consistency, removes configuration
flags that are (now) enabled by default on 0.5.0 and also removes some
pre-generated files.

Jean-Pierre De Jesus DIAZ (4):
gnu: libsecp256k1: Update to 0.5.0.
gnu: libsecp256k1: Move home-page field.
gnu: libsecp256k1: Remove features enabled by default.
gnu: libsecp256k1: Remove pre-generated files.

gnu/packages/crypto.scm | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)


base-commit: b31a49cb5ea036a9869f3c2cd40d0f8b99af01f9
--
2.41.0
J
J
Jean-Pierre De Jesus DIAZ wrote on 15 May 20:00 +0200
[PATCH 1/4] gnu: libsecp256k1: Update to 0.5.0.
(address . 70965@debbugs.gnu.org)(name . Jean-Pierre De Jesus DIAZ)(address . jean@foundation.xyz)
0b7261e6181f7063e6eec1838010cb95e9df4760.1715795603.git.jean@foundation.xyz
* gnu/packages/crypto.scm (libsecp256k1): Update to 0.5.0.

Change-Id: I441085a0914f5998fd30d5dbdcc4d8b82f4aa332
---
gnu/packages/crypto.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (33 lines)
diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 9c62689d18..e1b6b4d2ec 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -26,7 +26,7 @@
;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan@selidor.net>
-;;; Copyright © 2023 Foundation Devices, Inc. <hello@foundationdevices.com>
+;;; Copyright © 2023,2024 Foundation Devices, Inc. <hello@foundation.xyz>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1078,7 +1078,7 @@ (define-public enchive
(define-public libsecp256k1
(package
(name "libsecp256k1")
- (version "0.3.2")
+ (version "0.5.0")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -1087,7 +1087,7 @@ (define-public libsecp256k1
(file-name (git-file-name name version))
(sha256
(base32
- "12wksk7bi3yfzmk1zwh5b6846zcaycqz1w4w4p23apjc8da4jwpn"))))
+ "1b5mi1byg46waa7v4z4b4vdhg5zaaaqg2f1vnfsvk0k7wb643k2x"))))
(build-system gnu-build-system)
(arguments
'(#:configure-flags '("--enable-module-recovery"
--
2.41.0
J
J
Jean-Pierre De Jesus DIAZ wrote on 15 May 20:00 +0200
[PATCH 2/4] gnu: libsecp256k1: Move home-page field.
(address . 70965@debbugs.gnu.org)(name . Jean-Pierre De Jesus DIAZ)(address . jean@foundation.xyz)
5f9e78e8c5525ff3ff88fa3d1e99262c79fbe5eb.1715795603.git.jean@foundation.xyz
* gnu/packages/crypto.scm (libsecp256k1) <home-page>: Move above
synopsis.

Change-Id: I3bc91a1eece7c739d77f327094099d3df4d4e38b
---
gnu/packages/crypto.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (22 lines)
diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index e1b6b4d2ec..1f3ec5bb06 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -1099,6 +1099,7 @@ (define-public libsecp256k1
"--disable-benchmark")))
(native-inputs
(list autoconf automake libtool))
+ (home-page "https://github.com/bitcoin-core/secp256k1")
(synopsis "C library for EC operations on curve secp256k1")
(description
"Optimized C library for EC operations on curve secp256k1.
@@ -1118,7 +1119,6 @@ (define-public libsecp256k1
@item Optional module for ECDH key exchange.
@item Optional module for Schnorr signatures according to BIP-340.
@end itemize\n")
- (home-page "https://github.com/bitcoin-core/secp256k1")
(license license:expat)))
(define-public libsecp256k1-bitcoin-cash
--
2.41.0
J
J
Jean-Pierre De Jesus DIAZ wrote on 15 May 20:00 +0200
[PATCH 3/4] gnu: libsecp256k1: Remove features enabled by default.
(address . 70965@debbugs.gnu.org)(name . Jean-Pierre De Jesus DIAZ)(address . jean@foundation.xyz)
318ead792a74218c3bb9ec2c7090acbc05361e62.1715795603.git.jean@foundation.xyz
These features are enabled by default so it doesn't make sense to have
these here.

* gnu/packages/crypto.scm (libsecp256k1) <arguments>: Remove
--enable-module-ecdh and --enable-module-schnorrsig from
configure-flags.

Change-Id: I64935d5c9725e13e8d6c191a30bd79381b630a24
---
gnu/packages/crypto.scm | 2 --
1 file changed, 2 deletions(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 1f3ec5bb06..abc535c0a2 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -1092,8 +1092,6 @@ (define-public libsecp256k1
(arguments
'(#:configure-flags '("--enable-module-recovery"
"--enable-experimental"
- "--enable-module-ecdh"
- "--enable-module-schnorrsig"
"--enable-shared"
"--disable-static"
"--disable-benchmark")))
--
2.41.0
J
J
Jean-Pierre De Jesus DIAZ wrote on 15 May 20:00 +0200
[PATCH 4/4] gnu: libsecp256k1: Remove pre-generated files.
(address . 70965@debbugs.gnu.org)(name . Jean-Pierre De Jesus DIAZ)(address . jean@foundation.xyz)
e12368438778f010de97889d98c8f2b5ad16610f.1715795603.git.jean@foundation.xyz
* gnu/packages/crypto.scm (libsecp256k1) <source>: Remove pre-generated
files.

Change-Id: Iac49ee8c4caedf7bf997f00640f32bab98e25c52
---
gnu/packages/crypto.scm | 6 ++++++
1 file changed, 6 insertions(+)

Toggle diff (19 lines)
diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index abc535c0a2..15d9188769 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -1085,6 +1085,12 @@ (define-public libsecp256k1
(url "https://github.com/bitcoin-core/secp256k1")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
+ (modules '((guix build utils)))
+ (snippet
+ ;; These files are pre-generated, the build system is able to
+ ;; re-generate those.
+ #~(for-each delete-file '("src/precomputed_ecmult.c"
+ "src/precomputed_ecmult_gen.c")))
(sha256
(base32
"1b5mi1byg46waa7v4z4b4vdhg5zaaaqg2f1vnfsvk0k7wb643k2x"))))
--
2.41.0
?