[PATCH] gnu: e2fsprogs: Downgrade to 1.46.6.

  • Done
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Zheng Junjie
Owner
unassigned
Submitted by
Efraim Flashner
Severity
normal
E
E
Efraim Flashner wrote on 13 May 10:10 +0200
(address . guix-patches@gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)
82f6a0c61de3a93c6f44eb017544ccdfdd8a7c68.1715586334.git.efraim@flashner.co.il
1.47.0 would, by default, create an ext4 filesystem which was not
readable by our current version of grub. This should also address a
number of the system test failures.

* gnu/packages/linux.scm (e2fsprogs): Downgrade to 1.46.6.

Change-Id: Ifa6841185ab85d24479f981afc1b42a349716d80
---
gnu/packages/linux.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (33 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 2e0c05b4f7..76c69701b8 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2548,10 +2548,12 @@ (define-public usbip-utils
module.")
(license license:gpl2)))
+;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
+;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
(define-public e2fsprogs
(package
(name "e2fsprogs")
- (version "1.47.0")
+ (version "1.46.6")
(source (origin
(method url-fetch)
(uri (string-append
@@ -2560,7 +2562,7 @@ (define-public e2fsprogs
"e2fsprogs-" version ".tar.xz"))
(sha256
(base32
- "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
+ "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
(build-system gnu-build-system)
(inputs (list `(,util-linux "lib")))
(native-inputs (list pkg-config

base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d
--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
E
E
Efraim Flashner wrote on 27 May 10:44 +0200
Re: bug#70912: Acknowledgement ([PATCH] gnu: e2fsprogs: Downgrade to 1.46.6.)
(address . 70912-done@debbugs.gnu.org)
ZlRH3dD1JN6c7G81@3900XT
Patch applied

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmZUR9kACgkQQarn3Mo9
g1EcbhAAipYrAweZYwyPJ4ZQB7H/LrFP+i8/Bg3VD/VoOn8lnfY2oUZzM1l7+rPK
uHQ3XwJlUEqsNUgEL9enBUA5FWpYML6CEJTJBMi9rekRuCVodnq94Qa0t1zF7xGq
BpUn5HNO8DXMjLM0FQUzKeanIvF6mRhQOHmtpTM7v36F+x+W/QSy6c2nLC6z+EAp
0hK3vAMYwDkaLl/jSGlN0dlgyq5HexQ9zoLuJt3+04o4o8wQSOfjxg4wRIkrgts3
nRRaDaB2w2uYJj0OrpXUoMZE3QuWNZ1iynXd+BvROagyUBzv4oduvArhsQ4jvxLw
wdQtj7WePiFs4xJNuWaLjcUZ3i0MihzVsoKJR3Y78eBXgtSKnJP6gaTVduAUs2vL
kG4m32uIkr5cOCD1sMmz43Tb6AUH87W/9H9m5tr6s7/uZ7hxEB/GbcFvWt2ow/bC
hFtDlPfYHwO1xa+Zoung5DsQRXwI2xSb9HgsDHTENRgZonkUrtfh1Tod8Oe8m4Sl
a3nr/D3kwAA2PUO4Z70z0zYMsptn8yHAfvxVVBBAAQyxYw/QoqP+R7o772ggjW34
gVQ7OvV/BHvStVNbZVFPhNQ6dUi5qTDvV2d7Hljh9ytupSsqZUgrOmZh2WDN16fl
HQbQxTsojB15qFahWxO94vypG50Zd/chw9VPqXEo9zevzDNHwas=
=jDiN
-----END PGP SIGNATURE-----


Closed
Z
Z
Zheng Junjie wrote on 31 May 16:24 +0200
Re: [bug#70912] [PATCH] gnu: e2fsprogs: Downgrade to 1.46.6.
(name . Efraim Flashner)(address . efraim@flashner.co.il)
87cyp2qcth.fsf@iscas.ac.cn
Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (40 lines)
> 1.47.0 would, by default, create an ext4 filesystem which was not
> readable by our current version of grub. This should also address a
> number of the system test failures.
>
> * gnu/packages/linux.scm (e2fsprogs): Downgrade to 1.46.6.
>
> Change-Id: Ifa6841185ab85d24479f981afc1b42a349716d80
> ---
> gnu/packages/linux.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 2e0c05b4f7..76c69701b8 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -2548,10 +2548,12 @@ (define-public usbip-utils
> module.")
> (license license:gpl2)))
>
> +;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
> +;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
> (define-public e2fsprogs
> (package
> (name "e2fsprogs")
> - (version "1.47.0")
> + (version "1.46.6")
> (source (origin
> (method url-fetch)
> (uri (string-append
> @@ -2560,7 +2562,7 @@ (define-public e2fsprogs
> "e2fsprogs-" version ".tar.xz"))
> (sha256
> (base32
> - "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
> + "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
> (build-system gnu-build-system)
> (inputs (list `(,util-linux "lib")))
> (native-inputs (list pkg-config
>
> base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d
hello, this downgrade make my visionfive2 boot fail,

#+begin_src bash

/dev/mmcblk1p3 has unsupported feature(s): FEATURE_C12
e2fsck: Get a newer version of e2fsck!

Guix_image: ********** WARNING: Filesystem still has errors **********

File system check on /dev/mmcblk1p3 failed

#+end_src
i think maybe we should use 1.47.0 and disable metadata_csum_seed by
default, like debian and gentoo?

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmZZ3ZoACgkQO1qpk+Gi
3/BKSRAAgmQ2EmT3O+4+Jrd3g2i6hp0R/r5T0hl5YnflcHjHAXLr8We5U37XRxdD
/A19DCIbsMDfhlyGdHQtIEjAhcT09IhjijOR430SCOUM9dD/sJy3+ctTBoDjbqBa
lsQZyOAs3f21SOTrPXBh2ICFF2Oar8ug9dg+cdsQ82+H0aLoR1XN0ctnn78pJwoB
Y9DMaIai5qhJdK7GrjJ4bdMgGVLa8ekzfhI2DbFXQ/EqfSXtDNEWMAsq175siVLi
d92j/34QzmK9mGgrs3dSWldHYuwLJ3/mLzf+0D+qEzWnM25O37nKNvN7FfnNbkF3
gyP/y6w0Rzo9dO8I7BpyRhJl8X6wK0Tmn4wouJno5anxhxph74FsI9fW/2sHNC4C
gwunThRRLpwIgTnFnmetYpwCzhE9Mf3xSIok0faI7+6SvWGfAwTtktqUzUOsU/qy
vt2L4aM/iqhgYMsp9zO7zqZwViUTPT8abp6H8QnTv6+BFTaXRdJXtDZLPWi05KSi
cy5SjLCSW2m3d0mER54cpO9oCfk6XYp9l82ijL4A+nNtAdUM874U1b0BXukr3tjh
p/ABPkG14yQ08phTSWt9lOEEUs1CONwc3Bc/KPu1rUmwY4hJzvARFprdUAXxss/A
9SRiAD0CuRGYMTzB1mgx1VotaCvK2kVPAdGaxDqy2ISK2itqsNA=
=TMnO
-----END PGP SIGNATURE-----

E
E
Efraim Flashner wrote on 31 May 16:27 +0200
(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)
2D4257E9-21C8-4A1C-9DBB-13C0E11220D2@flashner.co.il
Considering there was a second commit to fix this from the grub side I think we can upgrade e2fsprogs back to 1.47.0. Do you want to do it? I won't be able to for a few days.

On May 31, 2024 2:24:26 PM UTC, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
Toggle quote (60 lines)
>Efraim Flashner <efraim@flashner.co.il> writes:
>
>> 1.47.0 would, by default, create an ext4 filesystem which was not
>> readable by our current version of grub. This should also address a
>> number of the system test failures.
>>
>> * gnu/packages/linux.scm (e2fsprogs): Downgrade to 1.46.6.
>>
>> Change-Id: Ifa6841185ab85d24479f981afc1b42a349716d80
>> ---
>> gnu/packages/linux.scm | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index 2e0c05b4f7..76c69701b8 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -2548,10 +2548,12 @@ (define-public usbip-utils
>> module.")
>> (license license:gpl2)))
>>
>> +;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
>> +;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
>> (define-public e2fsprogs
>> (package
>> (name "e2fsprogs")
>> - (version "1.47.0")
>> + (version "1.46.6")
>> (source (origin
>> (method url-fetch)
>> (uri (string-append
>> @@ -2560,7 +2562,7 @@ (define-public e2fsprogs
>> "e2fsprogs-" version ".tar.xz"))
>> (sha256
>> (base32
>> - "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
>> + "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
>> (build-system gnu-build-system)
>> (inputs (list `(,util-linux "lib")))
>> (native-inputs (list pkg-config
>>
>> base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d
>hello, this downgrade make my visionfive2 boot fail,
>
>#+begin_src bash
>
>/dev/mmcblk1p3 has unsupported feature(s): FEATURE_C12
>e2fsck: Get a newer version of e2fsck!
>
>Guix_image: ********** WARNING: Filesystem still has errors **********
>
>File system check on /dev/mmcblk1p3 failed
>
>#+end_src
>i think maybe we should use 1.47.0 and disable metadata_csum_seed by
>default, like debian and gentoo?
>
>see https://sources.debian.org/data/main/e/e2fsprogs/1.47.0-2/debian/patches/disable-metadata_csum_seed-and-orphan_file-by-default
>and https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=747be80bc0594b776e233912ce517b38d5726891

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Z
Z
Zheng Junjie wrote on 31 May 16:32 +0200
(name . Efraim Flashner)(address . efraim@flashner.co.il)
878qzqqcg6.fsf@iscas.ac.cn
Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

Toggle quote (60 lines)
> Efraim Flashner <efraim@flashner.co.il> writes:
>
>> 1.47.0 would, by default, create an ext4 filesystem which was not
>> readable by our current version of grub. This should also address a
>> number of the system test failures.
>>
>> * gnu/packages/linux.scm (e2fsprogs): Downgrade to 1.46.6.
>>
>> Change-Id: Ifa6841185ab85d24479f981afc1b42a349716d80
>> ---
>> gnu/packages/linux.scm | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index 2e0c05b4f7..76c69701b8 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -2548,10 +2548,12 @@ (define-public usbip-utils
>> module.")
>> (license license:gpl2)))
>>
>> +;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
>> +;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
>> (define-public e2fsprogs
>> (package
>> (name "e2fsprogs")
>> - (version "1.47.0")
>> + (version "1.46.6")
>> (source (origin
>> (method url-fetch)
>> (uri (string-append
>> @@ -2560,7 +2562,7 @@ (define-public e2fsprogs
>> "e2fsprogs-" version ".tar.xz"))
>> (sha256
>> (base32
>> - "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
>> + "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
>> (build-system gnu-build-system)
>> (inputs (list `(,util-linux "lib")))
>> (native-inputs (list pkg-config
>>
>> base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d
> hello, this downgrade make my visionfive2 boot fail,
>
> #+begin_src bash
>
> /dev/mmcblk1p3 has unsupported feature(s): FEATURE_C12
> e2fsck: Get a newer version of e2fsck!
>
> Guix_image: ********** WARNING: Filesystem still has errors **********
>
> File system check on /dev/mmcblk1p3 failed
>
> #+end_src
> i think maybe we should use 1.47.0 and disable metadata_csum_seed by
> default, like debian and gentoo?
>
> see https://sources.debian.org/data/main/e/e2fsprogs/1.47.0-2/debian/patches/disable-metadata_csum_seed-and-orphan_file-by-default
> and https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=747be80bc0594b776e233912ce517b38d5726891

I can continue boot when I exit the Bourne-like REPL, but I have to
enter it manually, which is inconvenient and easily misinterpreted as a
boot failure.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmZZ33kACgkQO1qpk+Gi
3/Cgaw//UrN9tK1tcNUjRLMeuUKOH+Afo4XKBHOYdNLDYJvXmj7g3vH/NXxYqMVc
AwRRejaS3QjAaoJ/I1CUiDg3hNTKBDZPxSlmVNUo1hAv4aFGP/OXUBP03SohRmiY
bkLFK/sDhxqUF9Tg9IxVi1/WRHfVlTCUKzyf8lXQd70Ef+iZ92mT7uMoRU6EaOeV
lDkafJdk9VvVQGSwksrN9xbwfFGQGGdNvlO3eh9x6JWAWGARGYfJOlvit7BoeVPD
gCYQtiuCXoVw+KE7JE5YGtPuD0LLmnd1dI7lTo6MBxrNjVRDCUyXoRCL1pgIEcwY
fL//ws6v8yJ8KxN5KxFBd1bdhW+E1asovCYpiQyc87y4rY9dJJnmdnFOxPE7vD9N
CthhHPeoVt/PnzlDstIrJhbDBKQwpfeNTPZRNyx9/2Q3mF/6SB0Ob7AaletTpl9O
5ZIrv5+09GFfNoCmXTZoFh/e9IouJJTuYtc1+vkcjE6g+nGtVHEzjMPSb+jzhAUF
jN+qvXp0DltGhOfmvDkRzdBPjFX+AovV7kXomfkMSJzs27tK6u41lIkRkLaTWeMj
ETPu2N0dtgBfK9R7cjtq7tDYsZkmMNfVUD/XkcPeOdaosNHe2tmd5UOkdmqAx0l7
v0SXlSHGVp7sVGROOIHAD+CYtUqAidPoQXBfw25oEOBzexYB9uY=
=mHKq
-----END PGP SIGNATURE-----

Z
Z
Zheng Junjie wrote on 31 May 16:56 +0200
(name . Efraim Flashner)(address . efraim@flashner.co.il)
874jaeqbch.fsf@iscas.ac.cn
Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (65 lines)
> Considering there was a second commit to fix this from the grub side I
> think we can upgrade e2fsprogs back to 1.47.0. Do you want to do it? I
> won't be able to for a few days.
>
> On May 31, 2024 2:24:26 PM UTC, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
>>Efraim Flashner <efraim@flashner.co.il> writes:
>>
>>> 1.47.0 would, by default, create an ext4 filesystem which was not
>>> readable by our current version of grub. This should also address a
>>> number of the system test failures.
>>>
>>> * gnu/packages/linux.scm (e2fsprogs): Downgrade to 1.46.6.
>>>
>>> Change-Id: Ifa6841185ab85d24479f981afc1b42a349716d80
>>> ---
>>> gnu/packages/linux.scm | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>>> index 2e0c05b4f7..76c69701b8 100644
>>> --- a/gnu/packages/linux.scm
>>> +++ b/gnu/packages/linux.scm
>>> @@ -2548,10 +2548,12 @@ (define-public usbip-utils
>>> module.")
>>> (license license:gpl2)))
>>>
>>> +;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
>>> +;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
>>> (define-public e2fsprogs
>>> (package
>>> (name "e2fsprogs")
>>> - (version "1.47.0")
>>> + (version "1.46.6")
>>> (source (origin
>>> (method url-fetch)
>>> (uri (string-append
>>> @@ -2560,7 +2562,7 @@ (define-public e2fsprogs
>>> "e2fsprogs-" version ".tar.xz"))
>>> (sha256
>>> (base32
>>> - "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
>>> + "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
>>> (build-system gnu-build-system)
>>> (inputs (list `(,util-linux "lib")))
>>> (native-inputs (list pkg-config
>>>
>>> base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d
>>hello, this downgrade make my visionfive2 boot fail,
>>
>>#+begin_src bash
>>
>>/dev/mmcblk1p3 has unsupported feature(s): FEATURE_C12
>>e2fsck: Get a newer version of e2fsck!
>>
>>Guix_image: ********** WARNING: Filesystem still has errors **********
>>
>>File system check on /dev/mmcblk1p3 failed
>>
>>#+end_src
>>i think maybe we should use 1.47.0 and disable metadata_csum_seed by
>>default, like debian and gentoo?
>>
>>see https://sources.debian.org/data/main/e/e2fsprogs/1.47.0-2/debian/patches/disable-metadata_csum_seed-and-orphan_file-by-default
>>and https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=747be80bc0594b776e233912ce517b38d5726891

I don't have a grub + ext4 machine now, but it seems to me that I should only need to Revert this commit?
From 946991731da55ce5c1c541b1e118340d5a531be4 Mon Sep 17 00:00:00 2001
Message-ID: <946991731da55ce5c1c541b1e118340d5a531be4.1717167184.git.zhengjunjie@iscas.ac.cn>
From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
Date: Fri, 31 May 2024 22:51:04 +0800
Subject: [PATCH] Revert "gnu: e2fsprogs: Downgrade to 1.46.6."

This reverts commit dd8364cfae6f666187eda62684cdbcd704fd9081.

Commit 00384aedbc6a371aaf90ca344a446952fdd5a6b3 let grub ignore
metadata-csum-seed, so we can update to 1.47+.
---
gnu/packages/linux.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (31 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 3129c5a073..0a9b31685d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2640,12 +2640,10 @@ (define-public usbip-utils
module.")
(license license:gpl2)))
-;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
-;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
(define-public e2fsprogs
(package
(name "e2fsprogs")
- (version "1.46.6")
+ (version "1.47.0")
(source (origin
(method url-fetch)
(uri (string-append
@@ -2654,7 +2652,7 @@ (define-public e2fsprogs
"e2fsprogs-" version ".tar.xz"))
(sha256
(base32
- "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
+ "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
(build-system gnu-build-system)
(inputs (list `(,util-linux "lib")))
(native-inputs (list pkg-config

base-commit: 83d29d56f8808ca1f076dda37ef34150d0308e9a
--
2.41.0
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmZZ5Q4ACgkQO1qpk+Gi
3/Cc/A//Uz+WImmVn6d7WFioRuWyWMOfTTRrNq9L5MimIAeELKMdiz9ULB3qubZi
JR7e0uMQGHLiDiGkGwOfXbKy6xcOf/fJaphnxY15E2oePZQ3tmCK1lAZYof7TJL3
SKK4a5ip/3lG6hGpLUEeqFuB2RgKl0hh5XdUkJ92THyXb60C5rxDLCjzgPG8hTiq
TbteHiXSEa9PmB1Sn8jawDSG1ucVNOHZqH51w4AnFrZ1pKIUXKf8ODBV7rXjLW2C
1kbLpCBpzseh0Dj9Rpc3wZWk5fKJtLrW3hSGMsjeyC6SabSY4I7jTjLT3n3OEQRZ
L2WvOqgK8jiC3Ja6VBwH5pYCTE4J5TsMASQ/8asqEE7K9Rqhz5+R2eXSZBj6B6wM
psV/rnxgC4AHhLFVBTKNUdcuPIqzI2va+8toajnitJ2ApyteCiyYGTSU3t78TG/7
8+Zi7YaolIaxXiM25zKMHxqjlPEz8tx3//1bwuD+h4VawaJA8iCGXV3c+09IgDWA
MbgoTKFMncO4WKuKslRIWdyTe3mUuCIOUdhk6ryWafmDqQ361CdUX/4/zeyi2dtZ
XLRQHF7PgPk2xmqgS4OKEqY0iewUYo+vSE4UuDLG4jBlSodgdSrAVUJJA3paUDM0
lcKnx2w5EpUExamSAFdokoANXuY3YMbP6p4S06Fms5JS0R6Dnug=
=kfos
-----END PGP SIGNATURE-----

E
E
Efraim Flashner wrote on 31 May 17:35 +0200
(name . Zheng Junjie)(address . zhengjunjie@iscas.ac.cn)
996DEB00-276E-4600-AF88-BDBDBE7BFD72@flashner.co.il
Yeah, that should take care of it

On May 31, 2024 2:56:14 PM UTC, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
Toggle quote (70 lines)
>Efraim Flashner <efraim@flashner.co.il> writes:
>
>> Considering there was a second commit to fix this from the grub side I
>> think we can upgrade e2fsprogs back to 1.47.0. Do you want to do it? I
>> won't be able to for a few days.
>>
>> On May 31, 2024 2:24:26 PM UTC, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
>>>Efraim Flashner <efraim@flashner.co.il> writes:
>>>
>>>> 1.47.0 would, by default, create an ext4 filesystem which was not
>>>> readable by our current version of grub. This should also address a
>>>> number of the system test failures.
>>>>
>>>> * gnu/packages/linux.scm (e2fsprogs): Downgrade to 1.46.6.
>>>>
>>>> Change-Id: Ifa6841185ab85d24479f981afc1b42a349716d80
>>>> ---
>>>> gnu/packages/linux.scm | 6 ++++--
>>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>>>> index 2e0c05b4f7..76c69701b8 100644
>>>> --- a/gnu/packages/linux.scm
>>>> +++ b/gnu/packages/linux.scm
>>>> @@ -2548,10 +2548,12 @@ (define-public usbip-utils
>>>> module.")
>>>> (license license:gpl2)))
>>>>
>>>> +;; XXX: Before updating to 1.47+ check if grub supports the ext4 flag
>>>> +;; metadata_csum_seed, otherwise grub will complain about an unknown filesystem.
>>>> (define-public e2fsprogs
>>>> (package
>>>> (name "e2fsprogs")
>>>> - (version "1.47.0")
>>>> + (version "1.46.6")
>>>> (source (origin
>>>> (method url-fetch)
>>>> (uri (string-append
>>>> @@ -2560,7 +2562,7 @@ (define-public e2fsprogs
>>>> "e2fsprogs-" version ".tar.xz"))
>>>> (sha256
>>>> (base32
>>>> - "1nymjw801lmlr5y6bg1zv9jsip5dkyxqislbdzpir4mx5czzajhl"))))
>>>> + "1z7lqkvrw97jym2w2gz1aj3d9maxhrk6alv3vrzfkr7mkzqifxd7"))))
>>>> (build-system gnu-build-system)
>>>> (inputs (list `(,util-linux "lib")))
>>>> (native-inputs (list pkg-config
>>>>
>>>> base-commit: 56980ea500a1db3c8586972b8abfaf5c4e24f82d
>>>hello, this downgrade make my visionfive2 boot fail,
>>>
>>>#+begin_src bash
>>>
>>>/dev/mmcblk1p3 has unsupported feature(s): FEATURE_C12
>>>e2fsck: Get a newer version of e2fsck!
>>>
>>>Guix_image: ********** WARNING: Filesystem still has errors **********
>>>
>>>File system check on /dev/mmcblk1p3 failed
>>>
>>>#+end_src
>>>i think maybe we should use 1.47.0 and disable metadata_csum_seed by
>>>default, like debian and gentoo?
>>>
>>>see https://sources.debian.org/data/main/e/e2fsprogs/1.47.0-2/debian/patches/disable-metadata_csum_seed-and-orphan_file-by-default
>>>and https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=747be80bc0594b776e233912ce517b38d5726891
>
>I don't have a grub + ext4 machine now, but it seems to me that I should only need to Revert this commit?
>

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 70912@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70912
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch