[PATCH] gnu: nss/fixed: Tweak performance test.

Done

Details

3 participants

Ludovic Courtès
Christopher Baines
Maxim Cournoyer

Owner: unassigned

Submitted by: Christopher Baines

Severity: normal

Christopher Baines wrote on 1 May 11:41 +0200

Recipients:(address . guix-patches@gnu.org)

Message-ID:26a7162056587eb3c5855e6d35e70c15b9fb72cc.1714556505.git.mail@cbaines.net

As I'm seeing this test fail with results of 5 to 7 seconds.

* gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher

time threshold.

Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a

---

gnu/packages/nss.scm | 8 ++++++++

1 file changed, 8 insertions(+)

Toggle diff (23 lines)diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 162e748094..60bc4d52de 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -280,6 +280,14 @@ (define-public nss/fixed
                          (setenv "USE_IP" "TRUE")
                          (setenv "IP_ADDRESS" "127.0.0.1")
 
+                         ;; This specific test is looking at performance "now
+                         ;; verify that we can quickly dump a database", and
+                         ;; we're not testing performance here (especially
+                         ;; since we're using faketime), so raise the
+                         ;; threshold
+                         (substitute* "tests/dbtests/dbtests.sh"
+                           ((" -lt 5") " -lt 50"))
+
                          ;; The "PayPalEE.cert" certificate expires every six months,
                          ;; leading to test failures:
                          ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=609734>.  To

base-commit: 7d4ae2fca723114fb1df56de33b82177fbc4d0a6
-- 
2.41.0

Christopher Baines wrote on 1 May 11:51 +0200

[PATCH v2] gnu: nss/fixed: Tweak performance test.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:df3f8e708890db3ba960082d90dc8f8f8d4931e8.1714557075.git.mail@cbaines.net

As I'm seeing this test fail with results of 5 to 7 seconds.

* gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher

time threshold.

Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a

---

gnu/packages/nss.scm | 8 ++++++++

1 file changed, 8 insertions(+)

Toggle diff (23 lines)diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 162e748094..80bf627583 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -280,6 +280,14 @@ (define-public nss/fixed
                          (setenv "USE_IP" "TRUE")
                          (setenv "IP_ADDRESS" "127.0.0.1")
 
+                         ;; This specific test is looking at performance "now
+                         ;; verify that we can quickly dump a database", and
+                         ;; we're not testing performance here (especially
+                         ;; since we're using faketime), so raise the
+                         ;; threshold
+                         (substitute* "nss/tests/dbtests/dbtests.sh"
+                           ((" -lt 5") " -lt 50"))
+
                          ;; The "PayPalEE.cert" certificate expires every six months,
                          ;; leading to test failures:
                          ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=609734>.  To

base-commit: 7d4ae2fca723114fb1df56de33b82177fbc4d0a6
-- 
2.41.0

Maxim Cournoyer wrote on 1 May 18:32 +0200

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 70693@debbugs.gnu.org)

Message-ID:871q6l8pd4.fsf@gmail.com

Christopher Baines <mail@cbaines.net> writes:

Toggle quote (7 lines)

> As I'm seeing this test fail with results of 5 to 7 seconds.

> * gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher

> time threshold.

> Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

Thanks,

Maxim

Ludovic Courtès wrote on 2 May 10:16 +0200

Recipients:(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)

Message-ID:87ikzw1vdx.fsf@gnu.org

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

Toggle quote (11 lines)> Christopher Baines <mail@cbaines.net> writes:
>
>> As I'm seeing this test fail with results of 5 to 7 seconds.
>>
>> * gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher
>> time threshold.
>>
>> Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

+1!

Not immediately related but Christina submitted patches to make nss

reproducible and to upgrade it that we should look into while we’re at

it:

https://issues.guix.gnu.org/40316

Ludo’.

Christopher Baines wrote on 7 May 21:45 +0200

[PATCH v2 2/3] gnu: Add po4a-minimal.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:be6d275a1a45d831adb0129755a991606b54dcdc.1715111123.git.mail@cbaines.net

The main reason is to avoid the texlive-updmap.cfg input indirectly pulling in

nss, which has a very time consuming testsuite.

* gnu/packages/gettext.scm (po4a-minimal): New variable.

Change-Id: If8d46a18a02e57d5427852e8e122de01f970ded4

---

gnu/packages/gettext.scm | 13 +++++++++++++

1 file changed, 13 insertions(+)

Toggle diff (23 lines)diff --git a/gnu/packages/gettext.scm b/gnu/packages/gettext.scm
index 1408cc4cb4..27212e3574 100644
--- a/gnu/packages/gettext.scm
+++ b/gnu/packages/gettext.scm
@@ -317,3 +317,16 @@ (define-public po4a
 more interestingly, the maintenance of translations) using gettext tools on
 areas where they were not expected like documentation.")
     (license gpl2+)))
+
+(define-public po4a-minimal
+  (package/inherit po4a
+    (native-inputs
+     ;; Remove test dependencies
+     (modify-inputs (package-native-inputs po4a)
+       (delete "docbook-xml")
+       (delete "perl-test-pod")
+       (delete "texlive-updmap.cfg")))
+    (arguments
+     (substitute-keyword-arguments (package-arguments po4a)
+       ((#:tests? _ #t) #f)))
+    (properties '((hidden? . #t)))))
-- 
2.41.0

Christopher Baines wrote on 7 May 21:45 +0200

[PATCH v2 1/3] gnu: nss/fixed: Tweak performance test.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:86386e3f8cd94c44ac685abb9b722d746d22177a.1715111123.git.mail@cbaines.net

As I'm seeing this test fail with results of 5 to 7 seconds.

* gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher

time threshold.

Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a

---

gnu/packages/nss.scm | 8 ++++++++

1 file changed, 8 insertions(+)

Toggle diff (23 lines)diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 162e748094..80bf627583 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -280,6 +280,14 @@ (define-public nss/fixed
                          (setenv "USE_IP" "TRUE")
                          (setenv "IP_ADDRESS" "127.0.0.1")
 
+                         ;; This specific test is looking at performance "now
+                         ;; verify that we can quickly dump a database", and
+                         ;; we're not testing performance here (especially
+                         ;; since we're using faketime), so raise the
+                         ;; threshold
+                         (substitute* "nss/tests/dbtests/dbtests.sh"
+                           ((" -lt 5") " -lt 50"))
+
                          ;; The "PayPalEE.cert" certificate expires every six months,
                          ;; leading to test failures:
                          ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=609734>.  To

base-commit: 014875b29e68da6357a5323e6dd1eaa74a05b753
-- 
2.41.0

Christopher Baines wrote on 7 May 21:45 +0200

[PATCH v2 3/3] Use po4a-minimal for guix.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:426f2432592afe22d59d9952f0078a20c9b18a4d.1715111123.git.mail@cbaines.net

As this avoids the indirect dependency on nss, which has a testsuite that

takes a long time to run.

* gnu/packages/package-management.scm (guix)[native-inputs]: Use po4a-minimal.

* guix/self.scm (%packages, translate-texi-manuals): Use po4a-minimal.

Change-Id: Iac7555cc850c1618d3d54f1b290faa4f9cfb4f8a

---

gnu/packages/package-management.scm | 2 +-

guix/self.scm | 8 ++++----

2 files changed, 5 insertions(+), 5 deletions(-)

Toggle diff (48 lines)diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index faa1a75aa0..631cbe1009 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -493,7 +493,7 @@ (define-public guix
                        ("graphviz" ,graphviz-minimal)
                        ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
                        ("help2man" ,help2man)
-                       ("po4a" ,po4a)))
+                       ("po4a" ,po4a-minimal)))
       (inputs
        `(("bzip2" ,bzip2)
          ("gzip" ,gzip)
diff --git a/guix/self.scm b/guix/self.scm
index 19c6d08e01..8c85684090 100644
--- a/guix/self.scm
+++ b/guix/self.scm
@@ -71,7 +71,7 @@ (define %packages
       ("bzip2"              . ,(ref 'compression 'bzip2))
       ("xz"                 . ,(ref 'compression 'xz))
       ("git-minimal"        . ,(ref 'version-control 'git-minimal))
-      ("po4a"               . ,(ref 'gettext 'po4a))
+      ("po4a-minimal"       . ,(ref 'gettext 'po4a-minimal))
       ("gettext-minimal"    . ,(ref 'gettext 'gettext-minimal))
       ("gcc-toolchain"      . ,(ref 'commencement 'gcc-toolchain))
       ("glibc-utf8-locales" . ,(delay
@@ -291,8 +291,8 @@ (define* (locale-data source domain
 
 (define (translate-texi-manuals source)
   "Return the translated texinfo manuals built from SOURCE."
-  (define po4a
-    (specification->package "po4a"))
+  (define po4a-minimal
+    (specification->package "po4a-minimal"))
 
   (define gettext-minimal
     (specification->package "gettext-minimal"))
@@ -317,7 +317,7 @@ (define (translate-texi-manuals source)
           (define (translate-tmp-texi po source output)
             "Translate Texinfo file SOURCE using messages from PO, and write
 the result to OUTPUT."
-            (invoke #+(file-append po4a "/bin/po4a-translate")
+            (invoke #+(file-append po4a-minimal "/bin/po4a-translate")
               "-M" "UTF-8" "-L" "UTF-8" "-k" "0" "-f" "texinfo"
               "-m" source "-p" po "-l" output))
 
-- 
2.41.0

Christopher Baines wrote on 7 May 21:53 +0200

Re: [bug#70693] [PATCH v2] gnu: nss/fixed: Tweak performance test.

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:871q6dh000.fsf@cbaines.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (21 lines)> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> As I'm seeing this test fail with results of 5 to 7 seconds.
>>>
>>> * gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher
>>> time threshold.
>>>
>>> Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a
>>
>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
>
> +1!
>
> Not immediately related but Christina submitted patches to make nss
> reproducible and to upgrade it that we should look into while we’re at
> it:
>
>   https://issues.guix.gnu.org/40316

I haven't got around to looking at that, but the data service failed to
process the v1 patch, the job timed out after 72 hours.

I don't think that necessarily means that patch hasn't worked, it's just
that we needed to build nss (because grafts, see #61363) to compute the
guix derivation for each system. As Ludo pointed out to me on IRC
though, that can probably be avoided so I've sent a v2 series that
includes a couple of patches to remove the link between guix and nss via
packages needed for the po4a tests.

Lets see if this gets further and we hopefully see how nss builds on
different systems.

Ludovic Courtès wrote on 9 May 16:09 +0200

Re: [bug#70693] [PATCH v2 3/3] Use po4a-minimal for guix.

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:87ikzn3wmx.fsf@gnu.org

Hi,

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (8 lines)

> As this avoids the indirect dependency on nss, which has a testsuite that

> takes a long time to run.

> * gnu/packages/package-management.scm (guix)[native-inputs]: Use po4a-minimal.

> * guix/self.scm (%packages, translate-texi-manuals): Use po4a-minimal.

> Change-Id: Iac7555cc850c1618d3d54f1b290faa4f9cfb4f8a

LGTM, thanks!

Ludo’.

Ludovic Courtès wrote on 9 May 16:11 +0200

Re: [bug#70693] [PATCH v2 2/3] gnu: Add po4a-minimal.

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 70693@debbugs.gnu.org)

Message-ID:87edab3wim.fsf@gnu.org

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (7 lines)

> The main reason is to avoid the texlive-updmap.cfg input indirectly pulling in

> nss, which has a very time consuming testsuite.

> * gnu/packages/gettext.scm (po4a-minimal): New variable.

> Change-Id: If8d46a18a02e57d5427852e8e122de01f970ded4

[...]

Toggle quote (5 lines)

> +(define-public po4a-minimal

> + (package/inherit po4a

> + (native-inputs

> + ;; Remove test dependencies

Maybe add: “, primarily to reduce the size of the dependency graph of the

‘guix’ package.”

Toggle quote (5 lines)

> + (modify-inputs (package-native-inputs po4a)

> + (delete "docbook-xml")

> + (delete "perl-test-pod")

> + (delete "texlive-updmap.cfg")))

This can be: (delete "docbook-xml" "perl-test-pod" "texlive-updmap.cfg").

Otherwise LGTM!

Ludo’.

Ludovic Courtès wrote on 9 May 16:13 +0200

Re: [bug#70693] [PATCH v2] gnu: nss/fixed: Tweak performance test.

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:87a5kz3wfq.fsf@gnu.org

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (7 lines)

> I don't think that necessarily means that patch hasn't worked, it's just

> that we needed to build nss (because grafts, see #61363) to compute the

> guix derivation for each system. As Ludo pointed out to me on IRC

> though, that can probably be avoided so I've sent a v2 series that

> includes a couple of patches to remove the link between guix and nss via

> packages needed for the po4a tests.

It would still make sense to apply the initial patch here, IMO.

Also, we could create an ‘nss-upgrade’ branch to remove the graft and

upgrade ‘nss’, also applying the reproducibility patches that Christina

posted.

WDYT?

Thanks,

Ludo’.

Christopher Baines wrote on 9 May 16:35 +0200

[PATCH v3 1/3] gnu: nss/fixed: Tweak performance test.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:e18f8abc59798e33072b959b3ccb8e60111d630b.1715265342.git.mail@cbaines.net

As I'm seeing this test fail with results of 5 to 7 seconds.

* gnu/packages/nss.scm (nss/fixed)[arguments]: Tweak a test to have a higher

time threshold.

Change-Id: Icb0551cd986acf67b2ba17dc8772a67b9747d31a

---

gnu/packages/nss.scm | 8 ++++++++

1 file changed, 8 insertions(+)

Toggle diff (23 lines)diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 162e748094..80bf627583 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -280,6 +280,14 @@ (define-public nss/fixed
                          (setenv "USE_IP" "TRUE")
                          (setenv "IP_ADDRESS" "127.0.0.1")
 
+                         ;; This specific test is looking at performance "now
+                         ;; verify that we can quickly dump a database", and
+                         ;; we're not testing performance here (especially
+                         ;; since we're using faketime), so raise the
+                         ;; threshold
+                         (substitute* "nss/tests/dbtests/dbtests.sh"
+                           ((" -lt 5") " -lt 50"))
+
                          ;; The "PayPalEE.cert" certificate expires every six months,
                          ;; leading to test failures:
                          ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=609734>.  To

base-commit: cf5f7a8bf9ca2288700fcf351bbca0fc341ec969
-- 
2.41.0

Christopher Baines wrote on 9 May 16:35 +0200

[PATCH v3 2/3] gnu: Add po4a-minimal.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:3a9488a476a1cb365892f433342360d7dff776c7.1715265342.git.mail@cbaines.net

The main reason is to avoid the texlive-updmap.cfg input indirectly pulling in

nss, which has a very time consuming testsuite.

* gnu/packages/gettext.scm (po4a-minimal): New variable.

Change-Id: If8d46a18a02e57d5427852e8e122de01f970ded4

---

gnu/packages/gettext.scm | 12 ++++++++++++

1 file changed, 12 insertions(+)

Toggle diff (22 lines)diff --git a/gnu/packages/gettext.scm b/gnu/packages/gettext.scm
index 1408cc4cb4..31fe95f6ad 100644
--- a/gnu/packages/gettext.scm
+++ b/gnu/packages/gettext.scm
@@ -317,3 +317,15 @@ (define-public po4a
 more interestingly, the maintenance of translations) using gettext tools on
 areas where they were not expected like documentation.")
     (license gpl2+)))
+
+(define-public po4a-minimal
+  (package/inherit po4a
+    (native-inputs
+     ;; Remove test dependencies, primarily to reduce the size of the
+     ;; dependency graph of the ‘guix’ package.
+     (modify-inputs (package-native-inputs po4a)
+       (delete "docbook-xml" "perl-test-pod" "texlive-updmap.cfg")))
+    (arguments
+     (substitute-keyword-arguments (package-arguments po4a)
+       ((#:tests? _ #t) #f)))
+    (properties '((hidden? . #t)))))
-- 
2.41.0

Christopher Baines wrote on 9 May 16:35 +0200

[PATCH v3 3/3] Use po4a-minimal for guix.

Recipients:(address . 70693@debbugs.gnu.org)

Message-ID:3e8a5857a16857bd0c48243ead1a49cfc1827df1.1715265342.git.mail@cbaines.net

As this avoids the indirect dependency on nss, which has a testsuite that

takes a long time to run.

* gnu/packages/package-management.scm (guix)[native-inputs]: Use po4a-minimal.

* guix/self.scm (%packages, translate-texi-manuals): Use po4a-minimal.

Change-Id: Iac7555cc850c1618d3d54f1b290faa4f9cfb4f8a

---

gnu/packages/package-management.scm | 2 +-

guix/self.scm | 8 ++++----

2 files changed, 5 insertions(+), 5 deletions(-)

Toggle diff (48 lines)diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index faa1a75aa0..631cbe1009 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -493,7 +493,7 @@ (define-public guix
                        ("graphviz" ,graphviz-minimal)
                        ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
                        ("help2man" ,help2man)
-                       ("po4a" ,po4a)))
+                       ("po4a" ,po4a-minimal)))
       (inputs
        `(("bzip2" ,bzip2)
          ("gzip" ,gzip)
diff --git a/guix/self.scm b/guix/self.scm
index 19c6d08e01..8c85684090 100644
--- a/guix/self.scm
+++ b/guix/self.scm
@@ -71,7 +71,7 @@ (define %packages
       ("bzip2"              . ,(ref 'compression 'bzip2))
       ("xz"                 . ,(ref 'compression 'xz))
       ("git-minimal"        . ,(ref 'version-control 'git-minimal))
-      ("po4a"               . ,(ref 'gettext 'po4a))
+      ("po4a-minimal"       . ,(ref 'gettext 'po4a-minimal))
       ("gettext-minimal"    . ,(ref 'gettext 'gettext-minimal))
       ("gcc-toolchain"      . ,(ref 'commencement 'gcc-toolchain))
       ("glibc-utf8-locales" . ,(delay
@@ -291,8 +291,8 @@ (define* (locale-data source domain
 
 (define (translate-texi-manuals source)
   "Return the translated texinfo manuals built from SOURCE."
-  (define po4a
-    (specification->package "po4a"))
+  (define po4a-minimal
+    (specification->package "po4a-minimal"))
 
   (define gettext-minimal
     (specification->package "gettext-minimal"))
@@ -317,7 +317,7 @@ (define (translate-texi-manuals source)
           (define (translate-tmp-texi po source output)
             "Translate Texinfo file SOURCE using messages from PO, and write
 the result to OUTPUT."
-            (invoke #+(file-append po4a "/bin/po4a-translate")
+            (invoke #+(file-append po4a-minimal "/bin/po4a-translate")
               "-M" "UTF-8" "-L" "UTF-8" "-k" "0" "-f" "texinfo"
               "-m" source "-p" po "-l" output))
 
-- 
2.41.0

Christopher Baines wrote on 9 May 16:36 +0200

Re: [bug#70693] [PATCH v2 2/3] gnu: Add po4a-minimal.

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 70693@debbugs.gnu.org)

Message-ID:87ttj7dpcv.fsf@cbaines.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (26 lines)> Christopher Baines <mail@cbaines.net> skribis:
>
>> The main reason is to avoid the texlive-updmap.cfg input indirectly pulling in
>> nss, which has a very time consuming testsuite.
>>
>> * gnu/packages/gettext.scm (po4a-minimal): New variable.
>>
>> Change-Id: If8d46a18a02e57d5427852e8e122de01f970ded4
>
> [...]
>
>> +(define-public po4a-minimal
>> +  (package/inherit po4a
>> +    (native-inputs
>> +     ;; Remove test dependencies
>
> Maybe add: “, primarily to reduce the size of the dependency graph of the
> ‘guix’ package.”
>
>> +     (modify-inputs (package-native-inputs po4a)
>> +       (delete "docbook-xml")
>> +       (delete "perl-test-pod")
>> +       (delete "texlive-updmap.cfg")))
>
> This can be: (delete "docbook-xml" "perl-test-pod" "texlive-updmap.cfg").

I've sent a v3 with these changes now.

Thanks,

Chris

Christopher Baines wrote on 9 May 16:52 +0200

Re: [bug#70693] [PATCH v2] gnu: nss/fixed: Tweak performance test.

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:87o79fdomg.fsf@cbaines.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (11 lines)> Christopher Baines <mail@cbaines.net> skribis:
>
>> I don't think that necessarily means that patch hasn't worked, it's just
>> that we needed to build nss (because grafts, see #61363) to compute the
>> guix derivation for each system. As Ludo pointed out to me on IRC
>> though, that can probably be avoided so I've sent a v2 series that
>> includes a couple of patches to remove the link between guix and nss via
>> packages needed for the po4a tests.
>
> It would still make sense to apply the initial patch here, IMO.

Personally I'm waiting for QA to build things since I want to see if

this does fix nss on the 4 systems it's currently broken on, and so that

there's substitutes available if and when this is merged.

The large number of builds recently on the master branch might delay

this though.

Toggle quote (6 lines)

> Also, we could create an ‘nss-upgrade’ branch to remove the graft and

> upgrade ‘nss’, also applying the reproducibility patches that Christina

> posted.

> WDYT?

I don't mind, if it doesn't happen on core-updates then that seems like

an OK approach.

Ludovic Courtès wrote on 13 May 10:58 +0200

Re: [bug#70693] [PATCH v3 1/3] gnu: nss/fixed: Tweak performance test.

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 70693@debbugs.gnu.org)

Message-ID:87h6f2dr5m.fsf@gnu.org

Hi!

LGTM to me, please push!

Ludo’.

Christopher Baines wrote on 13 May 14:44 +0200

Recipients:(address . 70693-done@debbugs.gnu.org)

Message-ID:871q6551ay.fsf@cbaines.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (4 lines)

> Hi!

> LGTM to me, please push!

Things are building, so I've pushed this to master as

7b0f145802f0c2c785014293d748721678fef824.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 70693@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 70693

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date