[PATCH] gnu: simavr: Remove modules from arguments.

  • Done
  • quality assurance status badge
Details
3 participants
  • Dale Mellor
  • Jean-Pierre De Jesus DIAZ
  • Christopher Baines
Owner
Somebody
Submitted by
Jean-Pierre De Jesus DIAZ
Severity
normal
J
J
Jean-Pierre De Jesus DIAZ wrote on 9 Apr 2024 14:37
(address . guix-patches@gnu.org)(name . Jean-Pierre De Jesus DIAZ)(address . jean@foundation.xyz)
58471ab754529c96bda543ebb62e40d3313c0357.1712666207.git.jean@foundation.xyz
* gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
keyword argument as it contains the default modules only.

Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
---
gnu/packages/avr-xyz.scm | 2 --
1 file changed, 2 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index e6092df082..86ac941770 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -62,8 +62,6 @@ (define-public simavr
(arguments
(list
#:tests? #f
- #:modules '((guix build gnu-build-system)
- (guix build utils))
#:phases #~(modify-phases %standard-phases
(delete 'configure)
(replace 'check

base-commit: 6d0502f9c3608ffd6b3b3c9b603cb5d4ad14d8c9
--
2.41.0
D
D
Dale Mellor wrote on 12 Apr 2024 10:22
Own 70309
(name . control)(address . control@debbugs.gnu.org)
8354e3ba09d7bc7a18b4c77a366915baacd46a1b.camel@rdmp.org
owner 70309 !
user guix
usertag 70309 + under-review
quit
D
D
Dale Mellor wrote on 12 Apr 2024 10:25
[PATCH v2] gnu: simavr: Remove modules from arguments.
(address . 70309@debbugs.gnu.org)
20240412082549.1334944-1-guix-devel-0brg6a@rdmp.org
From: Jean-Pierre De Jesus DIAZ <jean@foundation.xyz>

* gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
keyword argument as it contains the default modules only.

Review:
* Trivial change, totally benign
* lint/build-check/install all clean

Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
---
gnu/packages/avr-xyz.scm | 2 --
1 file changed, 2 deletions(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/avr-xyz.scm b/gnu/packages/avr-xyz.scm
index e6092df082..86ac941770 100644
--- a/gnu/packages/avr-xyz.scm
+++ b/gnu/packages/avr-xyz.scm
@@ -62,8 +62,6 @@ (define-public simavr
(arguments
(list
#:tests? #f
- #:modules '((guix build gnu-build-system)
- (guix build utils))
#:phases #~(modify-phases %standard-phases
(delete 'configure)
(replace 'check
--
2.41.0
C
C
Christopher Baines wrote on 15 Apr 2024 11:33
(name . Dale Mellor)(address . guix-devel-0brg6a@rdmp.org)
871q770y3b.fsf@cbaines.net
Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:

Toggle quote (15 lines)
> From: Jean-Pierre De Jesus DIAZ <jean@foundation.xyz>
>
> * gnu/packages/avr-xyz.scm (simavr) <arguments>: Remove the #:modules
> keyword argument as it contains the default modules only.
>
> Review:
> * Trivial change, totally benign
> * lint/build-check/install all clean
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
> Change-Id: Idf350cad53db879e90a53849c23ac4e63b53cfd1
> ---
> gnu/packages/avr-xyz.scm | 2 --
> 1 file changed, 2 deletions(-)

Thanks both, I've pushed this to master as
188168ee08f1913b1d11cdef153020c96d3f18fe.

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYc9GhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdvAhAApl1ROX1Paj5JFlo+/XlZ2NwC9mAa/Vc4
dkb75/SaJBdvpzRxLogGNXZMrAooVwur9LULCC/1zC6CHz4SVArnPShxfhXFjK/G
pn39KmMOv8LPa0/JZ1vB1IjswGDB/OsC811jKJUVmWrZsAcoK99VW2R5O69X4RUa
CX2+o2D9sMUD20W0UiwpfN2CcOWBgco+HoXuC3hqznE9SVFiLUrG++ab1X5a07fu
wzBk29qx8ipKzWuUVG2T3vHiG19fDFcD73DHVQkwaHfhVfmc6S4AMsw1b6+3xWBx
58WBe7L4LrZnT8lAMBWKogM6T7OvPDEvVQduvmLt0883hKIFWFMefbTGdbelwJD0
XofFtZ/QN+dmdQyiwTZtSGhNSAjCbTrj/wTfFgmrPlUDPQnEmeVj+jgCVHt+NQqt
RRIV4O+aJhLd37anbVHVY1I4DYxgozHwXywJ0X6mriH9qKFYPwYuXDSN2gH3Byns
vTQzsXbe+1orz/3+9O6MqV0dEJ9Yh24i3yfRw8VEPNhtvJ8wV2cl3pI+76TMklfS
MNRUmgXMZ4UdU0HEZgfZ6kFPoBBQlCBYRjBv3kzQ0z8OxhlfkznKRpy2vrTOPk+Q
ctcN9rf19TudUheMyeHQI5BdqfTEFeSnt1Q+YLNq82eiEgfghLDTFRSIQJRfQ1Vc
fqDPU597Rew=
=tbJA
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 70309@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 70309
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch