(operating-system) structure requires a kernel

Recipients:(address . bug-guix@gnu.org)

Message-ID:ZhFhfu_fcTyfxjeV@ws

Attachment: file

Ludovic Courtès wrote on 8 Apr 14:28 +0200

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . 70239@debbugs.gnu.org)

Message-ID:87cyr0qbqt.fsf@gnu.org

Hi,

Tomas Volf <~@wolfsden.cz> skribis:

Toggle quote (10 lines)>     (operating-system
>       (host-name "guix")
>       ;; Servers usually use UTC regardless of the location.
>       (timezone "Etc/UTC")
>       (locale "en_US.utf8")
>       (firmware '())
>       (initrd-modules '())
>     ;  (kernel %ct-dummy-kernel)
>     (kernel #f)

[...]

Toggle quote (17 lines)>     In gnu/services.scm:
>       1031:29  7 (linux-builder-configuration->system-entry _)
>     In guix/profiles.scm:
>         439:4  6 (packages->manifest _)
>     In srfi/srfi-1.scm:
>        586:17  5 (map1 (#f))
>     In guix/inferior.scm:
>         549:2  4 (loop #f "out" #<promise #<procedure 7f8c96627f98 at gu…>)
>         529:4  3 (inferior-package-input-field #f _)
>        473:18  2 (inferior-package-field #f (compose (lambda (#) (…)) #))
>     In ice-9/boot-9.scm:
>       1685:16  1 (raise-exception _ #:continuable? _)
>       1685:16  0 (raise-exception _ #:continuable? _)
>
>     ice-9/boot-9.scm:1685:16: In procedure raise-exception:
>     In procedure struct-vtable: Wrong type argument in position 1 (expecting struct): #f

Indeed, ‘linux-builder-configuration->system-entry’ is not prepared for

that, but we can fix it.

Toggle quote (16 lines)> The (kernel (plain-file "fake-kernel" "")) leads to a different error:
>
>     building /gnu/store/idy2sylx9zbvphzlqvhnldjvg242hd2a-linux-modules.drv...
>     find-files: /gnu/store/jfcbq6djya5pi54yhpvzj66r18h4mp09-dummy-kernel-1/lib/modules: Not a directory
>     Backtrace:
>                4 (primitive-load "/gnu/store/sckm34nzvmkcynhgn6zs5aq6xfs?")
>     In ice-9/eval.scm:
>         619:8  3 (_ #f)
>        626:19  2 (_ #<directory (guile-user) 7ffff77f7c80>)
>         159:9  1 (_ #<directory (guile-user) 7ffff77f7c80>)
>     In unknown file:
>                0 (car ())
>
>     ERROR: In procedure car:
>     In procedure car: Wrong type (expecting pair): ()

I believe this one is a regression introduced in
8f8ec56052766aa5105d672b77ad9eaca5c1ab3c.  I believe this is fixed by
this patch:

Toggle diff (35 lines)diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 561cfe2fd0..40ff2dc808 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -134,18 +134,23 @@ (define (flat-linux-module-directory linux modules)
                          (guix build utils)
                          (rnrs io ports)
                          (srfi srfi-1)
-                         (srfi srfi-26))
+                         (srfi srfi-26)
+                         (ice-9 match))
 
             (define module-dir
               (string-append #$linux "/lib/modules"))
 
             (define builtin-modules
-              (call-with-input-file
-                  (first (find-files module-dir "modules.builtin$"))
-                (lambda (port)
-                  (map file-name->module-name
-                       (string-tokenize
-                        (get-string-all port))))))
+              (match (find-files module-dir (lambda (file stat)
+                                              (string=? (basename file)
+                                                        "modules.builtin")))
+                ((file . _)
+                 (call-with-input-file file
+                   (lambda (port)
+                     (map file-name->module-name
+                          (string-tokenize (get-string-all port))))))
+                (_
+                 '())))
 
             (define modules-to-lookup
               (lset-difference string=? '#$modules builtin-modules))

Could you confirm?

Toggle quote (3 lines)

> I think it would be best to just support (kernel #f) for container deployments,

> since that would simplify it and keep it manageable.

Yes, let’s do that too.

Thanks,

Ludo’.

Tomas Volf wrote on 9 Apr 18:04 +0200

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 70239@debbugs.gnu.org)

Message-ID:ZhVm82D2jgxyp3w2@ws

Hi,

On 2024-04-08 14:28:58 +0200, Ludovic Courtès wrote:

Toggle quote (4 lines)

> [..]

> Could you confirm?

Yes, the attached patch fixed the issue for me. :)

Toggle quote (9 lines)

> > I think it would be best to just support (kernel #f) for container deployments,

> > since that would simplify it and keep it manageable.

> Yes, let’s do that too.

> Thanks,

> Ludo’.

Tomas

There are only two hard things in Computer Science:

cache invalidation, naming things and off-by-one errors.

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 70239@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date