Magit autoloads missing in Emacs 29.3

  • Done
  • quality assurance status badge
Details
3 participants
  • Clément Lassieur
  • Jake
  • Liliana Marie Prikler
Owner
unassigned
Submitted by
Jake
Severity
normal
J
J
Jake wrote on 1 Apr 05:33 +0200
(address . bug-guix@gnu.org)(address . liliana.prikler@gmail.com)
CAJqVjv_kC33CGqKUD_Tf8264gnJPPy3ML61iGmD5nF_6QL4dBg@mail.gmail.com
Hello

Since upgrading from Emacs 29.1 to 29.3, it seems like magit's autoload
definitions are not loaded.

To reproduce:

guix shell --pure emacs emacs-magit -- emacs -q --eval "(call-interactively
'magit)"

In Emacs 29.3 this gives me: Wrong type argument: commandp, magit

Thanks
Jake
Attachment: file
L
L
Liliana Marie Prikler wrote on 1 Apr 17:50 +0200
[PATCH] gnu: emacs-magit: Fix generation of autoloads.
(address . 70121@debbugs.gnu.org)(name . Jake)(address . jforst.mailman@gmail.com)
64e17caf531cefa38b6eddadf89021107efcff2c.1711986763.git.liliana.prikler@gmail.com
* gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
like the others.

Fixes: Magit autoloads are missing https://bugs.gnu.org/70121
---
gnu/packages/emacs-xyz.scm | 4 ++++
1 file changed, 4 insertions(+)

Toggle diff (22 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 975b26813a..f47f5fcb8a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1668,6 +1668,10 @@ (define-public emacs-magit
(lambda args
(with-directory-excursion "lisp"
(apply (assoc-ref %standard-phases 'expand-load-path) args))))
+ (replace 'make-autoloads
+ (lambda args
+ (with-directory-excursion "lisp"
+ (apply (assoc-ref %standard-phases 'make-autoloads) args))))
(replace 'install
(lambda args
(with-directory-excursion "lisp"

base-commit: 4d79a9cd6b5f0d8c5afbab0c6b70ae42740d5470
prerequisite-patch-id: c275e4e44896c8ab96e5cc9557ec5dc522d62fd0
prerequisite-patch-id: 1675bb658c90730025a744f7869a3566fb5cf41a
prerequisite-patch-id: 9c02fe03b70a5312cc982fd4b48e73e889a9afdf
--
2.41.0
C
C
Clément Lassieur wrote on 3 Apr 12:27 +0200
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)
871q7m4u7y.fsf@lassieur.org
On Mon, Apr 01 2024, Liliana Marie Prikler wrote:

Toggle quote (6 lines)
> * gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
> like the others.
>
> Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
> ---

Hi,

Tested, looks good to me.
C
C
Clément Lassieur wrote on 3 Apr 12:40 +0200
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)
87ttkienl7.fsf@lassieur.org
On Wed, Apr 03 2024, Clément Lassieur wrote:

Toggle quote (12 lines)
> On Mon, Apr 01 2024, Liliana Marie Prikler wrote:
>
>> * gnu/packages/emacs-xyz.scm (emacs-magit)[#:phases]: Replace ‘make-autoloads’
>> like the others.
>>
>> Fixes: Magit autoloads are missing <https://bugs.gnu.org/70121>
>> ---
>
> Hi,
>
> Tested, looks good to me.

Pushed, thanks.
Closed
?