[PATCH gnome-team] gnu: pango@1.90: Disable failing test.

  • Done
  • quality assurance status badge
Details
2 participants
  • Christopher Baines
  • Vivien Kraus
Owner
unassigned
Submitted by
Vivien Kraus
Severity
normal

Debbugs page

Vivien Kraus wrote 12 months ago
(address . guix-patches@gnu.org)
f6ef6580c8d10f0fe0470101db710b8d26768f0f.1711143964.git.vivien@planete-kraus.eu
* gnu/packages/gtk.scm (pango-1.90) [snippet]: Disable failing test.

Change-Id: Ib0f6dcd42c9475c4b543400f43836c2f3f8db16f
---
Dear Guix,

I don’t fully understand what’s pango 1.90, but it has an unfixed failing test
and very few users, so maybe disabling the failing test could be OK.

What do you think?

Best regards,

Vivien

gnu/packages/gtk.scm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Toggle diff (22 lines)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index f43eece4f2..9252315fd2 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -466,7 +466,12 @@ (define-public pango-1.90
#~(begin
(substitute* "pango/pangocairo-font.c"
(("cairo_user_font_face_set_render_color_glyph_func")
- "cairo_user_font_face_set_render_glyph_func"))))))))
+ "cairo_user_font_face_set_render_glyph_func"))
+ ;; Disable a failing test
+ (substitute* "tests/testmisc.c"
+ (("\
+g_test_add_func \\(\"/layout/gravity-metrics2\", test_gravity_metrics2\\);")
+ ""))))))))
(define-public pangox-compat
(package

base-commit: a9951a74a591a9b22ee2d93d8efe0523c6c42c97
--
2.41.0
Christopher Baines wrote 12 months ago
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87zfunhqam.fsf@cbaines.net
Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (11 lines)
> * gnu/packages/gtk.scm (pango-1.90) [snippet]: Disable failing test.
>
> Change-Id: Ib0f6dcd42c9475c4b543400f43836c2f3f8db16f
> ---
> Dear Guix,
>
> I don’t fully understand what’s pango 1.90, but it has an unfixed failing test
> and very few users, so maybe disabling the failing test could be OK.
>
> What do you think?

Sounds good, I've pushed this to gnome-team as
d48d0baad16b3acc393f74a9fbea358ce94f1449.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYAAaFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xefkg/8CvSA35ctCY5wXIkbeSTNElG6vdq35m70
MxmwwlNsZXZ9Gvm9FP22OsdoBAPpK7vz2fTh3cdsfsRHW33zAIC82nlNtMF06KJ4
4wU66oZoGHfJNf+5v9IN4xaYlrUU92Wd2j4+jVQmlxJ8bbsOA0fxhhQ72nfgtWlN
24dYjn5VyGY2tGutGXkL3aB8ZmC1uyE2p52idQI2LuQ1HckciukYNJ5FbqOGb+RJ
FIbDNybA7MxdZ8SxwNdzInwMFW4RRWl4VYUAlgsL3fWt7iL80wrIRlo9TIr5wc4z
CNdgLfYl6g4B879tlvR6hdNAtHls6ypz0BA2zgPj6Sla9m4G2FYZem4ii/J9+hTf
ooyYfvvuxAjVFa1DhkT+UAzLGE/jiThBIQ5QFgmSzOgByl7hCnNNayH3+ODr7zbB
1jFh39G2G4CzUBknz1lSdjzlyia3EDHY+uUKnkwEvbvwT3T/qVg/U7XVZjoz9NBT
vpRdtUu6PxqkaxKMQx9ill12PC53CHa2vdYLRPVc/7EoPRt82+Oaf9f4avoifxet
FB1i+iAEGXbdKYod9g3kl7n9Ytsk/KQ/wfq3Z3bJmiSE306WBbSSuE3kAuvv6ONk
r23XCCCoqhupTCayBBKhub5qSYxBSAFkpoG5kXBX1QYnxB4kN++qSdZ/49tOxa/R
DGLYg/Hk+yY=
=ixxF
-----END PGP SIGNATURE-----

?
Your comment

This issue is archived.

To comment on this conversation send an email to 69949@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 69949
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help