Rclone is 4 years outdated

  • Open
  • quality assurance status badge
Details
4 participants
  • Alexandre Hannud Abdo
  • Adroit
  • Leo Famulari
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Adroit
Severity
normal
A
A
Adroit wrote on 19 Mar 2024 02:35
(name . bug-guix@gnu.org)(address . bug-guix@gnu.org)
DDJxa6Qb9IjNORSwiW0X-vuwGaojVBUSU2Ha7U_Tk_ralvfs8SsnLwSnIAdPyp3f7zBpJHOM6WT1l3K2851OCaTGdTGGBEUBcR3Fgbo3dIE=@proton.me
The package "rclone" has not been updated in a long time. I did not find any open bug reports about it.

I was brave and tried to run the latest myself using:
`guix build rclone --with-source=rclone@1.66.0=./rclone-1.66.0.tar.gz`
With the latest source tarball from the Github release. The recipe (in sync.scm) uses a tar download rather than a git-fetch for some reason, so I wasn't able to reuse the recipe with --with-branch. (Btw --with-version would be nice to have, since the version's download URL is done correctly in the recipe.)

Unfortunately I ran into some obscure build error and don't know how to proceed as this is outside of my familiarity.
Attachment: file
A
A
Alexandre Hannud Abdo wrote on 23 Dec 2024 13:30
(address . 69889@debbugs.gnu.org)
262bf077-476d-4727-8d2c-61a3fa18a1de@member.fsf.org
Ni! Using `--with-latest` and using `--with-version` also fails during build.

Build log is attached.

I've never played with the go build system, but it seems that the definition doesn't include the required dependencies.

There's a comment in the current outdated definition saying that dependencies are bundled with the tarball. Looking at current files that no longer seems to be the case. I'm assuming --with-latest and --with-version just download newer tarballs.

There seems to be many dependencies. I have no idea whether they're all in guix, so I wonder how hard would it be to fix this. And if it's really only the dependencies that are missing from the definition.

.~´
S
S
Sharlatan Hellseher wrote 7 days ago
(address . 69889@debbugs.gnu.org)(address . leo@famulari.name)
87bjvijbjy.fsf@gmail.com
Hi,

Thanks for reporting.

Toggle snippet (13 lines)
guix describe
Generation 75 Feb 03 2025 21:37:27 (current)
guix 2574ae3
repository URL: https://git.savannah.gnu.org/git/guix.git
branch: master
commit: 2574ae3733637ead786fb3dc454369590794bc51

guix show rclone
name: rclone
version: 1.52.3
<...>

<2020-08-08> in Guix

<2025-01-14> the current latest release

The project changed the module of release and now ships vendor and source separatly:

It means we need to package all missing inputs before update to the
latest.

CC Leo for the second opinion if we may grab vendor and ingest it
during build and initiate packaging for the future to reduce amount of
vendored packages.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmeh38EACgkQdtcnv/Ys
0rX7mA//WYqzt0+K5CsCaqwgs8gtqhs4GNjQVA/2izkOEvKomijyJl26Fx2R/v7F
kqIsS5FJ7zjKnpgK6w6J3nR+9KlYU752JiXUzSRzQG1OK5QGqNmABDsHvngigeN+
Br143bEpSUnmR8gxXpA04+1mBp9vwCPtZlQDSLAMot3odFJMyXfp0mpF1xRVBP0R
t0zcRZWje8cU+Ek/oLAOlX11GnvcQ0HckFS0ZrPghsjoiX4oZszHxspXocr98VMP
yH+n29xIxLMpPlBAaHagLiAqeiSocaG86yaeG4QyOmZpG2JaILVAoY5uHx1MErf4
gmy38aMzBtDveJZiJ7yebyFXWriXCWm1oPtb4LvyeYTitmXGex/AWkcBvd3bGeRf
9Fu15EoVUjUgCY42UzaEx86bjcS62NAUQFLm9SQJ1ZVGKJ4QPPBIRE5/FMptVzoK
78GcUOi5zkifkpKV8AEHZz0+KEEbuMirOCOkonQ2J89fYziuXkibQmfS3nvju9io
2NjDemxv0X9k+YsVuP2fVQPF/TV1Xifne9aOygjs9maRsqf6BA8tpmNJ67GVGVwV
yUOxfUQPYQWpsCSD5WZUXvKzx3axEAKcX6EImu14viWDmvuWecnK/Ud0wLNSohkm
q7CtNNuBz+GuvZ6SFvmQ/P9NwKXSCSsjyWyxW/KDsWnENqRUszI=
=H3CH
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote 5 days ago
(name . Sharlatan Hellseher)(address . sharlatanus@gmail.com)(address . 69889@debbugs.gnu.org)
Z6P9g3-M0ZvwV-M-@jasmine.lan
On Tue, Feb 04, 2025 at 09:37:05AM +0000, Sharlatan Hellseher wrote:
Toggle quote (7 lines)
> The project changed the module of release and now ships vendor and source separatly:
> - https://github.com/rclone/rclone/releases/download/v1.69.0/rclone-v1.69.0-vendor.tar.gz
> - https://github.com/rclone/rclone/releases/download/v1.69.0/rclone-v1.69.0.tar.gz
>
> It means we need to package all missing inputs before update to the
> latest.

I see.

Toggle quote (4 lines)
> CC Leo for the second opinion if we may grab vendor and ingest it
> during build and initiate packaging for the future to reduce amount of
> vendored packages.

I think it's fine to use this vendored / bundled tarball.

Using the vendored code is not the Guix way, but we are already using
the bundled dependencies for this package.

The change is that now they are provided in a separate tarball.

This is not a meaningful change with respect to the why Guix generally
doesn't use bundled source code and I don't think the code review
process for this update should force them to be unbundled now.

In the past I've argued that the way we handle Go packages right now is
insufficient to package them properly. Either we could make an easy to
parameterize Go libraries / modules so that they are not vendored
(improve the importer as part of that?), or just use the vendored code.

But I always say that motivation is not fungible. If you are interested
in packaging these dependencies in the future, go for it!
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 69889@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 69889
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch