pre-push hook does not check the ref being pushed

  • Open
  • quality assurance status badge
Details
One participant
  • Tomas Volf
Owner
unassigned
Submitted by
Tomas Volf
Severity
normal
T
T
Tomas Volf wrote on 4 Mar 12:32 +0100
(address . bug-guix@gnu.org)
ZeWxOkp07ZdcHZle@ws
Hello,

the pre-push hook just calls `make authenticate check-channel-news' without any
attempt to actually switch to the ref that it should check. This means it
always authenticates HEAD, not the ref being pushed. That seems wrong.

Have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmXlsToACgkQL7/ufbZ/
wakcUw//U1VrowluFrBmiT0xK/KY2OToPLoja/9TjLzUO3ifB9JeWEWQH9BsLX2o
ToNogZdYaHF51XNUlPwZgN4m+m7wUJ8rjsoKs3CfgBBBf504q1VE7FfuPXcE4P8i
vds1/QGjFC6ZuLzf8NZy/nc/AATUzkcCh4++6vUupXrtWSdJ5g3VcuYEURNQBdcI
PnBoMrR931oHok+BK5vnMHUet18IBeB5RJHEhVluEbhL2jffLGai6pGS1yM+HWDm
UcJoNKW6ysmwcs0VKfwgmC/NRiGRK2hCJhgjrfrYyBzgtAnQCt8bQ7lov4BYRlMj
Lzgkbb0aI0XD1NFBPpRiR/OvUVTYqWkM9d9FRZ6deUhoFoZxM54yVllD5xuh09Bc
D2cC1+Ge2tBrpjUUiqMFIQn3tQVuVVU0j9NZVswZMNuj0qGqws+8hcEKtTP1xTNd
QiLhz5OS69On5b/XEHbHAdlC3n/MpyG84WQqz3MFdGa3tXi6XoqO+xXFs4eBDcKX
WSLE3+slkFCQY2GRBwVqC127hE/CKfVOzsSe2hcGRSJsB++ck9dcHG6oxNp0TqBI
j5VD0DzVXlYI7h9ftRIslJsc1SKXeTkbBzTXU8bw0QqNdWQmYyTr9vn5EK/Wylhu
sIRFQqtMoMg8bR9+xOvzJsDzXlJC527b7W7gi69ziwNxuY73Kec=
=RGTN
-----END PGP SIGNATURE-----


?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 69541@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 69541
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch